effective_test_bot 1.1.23 → 1.1.24

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7c5680e555e47bbf34f48eb0b94cde7030ea3620b89086ce240ef1ca26f2c104
-  data.tar.gz: 512d0f243668ccca14b34382cdf1f3f678a90a21ef35dfc5469351a7d4c76787
+  metadata.gz: eccff959a9793ba3408242d0ce772d74ffec74b5e814052ee6ee27086d934491
+  data.tar.gz: 631e4aca51755e878e549edc85547297bd630c199996b0a67ca34f36ed215e75
 SHA512:
-  metadata.gz: eb95d66b4f2f04facf6e8c077ee21457dbece6cd811270483e41172af4bab60c7129c17b46a4bea2572dbbdf4b81142d913569d4598044b098aeaad3841d4601
-  data.tar.gz: 2724eed26fc9907c1153aa3b0f5a74100a63c554275d968d47e7ece8c2b1b5522255a11492aac9b899e5c14232b73eb4d614bdb57a702f1155cad716932bcf4c
+  metadata.gz: db5b468dbb02f65c4e2050a77168c1559f30ec12e6d2f046a014e1a815b78450a93d3816956f3500b969fb8ec5cb6e0065f1040eef4649f4a7be780f4e1930cd
+  data.tar.gz: 7c997a7afa4c1875a44e32c4f8de06713f589d6b5e3a51ffa3e3a04c8c37b999d3d24feadae466d1d2f170e93be3666c1f4448f1f9d7ab5d6167a3c53c4227d1

data/lib/effective_test_bot.rb

@@ -66,7 +66,7 @@ module EffectiveTestBot
   end
 
   def self.gifs?
-    image_processing_class.present?
+    screenshots? && image_processing_class.present?
   end
 
   def self.image_processing_class
@@ -97,7 +97,7 @@ module EffectiveTestBot
     if ENV['TOUR'].present?
       ENV['TOUR'].to_s != 'false'
     else
-      screenshots? && (tour_mode != false)
+      gifs? && (tour_mode != false)
     end
   end
 
@@ -106,7 +106,7 @@ module EffectiveTestBot
     if ENV['TOUR'].present?
       ['extreme', 'debug'].include?(ENV['TOUR'].to_s.downcase)
     else
-      screenshots? && ['extreme', 'debug'].include?(tour_mode.to_s)
+      gifs? && ['extreme', 'debug'].include?(tour_mode.to_s)
     end
   end
 

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '1.1.23'.freeze
+  VERSION = '1.1.24'.freeze
 end

data/test/support/effective_test_bot_form_faker.rb

@@ -5,6 +5,8 @@ require 'faker'
 module EffectiveTestBotFormFaker
   DIGITS = ('1'..'9').to_a
   LETTERS = %w(A B C E G H J K L M N P R S T V X Y) # valid letters of a canadian postal code, eh?
+  TRUE_VALUES = [true, 1, '1', 't', 'T', 'true', 'TRUE', 'on', 'ON']
+  FALSE_VALUES = [false, 0, '0', 'f', 'F', 'false', 'FALSE', 'off', 'OFF']
 
   # Generates an appropriately pseudo-random value for the given field
   # Pass in a Hash of fills to define pre-selected values
@@ -269,19 +271,11 @@ module EffectiveTestBotFormFaker
   end
 
   def truthy?(value)
-    if defined?(::ActiveRecord::ConnectionAdapters::Column::TRUE_VALUES)  # Rails 5
-      ::ActiveRecord::ConnectionAdapters::Column::TRUE_VALUES.include?(value)
-    else
-      ActiveRecord::Type::Boolean.new.cast(value)
-    end
+    TRUE_VALUES.include?(value)
   end
 
   def falsey?(value)
-    if defined?(::ActiveRecord::ConnectionAdapters::Column::FALSE_VALUES)  # Rails 5
-      ::ActiveRecord::ConnectionAdapters::Column::FALSE_VALUES.include?(value)
-    else
-      ::ActiveRecord::Type::Boolean.new.cast(value) == false
-    end
+    FALSE_VALUES.include?(value)
   end
 
 end

data/test/support/effective_test_bot_form_filler.rb

@@ -130,6 +130,7 @@ module EffectiveTestBotFormFiller
     @filled_country_fields = nil
 
     save_test_bot_screenshot
+    true
   end
 
   def fill_input_text(field, value)

data/test/support/effective_test_bot_screenshots_helper.rb

@@ -7,17 +7,15 @@ module EffectiveTestBotScreenshotsHelper
   end
 
   def save_test_bot_screenshot
-    return unless EffectiveTestBot.screenshots?
+    return unless EffectiveTestBot.gifs?
     return unless page.current_path.present?
-    
+
     page.save_screenshot("#{current_test_temp_path}/#{current_test_screenshot_id}.png")
     true
   end
 
   def save_test_bot_failure_gif
-    return unless EffectiveTestBot.screenshots?
     return unless EffectiveTestBot.gifs?
-
     return unless save_test_bot_screenshot
 
     Dir.mkdir(current_test_failure_path) unless File.exist?(current_test_failure_path)
@@ -28,7 +26,6 @@ module EffectiveTestBotScreenshotsHelper
   end
 
   def save_test_bot_tour_gif
-    return unless EffectiveTestBot.screenshots?
     return unless EffectiveTestBot.gifs?
     return unless (@test_bot_screenshot_id || 0) > 0
 
@@ -42,9 +39,12 @@ module EffectiveTestBotScreenshotsHelper
   def without_screenshots(&block)
     original = EffectiveTestBot.screenshots
 
-    EffectiveTestBot.screenshots = false
-    yield
-    EffectiveTestBot.screenshots = original
+    begin
+      EffectiveTestBot.screenshots = false
+      yield
+    ensure
+      EffectiveTestBot.screenshots = original
+    end
   end
 
   protected

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 1.1.23
+  version: 1.1.24
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-07-21 00:00:00.000000000 Z
+date: 2020-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails