effective_test_bot 1.1.9 → 1.1.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 388b001b2623967980652158d514fced5cc43e1aa68d8e82ed58477b5259ce7e
-  data.tar.gz: 75f822d0e2b123ac4895ffca16c43177b9cc535d8b1f6662a732d27095fa3c32
+  metadata.gz: 3b3829648f3fc69bd8f75d3312984aee55b9d6c534fe57c2af5ff5902633c9a9
+  data.tar.gz: 04da07a2a5860b4c55755b8e9627d32e0b90f538323fbf9111f26bd3416cb500
 SHA512:
-  metadata.gz: 928fd9aa3369645ceafc2649c1f1b829194805438bfa64e8396dff29c9bc74fa6c4b2157da0172658ec7243c16447afd46093d2d5a7ec9bbb8e4b200c41c4ec1
-  data.tar.gz: eb8435cb593eb355924ea139255050d3699c33fd38c80627d384d4d651ef93cd998eaea22cda87fb3f29b53187c4b1e8186fbfb120bda9634a17bea31deff45b
+  metadata.gz: f5ebc7ca28ffdbacc2f76948f87b4f6b6b0477d100c68acc2138a054a15b8f2e955d820c5783672554d79a4e227198aa0800a46aa70cf6255dcc8a35920b73ec
+  data.tar.gz: 35af10f02568f30c12efb8d6e8523aa8fe881c0cdb5ad33f77aed6b6de72f884313c275b77ff650558eed919dd74c081213fef2aaac9ef12d564cb752d78f8cf

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '1.1.9'.freeze
+  VERSION = '1.1.10'.freeze
 end

data/test/support/effective_test_bot_assertions.rb

@@ -140,7 +140,8 @@ module EffectiveTestBotAssertions
   # It ensures there are no HTML5 validation errors that would prevent the form from being submit
   # Browsers seem to only consider visible fields, so we will to
   def assert_no_html5_form_validation_errors(message: nil)
-    errors = all(':invalid', visible: true, wait: false).map { |field| field['name'] }
+    errors = all(':invalid', visible: true, wait: false).map { |field| field['name'].presence }.compact
+
     assert errors.blank?, message || "(no_html5_form_validation_errors) Unable to submit form, unexpected HTML5 validation error present on the following fields:\n#{errors.join("\n")}"
   end
 

data/test/support/effective_test_bot_form_filler.rb

@@ -296,7 +296,7 @@ module EffectiveTestBotFormFiller
     field_id.start_with?('filters_scope_') ||
     field_id.start_with?('filters_') && field['name'].blank? ||
     (field.disabled? rescue true) || # Selenium::WebDriver::Error::StaleElementReferenceError: stale element reference: element is not attached to the page document
-    (!field.visible? && !ckeditor_text_area?(field) && !custom_control_input?(field)) ||
+    (!field.visible? && !ckeditor_text_area?(field) && !custom_control_input?(field) && !file_input?(field)) ||
     ['true', true, 1].include?(field['data-test-bot-skip']) ||
     (@test_bot_excluded_fields_xpath.present? && field.path.include?(@test_bot_excluded_fields_xpath))
   end

data/test/support/effective_test_bot_form_helper.rb

@@ -104,10 +104,13 @@ module EffectiveTestBotFormHelper
       puts "Clicking: <#{submit.tag_name} id='#{submit['id']}' class='#{submit['class']}' name='#{submit['name']}' value='#{submit['value']}' href='#{submit['href']}' />"
     end
 
-    submit.click
-
-    if submit['data-confirm']
-      effective_bootstrap_custom_data_confirm? ? submit.click : page.accept_alert
+    if submit['data-confirm'] && effective_bootstrap_custom_data_confirm?
+      submit.click
+      submit.click # Twice
+    elsif submit['data-confirm']
+      page.accept_confirm { submit.click }
+    else
+      submit.click
     end
 
     synchronize!

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 1.1.9
+  version: 1.1.10
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-07 00:00:00.000000000 Z
+date: 2019-08-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails