effective_test_bot 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5f5f5c2542da07000f1d5a44c7f221e8c21445bc
-  data.tar.gz: 3304a80e911d3d33c3bb8ba53425ddad434c7a3c
+  metadata.gz: 974ef4a9d6b759cc434619a082215a74c9823904
+  data.tar.gz: 224d534f49202c588dc33d98284358dcdc249c99
 SHA512:
-  metadata.gz: 732e7628a607983ae21eb7b06a3cb4391252d2685152c3263c3f7c518183f7eb4cbb8d12ce9935d5f99e3790a1880a0e9abb1066d99e5614768751e7801a5194
-  data.tar.gz: a846a8e053b03809e4b267282d38ca27832cf0b36b4136f3ba771f2627f8e8bf1fc88c8f282bbb99c8f502f6d19a4f69200bfb613582fefd2caf40b372c7b37c
+  metadata.gz: 4fbbc8bee9fcfc819818edafe8dd8e6c1fc9aa33242e3e5137dcbd6e9f06d657fbfb9ee200fc102f1594882c714fb66a537c6b2b650b009fbee273611b170ee1
+  data.tar.gz: e186e7db807007b73033ad7b254b9961617f450aea119f754d77f505bc772425b75ff3d460722ed758dfc34262e3045aa2c5b92b57d63ef5c06b3c97970421ea

data/README.md

@@ -114,7 +114,7 @@ The following assertions are added for use in any integration test:
 
 - `assert_assigns` asserts a given rails view_assigns object is present.
 - `assert_assigns_errors` use after an intentionally invalid form submit to make sure your assigned rails object has errors, or a specific error.
-- `assert_authorization` checks for a 403 Access Denied error.  For this to work, please add `assign_test_bot_access_denied_exception(exception) if defined?(EffectiveTestBot)` to your ApplicationController's `rescue_from` block to generate more information.
+- `assert_authorization` checks for a 403 Access Denied error.  For this to work, please add `assign_test_bot_access_denied_exception(exception) if defined?(EffectiveTestBot)` to the bottom of your ApplicationController's `rescue_from` block, after the respond_to, to generate more information.
 - `assert_no_assigns_errors` should be used after any form submit to make sure your assigned rails object has no errors.  Prints out any errors if they exist.
 - `assert_current_path(path)` asserts the current page path.
 - `assert_email(action)` asserts an email with the given action name was sent. Also supports `assert_email(to: email)` type syntax with to, from, subject, body.

data/config/application_system_test_case.rb

@@ -1,7 +1,18 @@
 require 'test_helper'
 
+require 'capybara'
+require 'selenium-webdriver'
+
+Capybara.register_driver :effective_headless do |app|
+  options = Selenium::WebDriver::Chrome::Options.new
+
+  ['headless', 'disable-gpu', 'window-size=1366x1366'].each { |arg| options.add_argument(arg) }
+
+  Capybara::Selenium::Driver.new(app, browser: :chrome, options: options)
+end
+
 class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
-  driven_by :selenium_chrome_headless, screen_size: [1366, 768]
+  driven_by :effective_headless
 
   include Warden::Test::Helpers if defined?(Devise)
   include EffectiveTestBot::DSL

data/lib/effective_test_bot/dsl.rb

@@ -29,5 +29,10 @@ module EffectiveTestBot
       include TestBotable::RedirectDsl
       include TestBotable::WizardDsl
     end
+
+    def absolute_image_path
+      Rails.root.join("tmp/screenshots/#{image_name.gsub('/', '-')}.png")
+    end
+
   end
 end

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '1.0.2'.freeze
+  VERSION = '1.0.3'.freeze
 end

data/test/support/effective_test_bot_form_filler.rb

@@ -208,9 +208,9 @@ module EffectiveTestBotFormFiller
 
     when 'input_file'
       if field['class'].to_s.include?('asset-box-uploader-fileinput')
-        "#{File.dirname(__FILE__)}/../fixtures/documents._test"
+        "#{File.dirname(__FILE__).sub('test/support', 'test/fixtures')}/documents._test"
       else
-        "#{File.dirname(__FILE__)}/../fixtures/logo.png"
+        "#{File.dirname(__FILE__).sub('test/support', 'test/fixtures')}/logo.png"
       end
 
     when 'input_number'
@@ -392,6 +392,10 @@ module EffectiveTestBotFormFiller
     end
   end
 
+  def clear_effective_select(field)
+    page.execute_script("try { $('select##{field['id']}').val('').trigger('change.select2'); } catch(e) {};")
+  end
+
   def close_effective_date_time_picker(field)
     page.execute_script("try { $('input##{field['id']}').data('DateTimePicker').hide(); } catch(e) {};")
   end

data/test/support/effective_test_bot_form_helper.rb

@@ -46,11 +46,11 @@ module EffectiveTestBotFormHelper
   def clear_form
     all('input,select,textarea').each do |field|
       if field.tag_name == 'select' && field['class'].to_s.include?('select2') # effective_select
-        within(field.query_scope) { first(:css, '.select2-selection__clear').try(:click) }
+        clear_effective_select(field)
       end
 
       begin
-        field.set('');
+        field.set('')
         close_effective_date_time_picker(field) if field['class'].to_s.include?('effective_date')
         save_test_bot_screenshot if EffectiveTestBot.tour_mode_extreme?
       rescue => e; end
@@ -63,7 +63,7 @@ module EffectiveTestBotFormHelper
   # This kind of sucks, as we want to simulate mouse movements with the tour
   # Instead we manually trigger submit buttons and use the data-disable-with to
   # make the 'submit form' step look nice
-  def click_submit(label, last: false, debug: false)
+  def click_submit(label = nil, last: false, debug: false)
     submit = find_submit(label, last: last)
 
     if EffectiveTestBot.screenshots?
@@ -85,7 +85,7 @@ module EffectiveTestBotFormHelper
   end
 
   # Keys are :value, should be one of :count, :minimum, :maximum, :between, :text, :id, :class, :visible, :exact, :exact_text, :match, :wait, :filter_se
-  def find_submit(label, last: false)
+  def find_submit(label = nil, last: false)
     submit = nil
 
     if label.present?

data/test/test_botable/base_test.rb

@@ -80,18 +80,10 @@ module BaseTest
   # Try to find a link_to_delete already on this page
   # Otherwise create one
   # Returns the link element
-  def find_or_create_rails_ujs_link_to_delete(resource)
-    selector = "a[href='#{resource_path(resource)}'][data-method='delete']"
-    link_to_delete = page.document.all(selector, visible: false).first # could be nil, but this is a non-blocking selector
-
-    if link_to_delete.present? # Take excessive efforts to ensure it's visible and clickable
-      page.execute_script("$('body').prepend($(\"#{selector}\").first().clone().show().removeProp('disabled').html('Delete'));")
-    else  # Create our own link
-      page.execute_script("$('body').prepend($('<a>').attr({href: '#{resource_path(resource)}', 'data-method': 'delete', 'data-confirm': 'Are you sure?'}).html('Delete'));")
-    end
+  def create_rails_ujs_link_to_delete(resource)
+    selector = "a[href='#{destroy_resource_path(resource)}'][data-method='delete']"
 
-    # capybara-webkit doesn't seem to stop on the alert 'Are you sure?'.
-    # Otherwise we'd want to take a screenshot of it
+    page.execute_script("$('body').prepend($('<a>').attr({href: '#{destroy_resource_path(resource)}', 'data-method': 'delete'}).html('Delete'));")
 
     (page.document.first(:css, selector) rescue nil)
   end
@@ -115,4 +107,9 @@ module BaseTest
   def edit_resource_path(resource) # edit
     effective_resource.action_path(:edit, resource)
   end
+
+  def destroy_resource_path(resource)
+    effective_resource.action_path(:destroy, resource)
+  end
+
 end

data/test/test_botable/crud_test.rb

@@ -67,7 +67,10 @@ module CrudTest
     assert_assigns_errors(resource_name) unless test_bot_skip?(:assigns_errors)
 
     assert_equal(before[:count], after[:count], "Expected #{resource_class}.count to be unchanged") if resource_class.respond_to?(:count)
-    assert_equal(resources_path, page.current_path, "(path) Expected current_path to match resource #create path #{resources_path}") unless test_bot_skip?(:path)
+
+    if resources_path.present? && !test_bot_skip?(:path)
+      assert_equal(resources_path, page.current_path, "(path) Expected current_path to match resource #create path #{resources_path}")
+    end
 
     assert_flash(:danger) unless test_bot_skip?(:flash)
   end
@@ -150,13 +153,14 @@ module CrudTest
     assert_assigns(resource_name) unless test_bot_skip?(:assigns)
     assert_assigns_errors(resource_name) unless test_bot_skip?(:assigns_errors)
 
-    assert_equal(resource_path(resource), page.current_path, "(path) Expected current_path to match resource #update path") unless test_bot_skip?(:path)
+    if effective_resource.action_path(:update, resource) && !test_bot_skip?(:path)
+      assert_equal(effective_resource.action_path(:update, resource), page.current_path, "(path) Expected current_path to match resource #update path") unless test_bot_skip?(:path)
+    end
 
     assert_equal before[:count], after[:count], "Expected: #{resource_class}.count to be unchanged"
     assert_equal(before[:updated_at], after[:updated_at], "(updated_at) Expected @#{resource_name}.updated_at to be unchanged") if (resource.respond_to?(:updated_at) && !test_bot_skip?(:updated_at))
 
     assert_flash(:danger) unless test_bot_skip?(:flash)
-
   end
 
   def test_bot_update_valid_test
@@ -203,7 +207,7 @@ module CrudTest
     visit(resources_path)
     save_test_bot_screenshot
 
-    link_to_delete = find_or_create_rails_ujs_link_to_delete(resource)
+    link_to_delete = create_rails_ujs_link_to_delete(resource)
 
     if link_to_delete.present? && (link_to_delete.click() rescue false)
       synchronize!
@@ -217,7 +221,7 @@ module CrudTest
       # So we just assert the 200 status code, and page title present manually
       # Javascript errors cannot be detected
 
-      visit_delete(resource_path(resource), user)
+      visit_delete(destroy_resource_path(resource), user)
       assert_equal(200, @visit_delete_page.try(:status_code), '(page_status) Expected 200 HTTP status code') unless test_bot_skip?(:page_status)
       assert((@visit_delete_page.find(:xpath, '//title', visible: false) rescue nil).present?, '(page_title) Expected page title to be present') unless test_bot_skip?(:page_title)
     end

data/test/test_botable/devise_test.rb

@@ -57,9 +57,10 @@ module DeviseTest
 
     within_if('form#new_user', !test_bot_skip?(:form)) do
       fill_form(email: email, password: 'not-correct-password')
-      submit_form
+      submit_novalidate_form
     end
 
+    assert_assigns_errors(:user)
     assert_page_normal
 
     assert_signed_out

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-25 00:00:00.000000000 Z
+date: 2018-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails