effective_test_bot 0.6.1 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 07bf0cd7c284cd899943335e6eabe61280ff4fb1
-  data.tar.gz: 5846e0ae040d8c3d44607e1550cdcc261a472e71
+  metadata.gz: 348dcab0f742b0fc3c398a29924e03373b1c8899
+  data.tar.gz: 3f4657ab5beea8f59ea201da177df6dbc9ff2d8c
 SHA512:
-  metadata.gz: 24fa43aec87401f7892873e4fe5deb19bc27cc82607d35b21ef11a8f5e613f324d0c094eaae8f069f5c018c9d13195a737d21d0bb3792fab2d35c7a448421020
-  data.tar.gz: 6d19efb1e8c8ccee2286911f9624be53bb2bdec3adf3d79e0a2aa49237936d56ddb7a9464d731058db65361d955736f0ddfb520431ca4b9bbae9fa7cd4ddbc1c
+  metadata.gz: 8d5fb505be70bf496edeae75bb397835db2385148a5b69cc87b903ec4af64e8c54e581afcf7c96af25e46d6e95b2c8be6dec9b7a729e937c43555c0633f9d7bc
+  data.tar.gz: d54670db3513736069612105476f68b93c8e0a39cfcc36751a3804bb8f152dea7bdde713caa8b81e324b67b305ffa13beff64ba7622589df54b41cf5ee643649

data/config/test_helper.rb

@@ -85,7 +85,7 @@ end
 
 # "Connection not rolling back" snippets
 # These are some snippets that the internet has collected to fix test threading issues.
-# They are unneeded with effective_test_bot.  On my machine. But I leave them here as a reference.
+# They are unneeded with effective_test_bot. On my machine. But I leave them here as a reference.
 # Try one or both if you are having issues passing rake test:bot:environment
 
 # class ActiveRecord::Base

data/lib/effective_test_bot.rb

@@ -120,7 +120,7 @@ module EffectiveTestBot
   def self.save_passed_test(name)
     EffectiveTestBot.passed_tests[name] = true
 
-    Dir.mkdir(passed_tests_path) unless File.exists?(passed_tests_path)
+    Dir.mkdir(passed_tests_path) unless File.exist?(passed_tests_path)
 
     File.open(passed_tests_filename, 'w') do |file|
       passed_tests.each { |test_name, _| file.puts(test_name) }

data/lib/effective_test_bot/middleware.rb

@@ -27,8 +27,8 @@ module EffectiveTestBot
       dir = File.join(Dir.pwd, 'tmp', 'test_bot')
       file = File.join(dir, 'exception.txt')
 
-      Dir.mkdir(dir) unless File.exists?(dir)
-      File.delete(file) if File.exists?(file)
+      Dir.mkdir(dir) unless File.exist?(dir)
+      File.delete(file) if File.exist?(file)
 
       File.open(file, 'w') do |file|
         file.write "================== Start server exception ==================\n"

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '0.6.1'.freeze
+  VERSION = '0.6.2'.freeze
 end

data/lib/generators/effective_test_bot/install_generator.rb

@@ -8,7 +8,7 @@ module EffectiveTestBot
       source_root File.expand_path('../../templates', __FILE__)
 
       def install_minitest
-        return if File.exists?('test/test_helper.rb')
+        return if File.exist?('test/test_helper.rb')
         puts '[effective_test_bot] installing minitest'
         run 'bundle exec rails generate minitest:install'
       end

data/lib/tasks/effective_test_bot_tasks.rake

@@ -116,7 +116,7 @@ namespace :test do
   desc 'loads test/fixtures/seeds.rb'
   task :load_fixture_seeds => :environment do
     seeds = "#{Rails.root}/test/fixtures/seeds.rb"
-    load(seeds) if File.exists?(seeds)
+    load(seeds) if File.exist?(seeds)
   end
 
   # This ensures rake test:prepare is run before rake test:bot or rake test:bot:environment run
@@ -125,11 +125,13 @@ namespace :test do
     Rake::TestTask.new('effective_test_bot' => 'test:prepare') do |t|
       t.libs << 'test'
       t.test_files = FileList["#{File.dirname(__FILE__)}/../../test/test_bot/integration/application_test.rb"]
+      t.warning = false
     end
 
     Rake::TestTask.new('effective_test_bot_environment' => 'test:prepare') do |t|
       t.libs << 'test'
       t.test_files = FileList["#{File.dirname(__FILE__)}/../../test/test_bot/integration/environment_test.rb"]
+      t.warning = false
     end
   end
 

data/test/support/effective_test_bot_assertions.rb

@@ -94,7 +94,7 @@ module EffectiveTestBotAssertions
   def assert_no_exceptions(message = "(no_exceptions) Unexpected rails server exception:\n:exception:")
     # this file is created by EffectiveTestBot::Middleware when an exception is encountered in the rails app
     file = File.join(Dir.pwd, 'tmp', 'test_bot', 'exception.txt')
-    return unless File.exists?(file)
+    return unless File.exist?(file)
 
     exception = File.read(file)
     File.delete(file)

data/test/support/effective_test_bot_minitest_helper.rb

@@ -4,10 +4,18 @@ module EffectiveTestBotMinitestHelper
   # end
 
   # This gets called after every test.  Minitest hook for plugin developers
-  def after_teardown
+  def before_teardown
+    super
+
     if EffectiveTestBot.screenshots? && (@test_bot_screenshot_id || 0) > 0
-      save_test_bot_failure_gif if !passed? && EffectiveTestBot.autosave_animated_gif_on_failure?
-      save_test_bot_tour_gif if passed? && EffectiveTestBot.tour_mode?
+      if !passed? && EffectiveTestBot.autosave_animated_gif_on_failure?
+        save_test_bot_screenshot
+        save_test_bot_failure_gif
+      end
+
+      if passed? && EffectiveTestBot.tour_mode?
+        save_test_bot_tour_gif
+      end
     end
 
     if passed? && !EffectiveTestBot.passed_tests[current_test_name]

data/test/support/effective_test_bot_screenshots_helper.rb

@@ -16,7 +16,7 @@ module EffectiveTestBotScreenshotsHelper
   end
 
   def save_test_bot_failure_gif
-    Dir.mkdir(current_test_failure_path) unless File.exists?(current_test_failure_path)
+    Dir.mkdir(current_test_failure_path) unless File.exist?(current_test_failure_path)
     full_path = (current_test_failure_path + '/' + current_test_failure_filename)
 
     save_test_bot_gif(full_path)
@@ -24,7 +24,7 @@ module EffectiveTestBotScreenshotsHelper
   end
 
   def save_test_bot_tour_gif
-    Dir.mkdir(current_test_tour_path) unless File.exists?(current_test_tour_path)
+    Dir.mkdir(current_test_tour_path) unless File.exist?(current_test_tour_path)
     full_path = (current_test_tour_path + '/' + current_test_tour_filename)
 
     save_test_bot_gif(full_path)

data/test/test_bot/integration/environment_test.rb

@@ -48,27 +48,36 @@ module TestBot
       assert_signed_out
     end
 
-    test '08: capybara can execute javascript' do
+    test '08: capybara database connection is shared' do
+      user = User.new(email: 'unique@testbot.com', password: '!Password123', password_confirmation: '!Password123')
+      user.username = 'unique-username' if user.respond_to?(:username)
+      user.login = 'unique-login' if user.respond_to?(:login)
+      user.save(validate: false)
+
+      without_screenshots { sign_in_manually(user, '!Password123') }
+      assert_signed_in("expected successful devise manual sign in with user created in this test.\nTry using one of the ActiveRecord shared_connection snippets in test/test_helper.rb")
+    end
+
+    test '09: capybara can execute javascript' do
       visit root_path
       assert_capybara_can_execute_javascript
     end
 
-    test '09: jquery is present' do
+    test '10: jquery is present' do
       visit root_path
       assert_jquery_present
     end
 
-    test '10: rails jquery_ujs is present' do
+    test '11: rails jquery_ujs is present' do
       visit root_path
       assert_jquery_ujs_present
     end
 
-    test '11: action_mailer.default_url_options are present' do
+    test '12: action_mailer.default_url_options are present' do
       assert(
         (Rails.application.config.action_mailer.default_url_options[:host] rescue nil).present?,
         "expected action_mailer.default_url_options[:host] to be present.\nAdd config.action_mailer.default_url_options = { host: 'example.com' } to config/environments/test.rb"
       )
-
     end
   end
 end

data/test/test_botable/base_test.rb

@@ -10,7 +10,6 @@ module BaseTest
     assert_no_exceptions unless test_bot_skip?(:exceptions)
     assert_page_status unless test_bot_skip?(:page_status)
     assert_no_js_errors unless test_bot_skip?(:no_js_errors)
-    assert_no_flash_errors unless test_bot_skip?(:no_flash_errors)
     assert_page_title unless (test_bot_skip?(:page_title) || all('head').blank? || was_download?)
   end
 

data/test/test_botable/crud_test.rb

@@ -90,6 +90,7 @@ module CrudTest
     after = { count: resource_class.count, path: page.current_path }
 
     assert_page_normal
+    assert_no_flash_errors unless test_bot_skip?(:no_flash_errors)
 
     # In a rails controller, if I redirect to resources_path it may not assign the instance variable
     # Wheras if I redirect to edit_resource_path I must ensure that the instance variable is set
@@ -179,6 +180,7 @@ module CrudTest
     after = { count: resource_class.count, updated_at: (resource.updated_at rescue nil) }
 
     assert_page_normal
+    assert_no_flash_errors unless test_bot_skip?(:no_flash_errors)
 
     # In a rails controller, if i redirect to resources_path it may not assign the instance variable
     # Wheras if I redirect to edit_resource_path I must ensure that the instance variable is set

data/test/test_botable/devise_test.rb

@@ -15,6 +15,7 @@ module DeviseTest
     end
 
     assert_page_normal
+    assert_no_flash_errors unless test_bot_skip?(:no_flash_errors)
 
     assert_signed_in('Expected @current_user to be present after sign up')
     assert User.where(email: email).first.present?, "Expected user to be present after submitting sign up form at #{new_user_registration_path}"
@@ -37,6 +38,7 @@ module DeviseTest
     end
 
     assert_page_normal
+    assert_no_flash_errors unless test_bot_skip?(:no_flash_errors)
 
     assert_signed_in
     assert_page_content(I18n.t('devise.sessions.signed_in')) unless test_bot_skip?(:page_content)

data/test/test_botable/member_test.rb

@@ -12,6 +12,8 @@ module MemberTest
     visit(path)
 
     assert_page_normal
+    assert_no_flash_errors unless test_bot_skip?(:no_flash_errors)
+
     assert_assigns(resource_name) unless (was_redirect?(path) || test_bot_skip?(:assigns))
   end
 

data/test/test_botable/page_test.rb

@@ -14,6 +14,7 @@ module PageTest
     end
 
     assert_page_normal
+    assert_no_flash_errors unless test_bot_skip?(:no_flash_errors)
   end
 
 end

data/test/test_botable/redirect_test.rb

@@ -9,6 +9,7 @@ module RedirectTest
 
     assert_redirect(from, to)
     assert_page_normal
+    assert_no_flash_errors unless test_bot_skip?(:no_flash_errors)
 
     #page.save_screenshot("#{from.parameterize}.png")
   end

data/test/test_botable/wizard_test.rb

@@ -25,7 +25,7 @@ module WizardTest
         submit_form
       end
 
-      assert_no_assigns_errors
+      assert_no_flash_errors unless test_bot_skip?(:no_flash_errors)
 
       if to.present?
         # Keep going till we hit a certain to_path

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - Code and Effect