effective_test_bot 0.5.1 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3e527752317f5fa4794ff447b856c3d975d4bf88
-  data.tar.gz: c4fd0acdfbc5bbb1d6435dd9cf01eaf3673b3320
+  metadata.gz: 1af9730f46872f097b9d825a6d6e084aa9b152ff
+  data.tar.gz: 3180d006dd3ff2fef23e86e68e8561f855bad160
 SHA512:
-  metadata.gz: 783e6c019ce1fa4316c894d2cbddf121ea0986b2d00ad55f770fed20dd5da220b437194d66d3e5bc1504b3d7724fc016a4a969bdd208f801a851cb46b71ca17a
-  data.tar.gz: fe44090e65b67525eb9ae2b2456a661307cce75b4c81ac701353d785e30fccc22df9554e03d4107796a1c78fc582d726ee59a341c4383446cf1f43e04983b921
+  metadata.gz: a1d4f26b996ebb47642951ef294656e0526bdc676163c5d25291696d661295fbe7091b6d4ee93e3bc344e232e7b44c167d34ed15aa3452552bac612a17df34ed
+  data.tar.gz: 53d3c71075a40210e2ace8507497562cfbf9ca856396b2e6dca459ea47ea222359c3a453249351c8dc57e83c461a571f8655c6ca43823e8b642dec0a043a951a

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '0.5.1'.freeze
+  VERSION = '0.5.2'.freeze
 end

data/test/support/effective_test_bot_form_filler.rb

@@ -37,6 +37,12 @@ module EffectiveTestBotFormFiller
       within('div' + tab['href']) { fill_form_fields(fills) }
     end
 
+    # If there is no visible submits, go back to the first tab
+    if all(:css, "input[type='submit']").length == 0
+      tabs.first.click()
+      synchronize!
+      save_test_bot_screenshot
+    end
   end
 
   # Only fills in visible fields
@@ -217,6 +223,15 @@ module EffectiveTestBotFormFiller
   def value_for_input_checkbox_field(field, fill_value)
     if fill_value.present?
       fill_values = Array(fill_value)  # Allow an array of fill values to be passed
+
+      if ::ActiveRecord::ConnectionAdapters::Column::TRUE_VALUES.include?(fill_value)
+        fill_values = ::ActiveRecord::ConnectionAdapters::Column::TRUE_VALUES.to_a
+      end
+
+      if ::ActiveRecord::ConnectionAdapters::Column::FALSE_VALUES.include?(fill_value)
+        fill_values = ::ActiveRecord::ConnectionAdapters::Column::FALSE_VALUES.to_a
+      end
+
       (fill_values.include?(field['value']) || fill_values.include?(field.find(:xpath, '..').text))
     elsif field['value'] == 'true'
       true
@@ -261,6 +276,10 @@ module EffectiveTestBotFormFiller
     number = Random.new.rand(min..max)
     number = (number.kind_of?(Float) ? number.round(2) : number)
 
+    if (field['step'] == '1' || field['class'].to_s.split(' ').include?('integer'))
+      number = number.to_i
+    end
+
     return number if field['max'].blank?
 
     shared_max_fields = all(selector)

data/test/support/effective_test_bot_form_helper.rb

@@ -64,22 +64,21 @@ module EffectiveTestBotFormHelper
   # Instead we manually trigger submit buttons and use the data-disable-with to
   # make the 'submit form' step look nice
   def click_submit(label)
-    if EffectiveTestBot.screenshots?
-      page.execute_script "$('input[data-disable-with]').each(function(i) { $.rails.disableFormElement($(this)); });"
-      save_test_bot_screenshot
-      page.execute_script "$('input[data-disable-with]').each(function(i) { $.rails.enableFormElement($(this)); });"
-    end
-
     if label.present?
       submit = find(:link_or_button, label)
       assert submit.present?, "TestBotError: Unable to find a visible submit link or button on #{page.current_path} with the label #{label}"
-      submit.click
     else
       submit = first(:css, "input[type='submit']")
       assert submit.present?, "TestBotError: Unable to find a visible input[type='submit'] on #{page.current_path}"
-      submit.click
     end
 
+    if EffectiveTestBot.screenshots?
+      page.execute_script "$('input[data-disable-with]').each(function(i) { $.rails.disableFormElement($(this)); });"
+      save_test_bot_screenshot
+      page.execute_script "$('input[data-disable-with]').each(function(i) { $.rails.enableFormElement($(this)); });"
+    end
+
+    submit.click
     synchronize!
     true
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-16 00:00:00.000000000 Z
+date: 2016-04-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails