effective_test_bot 0.4.8 → 0.4.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b74466446800d58bfb33f2216c378cf5528adc4d
-  data.tar.gz: 1ca9bacaae0a77a4df55a81542afd425e0a5b797
+  metadata.gz: 6cf4d62267c1a02ff2a0bd22303f3ee9910e16ba
+  data.tar.gz: 9c971d7950781d4195c2e13b0dd2af2dd4ebe7eb
 SHA512:
-  metadata.gz: 5b945654383760acb1fb5dc44a3f43acf72f760f97b2d49491b4d8d57c37ba36310b96c37629b552445254d9358512bc044474529a16b0d5bc652707759963be
-  data.tar.gz: cd991c7acf1fed501e492d664407cc2e9383d627f371d54527d0c30a52b2eda79a8d4f5236eb23d068b11bc983459574167d01cf6bd0fdf322605ae7fcb26f61
+  metadata.gz: e78e8b4eca28808362fd52db931bb236d26571a814d7dabf372a6c268899b853d9c2c2cc405c5b53013250854f692717e1d7cf1c9b822e13649fcbd19f3aeb65
+  data.tar.gz: 9ac142dffbfc8288e6ebe00d9335f4d7c5b8a69d470be8dd32503232e42859bebaa945688715ebc8d9083f0998a30f020e4a920217e6926c865b66e8331df27b

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '0.4.8'.freeze
+  VERSION = '0.4.9'.freeze
 end

data/test/concerns/test_botable/base_dsl.rb

@@ -119,7 +119,6 @@ module TestBotable
 
     # Instance Methods
 
-
     # Using reverse_merge! in the dsl action_tests makes sure that the
     # class level can assign a current_test variable
     # wheras the action level ones it's not present.
@@ -130,11 +129,17 @@ module TestBotable
         self.class.normalize_test_bot_options!(options)
       end
 
-      lets.each { |k, v| self.class.let(k) { v } } # Using the minitest spec let(:foo) { 'bar' } syntax
+      # Clear any previously defined memoized values
+      @_memoized = nil # This clears the minitest let! syntax memoized values
 
-      # test_bot may leak some lets from one test to the next, if they're not overridden
-      # I take special care to undefine just current test so far
-      self.class.let(:current_test) { nil } if options[:current_test].blank?
+      # Using the minitest spec let(:foo) { 'bar' } syntax
+      lets.each do |key, value|
+        if value.kind_of?(Hash) && !value.kind_of?(HashWithIndifferentAccess)
+          self.class.let(key) { HashWithIndifferentAccess.new(value) }
+        else
+          self.class.let(key) { value }
+        end
+      end
 
       lets
     end

data/test/support/effective_test_bot_assertions.rb

@@ -80,8 +80,9 @@ module EffectiveTestBotAssertions
 
   # This must be run after submit_form()
   # It ensures there are no HTML5 validation errors that would prevent the form from being submit
+  # Browsers seem to only consider visible fields, so we will to
   def assert_no_html5_form_validation_errors(message = nil)
-    errors = all(':invalid', visible: false).map { |field| field['name'] }
+    errors = all(':invalid', visible: true).map { |field| field['name'] }
     assert errors.blank?, message || "(no_html5_form_validation_errors) Unable to submit form, unexpected HTML5 validation error present on the following fields:\n#{errors.join("\n")}"
   end
 
@@ -128,7 +129,7 @@ module EffectiveTestBotAssertions
       assert errors.blank?, message || "(no_assigns_errors) Unexpected @#{key} rails validation errors:\n#{errors}"
     else
       assigns.each do |key, value|
-        errors = value['errors']
+        errors = value['errors'] if value.respond_to?(:[])
         assert errors.blank?, message || "(no_assigns_errors) Unexpected @#{key} rails validation errors:\n#{errors}"
       end
     end

data/test/support/effective_test_bot_form_filler.rb

@@ -5,7 +5,7 @@ module EffectiveTestBotFormFiller
   LETTERS = ('A'..'Z').to_a
 
   # Fill a boostrap tabs based form
-  def fill_bootstrap_tabs_form(fills = {}, boostrap_tab_elements = nil)
+  def fill_bootstrap_tabs_form(fills = HashWithIndifferentAccess.new, boostrap_tab_elements = nil)
     fills = HashWithIndifferentAccess.new(fills) unless fills.kind_of?(HashWithIndifferentAccess)
 
     tabs = boostrap_tab_elements || all("a[data-toggle='tab']")
@@ -42,7 +42,7 @@ module EffectiveTestBotFormFiller
 
   # Only fills in visible fields
   # fill_form(:email => 'somethign@soneone.com', :password => 'blahblah', 'user.last_name' => 'hlwerewr')
-  def fill_form_fields(fills = {})
+  def fill_form_fields(fills = HashWithIndifferentAccess.new)
     fills = HashWithIndifferentAccess.new(fills) unless fills.kind_of?(HashWithIndifferentAccess)
 
     save_test_bot_screenshot
@@ -191,10 +191,14 @@ module EffectiveTestBotFormFiller
       d[0] + d[1] + d[2] + '-' + d[3] + d[4] + d[5] + '-' + d[6] + d[7] + d[8] + d[9]
     when 'textarea'
       Faker::Lorem.paragraph
-    when 'input_checkbox'
-      [true, false].sample
-    when 'input_radio'
-      [true, false].sample
+    when 'input_checkbox', 'input_radio'
+      if field['value'] == 'true'
+        true
+      elsif field['value'] == 'false'
+        false
+      else
+        [true, false].sample
+      end
     when 'input_file'
       "#{File.dirname(__FILE__)}/important_documents._test"
     else

data/test/support/effective_test_bot_form_helper.rb

@@ -3,15 +3,16 @@ require 'timeout'
 module EffectiveTestBotFormHelper
   # Intelligently fills a form with Faker based randomish input
   # Delegates the form fill logic to effective_test_bot_form_filler
-  def fill_form(fills = {})
-    fills = HashWithIndifferentAccess.new(fills) unless fills.kind_of?(HashWithIndifferentAccess)
+  def fill_form(local_fills = {})
+    # The fills here are from a let!(:fills) { 'Something' } as defined in an _action test
+    fill_values = ((fills if defined?(fills)) || HashWithIndifferentAccess.new).merge(local_fills)
 
     bootstrap_tabs = all("a[data-toggle='tab']")
 
     if bootstrap_tabs.length > 1
-      fill_bootstrap_tabs_form(fills, bootstrap_tabs)
+      fill_bootstrap_tabs_form(fill_values, bootstrap_tabs)
     else
-      fill_form_fields(fills)
+      fill_form_fields(fill_values)
     end
     true
   end

data/test/support/effective_test_bot_test_helper.rb

@@ -29,6 +29,10 @@ module EffectiveTestBotTestHelper
     end
   end
 
+  def click_first(label)
+    click_link(label, match: :first)
+  end
+
   # EffectiveTestBot includes an after_filter on ApplicationController to set an http header
   # These values are 'from the last page submit or refresh'
   def flash

data/test/test_botable/wizard_test.rb

@@ -19,10 +19,17 @@ module WizardTest
         submit_form
       end
 
-      break if page.current_path == to_path
+      if to_path.present?
+        # Keep going till we hit a certain to_path
+        break if page.current_path == to_path
+      else
+        # Keep going till there's no more submit buttons
+        break if all("input[type='submit']").blank?
+      end
+
     end
 
-    assert_current_path to_path
+    assert_current_path(to_path) if to_path.present?
   end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 0.4.8
+  version: 0.4.9
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-20 00:00:00.000000000 Z
+date: 2015-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails