effective_test_bot 0.4.12 → 0.4.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5ede27ddd554e49edc914d193530a5d0d90b1334
-  data.tar.gz: 30ad17c211358cf211bd583d58044a44ec4a8946
+  metadata.gz: 3d9f3e47968588a874f9e16b0fbefa9e98ee9aee
+  data.tar.gz: c025706727691c283a8d99a1e902ae4ae5d61cc4
 SHA512:
-  metadata.gz: 13471d53e1e4cf34d78dae3b4802567c862c2eb93517b0503926fc367e7b42e3b7e9c1785ef5e74abb989e95facaccaa6846e7778db43717ac3a2e354566f7d4
-  data.tar.gz: 1d9b51c137546d51ef794dd2ed9e984e7fcc5bbba5e45c57882be783cf006f3dee0519450ca10c6be5d1f984e1496d1ae31c856a32a68285ec51c4bc3fdbacbe
+  metadata.gz: ffecc7b971cf73a4bf2d62e1c8a20d7978a4b81173fe2329c5da48fa5b5072b4ab9dd42bdd66420ee8182c94bafb379621c8d9dc9fa01a9469d82c1745ffe4a3
+  data.tar.gz: 0fbab2527ee173d00b150aad9f15a038736d0a067b6649ec9b72c30e535dec983a3037da1a56a5e685d8162ebaca445d1baa03042f9442f0c9c5a00cdc56c2ab

data/README.md

@@ -83,7 +83,7 @@ Finally, to test that your testing environment is set up correctly run `rake tes
 
 You now have effective_test_bot configured and you're ready to go.
 
-# How to use this gem
+## How to use this gem
 
 Effective TestBot provides 4 areas of support in writing [minitest](https://github.com/seattlerb/minitest) [capybara](https://github.com/jnicklas/capybara) tests. As a developer, use this gem to:
 

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '0.4.12'.freeze
+  VERSION = '0.4.13'.freeze
 end

data/test/support/effective_test_bot_assertions.rb

@@ -42,8 +42,12 @@ module EffectiveTestBotAssertions
     end
   end
 
-  def assert_submit_input(message = "(submit_input) Expected one or more input[type='submit'] to be present")
-    assert_selector 'input[type=submit]', message
+  def assert_form(selector, message = "(form) Expected visible form with selector :selector: to be present")
+    assert all(selector).present?, message.sub(':selector', selector)
+  end
+
+  def assert_submit_input(message = "(submit_input) Expected one or more visible input[type='submit'] to be present")
+    assert all('input[type=submit]').present?, message
   end
 
   def assert_page_status(status = 200, message = '(page_status) Expected :status: HTTP status code')

data/test/support/effective_test_bot_form_helper.rb

@@ -65,8 +65,18 @@ module EffectiveTestBotFormHelper
       page.execute_script "$('input[data-disable-with]').each(function(i) { $.rails.enableFormElement($(this)); });"
     end
 
-    label.present? ? find(:link_or_button, label).click : first(:css, "input[type='submit']").click
+    if label.present?
+      submit = find(:link_or_button, label)
+      assert submit.present?, "TestBotError: Unable to find a visible submit link or button on #{page.current_path} with the label #{label}"
+      submit.click
+    else
+      submit = first(:css, "input[type='submit']")
+      assert submit.present?, "TestBotError: Unable to find a visible input[type='submit'] on #{page.current_path}"
+      submit.click
+    end
+
     synchronize!
+    true
   end
 
   def with_raised_unpermitted_params_exceptions(&block)

data/test/test_bot/integration/application_test.rb

@@ -73,11 +73,16 @@ module TestBot
         return false unless CRUD_ACTIONS.include?(route.defaults[:action])
         return false unless route.defaults[:controller].present? && route.app.respond_to?(:controller)
 
-        controller_klass = (route.app.controller(route.defaults) rescue nil)
-        controller_instance = controller_klass.new()
+        begin
+          controller_klass = route.app.controller(route.defaults)
+          controller_instance = controller_klass.new()
+
+          # Is this a CRUD capable controller?
+          controller_instance.respond_to?(:new) && controller_instance.respond_to?(:create)
+        rescue => e
+          false
+        end
 
-        # Is this a CRUD capable controller?
-        controller_instance && controller_instance.respond_to?(:new) && controller_instance.respond_to?(:create)
       end
 
     end

data/test/test_botable/base_test.rb

@@ -31,21 +31,33 @@ module BaseTest
     EffectiveTestBot.skip?((current_test if defined?(current_test)), assertion)
   end
 
+  # There are numerous points of failure here, so we want to be very helpful with the error messages
   def find_or_create_resource!
-    existing = resource_class.last
-    (existing.present? && !existing.kind_of?(User)) ? existing : create_resource!
-  end
+    obj = resource_class.last
+    return obj if obj.present? && !obj.kind_of?(User)
+
+    hint = "Unable to find_or_create_resource!\nEither fixture/seed an instance of #{resource_class} or ensure that submitting form#new_#{resource_name} on #{(new_resource_path rescue nil) || 'the resource new page'} creates a new #{resource_name}"
 
-  def create_resource!
+    # It doesn't exist, so lets go to the new page and submit a form to build one
     without_screenshots do
+      assert((new_resource_path rescue nil), "TestBotError: Generated polymorphic route new_#{[*controller_namespace, resource_name].compact.join('_')}_path is undefined. #{hint}")
+
       visit(new_resource_path)
 
+      assert_form "form#new_#{resource_name}", "TestBotError: Failed to find form#new_#{resource_name}. #{hint}"
+
       within("form#new_#{resource_name}") do
-        fill_form(resource_attributes) and submit_novalidate_form
+        fill_form(resource_attributes)
+
+        assert_submit_input "TestBotError: Failed to find a visible input[type='submit'] on #{page.current_path}. #{hint}"
+        submit_novalidate_form
       end
     end
 
-    resource_class.last
+    obj = resource_class.last
+    assert obj.present?, "TestBotError: Failed to create a resource after submitting form. #{hint}"
+
+    obj
   end
 
   # Try to find a link_to_delete already on this page
@@ -76,7 +88,7 @@ module BaseTest
   end
 
   def new_resource_path # new
-    new_polymorphic_path([*controller_namespace, resource])
+    path = new_polymorphic_path([*controller_namespace, resource])
   end
 
   def edit_resource_path(resource) # edit

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 0.4.12
+  version: 0.4.13
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-02 00:00:00.000000000 Z
+date: 2016-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails