effective_test_bot 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8daba6efe86cb1bdf02b6894c786581de4b1a0d1
-  data.tar.gz: d894f71336ba73f58c5bc968b5eae7e69272f476
+  metadata.gz: e103116aeed8578d3cb62239ab87759208152860
+  data.tar.gz: a4978f5794f46d577111f8bbfbfbf32c0aafa9d6
 SHA512:
-  metadata.gz: 1d76c1ec917029ebed79bbb2b8c457573cc699aed07b45957831be86f0edddd08aea345054a29a89e5f799866071cc79d10a6abdad1ee21b4b7e91365e8ae2fd
-  data.tar.gz: 0602b7675e99bffc14cf809230532d2277c4285a11f069ead884f92c4c2575b6c3018f3ccb55e35732565246343fe8fb6b6b4df415457229e60e70b5eec66d03
+  metadata.gz: a18ae0e701b4e5abcd1275070c9347c10116b626896c6b59edcb7bfe2dcdfd987e7cf17a1fad08b8f6879b4de3eaa0182ccd81603d8f7b22e4108f84d56f0d92
+  data.tar.gz: c764261c4bbfbef91ac98864877dbae1f2e549b24b3cc01ed215a934c14cc3c68891fa821ea6367ddd5ef89e8af6d1cfa242b8f742b2fccf5ad300d6b6e0a7aa

data/app/helpers/effective_test_bot_controller_helper.rb

@@ -22,4 +22,12 @@ module EffectiveTestBotControllerHelper
 
     response.headers['Test-Bot-Assigns'] = Base64.encode64(test_bot_assigns.to_hash.to_json)
   end
+
+  # We get here if ApplicationController raised a ActionController::UnpermittedParameters error
+  def assign_test_bot_unpermitted_params_headers(exception)
+    if exception.kind_of?(ActionController::UnpermittedParameters)
+      response.headers['Test-Bot-Unpermitted-Params'] = Base64.encode64(exception.params.to_json)
+    end
+  end
+
 end

data/lib/effective_test_bot/engine.rb

@@ -30,6 +30,13 @@ module EffectiveTestBot
         if Rails.env.test?
           ActionController::Base.send :include, ::EffectiveTestBotControllerHelper
           ActionController::Base.send :after_filter, :assign_test_bot_http_headers
+
+          ApplicationController.instance_exec do
+            rescue_from ActionController::UnpermittedParameters do |exception|
+              assign_test_bot_unpermitted_params_headers(exception)
+            end
+          end
+
         end
       end
     end

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '0.4.0'.freeze
+  VERSION = '0.4.1'.freeze
 end

data/test/support/effective_test_bot_assertions.rb

@@ -29,6 +29,10 @@ module EffectiveTestBotAssertions
     assert_equal 0, errors.size, errors.ai
   end
 
+  def assert_no_unpermitted_params(message = 'Expected no unpermitted params')
+    assert_equal [], unpermitted_params, message
+  end
+
   # assert_flash
   # assert_flash :success
   # assert_flash :error, 'there was a specific error'

data/test/support/effective_test_bot_form_helper.rb

@@ -123,6 +123,21 @@ module EffectiveTestBotFormHelper
     submit_form(label)
   end
 
+  def with_raised_unpermitted_params_exceptions(&block)
+    action = nil
+
+    begin  # This will only work with Rails >= 4.0
+      action = ActionController::Parameters.action_on_unpermitted_parameters
+      ActionController::Parameters.action_on_unpermitted_parameters = :raise
+    rescue => e
+      puts 'unable to assign config.action_on_unpermitted_parameters = :raise, unpermitted params assertions disabled.'
+    end
+
+    yield
+
+    ActionController::Parameters.action_on_unpermitted_parameters = action if action.present?
+  end
+
   # The field here is going to be the %input{:type => file}. Files can be one or more pathnames
   # http://stackoverflow.com/questions/5188240/using-selenium-to-imitate-dragging-a-file-onto-an-upload-element/11203629#11203629
   def upload_effective_asset(field, files)

data/test/support/effective_test_bot_test_helper.rb

@@ -17,6 +17,7 @@ module EffectiveTestBotTestHelper
     # Assign the Flash and Assigns
     @flash = (JSON.parse(Base64.decode64(session.driver.response_headers['Test-Bot-Flash'])) rescue {})
     @assigns = (JSON.parse(Base64.decode64(session.driver.response_headers['Test-Bot-Assigns'])) rescue {})
+    @unpermitted_params = (JSON.parse(Base64.decode64(session.driver.response_headers['Test-Bot-Unpermitted-Params'])) rescue [])
   end
 
   # EffectiveTestBot includes an after_filter on ApplicationController to set an http header
@@ -29,4 +30,8 @@ module EffectiveTestBotTestHelper
     @assigns ||= (JSON.parse(Base64.decode64(page.response_headers['Test-Bot-Assigns'])) rescue {})
   end
 
+  def unpermitted_params
+    @unpermitted_params ||= (JSON.parse(Base64.decode64(page.response_headers['Test-Bot-Unpermitted-Params'])) rescue [])
+  end
+
 end

data/test/test_botable/crud_test.rb

@@ -23,11 +23,13 @@ module CrudTest
 
     within("form#new_#{resource_name}") do
       fill_form(resource_attributes)
-      submit_form
+      skip?(:unpermitted_params) == true ? submit_form : with_raised_unpermitted_params_exceptions { submit_form }
     end
 
     after = { count: resource_class.count, path: page.current_path }
 
+    assert_no_unpermitted_params '[create_valid: :unpermitted_params] Expected no unpermitted params' unless skip?(:unpermitted_params)
+
     refute_equal before[:count], after[:count], "Expected fill_form to create a #{resource_class} object"
     refute_equal(before[:path], after[:path], "[create_valid: :path] Expected unique before and after paths") unless skip?(:path)
 
@@ -86,12 +88,14 @@ module CrudTest
 
     within("form#edit_#{resource_name}_#{resource.id}") do
       fill_form(resource_attributes)
-      submit_form
+      skip?(:unpermitted_params) == true ? submit_form : with_raised_unpermitted_params_exceptions { submit_form }
     end
     resource = resource_class.find(resource.id)
 
     after = { count: resource_class.count, updated_at: (resource.updated_at rescue nil) }
 
+    assert_no_unpermitted_params '[update_valid: :unpermitted_params] Expected no unpermitted params' unless skip?(:unpermitted_params)
+
     assert_equal before[:count], after[:count], "Expected #{resource_class}.count to be unchanged"
     refute_equal(before[:updated_at], after[:updated_at], "Expected @#{resource_name}.updated_at to have changed") if resource.respond_to?(:updated_at)
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-06 00:00:00.000000000 Z
+date: 2015-07-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails