effective_storage 0.4.5 → 0.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8de0c7807726e325a8a2f34f1e205c14dd27740daed1f7622db12dd39fb865a2
-  data.tar.gz: 126797b758eed3ad5d192cde7ce3f365096dfad96ebdf232f217b8b5428b91b1
+  metadata.gz: ce0b1d8d9b061e3e2a3b81d4662a6ff7f4bea772bb3b639068e4148867b79e7c
+  data.tar.gz: 88115f4894e78a14807ef47eaf8af3f4f20e300ca42ac5f8e6148ff4b56aa84f
 SHA512:
-  metadata.gz: bba482aece015938fa979889a7d7da64ab68681100250409a3a147698c97274fe237c7257b2e2d5c6dec6ed97f8ab234e8b7cab654a36ab2a12ca53577996d07
-  data.tar.gz: 837259796bbbe60101329b80e96bfc0a1743b2b5afbcf42e2a59ef70b6ad97c433a5400bd8aeb91e5f9a5d01a44407599982f37c311fd29353a3b240341bf4e4
+  metadata.gz: c261ab3931f45c6892f7c1df8780e27f0f17fdf4af5b2eb1046682c8580496f23e9275f0a649f795c91421c33a012eacce8d352d335cf7150412640f97afe16a
+  data.tar.gz: e8bd885fe445aeb7b9b071cb101225199ff411ceb8da2194ed727ee18cb2e66d433640ef4e455190c6184ff40f1e6f350a43e67a0fc24e602ccf06a52c825917

data/app/models/concerns/active_storage_authorization.rb

@@ -14,6 +14,13 @@
 module ActiveStorageAuthorization
   extend ActiveSupport::Concern
 
+  AUTHORIZED_EFFECTIVE_DOWNLOADS = [
+    'Effective::CarouselItem', 
+    'Effective::PageBanner', 
+    'Effective::PageSection', 
+    'Effective::Permalink'
+  ]
+
   included do
     rescue_from(Effective::UnauthorizedStorageException, with: :unauthorized_active_storage_request)
   end
@@ -54,12 +61,18 @@ module ActiveStorageAuthorization
   def authorize_active_storage!
     return unless @blob.present?
 
+    # Disable strict loading and let the @blob just pull :attachments
+    @blob.strict_loading!(false) if @blob.try(:strict_loading?)
+
     # If the blob is not attached to anything, permit the blob
     return true if @blob.attachments.blank?
 
     # If the blob is an ActiveStorage::Variant it's been previously authorized
     return true if @blob.attachments.any? { |attachment| authorized_variant_download?(attachment) }
 
+    # If the blob is a known good effective class fast path it
+    return true if @blob.attachments.any? { |attachment| authorized_effective_download?(attachment) }
+
     # If we are authorized on any attached record, permit the download
     return true if @blob.attachments.any? { |attachment| authorized_attachment_download?(attachment) }
 
@@ -106,6 +119,12 @@ module ActiveStorageAuthorization
     attachment.record_type == 'ActiveStorage::VariantRecord'
   end
 
+  # These are always public images
+  # Fast path them so we don't have to load any user for a permission check
+  def authorized_effective_download?(attachment)
+    AUTHORIZED_EFFECTIVE_DOWNLOADS.include?(attachment.record_type)
+  end
+
   # This is a has_one_attached or has_many_attached record
   # Or an ActionText::RichText object, that belongs_to a record
   def authorized_attachment_download?(attachment)

data/lib/effective_storage/version.rb

@@ -1,3 +1,3 @@
 module EffectiveStorage
-  VERSION = '0.4.5'.freeze
+  VERSION = '0.4.6'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_storage
 version: !ruby/object:Gem::Version
-  version: 0.4.5
+  version: 0.4.6
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-11-29 00:00:00.000000000 Z
+date: 2023-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails