effective_resources 2.3.0 → 2.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0acfffc4958a2a571f0776a9f4e159c88ac9763df2309ed9b18e1a34c9b67fd1
-  data.tar.gz: f38964444f684fbf6d4a57291b24f8fcaac909f64ee88ef5120a6a1cc4109d5f
+  metadata.gz: 9fc4b2cb86902bbdc801204584d765041a0dded527e894eace36d5ea8d923f3f
+  data.tar.gz: ff36581881c3d5dd3667787cf0395c8b6b7b15676e583ac90e85c3e681a02a10
 SHA512:
-  metadata.gz: 66181b2e24aefa2ea7117a1feb0fb044c5b70a745276b9f0b39d28a9849cb1a0c772e5370742f3ed82e6f5d8886da9635398236076dd6fd8a3997aee52a49ea1
-  data.tar.gz: cd024fafd913cf073b390e07e4f85298315e55efd1bc8a7fc813bb17472acee7a1a7c33942c4951448c98bff7e3e43bdc57be8e6006656025585329b4d40619d
+  metadata.gz: a6bf9ede63c06935ee24d72e7b11d78950b7b1b2e3540338513ab18be3570a13e14189252279872f485f1755378ab180f4d3b517ad1e2c2b2564b2a9952035e9
+  data.tar.gz: 72aa0f77cef8f2f8477a50e50990a51eaf592e5889811a689e4a9fa095e5adb072d6cd8c626fd3945e831f22e4fb6b37d53a2b2349648d71320561b7244ad26a

data/app/controllers/concerns/effective/crud_controller/dsl.rb

@@ -34,8 +34,10 @@ module Effective
       # submit :toggle, 'Blacklist', if: -> { sync? }, class: 'btn btn-primary'
       # submit :toggle, 'Whitelist', if: -> { !sync? }, class: 'btn btn-primary'
       # submit :save, 'Save', success: -> { "#{resource} was saved okay!" }
-      def submit(action, label = nil, args = {})
-        _insert_submit(action, label, args)
+      def submit(action, label, args = {})
+        instance_exec do
+          before_action { _insert_submit(action, label, args) }
+        end
       end
 
       # This controls the resource buttons section of the page
@@ -46,13 +48,17 @@ module Effective
       # button :approve, 'Approve', unless: -> { resource.approved? }, redirect: :show
       # button :decline, false
       def button(action, label = nil, args = {})
-        _insert_button(action, label, args)
+        instance_exec do
+          before_action { _insert_button(action, label, args) }
+        end
       end
 
       # This is a way of defining the redirect, flash etc of any action without tweaking defaults
       # submit and buttons options will be merged ontop of these
       def on(action, args = {})
-        _insert_on(action, args)
+        instance_exec do
+          before_action { _insert_on(action, args) }
+        end
       end
 
       # page_title 'My Title', only: [:new]

data/app/controllers/concerns/effective/crud_controller/save.rb

@@ -4,10 +4,8 @@ module Effective
 
       # Based on the incoming params[:commit] or passed action. Merges all options.
       def commit_action(action = nil)
-        #config = (['create', 'update'].include?(params[:action]) ? self.class.submits : self.class.buttons)
-
-        config = self.class.submits
-        ons = self.class.ons
+        config = self.submits()
+        ons = self.ons()
 
         commit = config[params[:commit].to_s]
         commit ||= config.find { |_, v| v[:action] == action }.try(:last)

data/app/controllers/concerns/effective/crud_controller/submits.rb

@@ -1,122 +1,122 @@
 module Effective
   module CrudController
     module Submits
-      extend ActiveSupport::Concern
 
-      module ClassMethods
-        # { 'Save' => { action: save, ...}}
-        def submits
-          @_effective_submits ||= effective_resource.submits
-        end
-
-        # { 'Approve' => { action: approve, ...}}
-        def buttons
-          @_effective_buttons ||= effective_resource.buttons
-        end
-
-        # { :approve => { redirect: .. }}
-        def ons
-          @_effective_ons ||= effective_resource.ons
-        end
+      # { 'Save' => { action: save, ...}}
+      def submits
+        @_effective_submits ||= effective_resource.submits()
+      end
 
-        # :only, :except, :if, :unless, :redirect, :success, :danger, :class
-        def _insert_submit(action, label = nil, args = {})
-          raise 'expected args to be a Hash or false' unless args.kind_of?(Hash) || args == false
+      # { 'Approve' => { action: approve, ...}}
+      def buttons
+        @_effective_buttons ||= effective_resource.buttons()
+      end
 
-          if label == false
-            submits.delete_if { |label, args| args[:action] == action }; return
-          end
+      # { :approve => { redirect: .. }}
+      def ons
+        @_effective_ons ||= effective_resource.ons()
+      end
 
-          if args == false
-            submits.delete(label); return
-          end
+      # :only, :except, :if, :unless, :redirect, :success, :danger, :class
+      def _insert_submit(action, label = nil, args = {})
+        raise "expected first argument to be a Symbol. Try submit :approve, 'Approve'" unless action.kind_of?(Symbol)
+        raise 'expected args to be a Hash or false' unless args.kind_of?(Hash) || args == false
 
-          if label # Overwrite the default member action when given a custom submit
-            submits.delete_if { |label, args| args[:default] && args[:action] == action }
-          end
+        if label == false
+          submits.delete_if { |label, args| args[:action] == action }; return
+        end
 
-          if args.key?(:if) && args[:if].respond_to?(:call) == false
-            raise "expected if: to be callable. Try submit :approve, 'Save and Approve', if: -> { resource.finished? }"
-          end
+        if args == false
+          submits.delete(label); return
+        end
 
-          if args.key?(:unless) && args[:unless].respond_to?(:call) == false
-            raise "expected unless: to be callable. Try submit :approve, 'Save and Approve', unless: -> { resource.declined? }"
-          end
+        if label # Overwrite the default member action when given a custom submit
+          submits.delete_if { |label, args| args[:default] && args[:action] == action }
+        end
 
-          if args.key?(:only)
-            args[:only] = Array(args[:only])
-            raise "expected only: to be a symbol or array of symbols. Try submit :approve, 'Save and Approve', only: [:edit]" unless args[:only].all? { |v| v.kind_of?(Symbol) }
-          end
+        if args.key?(:if) && args[:if].respond_to?(:call) == false
+          raise "expected if: to be callable. Try submit :approve, 'Save and Approve', if: -> { resource.finished? }"
+        end
 
-          if args.key?(:except)
-            args[:except] = Array(args[:except])
-            raise "expected except: to be a symbol or array of symbols. Try submit :approve, 'Save and Approve', except: [:edit]" unless args[:except].all? { |v| v.kind_of?(Symbol) }
-          end
+        if args.key?(:unless) && args[:unless].respond_to?(:call) == false
+          raise "expected unless: to be callable. Try submit :approve, 'Save and Approve', unless: -> { resource.declined? }"
+        end
 
-          if args.key?(:redirect_to) # Normalize this option to redirect
-            args[:redirect] = args.delete(:redirect_to)
-          end
+        if args.key?(:only)
+          args[:only] = Array(args[:only])
+          raise "expected only: to be a symbol or array of symbols. Try submit :approve, 'Save and Approve', only: [:edit]" unless args[:only].all? { |v| v.kind_of?(Symbol) }
+        end
 
-          args[:action] = action
+        if args.key?(:except)
+          args[:except] = Array(args[:except])
+          raise "expected except: to be a symbol or array of symbols. Try submit :approve, 'Save and Approve', except: [:edit]" unless args[:except].all? { |v| v.kind_of?(Symbol) }
+        end
 
-          (submits[label] ||= {}).merge!(args)
+        if args.key?(:redirect_to) # Normalize this option to redirect
+          args[:redirect] = args.delete(:redirect_to)
         end
 
-        def _insert_button(action, label = nil, args = {})
-          raise 'expected args to be a Hash or false' unless args.kind_of?(Hash) || args == false
+        args[:action] = action
 
-          if label == false
-            buttons.delete_if { |label, args| args[:action] == action }; return
-          end
+        (submits[label] ||= {}).merge!(args)
+      end
 
-          if args == false
-            buttons.delete(label); return
-          end
+      def _insert_button(action, label = nil, args = {})
+        raise "expected first argument to be a Symbol. Try button :approve, 'Approve'" unless action.kind_of?(Symbol)
+        raise 'expected args to be a Hash or false' unless args.kind_of?(Hash) || args == false
 
-          if label # Overwrite the default member action when given a custom label
-            buttons.delete_if { |label, args| args[:default] && args[:action] == action }
-          end
+        if label == false
+          buttons.delete_if { |label, args| args[:action] == action }; return
+        end
 
-          if args.key?(:if) && args[:if].respond_to?(:call) == false
-            raise "expected if: to be callable. Try button :approve, 'Approve', if: -> { resource.finished? }"
-          end
+        if args == false
+          buttons.delete(label); return
+        end
 
-          if args.key?(:unless) && args[:unless].respond_to?(:call) == false
-            raise "expected unless: to be callable. Try button :approve, 'Approve', unless: -> { resource.declined? }"
-          end
+        if label # Overwrite the default member action when given a custom label
+          buttons.delete_if { |label, args| args[:default] && args[:action] == action }
+        end
 
-          if args.key?(:only)
-            args[:only] = Array(args[:only])
-            raise "expected only: to be a symbol or array of symbols. Try button :approve, 'Save and Approve', only: [:edit]" unless args[:only].all? { |v| v.kind_of?(Symbol) }
-          end
+        if args.key?(:if) && args[:if].respond_to?(:call) == false
+          raise "expected if: to be callable. Try button :approve, 'Approve', if: -> { resource.finished? }"
+        end
 
-          if args.key?(:except)
-            args[:except] = Array(args[:except])
-            raise "expected except: to be a symbol or array of symbols. Try button :approve, 'Save and Approve', except: [:edit]" unless args[:except].all? { |v| v.kind_of?(Symbol) }
-          end
+        if args.key?(:unless) && args[:unless].respond_to?(:call) == false
+          raise "expected unless: to be callable. Try button :approve, 'Approve', unless: -> { resource.declined? }"
+        end
 
-          if args.key?(:redirect_to) # Normalize this option to redirect
-            args[:redirect] = args.delete(:redirect_to)
-          end
+        if args.key?(:only)
+          args[:only] = Array(args[:only])
+          raise "expected only: to be a symbol or array of symbols. Try button :approve, 'Save and Approve', only: [:edit]" unless args[:only].all? { |v| v.kind_of?(Symbol) }
+        end
 
-          args[:action] = action
+        if args.key?(:except)
+          args[:except] = Array(args[:except])
+          raise "expected except: to be a symbol or array of symbols. Try button :approve, 'Save and Approve', except: [:edit]" unless args[:except].all? { |v| v.kind_of?(Symbol) }
+        end
 
-          (buttons[label] ||= {}).merge!(args)
+        if args.key?(:redirect_to) # Normalize this option to redirect
+          args[:redirect] = args.delete(:redirect_to)
         end
 
-        def _insert_on(action, args = {})
-          raise 'expected args to be a Hash' unless args.kind_of?(Hash)
+        args[:action] = action
 
-          if args.key?(:redirect_to) # Normalize this option to redirect
-            args[:redirect] = args.delete(:redirect_to)
-          end
+        (buttons[label] ||= {}).merge!(args)
+      end
 
-          args[:action] = action
+      def _insert_on(action, args = {})
+        raise "expected first argument to be a Symbol. Try on :approve, success: -> { ... }" unless action.kind_of?(Symbol)
+        raise 'expected args to be a Hash' unless args.kind_of?(Hash)
 
-          (ons[action] ||= {}).merge!(args)
+        if args.key?(:redirect_to) # Normalize this option to redirect
+          args[:redirect] = args.delete(:redirect_to)
         end
-      end
 
+        args[:action] = action
+
+        (ons[action] ||= {}).merge!(args)
+      end
     end
+
   end
 end

data/app/controllers/concerns/effective/crud_controller.rb

@@ -18,21 +18,7 @@ module Effective
     module ClassMethods
       include Effective::CrudController::Dsl
 
-      # This is used for the buttons/submits/ons
-      # It doesn't really work with the resource_scope correctly but the routes are important here
-      def effective_resource
-        @_effective_resource ||= begin
-          controller = new()
-          klass = (controller.resource_scope_relation.call().try(:klass) rescue false) if controller.respond_to?(:resource_scope_relation)
-
-          if klass.present?
-            namespace = controller_path.split('/')[0...-1].join('/').presence
-            Effective::Resource.new(klass, namespace: namespace)
-          else
-            Effective::Resource.new(controller_path)
-          end
-        end
-      end
+      def effective_crud_controller?; true; end
     end
 
     def resource # @thing

data/app/helpers/effective_resources_helper.rb

@@ -1,10 +1,9 @@
 # frozen_string_literal: true
 
 module EffectiveResourcesHelper
-
   # effective_bootstrap
   def effective_submit(form, options = {}, &block)
-    actions = (controller.respond_to?(:effective_resource) ? controller.class : find_effective_resource).submits
+    actions = controller.try(:submits) || raise('controller must be an Effective::CrudController')
     actions = actions.select { |k, v| v[:default] != true } if options.delete(:defaults) == false
     actions = permitted_resource_actions(form.object, actions)
 
@@ -17,7 +16,7 @@ module EffectiveResourcesHelper
 
   # effective_form_inputs
   def simple_form_submit(form, options = {}, &block)
-    actions = (controller.respond_to?(:effective_resource) ? controller.class : find_effective_resource).submits
+    actions = controller.try(:submits) || raise('controller must be an Effective::CrudController')
     actions = permitted_resource_actions(form.object, actions)
 
     submits = actions.map { |name, opts| form.button(:submit, name, opts.except(:action, :title, 'data-method')) }
@@ -38,7 +37,7 @@ module EffectiveResourcesHelper
 
   def render_resource_buttons(resource, atts = {}, &block)
     effective_resource = find_effective_resource
-    actions = (controller.respond_to?(:effective_resource) ? controller.class : effective_resource).buttons
+    actions = controller.try(:buttons) || raise('controller must be an Effective::CrudController')
 
     actions = if resource.kind_of?(Class)
       actions.select { |_, v| effective_resource.collection_get_actions.include?(v[:action]) }
@@ -302,19 +301,11 @@ module EffectiveResourcesHelper
   end
 
   def effective_translate(resource, attribute = nil)
-    return translate(resource) unless resource.respond_to?(:model_name)
-
-    if attribute.blank?
-      resource.model_name.human
-    elsif resource.respond_to?(:human_attribute_name)
-      resource.human_attribute_name(attribute)
-    else
-      resource.class.human_attribute_name(attribute)
-    end
+    EffectiveResources.et(resource, attribute)
   end
 
   def effective_translates(resource, attribute = nil)
-    effective_translate(resource, attribute).pluralize
+    EffectiveResources.ets(resource, attribute)
   end
 
   alias_method :et, :effective_translate

data/lib/effective_resources/version.rb

@@ -1,3 +1,3 @@
 module EffectiveResources
-  VERSION = '2.3.0'.freeze
+  VERSION = '2.4.0'.freeze
 end

data/lib/effective_resources.rb

@@ -178,4 +178,20 @@ module EffectiveResources
     end
   end
 
+  def self.et(resource, attribute = nil)
+    return I18n.t(resource) unless resource.respond_to?(:model_name)
+
+    if attribute.blank?
+      resource.model_name.human
+    elsif resource.respond_to?(:human_attribute_name)
+      resource.human_attribute_name(attribute)
+    else
+      resource.class.human_attribute_name(attribute)
+    end
+  end
+
+  def self.ets(resource, attribute = nil)
+    et(resource, attribute).pluralize
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_resources
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.4.0
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-02-09 00:00:00.000000000 Z
+date: 2023-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails