effective_resources 1.18.10 → 1.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c513100225a155db0f3922dbfcecfda7dc40b94b98746273053f35c2bf6c5d0b
-  data.tar.gz: 3669286a34fe2c0304d1a10a74e446279a7600f88766687e9e7cdbd06cbdc8f9
+  metadata.gz: 2ee4ff2d3193e327ddaa6fd457d83df4342e1ccfd1a5a0d2d06525ee5e8b5ce3
+  data.tar.gz: 63c5eebe27c1f4a49fba71dd2e1b69a92ce73faa35c915f53f77b4fca8dc8beb
 SHA512:
-  metadata.gz: f10ad3eafe4170593b01a684f8c68dfdbffa8748fbc61ef60892385b2d4d8e12eddb1d1b3855c6bc99afa56f33631a1e238b6485e7b5daa7f8a7678d0f457514
-  data.tar.gz: 37f1b0a1c9d54da6783641729225f18815d60aa7d78e1ea07d86897e855a8b527317763a62c6bc36f393f2ea8eaf62837d432d217c8076c2d90d3c7ce8f4c0ee
+  metadata.gz: d6f2209d606a8e800f9d9b715b06dfbe1d230f73dd429728257d2f7b2876211bba08a5111cf992a9ed20c92f8d320bf62a2cae994c550d8e27b354e4ea602c3d
+  data.tar.gz: 7d78f999628f819a663debe59ffd1799c1b8caeaafb264e4fe986b90f23a573d63d019612e83b455c75fb2741510367f706015b9c5587b0b24b731e3b398286a

data/app/controllers/concerns/effective/crud_controller/save.rb

@@ -29,44 +29,43 @@ module Effective
         end
 
         success = false
+        exception = nil
 
-        EffectiveResources.transaction(resource) do
-          begin
-            run_callbacks(:resource_before_save)
+        begin
+          ActiveRecord::Base.transaction do
+            EffectiveResources.transaction(resource) do
+              run_callbacks(:resource_before_save)
 
-            if resource.public_send("#{save_action}!") == false
-              raise Effective::ActionFailed.new("failed to #{action}")
-            end
+              if resource.public_send("#{save_action}!") == false
+                raise Effective::ActionFailed.new("failed to #{action}")
+              end
 
-            yield if block_given?
+              yield if block_given?
 
-            run_callbacks(:resource_after_save)
+              run_callbacks(:resource_after_save)
 
-            success = true
-          rescue => e
-            if Rails.env.development?
-              Rails.logger.info "  \e[31m\e[1mFAILED\e[0m\e[22m" # bold red
-              Rails.logger.info "  Unable to #{action} #{resource} - #{e.class} #{e}"
-              e.backtrace.first(5).each { |line| Rails.logger.info('  ' + line) }
+              success = true
+            rescue Effective::ActionFailed => e
+              exception = e   # Dont rollback
             end
+          end
+        rescue => e
+          exception = e
+        end
 
-            if resource.respond_to?(:restore_attributes) && resource.persisted?
-              resource.restore_attributes(['status', 'state'])
-            end
+        if exception.present?
+          Rails.logger.info "  \e[31m\e[1mFAILED\e[0m\e[22m" # bold red
+          Rails.logger.info "  Unable to #{action} #{resource} - #{e.class} #{e}"
+          exception.backtrace.first(5).each { |line| Rails.logger.info('  ' + line) }
 
-            flash.now[:danger] = resource_flash(:danger, resource, action, e: e)
-
-            case e
-            when ActiveRecord::StaleObjectError
-              flash.now[:danger] = "#{flash.now[:danger]} <a href='#', class='alert-link' onclick='window.location.reload(true); return false;'>reload page and try again</a>"
-              raise(ActiveRecord::Rollback) # This is a soft error, we want to display the flash message to user
-            when Effective::ActionFailed
-              # Nothing to do
-            when ActiveRecord::RecordInvalid, RuntimeError
-              raise(ActiveRecord::Rollback) # This is a soft error, we want to display the flash message to user
-            else
-              raise(e) # This is a real error that should be sent to 500. Client should not see the message.
-            end
+          if resource.respond_to?(:restore_attributes) && resource.persisted?
+            resource.restore_attributes(['status', 'state'])
+          end
+
+          flash.now[:danger] = resource_flash(:danger, resource, action, e: e)
+
+          if exception.kind_of?(ActiveRecord::StaleObjectError)
+            flash.now[:danger] = "#{flash.now[:danger]} <a href='#', class='alert-link' onclick='window.location.reload(true); return false;'>reload page and try again</a>"
           end
         end
 

data/lib/effective_resources/version.rb

@@ -1,3 +1,3 @@
 module EffectiveResources
-  VERSION = '1.18.10'.freeze
+  VERSION = '1.19.0'.freeze
 end

data/lib/effective_resources.rb

@@ -87,10 +87,7 @@ module EffectiveResources
   end
 
   def self.transaction(resource = nil, &block)
-    connection = 'ActiveRecord::Base'.safe_constantize
-    raise('unable to determine transaction class') unless connection.present?
-
-    connection.transaction { yield }
+    resource.class.transaction { yield }
   end
 
   # Used by streaming CSV export in datatables

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_resources
 version: !ruby/object:Gem::Version
-  version: 1.18.10
+  version: 1.19.0
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-09-12 00:00:00.000000000 Z
+date: 2022-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails