effective_qb_online 0.9.3 → 0.9.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c95b4f3d60018350ce0d6e4648aa36f90843879955fb36fe26c1c35c0886e04b
-  data.tar.gz: 72cf727a8dc9b8bceb893d93e2f5590ad97d0f1044454b9df6d6979c7578bc6d
+  metadata.gz: 75e9d79cb2a17b67a7c5d6add16160822d572e40122a89ba4b64541850a2457d
+  data.tar.gz: 2cf7ab4cd08e0ae4ad9cc4bdfc090eba23b86c93d6e3d554452689377fb8e798
 SHA512:
-  metadata.gz: a0d3c53199c2180fd09cc521cc6220bfa2a22e6c06349ef4d69590117102feea3c976267bbb52e8c470a3cf719e5908070779d2c10dce4bec70ea2bfdceec40d
-  data.tar.gz: 1d9eb040272f847b00e4066c29dd4e8feb2fb15079e50f6f5b76e5314c2d6fac7a8753a0f515a15c9b13d506c5f3e139116dd716a0f41f0e0157f430753fc949
+  metadata.gz: ca7e1412b2d19086a5e55acf282e6b023970323ba255e342e5f1a8582f5179a166debde4447ab9d7d7050fdd14e358c591fae04bb5d4ffe2cf8a520e2a0ebeb9
+  data.tar.gz: 38a668cff06a99766b813d045939b2b06048b30c775a599b46746f25d05aed34a456e7a61737cb6b47a54223d792e00304346aae7fc13cb502423825844b2c4e

data/app/models/effective/qb_api.rb

@@ -51,11 +51,11 @@ module Effective
 
     # Singular
     def company_info
-      with_service('CompanyInfo') { |service| service.fetch_by_id(realm.realm_id) }
+      @company_info ||= with_service('CompanyInfo') { |service| service.fetch_by_id(realm.realm_id) }
     end
 
     def accounts
-      with_service('Account') { |service| service.all }
+      @accounts ||= with_service('Account') { |service| service.all }
     end
 
     # Only accounts we can use for the Deposit to Account setting
@@ -68,7 +68,7 @@ module Effective
     end
 
     def items
-      with_service('Item') { |service| service.all }
+      @items ||= with_service('Item') { |service| service.all }
     end
 
     def items_collection
@@ -90,7 +90,7 @@ module Effective
     end
 
     def payment_methods
-      with_service('PaymentMethod') { |service| service.all }
+      @payment_methods ||= with_service('PaymentMethod') { |service| service.all }
     end
 
     def payment_methods_collection
@@ -154,38 +154,40 @@ module Effective
     end
 
     def tax_codes
-      with_service('TaxCode') { |service| service.all }
+      @tax_codes ||= with_service('TaxCode') { |service| service.all }
     end
 
     def tax_rates
-      with_service('TaxRate') { |service| service.all }
+      @tax_rates ||= with_service('TaxRate') { |service| service.all }
     end
 
     # Returns a Hash of BigDecimal.to_s String Tax Rate => TaxCode Object
     # { '0.0' => 'Quickbooks::Model::TaxCode(Exempt)', '5.0' => 'Quickbooks::Model::TaxCode(GST)' }
     def taxes_collection
-      rates = tax_rates()
-      codes = tax_codes()
+      @taxes_collection ||= begin
+        rates = tax_rates()
+        codes = tax_codes()
 
-      # Find Exempt 0.0
-      exempt = codes.find do |code|
-        rate_id = code.sales_tax_rate_list.tax_rate_detail.first&.tax_rate_ref&.value
-        rate = rates.find { |rate| rate.id == rate_id } if rate_id
+        # Find Exempt 0.0
+        exempt = codes.find do |code|
+          rate_id = code.sales_tax_rate_list.tax_rate_detail.first&.tax_rate_ref&.value
+          rate = rates.find { |rate| rate.id == rate_id } if rate_id
 
-        code.name.downcase.include?('exempt') && rate && rate.rate_value == 0.0
-      end
+          code.name.downcase.include?('exempt') && rate && rate.rate_value == 0.0
+        end
 
-      exempt = [['0.0', exempt]] if exempt.present?
+        exempt = [['0.0', exempt]] if exempt.present?
 
-      # Find The rest
-      tax_codes = codes.select(&:active?).map do |code|
-        rate_id = code.sales_tax_rate_list.tax_rate_detail.first&.tax_rate_ref&.value
-        rate = rates.find { |rate| rate.id == rate_id } if rate_id
+        # Find The rest
+        tax_codes = codes.select(&:active?).map do |code|
+          rate_id = code.sales_tax_rate_list.tax_rate_detail.first&.tax_rate_ref&.value
+          rate = rates.find { |rate| rate.id == rate_id } if rate_id
 
-        [rate.rate_value.to_s, code] if rate && (exempt.blank? || rate.rate_value.to_f > 0.0)
-      end
+          [rate.rate_value.to_s, code] if rate && (exempt.blank? || rate.rate_value.to_f > 0.0)
+        end
 
-      (Array(exempt) + tax_codes.compact.uniq { |key, _| key }).to_h
+        (Array(exempt) + tax_codes.compact.uniq { |key, _| key }).to_h
+      end
     end
 
     def with_service(name, &block)
@@ -193,18 +195,35 @@ module Effective
 
       with_authenticated_request do |access_token|
         service = klass.new(company_id: realm.realm_id, access_token: access_token)
+
+        # quickbooks-ruby's rebuild_connection! creates a new Faraday connection
+        # on every service call with no timeouts. Reuse a single connection with
+        # timeouts so all calls share one TCP connection via HTTP keep-alive.
+        service.oauth.client.connection = faraday_connection
+
         yield(service)
       end
     end
 
     private
 
+    def faraday_connection
+      @faraday_connection ||= Faraday.new do |faraday|
+        faraday.request :multipart
+        faraday.request :gzip
+        faraday.request :url_encoded
+        faraday.options.open_timeout = 10
+        faraday.options.timeout = 30
+        faraday.adapter Quickbooks.http_adapter
+      end
+    end
+
     def with_authenticated_request(max_attempts: 3, &block)
       attempts = 0
 
       begin
-        token = OAuth2::AccessToken.new(EffectiveQbOnline.oauth2_client, realm.access_token, refresh_token: realm.refresh_token)
-        yield(token)
+        @access_token ||= OAuth2::AccessToken.new(EffectiveQbOnline.oauth2_client, realm.access_token, refresh_token: realm.refresh_token)
+        yield(@access_token)
       rescue OAuth2::Error, Quickbooks::AuthorizationFailure => e
         puts "QuickBooks OAuth Error: #{e.message}"
 
@@ -212,7 +231,8 @@ module Effective
         raise "unable to refresh QuickBooks OAuth2 token" if attempts >= max_attempts
 
         # Refresh
-        refreshed = token.refresh!
+        refreshed = @access_token.refresh!
+        @access_token = nil  # Clear memoized token so it's rebuilt with new credentials
 
         realm.update!(
           access_token: refreshed.token,

data/lib/effective_qb_online/version.rb

@@ -1,3 +1,3 @@
 module EffectiveQbOnline
-  VERSION = '0.9.3'.freeze
+  VERSION = '0.9.4'.freeze
 end

data/lib/effective_qb_online.rb

@@ -21,12 +21,15 @@ module EffectiveQbOnline
   end
 
   def self.oauth2_client
-    OAuth2::Client.new(
+    @oauth2_client ||= OAuth2::Client.new(
       oauth_client_id,
       oauth_client_secret,
       site: 'https://appcenter.intuit.com/connect/oauth2',
       authorize_url: 'https://appcenter.intuit.com/connect/oauth2',
-      token_url: 'https://oauth.platform.intuit.com/oauth2/v1/tokens/bearer'
+      token_url: 'https://oauth.platform.intuit.com/oauth2/v1/tokens/bearer',
+      connection_opts: {
+        request: { open_timeout: 10, timeout: 30 }
+      }
     )
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_qb_online
 version: !ruby/object:Gem::Version
-  version: 0.9.3
+  version: 0.9.4
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-03-02 00:00:00.000000000 Z
+date: 2026-03-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -137,7 +137,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: haml
+  name: haml-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -164,6 +164,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: psych
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: wicked
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: effective_test_bot
   requirement: !ruby/object:Gem::Requirement
@@ -260,7 +288,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.5.9
 signing_key:
 specification_version: 4
 summary: Create QuickBooks Online SalesReceipts for purchased effective orders