effective_orders 6.3.0 → 6.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6bf799fd1e295b06b3e96d6083298bc3d56af80d2e5fc45aee9a3c45026e13bc
-  data.tar.gz: b03d84f686b369b97052b17f5b204b029d5ff79ab67bb8dd095e2b86a36af4be
+  metadata.gz: 79e445447643f3b8f6dc4d1580016faeb8fa2a55ec8c0ebe902b92b9e83861e7
+  data.tar.gz: eeb3097f18e106737fa428099e1e20d26e4ac630dc0dafa3bac74640196d5ef8
 SHA512:
-  metadata.gz: d96a318e778addc0d4174320c64fb54a0cf2c1e79fb0e4ea2286f69b5330562b08bdce127d9a4e02faae31afee9ebe1a1f0e043586623b92416c0256ced24d45
-  data.tar.gz: 6750bfa2d3c93be7cf208b0f8cc84dc355f7aab77a02553451e78d6c6a0b7ce10289ca8e4ca40ed1b93bf80594f40bc37b51d4b215d2742036565ef75b499b44
+  metadata.gz: d33e07601346e3dadc7edef24182911b23631a4b1d7ffd45c1c782f4060d2c45e50c6502dae447158649c23ec32fad30dfc19dcbabd5eb5bc123276acf5db81e
+  data.tar.gz: 8c0b0a04fd6b39c111f09a998fe495b4e7ce2001d185b3eadca02700000f370027f682e189d1c2f0a8131fdb20081a99d8266904710bdf2a79b9827b2c6d0c48

data/app/models/concerns/acts_as_purchasable.rb

@@ -80,7 +80,7 @@ module ActsAsPurchasable
     elsif value.blank?
       super
     else
-      raise 'expected price to be an Integer representing the number of cents.'
+      raise "expected price to be an Integer representing the number of cents. Got: #{value}"
     end
   end
 

data/app/models/effective/order.rb

@@ -116,14 +116,11 @@ module Effective
 
     # Price validations
     validates :subtotal, presence: true
+    validates :total, presence: true, if: -> { EffectiveOrders.minimum_charge.to_i > 0 }
 
-    with_options(if: -> { EffectiveOrders.minimum_charge.to_i > 0 }) do
-      validates :total, presence: true
-
-      validate(unless: -> { (free? && EffectiveOrders.free?) || (refund? && EffectiveOrders.refund?) }) do
-        if total.present? && total < EffectiveOrders.minimum_charge
-          errors.add(:total, "must be $#{'%0.2f' % (EffectiveOrders.minimum_charge.to_i / 100.0)} or more. Please add additional items.")
-        end
+    validate(if: -> { total.present? && EffectiveOrders.minimum_charge.to_i > 0 }, unless: -> { purchased? || (free? && EffectiveOrders.free?) || (refund? && EffectiveOrders.refund?) }) do
+      if total < EffectiveOrders.minimum_charge
+        errors.add(:total, "must be $#{'%0.2f' % (EffectiveOrders.minimum_charge.to_i / 100.0)} or more. Please add additional items.")
       end
     end
 

data/app/models/effective/order_item.rb

@@ -1,4 +1,7 @@
+# frozen_string_literal: true
+
 module Effective
+  # An Order Item
   class OrderItem < ActiveRecord::Base
     self.table_name = EffectiveOrders.order_items_table_name.to_s
 
@@ -9,9 +12,7 @@ module Effective
 
     log_changes(to: :order) if respond_to?(:log_changes)
 
-    if defined?(EffectiveQbSync)
-      has_one :qb_order_item
-    end
+    has_one :qb_order_item if defined?(EffectiveQbSync)
 
     effective_resource do
       name                  :string

data/lib/effective_orders/version.rb

@@ -1,3 +1,3 @@
 module EffectiveOrders
-  VERSION = '6.3.0'.freeze
+  VERSION = '6.3.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_orders
 version: !ruby/object:Gem::Version
-  version: 6.3.0
+  version: 6.3.1
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-03-22 00:00:00.000000000 Z
+date: 2023-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails