effective_messaging 0.7.2 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c36f8cc8cf0b957ff2cd66b902bb3e99cf13673d70da3a086bf837e7b424a6dd
-  data.tar.gz: 83a47842b7805daa82768dd1457c516b2bdcebd14adbac0000c09f3f4c3af9c7
+  metadata.gz: 5daa32cf8a7384da19b824c0dcf5cdea5cf3797e03fbadc420ecf8b99275d3e2
+  data.tar.gz: f7bfb3dfefc8a06cb959ecd874e7ae8f4c389b17639496d96637e78b865412bc
 SHA512:
-  metadata.gz: 0465d662b13537968d2b36fb6634c308321853290be44ad4763ee5c350fc633a9c45eca56f8f201fb160dcea44b32662ee0d5019dedf7e4511d3c76d82615612
-  data.tar.gz: de0aee24647a2068e4d8e37f6c72d9e8f90697eb7616d808b174ada792b5e1a12e32bcf7bec2eab52e177187168b86822d752a5554fb6b04f8f0186876ede8dd
+  metadata.gz: 99d125bebd71348909a9f60a336778cf0f53e70c1dca482b8a83250348054ea1ab8f6525dd494b05299d39da20756f1bbaa396f811ec20bd3beb4784593370d3
+  data.tar.gz: c1debff84d85589cd398fa01d2c0cfcabf8c450a4f05f2986253678df606787f3a3675de60b7b7bdd5040502e73460b3aeb681912dd958d20b38fa74527046df

data/app/models/effective/notification.rb

@@ -278,16 +278,28 @@ module Effective
 
       report.collection().find_each do |resource|
         next unless notifiable?(resource) || force
+
+        # Send Now functionality. Don't duplicate if it's same day.
+        next if force && already_notified_today?(resource)
+
         print('.')
 
-        # For logging
-        assign_attributes(current_resource: resource)
+        begin
+          # For logging
+          assign_attributes(current_resource: resource)
 
-        # Send the resource email
-        build_notification_log(resource: resource).save!
-        Effective::NotificationsMailer.notify_resource(self, resource).deliver_now
+          # Send the resource email
+          Effective::NotificationsMailer.notify_resource(self, resource).deliver_now
 
-        notified += 1
+          # Log that it was sent
+          build_notification_log(resource: resource).save!
+
+          # Count how many we actually sent
+          notified += 1
+        rescue => e
+          EffectiveLogger.error(e.message, associated: self) if defined?(EffectiveLogger)
+          ExceptionNotifier.notify_exception(e, data: { notification_id: id, resource_id: resource.id, resource_type: resource.class.name }) if defined?(ExceptionNotifier)
+        end
 
         GC.start if (notified % 250) == 0
       end
@@ -299,9 +311,19 @@ module Effective
       notified = 0
 
       if notifiable_scheduled? || force
-        build_notification_log(resource: nil).save!
-        Effective::NotificationsMailer.notify(self).deliver_now
-        notified += 1
+        begin
+          Effective::NotificationsMailer.notify(self).deliver_now
+
+          # Log that it was sent
+          build_notification_log(resource: nil).save!
+
+          # Count how many we actually sent
+          notified += 1
+        rescue => e
+          EffectiveLogger.error(e.message, associated: self) if defined?(EffectiveLogger)
+          ExceptionNotifier.notify_exception(e, data: { notification_id: id }) if defined?(ExceptionNotifier)
+        end
+
       end
 
       notified > 0 ? update!(last_notified_at: Time.zone.now, last_notified_count: notified) : touch
@@ -324,6 +346,17 @@ module Effective
       notifiable?(resource, date: date)
     end
 
+    def already_notified_today?(resource)
+      email = resource_email(resource) || resource_user(resource).try(:email)
+      raise("expected an email for #{report} #{report&.id} and #{resource} #{resource&.id}") unless email.present?
+
+      logs = notification_logs.select { |log| log.email == email }
+      return false if logs.count == 0
+
+      # If we already notified today
+      logs.any? { |log| log.created_at&.beginning_of_day == Time.zone.now.beginning_of_day }
+    end
+
     # Consider the notification logs which track how many and how long ago this notification was sent
     # It's notifiable? when first time or if it's been immediate_days since last notification
     def notifiable_immediate?(resource:, date: nil)

data/lib/effective_messaging/version.rb

@@ -1,3 +1,3 @@
 module EffectiveMessaging
-  VERSION = '0.7.2'.freeze
+  VERSION = '0.7.3'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_messaging
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.3
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-11-28 00:00:00.000000000 Z
+date: 2024-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails