effective_memberships 0.4.7 → 0.4.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a59918a13a42cc9da99200ecfa61ed9b45ae8881ca7e9c0d4e2fd0117605003
-  data.tar.gz: b1955f238384bbb8cfc4836ad06357b1b815c47c23a9e8ac11303e858feb8379
+  metadata.gz: 52711c835dc479a8bc52e2c523d295999270b98eac479cfa8af855d12452466e
+  data.tar.gz: d5368da347ce46759fc6858b4c231788f91a0baf4ba70a8a8c9104c10e991c1d
 SHA512:
-  metadata.gz: e2ad995fdad088a4db63c1f98467330a1315deb55fe6c912e12662a1a66d017365fd2c379038d7422f9cf5a5b9b7338aa24c05e65f519360be075098ffc4628d
-  data.tar.gz: de64346cc2ce1119672f925d2f60589b4e9e5cd0c5ab506438cee5e7ec2e31e36a79924ed26896c5e0bec639f6033401317e254adcdd03dc8ccf279d75f0a0c9
+  metadata.gz: 7a62bf9547cd039f6f9035c0e075328db83455173709a0dbd672db63be2a6c92cf10551d43962deddcafca76c828c53ff0df2cf374ebf26a8e960d443b71586b
+  data.tar.gz: 7d57abebdaffccdf19af9a1220e20cd244054f04e8807da1e2dc3a45bb40a6010758e4e8676ded2e6321f14d59e4ca488dd05ac391514403c0315464b21c5c86

data/app/controllers/admin/memberships_controller.rb

@@ -5,7 +5,7 @@ module Admin
 
     include Effective::CrudController
 
-    submit :save, 'Update Membership',
+    submit :revise, 'Update Membership',
       success: -> { "#{resource.owner} has been successfully updated. Please double check the membership history is correct" },
       redirect: -> { admin_owners_path(resource) }
 

data/app/models/concerns/effective_memberships_owner.rb

@@ -181,8 +181,8 @@ module EffectiveMembershipsOwner
     # Build the renewal fee
     fee ||= fees.build()
 
-    late_on ||= EffectiveMemberships.Registrar.late_fee_date(period: period)
-    bad_standing_on ||= EffectiveMemberships.Registrar.bad_standing_date(period: period)
+    late_on ||= EffectiveMemberships.Registrar.late_fee_date(period: period) if category.create_late_fees?
+    bad_standing_on ||= EffectiveMemberships.Registrar.bad_standing_date(period: period) if category.create_bad_standing?
 
     fee.assign_attributes(
       fee_type: 'Renewal',

data/app/models/concerns/effective_memberships_registrar.rb

@@ -284,52 +284,53 @@ module EffectiveMembershipsRegistrar
     retval
   end
 
-
   # This is intended to be run once per day in a rake task
   # rake effective_memberships:create_fees
   # Create Renewal and Late fees
-  def create_fees!(period: nil, late_on: nil, bad_standing_on: nil)
-    # The current period, based on Time.zone.now
+  def create_fees!(period: nil)
     period ||= current_period
-    late_on ||= late_fee_date(period: period)
-    bad_standing_on ||= bad_standing_date(period: period)
+    memberships = Effective::Membership.deep.with_unpaid_fees_through(period)
 
     # Create Renewal Fees
-    Effective::Membership.deep.with_unpaid_fees_through(period).find_each do |membership|
-      membership.categories.select(&:create_renewal_fees?).map do |category|
-        existing = membership.owner.membership_period_fee(category: category, period: period, except: 'Renewal')
-        next if existing.present? # This might be an existing Prorated fee
+    memberships.find_each { |membership| create_renewal_fees!(membership, period: period) }
+    GC.start
 
-        fee = membership.owner.build_renewal_fee(category: category, period: period, late_on: late_on, bad_standing_on: bad_standing_on)
-        raise("expected build_renewal_fee to return a fee for period #{period}") unless fee.kind_of?(Effective::Fee)
-        next if fee.purchased?
+    # Create Late Fees
+    memberships.find_each { |membership| create_late_fees!(membership, period: period) }
+    GC.start
 
-        puts("Created renewal fee for #{membership.owner}") if fee.new_record? && !Rails.env.test?
+    # Update Membership Status - Assign In Bad Standing
+    memberships.find_each { |membership| update_membership_status!(membership, period: period) }
+    GC.start
 
-        fee.save!
-      end
-    end
+    true
+  end
 
-    GC.start
+  def create_renewal_fees!(membership, period:)
+    membership.categories.select(&:create_renewal_fees?).map do |category|
+      existing = membership.owner.membership_period_fee(category: category, period: period, except: 'Renewal')
+      next if existing.present? # This might be an existing Prorated fee
 
-    # Create Late Fees
-    Effective::Membership.deep.with_unpaid_fees_through(period).find_each do |membership|
-      membership.categories.select(&:create_late_fees?).map do |category|
-        fee = membership.owner.build_late_fee(category: category, period: period)
-        next if fee.blank? || fee.purchased?
+      fee = membership.owner.build_renewal_fee(category: category, period: period)
+      raise("expected build_renewal_fee to return a fee for period #{period}") unless fee.kind_of?(Effective::Fee)
+      next if fee.purchased?
 
-        fee.save!
-      end
-    end
+      puts("Created renewal fee for #{membership.owner}") if fee.new_record? && !Rails.env.test?
 
-    GC.start
+      fee.save!
+    end
+  end
 
-    # Update Membership Status - Assign In Bad Standing
-    Effective::Membership.deep.with_unpaid_fees_through(period).find_each do |membership|
-      membership.owner.update_membership_status!
+  def create_late_fees!(membership, period:)
+    membership.categories.select(&:create_late_fees?).map do |category|
+      fee = membership.owner.build_late_fee(category: category, period: period)
+      next if fee.blank? || fee.purchased?
+      fee.save!
     end
+  end
 
-    true
+  def update_membership_status!(membership, period: nil)
+    membership.owner.update_membership_status!
   end
 
   # Called in the after_purchase of fee payment

data/app/models/effective/membership.rb

@@ -38,8 +38,9 @@ module Effective
     }
 
     scope :with_unpaid_fees_through, -> (period = nil) {
-      where(arel_table[:fees_paid_period].lt(period || EffectiveMemberships.Registrar.current_period))
-      .or(where(fees_paid_period: nil))
+      joined = where(arel_table[:joined_on].lt(period || EffectiveMemberships.Registrar.current_period))
+      unpaid = where(arel_table[:fees_paid_period].lt(period || EffectiveMemberships.Registrar.current_period)).or(where(fees_paid_period: nil))
+      joined.merge(unpaid)
     }
 
     before_validation do
@@ -119,7 +120,24 @@ module Effective
     end
 
     def fees_paid?
-      fees_paid_period == EffectiveMemberships.Registrar.current_period
+      paid_fees_through?(EffectiveMemberships.Registrar.current_period)
+    end
+
+    def paid_fees_through?(period = nil)
+      period ||= EffectiveMemberships.Registrar.current_period
+
+      return false if fees_paid_period.blank?
+      fees_paid_period >= period
+    end
+
+    def unpaid_fees_through?(period = nil)
+      period ||= EffectiveMemberships.Registrar.current_period
+
+      return false if joined_on.blank?
+      return false unless joined_on < period
+
+      return true if fees_paid_period.blank?
+      fees_paid_period < period
     end
 
     def change_fees_paid_period
@@ -127,6 +145,10 @@ module Effective
     end
 
     def change_fees_paid_period=(date)
+      if date.blank?
+        return assign_attributes(fees_paid_period: nil, fees_paid_through_period: nil)
+      end
+
       date = (date.respond_to?(:strftime) ? date : Date.parse(date))
 
       period = EffectiveMemberships.Registrar.period(date: date)
@@ -135,5 +157,20 @@ module Effective
       assign_attributes(fees_paid_period: period, fees_paid_through_period: period_end_on)
     end
 
+    # Admin updating membership info
+    def revise!
+      save!
+
+      period = EffectiveMemberships.Registrar.current_period
+      return true if paid_fees_through?(period)
+
+      # Otherwise build fees right now
+      EffectiveMemberships.Registrar.create_renewal_fees!(self, period: period)
+      EffectiveMemberships.Registrar.create_late_fees!(self, period: period)
+      EffectiveMemberships.Registrar.update_membership_status!(self, period: period)
+
+      true
+    end
+
   end
 end

data/app/views/admin/memberships/_form_membership.html.haml

@@ -21,7 +21,7 @@
     - periods = registrar.periods(from: f.object.joined_on)
     - collection = periods.reverse.map { |period| [registrar.period_end_on(date: period), period] }
 
-    = f.select :change_fees_paid_period, collection, label: 'Fees Paid Through', hint: 'Which period this user has fees paid through. Can change how renewal fees are created.'
+    = f.select :change_fees_paid_period, collection, label: 'Fees Paid Through', hint: 'Which period this user has fees paid through. Determines which renewal fees should be created. Setting this to a past or blank period may create a renewal fee in the current period.'
 
     %p.text-muted To update the current membership categories, use the 'Assign' or 'Reclassify' actions below
 

data/lib/effective_memberships/version.rb

@@ -1,3 +1,3 @@
 module EffectiveMemberships
-  VERSION = '0.4.7'
+  VERSION = '0.4.8'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_memberships
 version: !ruby/object:Gem::Version
-  version: 0.4.7
+  version: 0.4.8
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-04-12 00:00:00.000000000 Z
+date: 2022-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -178,6 +178,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: timecop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: effective_test_bot
   requirement: !ruby/object:Gem::Requirement