effective_memberships 0.1.16 → 0.1.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e736c438fe21abb1398077ecff10f2a615d2669c893c1e7036d0a8ba37487161
-  data.tar.gz: 5dc050a7056f57cd85e9fc152773eae8726e6e964a00409084a1aa9d922474d7
+  metadata.gz: cd013eabe2088b6b7c6740146f8ee843a86e2a0979e8003b57541da3713dbeff
+  data.tar.gz: 0c4cf214989bd8915647aca851fb095ebbb205cca3dd880c2edceca2127cd826
 SHA512:
-  metadata.gz: 3a394d9e628d00d325f0f1a19b70caae3cdb9b3784ced035def138ea94c66955f46a4b68fc72d23a228741a7d36c491b3816cef5ffe17ee4a578cdae51eace91
-  data.tar.gz: 55f39bfbf6ada343807bbf6670361a0e966badb3c8b1a7c7b0f6c59d9f4208c4028045290bba696356db665078468d844d2780284611950ccb005faeb83f9d13
+  metadata.gz: fc9fef9d1b5687fc5ea109fd819fd771adac2add632964d09bfa9d64235ebfd398cbab0be82b7747c95c4117d1fc0f17c4fca669df2f9d780035aae10188580d
+  data.tar.gz: c515f9644d45422845d5be92e1d6682e383a509da1539c317d2cd3717505239544d39fb82dd868f5ff0d68acea8f739cde14ec57006c5f7b76b375caf54600c2

data/app/models/concerns/effective_memberships_registrar.rb

@@ -253,6 +253,7 @@ module EffectiveMembershipsRegistrar
 
     # Create Renewal Fees
     Effective::Membership.create_renewal_fees(period).find_each do |membership|
+
       membership.categories.select(&:create_renewal_fees?).map do |category|
         fee = membership.owner.build_renewal_fee(category: category, period: period, late_on: late_on, bad_standing_on: bad_standing_on)
         raise("expected build_renewal_fee to return a fee for period #{period}") unless fee.kind_of?(Effective::Fee)

data/app/models/effective/membership.rb

@@ -39,21 +39,15 @@ module Effective
     }
 
     scope :create_renewal_fees, -> (period = nil) {
-      deep.with_unpaid_fees_through(period)
-        .where.not(fees_paid_period: nil) # Must have purchased a Prorated or Renewal Fee before
-        #.where(category_id: EffectiveMemberships.Category.create_renewal_fees)
+      deep.with_unpaid_fees_through(period).where.not(fees_paid_period: nil) # Must have purchased a Prorated or Renewal Fee before
     }
 
     scope :create_late_fees, -> (period = nil) {
-      deep.with_unpaid_fees_through(period)
-        .where.not(fees_paid_period: nil) # Must have purchased a Prorated or Renewal Fee before
-        #.where(category_id: EffectiveMemberships.Category.create_late_fees)
+      deep.with_unpaid_fees_through(period).where.not(fees_paid_period: nil) # Must have purchased a Prorated or Renewal Fee before
     }
 
     scope :create_bad_standing, -> (period = nil) {
-      deep.with_unpaid_fees_through(period)
-        .where.not(fees_paid_period: nil) # Must have purchased a Prorated or Renewal Fee before
-        #.where(category_id: EffectiveMemberships.Category.create_bad_standing)
+      deep.with_unpaid_fees_through(period).where.not(fees_paid_period: nil) # Must have purchased a Prorated or Renewal Fee before
     }
 
     before_validation do

data/lib/effective_memberships/version.rb

@@ -1,3 +1,3 @@
 module EffectiveMemberships
-  VERSION = '0.1.16'
+  VERSION = '0.1.17'
 end

data/lib/tasks/effective_memberships_tasks.rake

@@ -8,10 +8,14 @@ namespace :effective_memberships do
   # rake effective_memberships:create_fees
   desc 'Run daily to create Renewal and Late fees'
   task create_fees: :environment do
-    if ActiveRecord::Base.connection.table_exists?(:memberships)
-      EffectiveLogger.info "Running effective_memberships:create_fees scheduled task" if defined?(EffectiveLogger)
-      EffectiveMemberships.Registrar.create_fees!
+    begin
+      if ActiveRecord::Base.connection.table_exists?(:memberships)
+        EffectiveLogger.info "Running effective_memberships:create_fees scheduled task" if defined?(EffectiveLogger)
+        EffectiveMemberships.Registrar.create_fees!
+      end
+    rescue => e
+      ExceptionNotifier.notify_exception(e) if defined?(ExceptionNotifier)
+      puts "Error creating effective membership fees: #{e.errors.inspect}"
     end
   end
-
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: effective_memberships
 version: !ruby/object:Gem::Version
-  version: 0.1.16
+  version: 0.1.17
 platform: ruby
 authors:
 - Code and Effect