effective_logging 3.1.0 → 3.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 91790ca464dd429fb345fcbef0d15cbdebefdbd56f8685aaa8206653a7cd4350
-  data.tar.gz: fccd38fd9967c82487436ed7a25154bc7b84a4fc30c129691ce532683a951717
+  metadata.gz: e1dc7b7f4024ac664b211eba56892cd43828ec911f37361b91f1ac6496f87fb7
+  data.tar.gz: 512c990d5a8dddfcc665e28ff7dd6ef66302ce4f855d68d87fa89af44ef79ed4
 SHA512:
-  metadata.gz: 57df8caf9cf1a316d2a4591f28ca072b08fa2fae0da1bf71cdd72474971e16637d60337eeb9ce903bfe35033c1fcf68fb7ed76e022aab47a8a7503289fd8cbbc
-  data.tar.gz: 0b6106eade70761e9d71602846c5000308533de2058a6f8097e8aec22439155e5e55c83fafeeaf6a7e9c9339ec19cdd17cb15b372e3b3d79a1dc623eaf8b8bdf
+  metadata.gz: 612a1bed2cc27c80ee726a023a079e0a5a2dcf80b7d390e07bb9a692bf60da43c974d754bc29f99a17bc95d589e18457aa52261564da19e509947b47046a8f3c
+  data.tar.gz: 798375484126e11a779eaffbdf1c53e26a5530f701440b4190660948b52ee9c728e1e7f300684b088a636d4b9df1d08087b71dc3477a434a23c2422b576b27c7

data/app/controllers/admin/logs_controller.rb

@@ -16,19 +16,5 @@ module Admin
       @page_title = 'Logs'
     end
 
-    def show
-      @log = Effective::Log.includes(:logs).find(params[:id])
-      EffectiveResources.authorize!(self, :show, @log)
-
-      @log.next_log = Effective::Log.order(:id).where(parent_id: @log.parent_id).where('id > ?', @log.id).first
-      @log.prev_log = Effective::Log.order(:id).where(parent_id: @log.parent_id).where('id < ?', @log.id).last
-
-      @page_title = "Log ##{@log.to_param}"
-
-      if @log.logs.present?
-        @log.datatable = EffectiveLogsDatatable.new(self, log_id: @log.id)
-      end
-
-    end
   end
 end

data/app/controllers/effective/logs_controller.rb

@@ -41,26 +41,9 @@ module Effective
     # This is the User index event
     def index
       EffectiveResources.authorize!(self, :index, Effective::Log.new(user_id: current_user.id))
-
       @datatable = EffectiveLogsDatatable.new(self, user_id: current_user.id)
     end
 
-    # This is the User show event
-    def show
-      @log = Effective::Log.includes(:logs).find(params[:id])
-
-      EffectiveLogging.authorize!(self, :show, @log)
-
-      @log.next_log = Effective::Log.unscoped.order(:id).where(parent_id: @log.parent_id).where('id > ?', @log.id).first
-      @log.prev_log = Effective::Log.unscoped.order(:id).where(parent_id: @log.parent_id).where('id < ?', @log.id).last
-
-      @page_title = "Log ##{@log.to_param}"
-
-      if @log.logs.present?
-        @log.datatable = EffectiveLogsDatatable.new(self, log_id: @log.id)
-      end
-    end
-
     def html_part
       @log = Effective::Log.find(params[:id])
 

data/app/datatables/effective_log_changes_datatable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class EffectiveLogChangesDatatable < Effective::Datatable
   datatable do
     order :updated_at
@@ -5,19 +7,19 @@ class EffectiveLogChangesDatatable < Effective::Datatable
     col :updated_at, label: 'Date'
     col :id, visible: false
 
-    col :user, sort: false
+    col :user, search: :string, sort: false
 
     col :associated_type, visible: false
-    col :associated_id, visible: false
-    col :associated_to_s, visible: false
+    col :associated_id, visible: false, label: 'Associated Id'
+    col :associated_to_s, visible: false, label: 'Associated'
 
     col :message, sort: false do |log|
-      message = log.message.gsub("\n", '<br>')
+      (log.message || '').gsub!("\n", '<br>')
 
       if log.associated_id == attributes[:changes_to_id] && log.associated_type == attributes[:changes_to_type]
-        message
+        log.message
       else
-        "#{log.associated_type} #{log.associated_to_s} - #{message}"
+        "#{log.associated_type} #{log.associated_to_s} - #{log.message}"
       end
 
     end.search do |collection, term, column, sql_column|
@@ -29,9 +31,7 @@ class EffectiveLogChangesDatatable < Effective::Datatable
       tableize_hash(log.details)
     end
 
-    unless attributes[:actions] == false
-      actions_col partial: 'admin/logs/actions', partial_as: :log
-    end
+    actions_col
   end
 
   # A nil attributes[:log_id] means give me all the top level log entries

data/app/datatables/effective_logs_datatable.rb

@@ -8,16 +8,16 @@ class EffectiveLogsDatatable < Effective::Datatable
     if attributes[:user] == false
       # Do not include
     else
-      col :user, search: :string
+      col :user, search: :string, sort: false
     end
 
     unless attributes[:status] == false
       col :status, search: { collection: EffectiveLogging.statuses }
     end
 
-    col :associated_type, search: { as: :string }
-    col :associated_id, search: { as: :integer }, visible: false, label: 'Associated Id'
-    col :associated_to_s, search: { as: :string }, label: 'Associated'
+    col :associated_type, visible: false
+    col :associated_id, visible: false, label: 'Associated Id'
+    col :associated_to_s, label: 'Associated'
 
     col :message do |log|
       log.message.gsub("\n", '<br>')
@@ -29,9 +29,7 @@ class EffectiveLogsDatatable < Effective::Datatable
       tableize_hash(log.details.except(:email))
     end
 
-    unless attributes[:actions] == false
-      actions_col partial: 'admin/logs/actions', partial_as: :log
-    end
+    actions_col
   end
 
   # A nil attributes[:log_id] means give me all the top level log entries

data/app/models/effective/log.rb

@@ -2,11 +2,6 @@ module Effective
   class Log < ActiveRecord::Base
     self.table_name = EffectiveLogging.logs_table_name.to_s
 
-    # These 3 attr_accessors are set on the controller #show actions
-    attr_accessor :datatable
-    attr_accessor :next_log
-    attr_accessor :prev_log
-
     # Self-Referencing relationship
     belongs_to :parent, class_name: 'Effective::Log', counter_cache: true, optional: true
     has_many :logs, class_name: 'Effective::Log', foreign_key: :parent_id
@@ -58,6 +53,18 @@ module Effective
       self[:details] || {}
     end
 
+    def next_log
+      Log.order(id: :asc).where(parent_id: parent_id).where('id > ?', id).first
+    end
+
+    def prev_log
+      Log.order(id: :desc).where(parent_id: parent_id).where('id < ?', id).first
+    end
+
+    def child_logs_datatable
+      EffectiveLogsDatatable.new(log_id: id)
+    end
+
     # Dynamically add logging methods based on the defined statuses
     # EffectiveLogging.info 'my message'
     (EffectiveLogging.statuses || []).each do |status|

data/app/views/effective/logs/_log.html.haml

@@ -8,18 +8,22 @@
         %p= log.message.to_s.gsub("\n", '<br>').html_safe
 
       .col-md-4.text-right
-        - if log.prev_log
-          = link_to 'Prev', request.fullpath.sub('/' + log.to_param, '/' + log.prev_log.to_param), class: 'btn btn-primary'
+        - prev_log = log.prev_log
+        - next_log = log.next_log
 
-        - if log.next_log
-          = link_to 'Next', request.fullpath.sub('/' + log.to_param, '/' + log.next_log.to_param), class: 'btn btn-primary'
+        - if prev_log.present?
+          = link_to 'Prev', request.fullpath.sub('/' + log.to_param, '/' + prev_log.to_param), class: 'btn btn-primary'
+
+        - if next_log.present?
+          = link_to 'Next', request.fullpath.sub('/' + log.to_param, '/' + next_log.to_param), class: 'btn btn-primary'
 
   .panel-body.card-body
     .row
       .col-md-6
         %p
           - status_class = bootstrap_class_for_status(log.status)
-          %span{:class => (defined?(EffectiveBootstrap) ? "badge badge-#{status_class}" : "label label-#{status_class}")}= log.status
+          %span{class: (defined?(EffectiveBootstrap) ? "badge badge-#{status_class}" : "label label-#{status_class}")}= log.status
+
           = log.created_at.strftime("%F %H:%M:%S")
           = '(' + time_ago_in_words(log.created_at) + ' ago)'
 
@@ -28,7 +32,8 @@
           %p
             %strong User:
             = (log.user.to_s.starts_with?('#<User:0x') ? (log.user.email rescue log.user) : log.user)
-        - if (log.associated.present? rescue false)
+
+        - if log.associated_id.present? && log.associated_type.present? && (log.associated.present? rescue false)
           %p
             %strong Associated:
             - if log.associated.to_s.starts_with?('#<')
@@ -47,6 +52,4 @@
     - if log.logs.present?
       %hr
       %p This log contains #{log.logs_count} additional sub entries:
-
-      - unless log.datatable.nil?
-        = render_datatable(log.datatable)
+      = render_datatable(log.child_logs_datatable)

data/lib/effective_logging/version.rb

@@ -1,3 +1,3 @@
 module EffectiveLogging
-  VERSION = '3.1.0'.freeze
+  VERSION = '3.1.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_logging
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.1
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-02-18 00:00:00.000000000 Z
+date: 2021-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -98,10 +98,8 @@ files:
 - app/datatables/effective_logs_datatable.rb
 - app/helpers/effective_logging_helper.rb
 - app/models/concerns/acts_as_loggable.rb
-- app/models/effective/access_denied.rb
 - app/models/effective/log.rb
 - app/models/effective_logger.rb
-- app/views/admin/logs/_actions.html.haml
 - app/views/admin/logs/index.html.haml
 - app/views/admin/logs/show.html.haml
 - app/views/effective/logs/_log.html.haml

data/app/models/effective/access_denied.rb

@@ -1,17 +0,0 @@
-unless defined?(Effective::AccessDenied)
-  module Effective
-    class AccessDenied < StandardError
-      attr_reader :action, :subject
-
-      def initialize(message = nil, action = nil, subject = nil)
-        @message = message
-        @action = action
-        @subject = subject
-      end
-
-      def to_s
-        @message || I18n.t(:'unauthorized.default', :default => 'Access Denied')
-      end
-    end
-  end
-end

data/app/views/admin/logs/_actions.html.haml

@@ -1,8 +0,0 @@
-- show_path = (datatable.admin_namespace? ? effective_logging.admin_log_path(log) : effective_logging.log_path(log))
-
-- if defined?(EffectiveBootstrap)
-  = dropdown(variation: :dropleft) do
-    = dropdown_link_to 'View', show_path
-- else
-  = link_to show_path, title: 'View' do
-    %span.glyphicon.glyphicon-eye-open