effective_logging 1.10.10 → 1.10.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 36b5a7ee3912d627929363f7ec120d03bf76c2be
-  data.tar.gz: 23ff0c91d1e0722891f90d1c4e634f51b8e7211d
+  metadata.gz: fbbfbe91d61687d687bec5a337dc552ffbf03487
+  data.tar.gz: 6f5e24fd9cef93e38076cea14f5f713ff1cf6874
 SHA512:
-  metadata.gz: 28905e79a34fd949c5675a5b1f6c27979a9bb7d40172c41f4c012201d26a7786627577b6b415338b9f798394085a2c0a69a905f6786ffe09d9de82c1242f7205
-  data.tar.gz: ffeb205f6b400ba6e6c6b2fbb1bff92ef8454a453c7ed56549229d7abb39a8549c61ec6616d5abf65beb5ef3fe06c9cfe5da7472957f44f4fefbd942673a8321
+  metadata.gz: 1848b493da8d7b38b0725908fd820d3c26a0c15d0a7ed4d03957b413e0cd59f666592f77bb13cdca6daa44d46ea0ab51662e6def9d1af33b61415635929a6e30
+  data.tar.gz: f2cd75738f9dbf511a7a11c5bdce5f4fe9697071b356914bfc4e9838be7cc5b83ab3bfe1d82f21dad5fa4ea08414cb54e5c40e8b7d92a8f0f3615598da118ce9

data/app/models/concerns/acts_as_loggable.rb

@@ -20,7 +20,7 @@ module ActsAsLoggable
       @acts_as_loggable_new_record = new_record?
 
       unless @acts_as_loggable_new_record
-        @acts_as_loggable_update_record = EffectiveLogging::ActiveRecordLogger.new(self, log_changes_options).changed!
+        @acts_as_loggable_update_record = EffectiveLogging::ActiveRecordLogger.new(self, log_changes_options).execute!
       end
 
       block.call

data/db/migrate/01_create_effective_logging.rb.erb

@@ -1,4 +1,4 @@
-class CreateEffectiveLogging < ActiveRecord::Migration
+class CreateEffectiveLogging < ActiveRecord::Migration[4.2]
   def self.up
     create_table <%= @logs_table_name %> do |t|
       t.integer       :parent_id

data/lib/effective_logging/active_record_logger.rb

@@ -9,6 +9,7 @@ module EffectiveLogging
 
       @object = object
       @resource = Effective::Resource.new(object)
+      @logged = false # If work was done
 
       @logger = options.delete(:logger) || object
       @depth = options.delete(:depth) || 0
@@ -26,6 +27,9 @@ module EffectiveLogging
       else
         changed!
       end
+      log_nested_resources!
+
+      @logged
     end
 
     # before_destroy
@@ -43,7 +47,8 @@ module EffectiveLogging
       log('Updated', details: applicable(resource.instance_attributes))
     end
 
-    # before_save
+    private
+
     def changed!
       applicable(resource.instance_changes).each do |attribute, (before, after)|
         next if before == nil && after == ''.freeze
@@ -62,21 +67,19 @@ module EffectiveLogging
 
         log("#{attribute}: #{before.presence || BLANK} → #{after.presence || BLANK}", details: { attribute: attribute, before: before, after: after })
       end
+    end
 
+    def log_nested_resources!
       # Log changes on all accepts_as_nested_parameters has_many associations
       resource.nested_resources.each do |association|
         title = association.name.to_s.singularize.titleize
 
         Array(object.send(association.name)).each_with_index do |child, index|
-          @logged ||= ActiveRecordLogger.new(child, options.merge(logger: logger, depth: (depth + 1), prefix: "#{title} #{index} - #{child} - ")).execute!
+          @logged = true if ActiveRecordLogger.new(child, options.merge(logger: logger, depth: depth+1, prefix: "#{title} #{index} - #{child} - ")).execute!
         end
       end
-
-      @logged == true
     end
 
-    private
-
     def log(message, details: {})
       @logged = true
 

data/lib/effective_logging/version.rb

@@ -1,3 +1,3 @@
 module EffectiveLogging
-  VERSION = '1.10.10'.freeze
+  VERSION = '1.10.11'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_logging
 version: !ruby/object:Gem::Version
-  version: 1.10.10
+  version: 1.10.11
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-23 00:00:00.000000000 Z
+date: 2017-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails