eff 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 64373ef4d04e08aa57e86223ecdfcdc894c42284
-  data.tar.gz: caf6cb5718cd8f233544c6677f49986bca2a4918
+  metadata.gz: f0425334fa0adbd66e98d2b270d4eed0e0dd7000
+  data.tar.gz: 234c51413119612b6776ea5d0f789cb1930a94fc
 SHA512:
-  metadata.gz: 1b64d1437efd27bbc7658343800eaf61861578639eb048e154131cdff4abfd583d5e83eae59d99057fcd91250e016aede19cd6128ebef267ed5721c8d1f2b06c
-  data.tar.gz: 7d050694d14e74b32595793f48b9926ce1e0e99d3bb8651d78291083e551d4c946ecac25e67f8e7ce0a178ccbfdc046c223aacd4e38f8e5cf9859dacb30dbee2
+  metadata.gz: c3505f441176e2e01e3a7d636aecf5630fe576cb586173df3cd0dfcf4b1fc3f3a43e39a6336e1bf7307d9a2a45b5df3dc0dc15c858688a33f62ec84e8b49e739
+  data.tar.gz: d97639c74a95774d24f504f44c75a1cee841aa3f7b70c064ed812d9e650db1b07991d4bddbc13589bc03c88069e7ab344c5dd7bea822f04abe9cf21ba683c7f6

data/.travis.yml

@@ -1,10 +1,7 @@
 language: ruby
 rvm:
-  - 1.9.3
   - 2.0.0
-  - jruby-19mode
   - jruby-head
-  - rbx-19mode
 script: bundle exec rspec spec
 branches:
   only:
@@ -12,6 +9,4 @@ branches:
 matrix:
   fast_finish: true
   allow_failures:
-    - rvm: jruby-19mode
     - rvm: jruby-head
-    - rvm: rbx-19mode

data/README.md

@@ -1,6 +1,8 @@
 # Eff
 
-TODO: Write a gem description
+[![Gem Version](https://badge.fury.io/rb/eff.png)](http://badge.fury.io/rb/eff) [![Build Status](https://travis-ci.org/Toady00/eff.png)](https://travis-ci.org/Toady00/eff) [![Code Climate](https://codeclimate.com/github/Toady00/eff.png)](https://codeclimate.com/github/Toady00/eff) [![Coverage Status](https://coveralls.io/repos/Toady00/eff/badge.png)](https://coveralls.io/r/Toady00/eff) [![Dependency Status](https://gemnasium.com/Toady00/eff.png)](https://gemnasium.com/Toady00/eff)
+
+This gems aims to be a way to help simplify the task of building multiple packages with [FPM](https://github.com/jordansissel/fpm).
 
 ## Installation
 

data/eff.gemspec

@@ -30,5 +30,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "pry"
   spec.add_development_dependency "pry-plus"
   spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "coveralls"
   spec.add_development_dependency "fakefs"
 end

data/lib/eff/downloader.rb

@@ -11,18 +11,11 @@ module Eff
 
     def get
       @response = Faraday.get(uri)
+      save
     end
 
-    def save
-      File.open(file, 'wb') do |f|
-        f.write(response_body)
-      end if success?
-    end
-
-    # TODO: should this really trigger it to download?
     def success?
-      get unless response
-      @response.success?
+      response ? response.success? : false
     end
 
     def file=(value)
@@ -36,6 +29,13 @@ module Eff
     end
 
   private
+    def save
+      File.open(file, 'wb') do |f|
+        f.write(response_body)
+      end if success?
+      success?
+    end
+
     def response_body
       response.body
     end

data/lib/eff/package.rb

@@ -1,45 +1,65 @@
 require 'eff/downloader'
 require 'eff/template'
 require 'eff/package/semantic_version'
+require 'eff/verifier'
 
 module Eff
   class Package
-    attr_accessor :save_file, :version
+    attr_accessor :name, :save_file, :version, :checksum, :hash_function
 
     def initialize(options = {})
+      @name          = options[:name]
       @url_template  = options[:url_template]
-      self.save_file = options[:save_file]
+      @file_template = options[:file_template]
       self.version   = options[:version]
-      new_downloader
+      @checksum      = options[:checksum]
+      @hash_function = options[:hash_function]
+
+      after_init_hook
     end
 
     def download
       downloader.get
     end
 
-    def save
-      downloader.save
-    end
-
-    # TODO: should this really trigger it to download?
     def downloaded?
-      downloader.success?
+      downloader_success?
     end
 
     def url
-      template = Eff::Template.new(@url_template, version)
-      template.result
+      template_for(:url).result
     end
 
-    def save_file=(value)
-      @save_file = File.expand_path(value, Dir.pwd)
+    def file_name
+      template_for(:file).result
+    end
+
+    def save_file
+      File.expand_path(file_name, Dir.pwd)
     end
 
     def version=(value)
       @version = SemanticVersion.new(value)
+      clear_download!
+    end
+
+    def ==(other)
+      (name == other.name) && (version == other.version)
+    end
+
+    def verified?
+      verifiable? ? Verifier.check(save_file, checksum, hash_function) : false
+    end
+
+    def verifiable?
+      checksum && hash_function
     end
 
   private
+    def after_init_hook
+      new_downloader
+    end
+
     def downloader
       @downloader
     end
@@ -48,8 +68,17 @@ module Eff
       @downloader = Eff::Downloader.new(url, save_file)
     end
 
-    def download_response
-      downloader.response
+    def downloader_success?
+      downloader.success?
+    end
+
+    def clear_download!
+      new_downloader if downloader
+    end
+
+    def template_for(sym)
+      template = instance_variable_get("@#{sym}_template".to_sym)
+      Eff::Template.new(template, version)
     end
   end
 end

data/lib/eff/package/semantic_version.rb

@@ -1,7 +1,10 @@
 module Eff
   class Package
     class SemanticVersion
-      PARTS = %i(major minor patch release identity)
+      include Comparable
+
+      BASE_PARTS = %i(major minor patch)
+      PARTS = BASE_PARTS + %i(release identity)
 
       PARTS.each do |part|
         attr_accessor part
@@ -18,6 +21,15 @@ module Eff
         ]
       end
 
+      def <=>(other)
+        result = 0
+        BASE_PARTS.each do |part|
+          result = self.public_send(part).to_i <=> other.public_send(part).to_i
+          break unless result == 0
+        end
+        result
+      end
+
     private
       def parse!
         remaining, @identity   = @version_string.split("+")

data/lib/eff/verifier.rb

@@ -1,10 +1,18 @@
 module Eff
   class Verifier
     class << self
-      def check(file, checksum, algo = Digest::SHA1)
-        file_digest = algo.file(File.expand_path(file)).hexdigest
+      def check(file, checksum, hash_function)
+        return unless File.exists?(file)
+        function    = function_const_get(hash_function)
+        file_digest = function.file(file).hexdigest
         file_digest == checksum
       end
+
+    private
+      def function_const_get(value)
+        hash_function = value.to_s.upcase
+        Digest.const_get(hash_function)
+      end
     end
   end
 end

data/lib/eff/version.rb

@@ -1,3 +1,3 @@
 module Eff
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/eff/downloader_spec.rb

@@ -0,0 +1,89 @@
+require 'spec_helper'
+require 'eff/downloader'
+require 'ostruct'
+require 'fakefs/spec_helpers'
+
+describe Eff::Downloader do
+  include FakeFS::SpecHelpers
+
+  let(:url)          { "http://google.com" }
+  let(:file)         { "test.tmp" }
+  let(:full_path)    { File.expand_path(file, Dir.pwd) }
+  let(:fake_success) { OpenStruct.new(body: "I'm a fake response!", success?: true) }
+  let(:fake_failure) { OpenStruct.new(body: "I'm a fake response!", success?: false) }
+  let(:downloader)   { Eff::Downloader.new(url, file) }
+
+  before do
+    Faraday.stub(:get).and_return(fake_success)
+  end
+
+  context 'for successfull request' do
+    before do
+      downloader.get
+    end
+
+    describe '#get' do
+      it 'saves the file' do
+        File.exists?(File.expand_path(file, Dir.pwd)).should be_true
+      end
+    end
+
+    describe '#success?' do
+      it 'returns true' do
+        downloader.should be_success
+      end
+    end
+  end
+
+  context 'for unsuccessfull request' do
+    before do
+      Faraday.stub(:get).and_return(fake_failure)
+      downloader.get
+    end
+
+    describe '#get' do
+      it 'does not save a file' do
+        File.exists?(File.expand_path(file, Dir.pwd)).should_not be_true
+      end
+    end
+
+    describe '#success?' do
+      it 'returns false' do
+        downloader.should_not be_success
+      end
+    end
+  end
+
+  describe '#uri=' do
+    let(:another_url) { "http://example.com" }
+    let(:another_uri) { URI(another_url) }
+
+    it 'resets response to nil' do
+      downloader.get
+      downloader.response.should_not be_nil
+      downloader.uri = another_url
+      downloader.response.should be_nil
+    end
+
+    it 'sets the new uri' do
+      downloader.uri = another_url
+      downloader.uri.should eq(another_uri)
+    end
+  end
+
+  describe '#file=' do
+    let(:another_file) { '~/some_other_file' }
+
+    it 'resets response to nil' do
+      downloader.get
+      downloader.response.should_not be_nil
+      downloader.file = another_file
+      downloader.response.should be_nil
+    end
+
+    it 'sets the new file' do
+      downloader.file = another_file
+      downloader.file.should eq(File.expand_path(another_file, Dir.pwd))
+    end
+  end
+end

data/spec/eff/package/semantic_version_spec.rb

@@ -0,0 +1,66 @@
+require 'spec_helper'
+require 'eff/package/semantic_version'
+
+describe Eff::Package::SemanticVersion do
+  describe '#to_h' do
+    let(:version_hash) {
+      Hash[
+        :major,    "1",
+        :minor,    "2",
+        :patch,    "3",
+        :release,  "p456",
+        :identity, "7890"
+      ]
+    }
+    let(:valid_versions) { %w(1 1.2 1.2.3 1.2.3-p456 1.2.3-p456+7890) }
+
+    it 'should return the correct hash' do
+      valid_versions.each do |version_string|
+        semver = Eff::Package::SemanticVersion.new version_string
+        hash = semver.to_h
+        first_nil = false
+        version_hash.each do |part, value|
+          hash_value = hash[part]
+          first_nil ||= hash_value.nil?
+          if first_nil
+            hash[part].should be_nil
+          else
+            hash[part].should eq(value)
+          end
+        end
+      end
+    end
+  end
+
+  describe '#<=>' do
+    before do
+      @versions = []
+      %w(0.0.1 0.0.5 0.1.0 1.0.0 1.0.1 1.2.0 2.0.0).each do |version|
+        @versions << Eff::Package::SemanticVersion.new(version)
+      end
+    end
+
+    it 'compares versions correctly' do
+      @versions.each_with_index do |version, index|
+        @versions.each_with_index do |other, other_index|
+          if index > other_index
+            (version > other).should be_true
+            (version < other).should be_false
+            (version == other).should be_false
+            (version != other).should be_true
+          elsif index < other_index
+            (version > other).should be_false
+            (version < other).should be_true
+            (version == other).should be_false
+            (version != other).should be_true
+          else
+            (version > other).should be_false
+            (version < other).should be_false
+            (version == other).should be_true
+            (version != other).should be_false
+          end
+        end
+      end
+    end
+  end
+end

data/spec/eff/package_spec.rb

@@ -0,0 +1,124 @@
+require 'spec_helper'
+require 'eff/package'
+require 'fakefs/spec_helpers'
+
+describe Eff::Package do
+  include FakeFS::SpecHelpers
+
+  let(:url_template)   { '<%= "http://example.com/package-#{@major}.#{@minor}.#{@patch}.deb" %>' }
+  let(:file_template)  { '<%= "package-#{@major}.#{@minor}.#{@patch}.deb" %>' }
+  let(:version)        { '1.2.3'}
+  let(:options)        { { url_template: url_template, file_template: file_template, version: version } }
+  let(:package)        { Eff::Package.new options }
+
+  let(:fake_success) { OpenStruct.new(body: "I'm a fake response!", success?: true) }
+  let(:fake_failure) { OpenStruct.new(body: "I'm a fake response!", success?: false) }
+
+  subject { package }
+
+  before { Faraday.stub(:get).and_return(fake_success) }
+
+  it { should respond_to :name          }
+  it { should respond_to :download      }
+  it { should respond_to :downloaded?   }
+  it { should respond_to :url           }
+  it { should respond_to :file_name     }
+  it { should respond_to :save_file     }
+  it { should respond_to :version       }
+  it { should respond_to :checksum      }
+  it { should respond_to :hash_function }
+  it { should respond_to :verified?     }
+  it { should respond_to :verifiable?   }
+
+  describe 'downloader wrapper method' do
+    describe '#download' do
+      it 'calls Eff::Downloader#get' do
+        Eff::Downloader.any_instance.should_receive(:get)
+        package.download
+      end
+    end
+
+    describe '#downloaded?' do
+      it 'calls Eff::Downloader#success?' do
+        Eff::Downloader.stub(:previously_downloaded?)
+        Eff::Downloader.any_instance.should_receive(:success?)
+        package.downloaded?
+      end
+    end
+  end
+
+  describe '#url' do
+    let(:url) { 'http://example.com/package-1.2.3.deb' }
+
+    it 'returns the correct url' do
+      package.url.should eq(url)
+    end
+  end
+
+  describe '#version=' do
+    before do
+      package.download
+      package.should be_downloaded
+    end
+
+    let(:new_version)    { '4.5.6' }
+    let(:package_name)   { "package-#{new_version}.deb"}
+    let(:url)            { "http://example.com/#{package_name}" }
+    let(:full_save_path) { File.expand_path(package_name, Dir.pwd) }
+
+    it 'forgets about previous downloads' do
+      package.version = new_version
+      package.should_not be_downloaded
+    end
+
+    it 'updates the url' do
+      old_url = package.url
+      package.version = new_version
+      package.url.should_not eq old_url
+    end
+
+    it 'creates a new downloader with the correct url' do
+      Eff::Downloader.should_receive(:new).with(url, full_save_path)
+      package.version = new_version
+    end
+  end
+
+  describe 'verification' do
+    let(:package) { Eff::Package.new @options }
+
+    describe '#verifiable?' do
+      it 'returns false without checksum or hash_function' do
+        @options = options
+        package.should_not be_verifiable
+      end
+
+      it 'returns false without checksum' do
+        @options = options.merge(hash_function: 'sha1')
+        package.should_not be_verifiable
+      end
+
+      it 'returns false without hash_function' do
+        @options = options.merge(checksum: 'some_string')
+        package.should_not be_verifiable
+      end
+
+      it 'returns tru with checksum and hash_function' do
+        @options = options.merge(checksum: 'some_string', hash_function: 'sha1')
+        package.should be_verifiable
+      end
+    end
+
+    describe '#verified?' do
+      it 'returns false if not verifiable' do
+        @options = options
+        package.should_not be_verified
+      end
+
+      it 'calls Verifier.check if verifiable' do
+        @options = options.merge(checksum: 'some_string', hash_function: 'sha1')
+        Eff::Verifier.should_receive(:check).with(package.save_file, package.checksum, package.hash_function)
+        package.verified?
+      end
+    end
+  end
+end

data/spec/eff/verifier_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+require 'eff/verifier'
+
+describe Eff::Verifier do
+  let(:file)   { "spec/support/static_file_for_digesting.txt" }
+  let(:sha1)   { "75cfdde12aeb435fd0c68c99df1027190953997e" }
+  let(:md5)    { "1c0b1fcddc0cd9677ecfb79e1d127e03" }
+  let(:hashes) { { sha1: sha1, md5: md5 } }
+
+  describe '.check' do
+    it 'returns true if the hashes match' do
+      hashes.each do |hash_function, value|
+        Eff::Verifier.check(file, value, hash_function).should be_true
+      end
+    end
+
+    it 'returns false if the hashes do not match' do
+      hashes.each do |hash_function, value|
+        Eff::Verifier.check(file, "this doesn't match", hash_function).should be_false
+      end
+    end
+
+    it 'returns false if the file does not exist' do
+      Eff::Verifier.check('non-existant-file.txt', sha1, :sha1).should be_false
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eff
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Brandon Dennis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-13 00:00:00.000000000 Z
+date: 2014-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fpm
@@ -164,6 +164,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: fakefs
   requirement: !ruby/object:Gem::Requirement
@@ -204,14 +218,14 @@ files:
 - lib/eff/template.rb
 - lib/eff/verifier.rb
 - lib/eff/version.rb
-- spec/downloader_spec.rb
+- spec/eff/downloader_spec.rb
+- spec/eff/package/semantic_version_spec.rb
+- spec/eff/package_spec.rb
+- spec/eff/template_spec.rb
+- spec/eff/verifier_spec.rb
 - spec/eff_spec.rb
-- spec/package_semantic_version_spec.rb
-- spec/package_spec.rb
 - spec/spec_helper.rb
 - spec/support/static_file_for_digesting.txt
-- spec/template_spec.rb
-- spec/verifier_spec.rb
 homepage: ''
 licenses:
 - MIT
@@ -237,12 +251,12 @@ signing_key:
 specification_version: 4
 summary: Wrapper around fpm (effing package manager)
 test_files:
-- spec/downloader_spec.rb
+- spec/eff/downloader_spec.rb
+- spec/eff/package/semantic_version_spec.rb
+- spec/eff/package_spec.rb
+- spec/eff/template_spec.rb
+- spec/eff/verifier_spec.rb
 - spec/eff_spec.rb
-- spec/package_semantic_version_spec.rb
-- spec/package_spec.rb
 - spec/spec_helper.rb
 - spec/support/static_file_for_digesting.txt
-- spec/template_spec.rb
-- spec/verifier_spec.rb
 has_rdoc: 

data/spec/downloader_spec.rb

@@ -1,130 +0,0 @@
-require 'spec_helper'
-require 'eff/downloader'
-require 'ostruct'
-require 'fakefs/spec_helpers'
-
-describe Eff::Downloader do
-  include FakeFS::SpecHelpers
-
-  let(:url)          { "http://google.com" }
-  let(:file)         { "test.tmp" }
-  let(:full_path)   { File.expand_path(file, Dir.pwd) }
-  let(:fake_success) { OpenStruct.new(body: "I'm a fake response!", success?: true) }
-  let(:fake_failure) { OpenStruct.new(body: "I'm a fake response!", success?: false) }
-
-  # describe '.get' do
-  #   it 'returns the body if response is successful' do
-  #     Faraday.stub(:get).and_return(fake_success)
-  #     Eff::Downloader.get(url, file).should eq(fake_success.body)
-  #   end
-
-  #   it 'returns nil if the response is not successful' do
-  #     Faraday.stub(:get).and_return(fake_failure)
-  #     Eff::Downloader.get(url, file).should be_nil
-  #   end
-  # end
-
-  # describe '.get!' do
-  #   it 'writes the appropriate file' do
-  #     Faraday.stub(:get).and_return(fake_success)
-  #     Eff::Downloader.get!(url, file)
-  #     File.exists?(File.expand_path(file, Dir.pwd)).should be_true
-  #   end
-
-  #   it 'downloads the appropriate file' do
-  #     Faraday.should_receive(:get).with(URI(url)).and_return(fake_success)
-  #     Eff::Downloader.get!(url, file)
-  #   end
-
-  #   it 'returns the location of the saved file' do
-  #     Faraday.stub(:get).and_return(fake_success)
-  #     Eff::Downloader.get!(url, file).should be_true
-  #   end
-  # end
-
-  describe 'instance' do
-    before { Faraday.stub(:get).and_return(fake_success) }
-
-    let(:downloader) { Eff::Downloader.new(url, file) }
-
-    describe '#get' do
-      it 'returns a response' do
-        downloader.get.should respond_to :success?
-      end
-    end
-
-    describe '#uri=' do
-      let(:another_url) { "http://example.com" }
-      let(:another_uri) { URI(another_url) }
-      it 'resets response to nil' do
-        downloader.get
-        downloader.response.should_not be_nil
-        downloader.uri = another_url
-        downloader.response.should be_nil
-      end
-
-      it 'sets the new uri' do
-        downloader.uri = another_url
-        downloader.uri.should eq(another_uri)
-      end
-    end
-
-    describe '#file' do
-      let(:another_file) { '~/some_other_file' }
-
-      it 'resets response to nil' do
-        downloader.get
-        downloader.response.should_not be_nil
-        downloader.file = another_file
-        downloader.response.should be_nil
-      end
-
-      it 'sets the new file' do
-        downloader.file = another_file
-        downloader.file.should eq(File.expand_path(another_file, Dir.pwd))
-      end
-    end
-
-    context 'successfully downloaded' do
-      describe '#save' do
-        it 'gets the response if it has not already' do
-          Faraday.should_receive(:get).with(URI(url)).and_return(fake_success)
-          downloader.save
-        end
-
-        it 'writes the file to disk' do
-          downloader.save
-          File.exists?(File.expand_path(file, Dir.pwd)).should be_true
-        end
-      end
-
-      describe '#success?' do
-        it 'returns true' do
-          downloader.should be_success
-        end
-      end
-    end
-
-    context 'unsuccessfully downloaded' do
-      before { Faraday.stub(:get).and_return(fake_failure) }
-
-      describe '#save' do
-        it 'gets the response if it has not already' do
-          Faraday.should_receive(:get).with(URI(url)).and_return(fake_success)
-          downloader.save
-        end
-
-        it 'does not write the file to disk' do
-          downloader.save
-          File.exists?(File.expand_path(file, Dir.pwd)).should_not be_true
-        end
-      end
-
-      describe '#success?' do
-        it 'returns false' do
-          downloader.should_not be_success
-        end
-      end
-    end
-  end
-end

data/spec/package_semantic_version_spec.rb

@@ -1,34 +0,0 @@
-require 'spec_helper'
-require 'eff/package/semantic_version'
-
-describe Eff::Package::SemanticVersion do
-  describe '#to_h' do
-    let(:version_hash) {
-      Hash[
-        :major,    "1",
-        :minor,    "2",
-        :patch,    "3",
-        :release,  "p456",
-        :identity, "7890"
-      ]
-    }
-    let(:valid_versions) { %w(1 1.2 1.2.3 1.2.3-p456 1.2.3-p456+7890) }
-
-    it 'should return the correct hash' do
-      valid_versions.each do |version_string|
-        semver = Eff::Package::SemanticVersion.new version_string
-        hash = semver.to_h
-        first_nil = false
-        version_hash.each do |part, value|
-          hash_value = hash[part]
-          first_nil ||= hash_value.nil?
-          if first_nil
-            hash[part].should be_nil
-          else
-            hash[part].should eq(value)
-          end
-        end
-      end
-    end
-  end
-end

data/spec/package_spec.rb

@@ -1,58 +0,0 @@
-require 'spec_helper'
-require 'eff/package'
-require 'fakefs/spec_helpers'
-
-describe Eff::Package do
-  include FakeFS::SpecHelpers
-
-  let(:url_template)   { '<%= "http://example.com/package-#{@major}.#{@minor}.#{@patch}.deb" %>' }
-  let(:url)            { 'http://example.com/package-1.2.3.deb' }
-  let(:save_file)      { '~/example.txt' }
-  let(:full_save_path) { File.expand_path(save_file, Dir.pwd) }
-  let(:version)        { '1.2.3'}
-  let(:options)        { { url_template: url_template, save_file: save_file, version: version } }
-  let(:package)        { Eff::Package.new options }
-
-  let(:fake_success) { OpenStruct.new(body: "I'm a fake response!", success?: true) }
-  let(:fake_failure) { OpenStruct.new(body: "I'm a fake response!", success?: false) }
-
-  subject { package }
-
-  before { Faraday.stub(:get).and_return(fake_success) }
-
-  it { should respond_to :download }
-  it { should respond_to :save }
-  it { should respond_to :downloaded? }
-  it { should respond_to :url }
-  it { should respond_to :save_file }
-  it { should respond_to :version }
-
-  describe 'downloader wrapper method' do
-    describe '#download' do
-      it 'calls #get' do
-        Eff::Downloader.any_instance.should_receive(:get)
-        package.download
-      end
-    end
-
-    describe '#save' do
-      it 'calls #save' do
-        Eff::Downloader.any_instance.should_receive(:save)
-        package.save
-      end
-    end
-
-    describe '#downloaded?' do
-      it 'calls success?' do
-        Eff::Downloader.any_instance.should_receive(:success?)
-        package.downloaded?
-      end
-    end
-  end
-
-  describe '#url' do
-    it 'returns the correct url' do
-      package.url.should eq(url)
-    end
-  end
-end

data/spec/verifier_spec.rb

@@ -1,20 +0,0 @@
-require 'spec_helper'
-require 'eff/verifier'
-
-describe Eff::Verifier do
-  let(:file) { "spec/support/static_file_for_digesting.txt" }
-  let(:sha1) { "75cfdde12aeb435fd0c68c99df1027190953997e" }
-  let(:md5)  { "1c0b1fcddc0cd9677ecfb79e1d127e03" }
-
-  it 'returns true if the hashes match' do
-    Eff::Verifier.check(file, sha1).should be_true
-  end
-
-  it 'returns false if the hashes do not match' do
-    Eff::Verifier.check(file, "this doesn't match").should_not be_true
-  end
-
-  it 'can validate with md5' do
-    Eff::Verifier.check(file, md5, Digest::MD5).should be_true
-  end
-end