eeny-meeny 2.2.1 → 2.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a41d2bcdbde35c876dc16bf000f3fbbf6b88db74
-  data.tar.gz: 9a67ccc58b5c803a442b2ad4eae6bf5d3f943c48
+  metadata.gz: b63f2223b23e189cdf963583f0666227ec3a6410
+  data.tar.gz: c2e23b8389b07ed951ed3506b3b3f6a6e88bdf1b
 SHA512:
-  metadata.gz: d9b72b27bfcafae526af2566c1db0adc0c8cd717825d376cf68738572c385ac37889c9aa57a593b9364c459a5dbe7c72e88ab2644a84f06f0d1b0e10d657c6b3
-  data.tar.gz: '013679315176da558395a14d3f3dbfa66e975b9b1cc97a319164cf1d62c997c7be93905429f947f88a7c89220afe1efc537d4bbb590278a12b778bce01acfeca'
+  metadata.gz: 51f9a32c834a0b723e76ac840a9deca30deb98bb49bb41f671977f631d4dbddb5a094b0b6a35b16445b6886af629ce4413ed6f776b00e1ba410e02f048585f73
+  data.tar.gz: 79b2ed878d4a24c3a736b311a942d9386b5266eac1a0410ece9d0b76e90e42b6d640bdfadd798e4e9ed4b3b10af1c0c92704c03d6c3638b0550b2866ac50d136

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+### 2.2.2 (2019-04-08)
+
+Bugfixes:
+
+    - Handle scenario where EenyMeeny is configured with an empty experiments file (https://github.com/corthmann/eeny-meeny/issues/9)
+
+Other Changes:
+
+    - Update development dependency "yard" in .gemspec file
+
 ### 2.2.1 (2018-09-09)
 
 Changes:

data/eeny-meeny.gemspec

@@ -3,7 +3,7 @@ require File.expand_path('../lib/eeny-meeny/version', __FILE__)
 Gem::Specification.new do |s|
   s.name        = 'eeny-meeny'
   s.version     = EenyMeeny::VERSION.dup
-  s.date        = '2018-09-09'
+  s.date        = '2019-04-08'
   s.summary     = "A simple split and smoke testing tool for Rails"
   s.authors     = ["Christian Orthmann"]
   s.email       = 'christian.orthmann@gmail.com'
@@ -17,7 +17,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency('rspec', '~> 3')
   s.add_development_dependency('simplecov', '~> 0')
   s.add_development_dependency('simplecov-rcov', '~> 0')
-  s.add_development_dependency('yard', '~> 0')
+  s.add_development_dependency('yard', '>= 0.9.11', '< 1.0.0')
   s.add_development_dependency('rack-test', '~> 0.6.3')
   s.add_runtime_dependency('rack', '>= 1.2.1', '< 3')
   s.add_runtime_dependency('activesupport', '>= 3.0.0', '< 6.0.0')

data/lib/eeny-meeny/models/experiment.rb

@@ -10,12 +10,14 @@ module EenyMeeny
     attr_reader :id, :name, :version, :variations, :total_weight, :end_at, :start_at
 
     def self.find_all
+      return [] unless EenyMeeny.config.experiments
       EenyMeeny.config.experiments.map do |id, experiment|
         new(id, **experiment)
       end
     end
 
     def self.find_by_id(experiment_id)
+      return unless EenyMeeny.config.experiments
       experiment = EenyMeeny.config.experiments[experiment_id.to_sym]
       new(experiment_id, **experiment) if experiment
     end

data/lib/eeny-meeny/version.rb

@@ -1,3 +1,3 @@
 module EenyMeeny
-  VERSION = '2.2.1'
+  VERSION = '2.2.2'
 end

data/spec/eeny-meeny/models/experiment_spec.rb

@@ -170,6 +170,12 @@ describe EenyMeeny::Experiment do
         expect(described_class.find_all).to eq([])
       end
     end
+
+    context 'when EenyMeeny is configured with an empty experiments file', empty_experiments: true do
+      it 'returns an empty array' do
+        expect(described_class.find_all).to eq([])
+      end
+    end
   end
 
   describe '.find_by_id' do
@@ -192,6 +198,12 @@ describe EenyMeeny::Experiment do
         expect(described_class.find_by_id(:experiment_missing)).to be_nil
       end
     end
+
+    context 'when EenyMeeny is configured with an empty experiments file', empty_experiments: true do
+      it 'returns nil' do
+        expect(described_class.find_by_id(:experiment_missing)).to be_nil
+      end
+    end
   end
 
   describe '.find_by_cookie_name', experiments: true do

data/spec/spec_helper.rb

@@ -36,5 +36,10 @@ RSpec.configure do |config|
       config.experiments = YAML.load_file(File.join('spec','fixtures','experiments.yml'))
     end
   end
+  config.before(:each, empty_experiments: true) do
+    EenyMeeny.configure do |config|
+      config.experiments = YAML.load_file(File.join('spec','fixtures','empty_experiments.yml'))
+    end
+  end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eeny-meeny
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 2.2.2
 platform: ruby
 authors:
 - Christian Orthmann
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-09 00:00:00.000000000 Z
+date: 2019-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -70,16 +70,22 @@ dependencies:
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.9.11
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.9.11
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: rack-test
   requirement: !ruby/object:Gem::Requirement
@@ -166,6 +172,7 @@ files:
 - spec/eeny-meeny/models/variation_spec.rb
 - spec/eeny-meeny/routing/experiment_constraint_spec.rb
 - spec/eeny-meeny/routing/smoke_test_constraint_spec.rb
+- spec/fixtures/empty_experiments.yml
 - spec/fixtures/experiments.yml
 - spec/mock_rack_app.rb
 - spec/spec_helper.rb
@@ -190,7 +197,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.6.14.3
 signing_key: 
 specification_version: 4
 summary: A simple split and smoke testing tool for Rails