eefgilm 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 213bba7090ed949e3691e4d491d2b5c7000f9e09
-  data.tar.gz: c0a82a26ba9f22e5b3d6f81486e2f3aef194534c
+  metadata.gz: c84790515b5d71b3c39eb75ec2f7417855902220
+  data.tar.gz: bc84d0e662ac092ea9f9b9822912ff3c60dd218a
 SHA512:
-  metadata.gz: b9938207fb7f954a211ca40172efb29f4df497ccd4231880d487f810c0b67de8890f8afe03e40328c8fdaab0710be240b57cd70e32fceebad84240c56bfc5acb
-  data.tar.gz: 13c950cf7e793782f2b9ddfc4cc80af71a93a02269c8ba2d6551962fdfca8060699b0007c99e7393434189df282935b9b47ea29b85a4aff8a4195a788bbf988f
+  metadata.gz: e0567cab61b68de5e1bf85d4c81b3cb1fdbad6043011be10f6473bd519f3a39077b3018e1e599129344141c5939beea2580d82ba49d8bdabd964f1ba9c88f94c
+  data.tar.gz: dd0a5414a96a0634c549b0aef4306fe48dcd6aed9a27fe338ec1baee7b76ea2b602c517bb9d330cbd26e2ff10ab0b3bcb67787893f4a2c684152053b3272ed0b

data/Gemfile

@@ -1,5 +1,5 @@
 source 'https://rubygems.org'
 
+gem 'pry'
+gem 'pry-nav'
 gemspec
-gem "pry"
-gem "pry-nav"

data/README.md

@@ -4,10 +4,26 @@
 #Eefgilm: A gem for cleaning up your Gemfile
 
 #Description:
-**Important, currently does not support group blocks. If you have groups they will not included in the revised gemfile!**
 
 This gem automatically modifies a ruby gemfile to make them a little easier to read, it does this by alphabetizing the gems, removing all comments, and removing all whitespace including leading and trailing.
 
+These Gemfile best practices are all based on the [blog post](http://mcdowall.info/posts/gemfile-best-practices-and-discourse/) written by John McDowall.
+
+###These best practices are:
+  
+    Consistent use of Ruby hash syntax. Use either the old hashrocket or the new Ruby 1.9 syntax, but not both.
+    Consistent use of a single quoted delimiter. Use either apostrophes or quotation marks, but not both.
+    No commented Gem references. If it’s commented out, it shouldn’t be there.
+    Comments relating to a Gem are on the same line as the gem statement, not above.
+    Group gems that are sourced from Git repos at the top. Chances are they are referencing pre-versions that will become general release and you can change the reference to be part of the General project group later.
+    Group gems that are sourced from a project path after Git repo sourced Gems. These are probably gems that you might make public and thus reference in the general project gem group later.
+    Group all of the General project gems together (consider using the :default group).
+    Group all of the Production project gems together after the General gems.
+    Group all of the Asset gems after the Production group.
+    Group all of the Test related gems after the Asset gems.
+    Group all of the Development related gems after the Test gems.
+    Within all Gem groups, sort the references by Alphabetical order.
+    When adding new gems, maintain the alphabetical ordering within the groups.
 ---
 
 ## Installation
@@ -24,6 +40,14 @@ and then run
 
      bundle install
 
+---
+
+## Demo
+
+A gif of 2 versions of Gemfile i.e before using the gem and after using the gem.
+
+![Banner](http://i1248.photobucket.com/albums/hh483/jainrishi15/before-after-1_zps1b477ded.gif)
+
 ---
 ## Usage
 
@@ -47,21 +71,17 @@ We welcome contributions! If you want to help out you have many options:
 
 ---
 ##Issues
-If you find a bug or have a suggestion, please create a new issue and we will look into it. Thank You. 
+If you find a bug or have a suggestion, please create a new issue and we will look into it. Thank You.
 [Create a new issue](https://github.com/enilsen16/Eefgilm/issues/new)
 
----
-##Contact
-
-
 ---
 
 ##Thanks
-The following people have helped with development or project design in one form or another:  
-[Steve Buckley](https://github.com/buckleys78)  
-[Brook Riggio](https://github.com/brookr)  
-[Cheri](https://github.com/cherimarie)  
-[David](https://github.com/dbalatero)  
+The following people have helped with development or project design in one form or another:<br>
+[Steve Buckley](https://github.com/buckleys78)<br>
+[Brook Riggio](https://github.com/brookr)<br>
+[Cheri](https://github.com/cherimarie)<br>
+[David](https://github.com/dbalatero)<br>
 
 ---
 ##License

data/bin/eefgilm

@@ -2,6 +2,3 @@
 require 'eefgilm'
 gemfile = Eefgilm::Gemfile.new
 gemfile.clean!
-
-
-

data/lib/eefgilm/gemfile.rb

@@ -1,6 +1,6 @@
 module Eefgilm
   class Gemfile
-    attr_accessor :path, :source, :groups
+    attr_accessor :path, :source, :groups, :rubyversion
 
     def initialize(path = ".", options = {})
       @path  = path
@@ -35,6 +35,7 @@ module Eefgilm
 
       file_lines.each do |line|
         self.source = line if line.match(/^source/)
+        self.rubyversion = line if line.match(/^ruby/)
 
         if line.match(/^\s*group/)
           group_block = line.match(/^group (:.*)[,|\s]/)[1]
@@ -71,6 +72,7 @@ module Eefgilm
     def recreate_file
       output = File.open( "#{@path}/Gemfile", "w+" )
       output.puts @source
+      output.puts @rubyversion
       output.puts
 
       @groups.each do |group, gems|

data/lib/eefgilm/version.rb

@@ -1,3 +1,3 @@
 module Eefgilm
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

data/test/data/sources/original/railsgem

@@ -38,6 +38,7 @@ gem 'spring'
 # Use debugger
 # gem 'debugger'
 
+ruby "2.0.0"
 
 group :test do
   gem "minitest-rails-capybara"
@@ -51,7 +52,3 @@ group :production do
   gem 'pg'
   gem 'rails_12factor'
 end
-
-
-
-

data/test/features/gemfile_test.rb

@@ -32,9 +32,10 @@ describe "Gemfile" do
       @worker.groups[:all].must_equal @worker.groups[:all].sort
     end
 
-    # it "should alphabetize gems within a group" do
-
-    # end
+    it "should keep the ruby version" do
+      @worker.clean!
+      @worker.rubyversion.must_include 'ruby "2.0.0"'
+    end
 
   end
 end

data/test/test_helper.rb

@@ -1,5 +1,2 @@
 require "minitest/autorun"
 require "eefgilm"
-require "pry"
-require "pry-nav"
-

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: eefgilm
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Erik Nilsen
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-30 00:00:00.000000000 Z
+date: 2014-07-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest