ecwid_api 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5d60dce1b18b8bf9699f9c2b4d9d172e304b8930
-  data.tar.gz: e88d708e7aaab618524b3066a7580da065eb7f45
+  metadata.gz: 46dcd4e6a2d43c7fad4d64e00476a240b0d18c02
+  data.tar.gz: ea1cccacb59b117efa147353ad038605a867a957
 SHA512:
-  metadata.gz: 6961d44c77a5ca96aa4be870ffc3a4d207014fef70cd4a933ee4721412186b2514927a2e09d2373ff5735795ce45ecf3e6515b310c6c69c67c0780d366bcd93b
-  data.tar.gz: 76b6fb2275ae4204693e8b96e5c105f7898929d7d767b28857abf41b180e6f29ae3a6273881a2aaa3ed7e5167bc009a6316f23e549eeefa97429caf940603d63
+  metadata.gz: c8c88afb4c895ef03be8d767e2d8a347ca4109852813df33fc77126ada5109bc67c5809faaf48f77e2a8152eaea4be1e09e1a2478cf33204c3ac80ab73da6e13
+  data.tar.gz: e7a441c8d51c30971954ad531930c7777a5af0abde8d77cfd850ab41c4e382397cdbc3f2d932f9ba7d11aeadf4b1cbefccc123ca6ed3fb60fd8e79d3d0e7b648

data/lib/ecwid_api/order.rb

@@ -42,24 +42,20 @@ module EcwidApi
     end
 
     # Public: Returns the billing person
+    #
+    # If there isn't a billing_person, then it assumed to be the shipping_person
+    #
     def billing_person
-      return unless data["billingPerson"] || data["shippingPerson"]
-
-      @billing_person ||= if data["billingPerson"]
-        Person.new(data["billingPerson"])
-      else
-        shipping_person
-      end
+      build_billing_person || build_shipping_person
     end
 
     # Public: Returns the shipping person
+    #
+    # If there isn't a shipping_person, then it is assumed to be the 
+    # billing_person
+    #
     def shipping_person
-      return unless data["shippingPerson"] || data["billingPerson"]
-      @shipping_person ||= if data["shippingPerson"]
-        Person.new(data["shippingPerson"])
-      else
-        billing_person
-      end
+      build_shipping_person || build_billing_person
     end
 
     # Public: Returns a Array of `OrderItem` objects
@@ -78,5 +74,15 @@ module EcwidApi
     def fulfillment_status
       super && super.downcase.to_sym
     end
+
+    private
+
+    def build_billing_person
+      @billing_person ||= data["billingPerson"] && Person.new(data["billingPerson"])
+    end
+
+    def build_shipping_person
+      @shipping_person ||= data["shippingPerson"] && Person.new(data["shippingPerson"])
+    end
   end
 end

data/lib/ecwid_api/version.rb

@@ -1,3 +1,3 @@
 module EcwidApi
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

data/spec/spec_helper.rb

@@ -7,7 +7,6 @@
 
 require "ecwid_api"
 require "helpers/client"
-require "pry"
 
 RSpec.configure do |config|
   config.treat_symbols_as_metadata_keys_with_true_values = true

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ecwid_api
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - David Biehl