ecoportal-api 0.10.10 → 0.10.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 26fb7bdc3007d89987bd3e23d59c7ea0f3290b46bbd6e188c7746f92e9b329c4
-  data.tar.gz: 9b7b5f874fb7d8bd2e20dfe75064b1632815b30e29fe47276b5f9b29a0e9e1a0
+  metadata.gz: 5a555853c173845b7e088537a48316ab93d1e1cade81a1554bf75ebdd9d754c5
+  data.tar.gz: 1cbd64e04195227bd5d4eb2694b8968f0987ca301ccb48a558fd1ca7fb409e6c
 SHA512:
-  metadata.gz: 7a06edd0dca6647c2eb312ad104026f86ee1b2688c3ddc4a2b43aee1ecfc282e50ca5a4893cee98f03c88d0e27f264f762210e688eb70ea20cb25ffd98832dbf
-  data.tar.gz: d6434f2b2549a6d9101a88ba88f5ffd25390b80123dcc214c4600f7e458887fce92230357b44c8ba934e87b11c2777f50e1f91433432ffacd6928cb4e08d7776
+  metadata.gz: 7adc6cf22eef822270e8429e469d4566109e93bcfbb93431a4a47406e7ff370c1bd26f4f683ede1799fc2b8c7b4d46509d41d28674489868b58a2550f5eafa7b
+  data.tar.gz: 15ba327d877408f5b576e004789143deddf231f4d6954943034bfa82b9e69aa14137fb65c4a33f93dd8dc0be96164f540dcb29b7c1867d7315a2ee4ea285731f

data/.gitignore

@@ -21,3 +21,5 @@ scratch.rb
 
 #byebug
 .byebug_history
+
+.solargraph.yml

data/CHANGELOG.md

@@ -8,8 +8,14 @@ All notable changes to this project will be documented in this file.
 
 ### Changed
 
+- `MAX_START_DELAY` to be `120` (it was `60`).
+
 ### Fixed
 
+- `PersonDetails#changed?`: `ref` wasn't being used.
+- `Ecoportal::API::V1::Job::Awaiter`
+  - First timer relay should use `ldelay` of 1 second if it's first loop.
+
 ## [0.10.10] - 2025-04-04
 
 ### Fixed

data/lib/ecoportal/api/common/base_model.rb

@@ -4,9 +4,10 @@ module Ecoportal
     module Common
       class BaseModel
         class UnlinkedModel < StandardError
-          def initialize(msg = 'Something went wrong when linking the document.', from: nil, key: nil)
-            msg << " From: #{from}." if from
-            msg << " key: #{key}."   if key
+          def initialize(msg = nil, from: nil, key: nil)
+            msg ||= 'Something went wrong when linking the document.'
+            msg  << " From: #{from}." if from
+            msg  << " key: #{key}."   if key
             super(msg)
           end
         end

data/lib/ecoportal/api/common/client/time_out.rb

@@ -40,6 +40,9 @@ module Ecoportal
             throughput.eta_for(to_count(count), **kargs)
           end
 
+          # @todo introduce `min_wait`
+          #   - The reason is because small batches have still an associated lag
+          #     before the jobs start to run.
           def timeout_for(count, waited: 0, max_wait: nil, approach: :conservative)
             (waited + eta_for(count, approach: approach)).then do |time|
               next time unless max_wait

data/lib/ecoportal/api/common/hash_diff.rb

@@ -11,7 +11,7 @@ module Ecoportal
             when Hash
               {}.tap do |diffed|
                 a.each do |key, a_value|
-                  b_value    = b && b[key]
+                  b_value    = b[key] if b
                   no_changes = (a_value == b_value) || ignore.include?(key)
                   next if !ID_KEYS.include?(key) && no_changes
 

data/lib/ecoportal/api/v1/job/awaiter/timer.rb

@@ -11,7 +11,7 @@ module Ecoportal
 
           # The class
           Timer = Struct.new(*TIMER_ARGS) do
-            self::MAX_START_DELAY = 60
+            self::MAX_START_DELAY = 120
 
             attr_reader :timestamp
 
@@ -22,17 +22,24 @@ module Ecoportal
             end
 
             alias_method :original_start, :start
+            # Previous start or current timestamp.
+            # @note in practice this translates into the very first
+            #   timestamp (so it's an absolute start)
             def start
               original_start || timestamp
             end
 
             alias_method :original_last, :last
+            # Previous timestamp.
             def last
               original_last || start
             end
 
             def new(**kargs, &block)
-              self.class.new(**new_kargs.merge(kargs), &block)
+              self.class.new(
+                **new_kargs.merge(kargs),
+                &block
+              )
             end
 
             def job_id
@@ -40,10 +47,14 @@ module Ecoportal
             end
 
             def complete?
+              return false unless status
+
               status.complete?(total)
             end
 
             def started?
+              return false unless status
+
               status.started?
             end
 
@@ -59,14 +70,17 @@ module Ecoportal
               status.progress_increase(lstatus)
             end
 
+            # Total time waited (absolute).
             def waited
               timestamp - start
             end
 
+            # Time waited since last timestamp (relative).
             def lwaited
               timestamp - last
             end
 
+            # Absolute wait minus half of the last sleep.
             def net_waited
               last_delay = ldelay || 0
               waited - (last_delay / 2)
@@ -76,22 +90,26 @@ module Ecoportal
               (timeout_in - waited).round(2)
             end
 
+            # Time left before timing out job started
+            # or job finished.
+            def timeout_in
+              return time_left_total if started?
+
+              time_left_to_start
+            end
+
+            # Total time left before timing out.
             def time_left_total
               (timeout - waited).round(2)
             end
 
+            # Time left before Job start times out.
             def time_left_to_start
               return max_start_delay if started?
 
               (max_start_delay - waited).round(2)
             end
 
-            def timeout_in
-              return time_left_total if started?
-
-              time_left_to_start
-            end
-
             # timeout library is evil. So we make poor-man timeout.
             # https://jvns.ca/blog/2015/11/27/why-rubys-timeout-is-dangerous-and-thread-dot-raise-is-terrifying/
             def timeout?
@@ -141,7 +159,7 @@ module Ecoportal
               %i[total timeout start].each_with_object({}) do |key, kargs|
                 kargs[key] = send(key)
               end.tap do |kargs|
-                kargs[:start]   = start
+                kargs[:start]   = start # @todo redundant
                 kargs[:last]    = timestamp
                 kargs[:lstatus] = status
               end
@@ -149,6 +167,7 @@ module Ecoportal
 
             private
 
+            # We would not wait more than this time for a Job to start.
             def max_start_delay
               self.class::MAX_START_DELAY
             end

data/lib/ecoportal/api/v1/job/awaiter.rb

@@ -9,8 +9,14 @@ module Ecoportal
           include Common::Client::TimeOut
           include StatusFrequency
 
-          TIMEOUT_APPROACH   = :min # :conservative # adaptative timeout
-          TIMEOUT_FALLBACK   = :min
+          # available approaches are:
+          #  - `:min` assumes always the `MIN_THROUGHPUT`.
+          #  - `:last` last seen throughput.
+          #  - `:conservative` the bigger of: min throughput seen or `MIN_THROUGHPUT`.
+          #  - `:optimistic` the smoller of: max throughput seen or `MAX_THROUGHPUT`.
+          #  - `:average` the accumulated avarage of througoutputs.
+          TIMEOUT_APPROACH   = :min
+          TIMEOUT_FALLBACK   = :min # on timeout swap to this approach.
 
           attr_reader :job_api, :job_id, :total
 
@@ -51,10 +57,11 @@ module Ecoportal
 
               timer = timer.new(
                 status: job_api.status(job_id),
-                ldelay: delay_status_check
+                ldelay: delay_status_check || 1
               )
 
               # ratio = throughput!(timer.net_waited, count: timer.progress)
+              # last throughput (rather than average as above)
               ratio = throughput!(timer.lwaited, count: timer.increased)
 
               break timer.status if timer.complete?

data/lib/ecoportal/api/v1/job.rb

@@ -4,6 +4,7 @@ require 'ecoportal/api/v1/job/awaiter'
 module Ecoportal
   module API
     class V1
+      # @todo add `#relaunch` where only pending results are requested.
       class Job
         attr_reader :client, :person_class
 
@@ -15,7 +16,7 @@ module Ecoportal
           @created      = false
         end
 
-        # Allows to preserve the learned througoutput
+        # Allows to preserve the learned throughput
         def new
           self.class.new(client, person_class: person_class).tap do |out|
             out.awaiter = @awaiter

data/lib/ecoportal/api/v1/person_details.rb

@@ -25,6 +25,7 @@ module Ecoportal
         # @return [Array<SchemaFieldValue>] the array of fields of the schema.
         def fields
           return @fields if defined?(@fields)
+
           @fields = (doc['fields'] || []).each_with_index.map do |field, i|
             schema_field_value_class.new(field, parent: self, key: ['fields', i])
           end
@@ -66,10 +67,10 @@ module Ecoportal
         end
 
         # @return [Boolean] `true` if `id` exists and `value` has changed, `false` otherwise
-        def changed?(id, doc = :original)
+        def changed?(id, ref = :last)
           return false unless (field = get_field(id))
 
-          field.as_update.key?('value')
+          field.as_update(ref).key?('value')
         end
 
         def original_value(id)

data/lib/ecoportal/api/version.rb

@@ -1,5 +1,5 @@
 module Ecoportal
   module API
-    VERSION = '0.10.10'.freeze
+    VERSION = '0.10.11'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ecoportal-api
 version: !ruby/object:Gem::Version
-  version: 0.10.10
+  version: 0.10.11
 platform: ruby
 authors:
 - Tapio Saarinen
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-04-04 00:00:00.000000000 Z
+date: 2025-05-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry