economic-rest 0.6.2 → 0.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba643539fb39486d8b0a8833d9b4e7ef5ea8c36a1d68390ea6c7fdf50796a7aa
-  data.tar.gz: edf319c61901c9d7654c026ce72193e3f6dfc137327807d5b5592ec8299d5d65
+  metadata.gz: 5e67b392301ec491022017a99c741e61e22b9e66f87c77d4fe251787b15171eb
+  data.tar.gz: 751e03e4de3bc1d6974234009fdd079823b0f062abe1dac71e1108720e307833
 SHA512:
-  metadata.gz: 4c85b13a4a61538064f5dff85157eb9b664d1e8820a99a2ca35c3a362e925b4863a25a8a4791da1deecb1668d54c300e4ad2f6b80240c62676ff7867430b2a60
-  data.tar.gz: e685da1ddf6b7a84a0f91ab2f4a2b2a92ac6ec661cfa21344e67213ea44a354175d6880b545f73862be33f7169ba91f3a22a57478fa4cbbb6f3c6fb67f7d4af5
+  metadata.gz: 3906cc750544bdad9265b005c398e6daa3df32c358fa33038b45ee9c65ce5d7c0917f8c420c9ff4a81e7540174ab1bd18cdd4f479cfffd5327449e220f8ca026
+  data.tar.gz: ff01dd74f57a7ade5a70b28525d4a485bad4fc7c13dfef125ca1a6a19b4fcb76db892a0f225fe7261c02fb4bead654d70ee86ebff3872078992775c6679024b8

data/.ruby-version

@@ -0,0 +1 @@
+3.3.0

data/Gemfile

@@ -1,6 +1,6 @@
 source "https://rubygems.org"
 
-git_source(:bitbucket) { |_repo_name| "https://bitbucket.org/traels/economic-rest" }
+git_source(:github) { |_repo_name| "https://github.com/traels-it/economic-rest" }
 
 # Specify your gem's dependencies in economic-rest.gemspec
 gemspec

data/Gemfile.lock

@@ -1,148 +1,150 @@
 PATH
   remote: .
   specs:
-    economic-rest (0.6.1)
-      activesupport
-      rest-client
-      savon
+    economic-rest (0.6.4)
+      activesupport (~> 7.0)
+      rest-client (~> 2.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.1.4)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
+    activesupport (7.2.1.1)
+      base64
+      bigdecimal
+      concurrent-ruby (~> 1.0, >= 1.3.1)
+      connection_pool (>= 2.2.5)
+      drb
       i18n (>= 1.6, < 2)
+      logger (>= 1.4.2)
       minitest (>= 5.1)
-      tzinfo (~> 2.0)
-      zeitwerk (~> 2.3)
-    addressable (2.5.2)
-      public_suffix (>= 2.0.2, < 4.0)
-    akami (1.3.1)
-      gyoku (>= 0.4.0)
-      nokogiri
-    ast (2.4.0)
-    awesome_print (1.8.0)
-    builder (3.2.4)
-    concurrent-ruby (1.1.9)
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0, >= 2.0.5)
+    addressable (2.8.7)
+      public_suffix (>= 2.0.2, < 7.0)
+    ast (2.4.2)
+    awesome_print (1.9.2)
+    base64 (0.2.0)
+    bigdecimal (3.1.8)
+    concurrent-ruby (1.3.4)
+    connection_pool (2.4.1)
     coveralls (0.8.23)
       json (>= 1.8, < 3)
       simplecov (~> 0.16.1)
       term-ansicolor (~> 1.3)
       thor (>= 0.19.4, < 2.0)
       tins (~> 1.6)
-    crack (0.4.3)
-      safe_yaml (~> 1.0.0)
-    docile (1.3.1)
-    domain_name (0.5.20190701)
-      unf (>= 0.0.5, < 1.0.0)
-    dotenv (2.7.4)
-    gyoku (1.3.1)
-      builder (>= 2.1.2)
-    hashdiff (0.3.8)
+    crack (1.0.0)
+      bigdecimal
+      rexml
+    docile (1.4.1)
+    domain_name (0.6.20240107)
+    dotenv (3.1.4)
+    drb (2.2.1)
+    hashdiff (1.1.1)
     http-accept (1.7.0)
-    http-cookie (1.0.4)
+    http-cookie (1.0.7)
       domain_name (~> 0.5)
-    httpi (2.4.5)
-      rack
-      socksify
-    i18n (1.8.10)
+    i18n (1.14.6)
       concurrent-ruby (~> 1.0)
-    jaro_winkler (1.5.3)
-    json (2.1.0)
-    m (1.5.1)
+    json (2.7.2)
+    language_server-protocol (3.17.0.3)
+    lint_roller (1.1.0)
+    logger (1.6.1)
+    m (1.6.2)
       method_source (>= 0.6.7)
       rake (>= 0.9.2.2)
-    metaclass (0.0.4)
-    method_source (0.9.2)
-    mime-types (3.3.1)
+    method_source (1.1.0)
+    mime-types (3.6.0)
+      logger
       mime-types-data (~> 3.2015)
-    mime-types-data (3.2021.0225)
-    mini_portile2 (2.5.3)
-    minitest (5.11.3)
-    mocha (1.9.0)
-      metaclass (~> 0.0.1)
+    mime-types-data (3.2024.1001)
+    minitest (5.25.1)
+    mocha (2.4.5)
+      ruby2_keywords (>= 0.0.5)
     netrc (0.11.0)
-    nokogiri (1.11.7)
-      mini_portile2 (~> 2.5.0)
-      racc (~> 1.4)
-    nori (2.6.0)
-    parallel (1.17.0)
-    parser (2.6.4.1)
-      ast (~> 2.4.0)
-    public_suffix (3.0.3)
-    racc (1.5.2)
-    rack (2.2.3)
-    rainbow (3.0.0)
-    rake (10.5.0)
+    parallel (1.26.3)
+    parser (3.3.5.0)
+      ast (~> 2.4.1)
+      racc
+    public_suffix (6.0.1)
+    racc (1.8.1)
+    rainbow (3.1.1)
+    rake (13.2.1)
+    regexp_parser (2.9.2)
     rest-client (2.1.0)
       http-accept (>= 1.7.0, < 2.0)
       http-cookie (>= 1.0.2, < 2.0)
       mime-types (>= 1.16, < 4.0)
       netrc (~> 0.8)
-    rubocop (0.72.0)
-      jaro_winkler (~> 1.5.1)
+    rexml (3.3.8)
+    rubocop (1.66.1)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 2.6)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 2.4, < 3.0)
+      rubocop-ast (>= 1.32.2, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 1.7)
-    rubocop-performance (1.4.1)
-      rubocop (>= 0.71.0)
-    ruby-progressbar (1.10.1)
-    safe_yaml (1.0.4)
-    savon (2.12.1)
-      akami (~> 1.2)
-      builder (>= 2.1.2)
-      gyoku (~> 1.2)
-      httpi (~> 2.3)
-      nokogiri (>= 1.8.1)
-      nori (~> 2.4)
-      wasabi (~> 3.4)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.32.3)
+      parser (>= 3.3.1.0)
+    rubocop-performance (1.22.1)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
+    ruby-progressbar (1.13.0)
+    ruby2_keywords (0.0.5)
+    securerandom (0.3.1)
     simplecov (0.16.1)
       docile (~> 1.1)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.2)
-    socksify (1.7.1)
-    standard (0.1.4)
-      rubocop (~> 0.72.0)
-      rubocop-performance (~> 1.4.0)
-    term-ansicolor (1.7.1)
+    standard (1.41.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.66.0)
+      standard-custom (~> 1.0.0)
+      standard-performance (~> 1.5)
+    standard-custom (1.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.50)
+    standard-performance (1.5.0)
+      lint_roller (~> 1.1)
+      rubocop-performance (~> 1.22.0)
+    sync (0.5.0)
+    term-ansicolor (1.11.2)
       tins (~> 1.0)
-    thor (0.20.3)
-    tins (1.22.1)
-    tzinfo (2.0.4)
+    thor (1.3.2)
+    tins (1.36.1)
+      bigdecimal
+      sync
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unf (0.1.4)
-      unf_ext
-    unf_ext (0.0.7.7)
-    unicode-display_width (1.6.0)
-    wasabi (3.6.1)
-      addressable
-      httpi (~> 2.0)
-      nokogiri (>= 1.4.2)
-    webmock (3.5.1)
-      addressable (>= 2.3.6)
+    unicode-display_width (2.6.0)
+    webmock (3.24.0)
+      addressable (>= 2.8.0)
       crack (>= 0.3.2)
-      hashdiff
-    zeitwerk (2.4.2)
+      hashdiff (>= 0.4.0, < 2.0.0)
 
 PLATFORMS
-  ruby
+  arm64-darwin-21
+  arm64-darwin-22
+  arm64-darwin-23
 
 DEPENDENCIES
   awesome_print
-  bundler (~> 1.17)
+  bundler (~> 2.4)
   coveralls
   dotenv
   economic-rest!
   m
-  minitest (~> 5.0)
+  minitest (~> 5.25)
   mocha
-  rake (~> 10.0)
+  rake (~> 13.2)
   simplecov
   standard
-  webmock (~> 3.5)
+  webmock (~> 3.24)
 
 BUNDLED WITH
-   2.4.13
+   2.5.21

data/README.md

@@ -5,7 +5,7 @@
 [![Coverage Status](https://coveralls.io/repos/bitbucket/traels/economic-rest/badge.svg?branch=master)](https://coveralls.io/bitbucket/traels/economic-rest?branch=master)
 
 Ruby wrapper for the e-conomic REST API, that aims at making working with the API bearable.
-E-conomic is a web-based accounting system. For their marketing speak, see http://www.e-conomic.co.uk/about/. More details about their API at http://www.e-conomic.co.uk/integration/integration-partner/'.
+E-conomic is a web-based accounting system. For their marketing speak, see http://www.e-conomic.co.uk/about/. More details about their API at http://www.e-conomic.co.uk/integration/integration-partner/.
 The documentation can be found at https://restdocs.e-conomic.com
 
 
@@ -27,6 +27,90 @@ Or install it yourself as:
 
 ## Usage
 
+The gem started out with an architecture, that was a bit too hard to work with. Going forward this will change significantly. As of now the changes are not breaking, but the old way will be deprecated as the new architecture is implemented. No further development will be made for the old architecture, instead we aim to incrementally become feature complete using the new architecture.
+Once all the old models and repos have been converted to the new architecture, a date will be set for when they will be removed.
+
+### New architecure
+#### Repos
+The gem maps the API endpoint using classes called `Repos`.
+All the end points dealing with one resource will be accessible through one repo, for instance all the actions under `/customers` will be accessible through `Economic::Repos::Customer`:
+
+| HTTP method | Endpoint | Repo method |
+| -------- | -------- | --------- |
+| GET | `/customers`   | `repo.all` |
+| POST | `/customers`   | `repo.create(customer_instance)` |
+| GET | `/customers/:customerNumber`   | `repo.find(id_or_object_responding_to_id)` |
+| PUT | `/customers/:customerNumber`   | `repo.update(customer_instance_with_updated_data)` |
+| PATCH | `/customers/:customerNumber`   | *Special case - not yet implemented* |
+| DELETE | `/customers/:customerNumber`   | `repo.destroy(id_or_object_responding_to_id)` |
+
+##### `repo.all`
+Returns *all* the records for the repo. If there are more than 1.000, it handles the pagination automatically and returns the records in a single array.
+`all` can take a filter text if you are not interested in every single record. The allowed filtering operators are:
+
+| Operator | Syntax |
+| -------- | --------- |
+| Equals   | `$eq:` |
+| Not equals | `$ne:` |
+| Greater than | `$gt:` |
+| Greater than or equal | `$gte:` |
+| Less than | `$lt:` |
+| Less than or equal | `$lte:` |
+| Substring match | `$like:` |
+| And also | `$and:` |
+| Or else | `$or:` |
+| In | `$in:` |
+| Not In | `$nin:` |
+
+For more details see https://restdocs.e-conomic.com/#specifying-operator-affinity
+
+For now the attribute names must be in lower camelcase when filtering:
+```
+Economic::Repos::Customer.all(filter: "corporateIdentificationNumber$eq:22001884")
+```
+
+#### Credentials
+
+Repos require credentials to know which e-conomic account to connect to. These can be suuplied in two ways:
+1. Setting a global set of credentials through `Economic::Configuration` will apply to any repo you initialize:
+    ```
+    Economic::Configuration.app_secret_token = "Demo"
+    Economic::Configuration.agreement_grant_token = "Demo"
+
+    repo = Economic::Repo::Customer.new
+    repo.credentials => #<data Economic::Credentials app_secret_token="Demo", agreement_grant_token="Demo">
+    ```
+2. Supplying a set of credentials when initializing a repo, sets them for that instance only:
+    ```
+    credentials = Economic::Credentials.new(app_secret_token: "secret", agreement_grant_token: "grant")
+    
+    repo = Economic::Repo::Customer.new(credentials: credentials)
+    repo.credentials => #<data Economic::Credentials app_secret_token="secret", agreement_grant_token="grant">
+    ```
+
+#### Nested repos
+Some endpoints are nested under other endpoints, e.g. `/customers/:customerNumber/contacts`. This requires the id of the customer, whose contacts you want to manipulate. Therefore the repo must be initialized with an id or model:
+```
+customer = Economic::Models::Customer.new(id: 12)
+repo = Economic::Repos::Customers::Contact.new(customer).new
+repo.all => All instances of Economic::Models::Customers::Contact belonging to the customer
+```
+
+#### Error handling
+An error is raised when the response from e-conomic has one of the following error codes:
+
+| Error Code | Error class |
+| -------- | --------- |
+| 400 | Economic::BadRequestError |
+| 401 | Economic::UnauthorizedError |
+| 403 | Economic::ForbiddedError |
+| 404 | Economic::NotFoundError |
+| 500 | Economic::InternalError |
+
+The error message is the response body from e-conomic.
+
+### Old architecture
+
 ```ruby
 require 'economic/rest'
 
@@ -71,7 +155,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://bitbucket.org/traels/economic-rest. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at https://github.com/traels-it/economic-rest. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
 
 ## License
 
@@ -79,4 +163,6 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Code of Conduct
 
-Everyone interacting in the Economic::Rest project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://bitbucket.org/traels/economic-rest/blob/master/CODE_OF_CONDUCT.md).
+Everyone interacting in the Economic::Rest project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/traels-it/economic-rest/blob/main/CODE_OF_CONDUCT.md).
+
+

data/economic-rest.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
   spec.summary = 'Ruby wrapper for the e-conomic REST API, that aims at making working with the API bearable.
 E-conomic is a web-based accounting system. For their marketing speak, see http://www.e-conomic.co.uk/about/. More details about their API at http://www.e-conomic.co.uk/integration/integration-partner/.
 The documentation can be found at https://restdocs.e-conomic.com'
-  spec.homepage = "https://bitbucket.org/traels/economic-rest"
+  spec.homepage = "https://github.com/traels-it/economic-rest"
   spec.license = "MIT"
 
   # Specify which files should be added to the gem when it is released.
@@ -23,19 +23,18 @@ The documentation can be found at https://restdocs.e-conomic.com'
   spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.17"
+  spec.add_development_dependency "bundler", "~> 2.4"
   spec.add_development_dependency "m"
-  spec.add_development_dependency "minitest", "~> 5.0"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "minitest", "~> 5.25"
+  spec.add_development_dependency "rake", "~> 13.2"
   spec.add_development_dependency "simplecov"
-  spec.add_development_dependency "webmock", "~> 3.5"
+  spec.add_development_dependency "webmock", "~> 3.24"
   spec.add_development_dependency "dotenv"
   spec.add_development_dependency "standard"
   spec.add_development_dependency "awesome_print"
   spec.add_development_dependency "mocha"
   spec.add_development_dependency "coveralls"
 
-  spec.add_dependency "savon"
-  spec.add_dependency "rest-client"
-  spec.add_dependency "activesupport"
+  spec.add_dependency "rest-client", "~> 2.1"
+  spec.add_dependency "activesupport", "~> 7.0"
 end

data/lib/economic/accounting_year_repo.rb

@@ -1,4 +1,6 @@
 module Economic
   class AccountingYearRepo < Economic::BaseRepo
   end
+
+  deprecate_constant :AccountingYearRepo
 end

data/lib/economic/attribute.rb

@@ -0,0 +1,9 @@
+module Economic
+  class Attribute < Data.define(:name, :as)
+    def economic_name
+      return as.to_s unless as.to_s.blank?
+
+      name.to_s.camelize(:lower)
+    end
+  end
+end

data/lib/economic/base_repo.rb

@@ -22,11 +22,6 @@ module Economic
         modelize_response(response)
       end
 
-      def send(model, url: endpoint_url)
-        warn "use #{self}.save().  #{self}.send() is deprecated"
-        save(model, url: endpoint_url)
-      end
-
       def all(filter_text: "", url: endpoint_url)
         pagination = {}
         pageindex = 0
@@ -72,14 +67,14 @@ module Economic
         response = send_request(method: :delete, url: url)
 
         success_codes = [200, 204]
-        return true if success_codes.include?(response.code)
+        true if success_codes.include?(response.code)
       end
 
-      def send_request(method:, url:, payload: "", &block)
+      def send_request(method:, url:, payload: "", &)
         if payload.strip.empty?
-          RestClient::Request.execute(method: method, url: url, headers: headers, &block)
+          RestClient::Request.execute(method: method, url: url, headers: headers, &)
         else
-          RestClient::Request.execute(method: method, url: url, payload: payload, headers: headers, &block)
+          RestClient::Request.execute(method: method, url: url, payload: payload, headers: headers, &)
         end
       rescue => e
         warn "#{e} #{e.response}" if e.respond_to?(:response)
@@ -95,7 +90,7 @@ module Economic
           .gsub(":", "_4_")
           .gsub("&", "_5_")
           .gsub("/", "_6_")
-          .gsub('\\', "_7_")
+          .gsub("\\", "_7_")
           .gsub(" ", "_9_")
           .gsub("?", "_10_")
           .gsub(".", "_11_")
@@ -131,7 +126,7 @@ module Economic
       end
 
       def headers
-        {'X-AppSecretToken': Session.app_secret_token, 'X-AgreementGrantToken': Session.agreement_grant_token, 'Content-Type': "application/json"}
+        {"X-AppSecretToken": Session.app_secret_token, "X-AgreementGrantToken": Session.agreement_grant_token, "Content-Type": "application/json"}
       end
 
       def fetch(url: endpoint_url, pageindex: 0, filter_text: "")
@@ -143,7 +138,7 @@ module Economic
       end
 
       def kebab(string)
-        string.gsub(/::/, "/")
+        string.gsub("::", "/")
           .gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
           .gsub(/([a-z\d])([A-Z])/, '\1_\2')
           .tr("_", "-")

data/lib/economic/configuration.rb

@@ -0,0 +1,7 @@
+module Economic
+  class Configuration
+    class << self
+      attr_accessor :app_secret_token, :agreement_grant_token
+    end
+  end
+end

data/lib/economic/credentials.rb

@@ -0,0 +1,26 @@
+module Economic
+  class Credentials < Data.define(:app_secret_token, :agreement_grant_token)
+    class << self
+      def fetch!
+        credentials = new(
+          app_secret_token: Economic::Configuration.app_secret_token,
+          agreement_grant_token: Economic::Configuration.agreement_grant_token
+        )
+
+        raise MissingCredentialsError if credentials.missing?
+
+        credentials
+      end
+    end
+
+    def missing?
+      app_secret_token.nil? || agreement_grant_token.nil?
+    end
+  end
+
+  class MissingCredentialsError < StandardError
+    def message
+      "Credentials missing! Initialize the resource with a set of credentials or set them on Economic::Configuration"
+    end
+  end
+end

data/lib/economic/customer_contact_repo.rb

@@ -2,4 +2,6 @@ module Economic
   class CustomerContactRepo < Economic::NestedBaseRepo
     self.endpoint = "contacts"
   end
+
+  deprecate_constant :CustomerContactRepo
 end

data/lib/economic/customer_repo.rb

@@ -1,4 +1,6 @@
 module Economic
   class CustomerRepo < Economic::BaseRepo
   end
+
+  deprecate_constant :CustomerRepo
 end

data/lib/economic/invoice.rb

@@ -28,31 +28,6 @@ module Economic
     relation :references, fields: [:other]
     relation :lines, fields: [:lineNumber, :description, :sortKey, :quantity, :unitNetPrice, :discountPercentage, :unitCostPrice, :marginInBaseCurrency, :marginPercentage, :totalNetAmount], multiple: true
 
-    def self.build_from_soap_api(data)
-      # TODO: Add all the options
-      hash = {
-        "currency" => data[:currency_handle][:code],
-        "date" => data[:date].to_date,
-        "dueDate" => data[:due_date].to_date,
-        "exchangeRate" => data[:exchange_rate],
-        "grossAmount" => data[:gross_amount],
-        # where is grossAmountInBaseCurrency?
-        "lines" => repo.find_lines(data[:handle][:id]),
-        "marginInBaseCurrency" => data[:margin],
-        "marginPercentage" => data[:margin_as_percent],
-        "netAmount" => data[:net_amount],
-        "roundingAmount" => data[:rounding_amount],
-        "vatAmount" => data[:vat_amount],
-        "draftInvoiceNumber" => data[:handle][:id], # TODO: What about id?
-        "customer" => {"customerNumber" => data[:debtor_handle][:id].to_i},
-        "layout" => {"layoutNumber" => data[:layout_handle][:id].to_i},
-        "paymentTerms" => {"paymentTermsNumber" => data[:term_of_payment_handle][:id].to_i},
-        "references" => {"other" => data[:other_reference]},
-      }
-
-      new(hash)
-    end
-
     def self.repo
       Economic::Invoices::DraftsRepo
     end

data/lib/economic/invoices/booked_repo.rb

@@ -2,7 +2,7 @@ module Economic
   module Invoices
     class BookedRepo < Economic::Invoices::Repo
       class << self
-        def send(invoice, book_with_number: nil)
+        def save(invoice, book_with_number: nil)
           response = send_request(method: :post, url: endpoint_url, payload: payload(invoice, book_with_number: book_with_number))
 
           entry_hash = JSON.parse(response.body)

data/lib/economic/invoices/drafts_repo.rb

@@ -7,5 +7,7 @@ module Economic
         modelize_response(response)
       end
     end
+
+    deprecate_constant :DraftsRepo
   end
 end

data/lib/economic/invoices/repo.rb

@@ -13,7 +13,7 @@ module Economic
           invoices
         end
 
-        def send(model, url: endpoint_url)
+        def save(model, url: endpoint_url)
           response = send_request(method: :post, url: url, payload: model.to_h.to_json)
 
           modelize_response(response)

data/lib/economic/line.rb

@@ -15,26 +15,5 @@ module Economic
     relation :unit, fields: []
     relation :delivery, fields: []
     relation :departmentalDistribution, fields: []
-
-    def self.build_from_soap_api(data)
-      # This is not instantiated with the hash, as lines are never pulled out by themselves, but always as part of
-      # a invoice or order
-      {
-        "lineNumber" => data[:number].to_i,
-        "description" => data[:description],
-        "quantity" => data[:quantity].to_f,
-        "unitNetPrice" => data[:unit_net_price].to_f,
-        "discountPercentage" => data[:discount_as_percent].to_f,
-        "unitCostPrice" => data[:unit_cost_price].to_f,
-        "totalNetAmount" => data[:total_net_amount].to_f,
-        "marginPercentage" => data[:margin_as_percent].to_f,
-        "marginInBaseCurrency" => data[:total_margin].to_f,
-        "product" => {"productNumber" => data[:product_handle][:number]},
-        # Unmapped values in soap
-        # delivery_date
-        # :accrual_start_date => nil,
-        # :accrual_end_date => nil
-      }
-    end
   end
 end