ecom_core 1.3.5 → 1.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b98441f93ef2ac55a259a560966fb9700ce83f5f4db69f24fa2c25ead85725f7
-  data.tar.gz: 6a75eb6ea6dea439e47d413442d0064ba5ef5c883da5bc2cf6065d08957869d1
+  metadata.gz: ce6cc11612b16aefac6121429ece4bee60b97ada78dcfdba961c792fedc0c0f4
+  data.tar.gz: 52a55fb8f1e97dc391a7ccede45bf7ed97d318f8f7029a2a465960ec089db864
 SHA512:
-  metadata.gz: 386c8d0cece70aa3f6087e0eb57ce76bc3e41e168dafb43ec53ab2405ea43223aecaf4acf34d7354929316d2ce61c320b2a8afaef76dbb46985a6853c436b720
-  data.tar.gz: 11a8ba2dc16bee865f43df73fef3118f80b47805ca011489456daa63bee26356b231dd36a1a2fa1d54a62a7e41abb9b3c9b820dc53107c2e39aea580616abad6
+  metadata.gz: 5bbacc01ee8a03bf4c2c16f3774da1657faa9f00d449ee3368625652f0d562ea22e0721bcaf0038de3de9d4245de2f955746f7f5006cc0835965f2db87a84ee7
+  data.tar.gz: 13b332676a15fa87e7fecb4ac22e15aaeb359ca498bc1b05ae7b0d4bb202eff3c849f4a2cfb5e7fde3af413c0a9937f2e0a63fcbb0f65fdca005ab5d83069133

data/app/models/ecom/core/attendance_sheet_entry.rb

@@ -4,6 +4,8 @@ module Ecom
       belongs_to :attendance_sheet
       belongs_to :crew
       has_many :crew_times
+
+      validates :total_hours, presence: true, numericality: { greater_than_or_equal_to: 0 }
     end
   end
 end

data/app/models/ecom/core/crew_overtime.rb

@@ -10,6 +10,10 @@ module Ecom
 
       validates :hours, :raw_hours, presence: true
       validate :validate_overtime_by_type
+      validates :hours, presence: true, numericality: { greater_than_or_equal_to: 0 }
+      validates :overtime_type_id,
+                uniqueness: { scope: :overtime_sheet_entry_id,
+                              message: 'There exists a crew overtime for the given overtime sheet and overtime type' }
 
       scope :by_overtime, lambda { |id|
         joins(:overtime_sheet_entry).where(ecom_core_overtime_sheet_entries: { overtime_sheet_id: id })
@@ -23,8 +27,11 @@ module Ecom
 
         start = Time.zone.parse(overtime_type.from)
         finish = Time.zone.parse(overtime_type.to)
-        diff = ((finish - start) / 3600).round
-
+        diff = if finish >= start
+                 ((finish - start) / 3600).round
+               else
+                 ((start - finish) / 3600).round
+               end
         return unless raw_hours > diff
 
         errors.add(:crew_overtime, 'The selected overtime type does not allow the specified amount of hours.')

data/app/models/ecom/core/crew_time.rb

@@ -13,6 +13,7 @@ module Ecom
 
       validates :checkin_time, presence: true, if: :checkout_time
       validate :time_range_validation, :total_time_validation
+      validates :hours, presence: true, numericality: { greater_than_or_equal_to: 0 }
 
       scope :by_attendance, lambda { |id|
         joins(:attendance_sheet_entry).where(ecom_core_attendance_sheet_entries: { attendance_sheet_id: id })
@@ -31,9 +32,13 @@ module Ecom
       def total_time_validation
         return if checkout_time.nil? || checkin_time.nil?
 
-        return unless attendance_sheet_entry.total_hours + compute_hours > 8
-
-        errors.add(:attendance_sheet_entry, 'has more than 8 hours')
+        if new_record? & !persisted?
+          if attendance_sheet_entry.total_hours + compute_hours > 8
+            errors.add(:attendance_sheet_entry, 'has more than 8 hours')
+          end
+        elsif attendance_sheet_entry.total_hours + compute_hours - computed_hour > 8
+          errors.add(:attendance_sheet_entry, 'has more than 8 hours')
+        end
       end
 
       def calculate_hours
@@ -109,6 +114,21 @@ module Ecom
         time -= 1 if day_part == FULL_DAY
         time
       end
+
+      # A similar method as `compute_hours` but this one computes hours for
+      # the the currently presisted checkin_time and checkout_time
+      def computed_hour
+        # Reparse time to avoid errors caused by date differences
+        range = define_range
+        start = Time.zone.parse(checkin_time_was.strftime('%I:%M%p'))
+        finish = Time.zone.parse(checkout_time_was.strftime('%I:%M%p'))
+        day_part = find_range(start, finish)
+        left = start.before?(range[day_part][:start]) ? range[day_part][:start] : start
+        right = finish.after?(range[day_part][:finish]) ? range[day_part][:finish] : finish
+        time = (right - left) / 1.hour
+        time -= 1 if day_part == FULL_DAY
+        time
+      end
     end
   end
 end

data/app/models/ecom/core/overtime_sheet_entry.rb

@@ -4,6 +4,8 @@ module Ecom
       belongs_to :overtime_sheet
       belongs_to :crew
       has_many :crew_overtimes
+
+      validates :total_overtime, presence: true, numericality: { greater_than_or_equal_to: 0 }
     end
   end
 end

data/app/models/ecom/core/payment_detail.rb

@@ -5,7 +5,7 @@ module Ecom
       belongs_to :payment
 
       validates :hours, :ot_hours, :base_salary, :overtime, :gross_salary, :tax, :pension, :net_salary, :net_pay,
-                :advance, presence: true
+                :advance, presence: true, numericality: { greater_than_or_equal_to: 0 }
     end
   end
 end

data/app/services/ecom/core/filter_service.rb

@@ -0,0 +1,19 @@
+module Ecom
+  module Core
+    class FilterService
+      def get_filtered_data(type, filters)
+        positive = {}
+        negative = {}
+        obj = type.constantize
+        filters.each { |f|
+          if f[:cond] == 'P'
+            positive[f[:key]] = f[:value]
+          else
+            negative[f[:key]] = f[:value]
+          end
+        }
+        obj.where(positive).where.not(negative)
+      end
+    end
+  end
+end

data/db/migrate/20200410111827_create_ecom_core_crew_overtimes.rb

@@ -23,5 +23,6 @@ class CreateEcomCoreCrewOvertimes < ActiveRecord::Migration[6.0]
 
       t.timestamps
     end
+    add_index :ecom_core_crew_overtimes, [:overtime_type_id, :overtime_sheet_entry_id],unique: true, name: 'ot_on_ose_name_indx'
   end
 end

data/db/migrate/20201013094100_create_ecom_core_crew_id_cards.rb

@@ -8,7 +8,7 @@ class CreateEcomCoreCrewIdCards < ActiveRecord::Migration[6.0]
 
       t.datetime :issued_on, null: false
       t.datetime :valid_until, null: false
-      t.string :status, null: false, default: 'Active'
+      t.string :status, null: false, default: 'Valid'
 
       t.timestamps
     end

data/lib/ecom/core/version.rb

@@ -1,5 +1,5 @@
 module Ecom
   module Core
-    VERSION = '1.3.5'.freeze
+    VERSION = '1.3.6'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ecom_core
 version: !ruby/object:Gem::Version
-  version: 1.3.5
+  version: 1.3.6
 platform: ruby
 authors:
 - Henock L.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-12-27 00:00:00.000000000 Z
+date: 2021-01-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aasm
@@ -375,6 +375,7 @@ files:
 - app/serializers/ecom/core/user_role_serializer.rb
 - app/serializers/ecom/core/user_serializer.rb
 - app/services/ecom/core/crew_contract_transaction_service.rb
+- app/services/ecom/core/filter_service.rb
 - app/services/ecom/core/menu_service.rb
 - app/services/ecom/core/site_crew_service.rb
 - app/services/ecom/core/token_auth_service.rb
@@ -571,7 +572,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Core engine for construction management application.