eco-helpers 3.0.19 → 3.0.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0f6637f51c2d892eb93c881cca7613fba034cbb00ff2676966172c2277f583ce
-  data.tar.gz: 68703625905aa5ed2c00223a628de16612714a2c2cdd69a1c0a284c8c6096332
+  metadata.gz: 96eaee3dd7897d77b22857cf8f812ce6d0639af324565c54f649c1e8068b7fb4
+  data.tar.gz: c9af686fe8f01d45eb3ea6a0dc89de276b789dfd6e3f64b515e17107b233b2d3
 SHA512:
-  metadata.gz: 89bbd57468fd7de3412240e3e44f61122aee9982896401494c4ee88c5e2dec97563e421cac2da0794c4f68ff90206422bc52b2868ee1e7ef3422fce50f3ec73d
-  data.tar.gz: 82703dafe2ccecf25994567926c80e7bd40fe0af70853cce664dbcbfc12b56b0b9ad72308ccf2789a386e053baadce2a8c29095130aa57dc560228d99c27267e
+  metadata.gz: 66bdc8b7c98b2aa0e60e205ac64b47a302e2cd8dbe1efd1720ad36c04a4f4c1a70b2cbb4d4978c67a17bd0f86893d34b47ff809f95a3e06952c002b872872553
+  data.tar.gz: f205d190dc159c0218bc1cafa52f139a6faaa133a01190ae1b189d2b8b6ef2470f49b634169effcf2021023803ec58f1793b8ce4c019db9d1dd025df7bbf5493

data/.gitignore

@@ -5,6 +5,7 @@ Gemfile.lock
 *.gem
 /.bundle
 /.vscode
+.solargraph.yml
 /vendor/bundle
 /spec/reports/
 /tmp/

data/CHANGELOG.md

@@ -2,7 +2,23 @@
 
 All notable changes to this project will be documented in this file.
 
-## [3.0.19] - 2024-10-xx
+## [3.0.20] - 2024-12-xx
+
+### Added
+
+- Mailer: to specify non-default `space` in the subject, when used.
+- `Eco::API::Common::Loaders::Config`
+  - Can call config with params
+- `Eco::API::Common::Loaders::Session`
+  - Which switches the configuration to that of the specific environment
+
+### Changed
+
+- On failure, `Eco::API::Session::Job#summary` to give precise estimates on what is pending to be run.
+
+### Fixed
+
+## [3.0.19] - 2024-11-21
 
 ### Added
 
@@ -21,8 +37,6 @@ All notable changes to this project will be documented in this file.
   - `ecoportal-api-v2`
   - `ecoportal-api-graphql`
 
-### Fixed
-
 ## [3.0.18] - 2024-10-28
 
 ### Changed

data/lib/eco/api/common/loaders/config/session.rb

@@ -0,0 +1,12 @@
+class Eco::API::Common::Loaders::Session < Eco::API::Common::Loaders::Config
+  class << self
+    # This is a config tied to the current environment session.
+    def config
+      return @config if instance_variable_defined?(:@config)
+
+      @config = super(key: super.apis.active_root_name)
+    end
+  end
+
+  delegate_missing_to :workflow
+end

data/lib/eco/api/common/loaders/config/workflow/mailer.rb

@@ -18,9 +18,8 @@ class Eco::API::Common::Loaders::Workflow::Mailer < Eco::API::Common::Loaders::W
       next if     session.config.dry_run?
       next unless session.config.run_mode_remote?
 
-      # temporary contingency
-      maybe_error_pages_or_tree_updates = other_case?(io) && error?
-      next unless some_update?(io) || maybe_error_pages_or_tree_updates
+      # temporary contingency: maybe_error_or_tree_updates?
+      next unless some_update?(io) || maybe_error_pages_or_tree_updates?(io)
 
       subject = base_subject
 
@@ -47,7 +46,15 @@ class Eco::API::Common::Loaders::Workflow::Mailer < Eco::API::Common::Loaders::W
     end
 
     def base_subject
-      "#{org_name} (#{active_enviro}) at #{Time.now.iso8601}"
+      "#{org_name} (#{active_enviro_desc}) at #{Time.now.iso8601}"
+    end
+
+    def active_enviro_desc
+      space_desc = config.active_enviro_space.to_s.strip
+      space_desc = ''                          if space_desc == 'default'
+      space_desc = " - space: '#{space_desc}'" unless space_desc.empty?
+
+      "#{active_enviro}#{space_desc}"
     end
 
     def some_update?(io)
@@ -66,6 +73,11 @@ class Eco::API::Common::Loaders::Workflow::Mailer < Eco::API::Common::Loaders::W
       !!error
     end
 
+    # @note at some stage, tree cases should have their own case type
+    def maybe_error_pages_or_tree_updates?(io)
+      other_case?(io) && error?
+    end
+
     def errors_n_warnings(io)
       [error_message, log_err_n_warn(io)].join("\n")
     end
@@ -73,6 +85,7 @@ class Eco::API::Common::Loaders::Workflow::Mailer < Eco::API::Common::Loaders::W
     def log_err_n_warn(io)
       warn_errors = io.logger.cache.logs(level: %i[error warn])
       return if warn_errors.empty?
+
       "ALL WARNINGS & ERRORS:\n#{warn_errors.join}\n"
     end
 

data/lib/eco/api/common/loaders/config.rb

@@ -1,17 +1,24 @@
 class Eco::API::Common::Loaders::Config
   extend Eco::API::Common::ClassHelpers
   extend Eco::Language::Methods::DelegateMissing
+
   inheritable_class_vars :delegate_missing_to
 
   class << self
     # To create samples of configurations
     def config_block(&block)
       return @config_block unless block_given?
+
+      unless @config_block.nil?
+        msg = "Reconfiguring config_block on #{self}"
+        session.log(:warn) { msg }
+      end
+
       @config_block = block
     end
 
-    def config
-      ASSETS.config
+    def config(...)
+      ASSETS.config(...)
     end
 
     def cli
@@ -27,3 +34,4 @@ class Eco::API::Common::Loaders::Config
 end
 
 require_relative 'config/workflow'
+require_relative 'config/session'

data/lib/eco/api/common/session/sftp.rb

@@ -8,6 +8,7 @@ module Eco
           def initialize(enviro:)
             invalid_env = enviro && !enviro.is_a?(Eco::API::Common::Session::Environment)
             raise "Required Environment object (enviro:). Given: #{enviro}" if invalid_env
+
             @enviro = enviro
           end
 
@@ -103,6 +104,7 @@ module Eco
           def download(files, local_folder: nil, &block)
             puts "Creating local files:"
             created_files = []
+
             [files].flatten.compact.map do |fullname|
               basename = windows_basename(fullname)
               dest_fullname = File.join(local_folder || ".", basename)
@@ -110,6 +112,7 @@ module Eco
               created_files << dest_fullname
               sftp_session.download(fullname, dest_fullname)
             end.each(&:wait)
+
             # run SSH event loop while dw.active?
             created_files.tap { created_files.each(&block) }
           end
@@ -155,9 +158,11 @@ module Eco
           def windows_basename(remote_fullname)
             dir_sep = /[\\\/]/
             patr_re = /[<>:\\\/|?*]/
+
             parts   = remote_fullname.split(dir_sep).map do |node|
               node.gsub(patr_re, '_')
             end
+
             local_fullname = File.join(*parts)
             File.basename(local_fullname)
           end

data/lib/eco/api/custom/mailer.rb

@@ -5,5 +5,6 @@
 #  end
 class Eco::API::Custom::Mailer < Eco::API::Common::Loaders::Workflow::Mailer
   extend Eco::Language::Klass::WhenInherited
+
   when_inherited(&config_block)
 end

data/lib/eco/api/error.rb

@@ -96,9 +96,11 @@ module Eco
           end.sort do |k_1, k_2|
             next -1 if k_2 < k_1
             next  1 if k_1 < k_2
+
             0
           end.tap do |siblings|
             siblings.delete(Unclassified)
+
             if direct
               siblings.reject! do |si|
                 siblings.any? {|s| si < s}
@@ -120,8 +122,10 @@ module Eco
 
           descendants(direct: true).reverse.each do |klass|
             next unless klass.err_match?(err_msg)
+
             type = klass
             next unless klass.descendants?(direct: true)
+
             type = klass.get_type(err_msg, first: false) || type
           end
 

data/lib/eco/api/session/batch/job.rb

@@ -217,6 +217,7 @@ module Eco
             elsif !pqueue.empty?
               req_backup = as_update(pqueue, add_feedback: false)
               backup_update(req_backup)
+
               log(:debug) {
                 "Job ('#{name}':#{type}): going to launch batch against #{pqueue.count} entries"
               }
@@ -246,28 +247,25 @@ module Eco
           #   3. error messages in case they were errors from the server
           # @note if `launch` was not invoked, it specifies so
           # @return [String] the summary
-          def summary # rubocop:disable Metrics/AbcSize
+          def summary
             [].tap do |msg|
-              if pending?
-                msg << "PENDING - Batch #{type.to_s.upcase} - job '#{name}' - length: #{@queue.length}"
-              else
-                msg << feedback.generate(requests, only_stats: true)
+              msg << "PENDING Job -------->\n" if pending?
+              msg << feedback.generate(requests, only_stats: true)
 
-                if batch_policy && !batch_policy.compliant?(request_stats)
-                  msg << "Batch Policy Uncompliance:"
-                  msg << batch_policy.uncompliance(request_stats)
-                end
-
-                msg << status.errors.message if status
-                msg << subjobs_summary
+              if batch_policy && !batch_policy.compliant?(request_stats)
+                msg << 'Batch Policy Uncompliance:'
+                msg << batch_policy.uncompliance(request_stats)
               end
+
+              msg << status.errors.message if status
+              msg << subjobs_summary
             end.join("\n")
           end
 
           private
 
           def subjobs_summary
-            return "" unless subjobs.count.positive?
+            return '' unless subjobs.count.positive?
 
             [].tap do |msg|
               subjobs.map {|subjob| msg << subjob.summary}
@@ -431,7 +429,7 @@ module Eco
               next unless status.success?(entry)
 
               if type == :create && entry.respond_to?(:id=)
-                entry.id = status[entry].body["id"].tap do |id|
+                entry.id = status[entry].body['id'].tap do |id|
                   next unless id.to_s.strip.empty?
 
                   ref = Eco::API::Session::Batch::Feedback.person_ref(entry)
@@ -503,9 +501,9 @@ module Eco
 
           # Keep a copy of the requests for future reference
           def backup_update(requests, simulate: false)
-            dry_run   = simulate ? "_dry_run" : ""
+            dry_run   = simulate ? '_dry_run' : ''
             dir       = config.people.requests_folder
-            filename  = name.split(" ").join("-").gsub(/[=\\\/><,"-]+/, "_") # rubocop:disable Style/RedundantArgument
+            filename  = name.split(' ').join('-').gsub(/[=\\\/><,"-]+/, "_") # rubocop:disable Style/RedundantArgument
             file      = File.join(dir, "#{type}_data_#{filename}#{dry_run}.json")
             file_manager.save_json(requests, file, :timestamp)
           end

data/lib/eco/api/session/batch/jobs.rb

@@ -81,7 +81,7 @@ module Eco
           end
 
           def pending?
-            any? {|job| job.pending?}
+            any?(&:pending?)
           end
 
           # Launches every `Batch::Job` in the group.
@@ -108,19 +108,17 @@ module Eco
             end
           end
 
-          def status
+          def status(&block)
             if block_given?
-              status.each do |job, job_status|
-                yield(job, job_status)
-              end
+              status.each(&block)
               self
-            else # rubocop:disable Naming/MemoizedInstanceVariableName
-              @jobs_status ||= {}
+            else
+              @jobs_status ||= {} # rubocop:disable Naming/MemoizedInstanceVariableName
             end
           end
 
           def errors?
-            any? {|job| job.errors?}
+            any?(&:errors?)
           end
 
           def summary

data/lib/eco/api/session/batch/launcher/mode_size.rb

@@ -18,14 +18,17 @@ module Eco
             private
 
             # Swaps to batch endpoint on specific errors
-            def batch_mode_on(*error_types, options: self.options, allow_job_mode: true, &block)
+            def batch_mode_on(*error_types, options: self.options, allow_job_mode: true)
+              msg = "Expecting block. Non given"
+              raise ArgumentError, msg unless block_given?
+
               in_job_mode = allow_job_mode && job_mode?(options)
 
               yield(in_job_mode, batch_size(options))
             rescue *error_types
               raise unless in_job_mode
 
-              yield(false , batch_mode_size)
+              yield(false, batch_mode_size)
             end
 
             # MODE

data/lib/eco/api/session/batch/launcher/retry.rb

@@ -25,7 +25,12 @@ module Eco
               explanation << "You have #{retries_left} retries left."
               question    = " Do you want to retry (y/N)?"
 
-              prompt_user(question, default: "Y", explanation: explanation, timeout: 10) do |response|
+              prompt_user(
+                question,
+                default:     "Y",
+                explanation: explanation,
+                timeout:     10
+              ) do |response|
                 raise unless response.upcase.start_with?("Y")
 
                 puts "\nOkay... let's retry!"

data/lib/eco/api/session/config/api.rb

@@ -135,6 +135,7 @@ module Eco
             self.class.description(self)
           end
 
+          # @todo: deletage to `apis.one_off?`
           def one_off?
             name.is_a?(Symbol)
           end

data/lib/eco/api/session/config/apis/one_off.rb

@@ -4,14 +4,14 @@ module Eco
       class Config
         class Apis
           module OneOff
-            private
-
             def one_off?
-              @is_one_off ||=
+              @is_one_off ||= # rubocop:disable Naming/MemoizedInstanceVariableName
                 SCR.get_arg('-api-key') ||
                 SCR.get_arg('-one-off')
             end
 
+            private
+
             def one_off_key
               return @one_off_key if instance_variable_defined?(:@one_off_key)
 
@@ -48,10 +48,10 @@ module Eco
               return @one_off_org if instance_variable_defined?(:@one_off_org)
 
               msg = "You should specify -org NAME when using -api-key or -one-off"
-              raise msg unless org = SCR.get_arg('-org', with_param: true)
+              raise msg unless (org = SCR.get_arg('-org', with_param: true))
 
               str_org = "#{org.downcase.split(/[^a-z]+/).join('_')}_#{one_off_enviro.gsub('.', '_')}"
-              @one_off_org  ||= str_org.to_sym
+              @one_off_org ||= str_org.to_sym
             end
 
             def one_off_enviro
@@ -83,7 +83,7 @@ module Eco
 
               true
             rescue StandardError => err
-              puts "#{err}"
+              puts err.to_s
               false
             end
           end

data/lib/eco/api/session/config/workflow.rb

@@ -141,7 +141,8 @@ module Eco
           # @yieldreturn [Eco::API::UseCases::BaseIO] the `io` input/output object carried througout all the _workflow_
           # @return [Eco::API::Session::Config::Workflow] the current stage object (to ease chainig).
           def rescue(&block)
-            return @rescue unless block
+            return @rescue unless block_given?
+
             @rescue = block
             self
           end
@@ -150,7 +151,8 @@ module Eco
 
           # Called on `SystemExit` exception
           def exit_handle(&block)
-            return @exit_handle unless block
+            return @exit_handle unless block_given?
+
             @exit_handle = block
             self
           end
@@ -171,6 +173,7 @@ module Eco
           # @return [Eco::API::Session::Config::Workflow] the current stage object (to ease chainig).
           def before(key = nil, &block)
             raise ArgumentError, "A block should be given." unless block_given?
+
             if key
               stage(key).before(&block)
             else
@@ -195,6 +198,7 @@ module Eco
           # @return [Eco::API::Session::Config::Workflow] the current stage object (to ease chainig).
           def after(key = nil, &block)
             raise ArgumentError, "A block should be given." unless block_given?
+
             if key
               stage(key).after(&block)
             else
@@ -267,6 +271,7 @@ module Eco
                 io.evaluate(self, io, &c)
               end
             end
+
             io
           end
 
@@ -276,6 +281,7 @@ module Eco
                 io.evaluate(self, io, &c)
               end
             end
+
             io
           end
 
@@ -305,6 +311,7 @@ module Eco
                 io.evaluate(self, io, &@on)
               end
             end
+
             io
           ensure
             @pending = false
@@ -341,7 +348,11 @@ module Eco
 
           def stage(key)
             self.class.validate_stage(key)
-            @stages[key] ||= self.class.workflow_class(key).new(key, _parent: self, config: config)
+            @stages[key] ||= self.class.workflow_class(key).new(
+              key,
+              _parent: self,
+              config:  config
+            )
           end
 
           # helper to treat trigger the exit and rescue handlers
@@ -354,6 +365,7 @@ module Eco
             io = io_result(io: io) do
               io.evaluate(err, io, &exit_handle)
             end
+
             exit err.status
           rescue Interrupt => _int
             raise
@@ -362,6 +374,7 @@ module Eco
             io = io_result(io: io) do
               io.evaluate(err, io, &self.rescue)
             end
+
             raise
           end
         end

data/lib/eco/api/session.rb

@@ -70,6 +70,7 @@ module Eco
       )
         if live && api?(version: :graphql)
           return live_tree(include_archived: include_archived, **kargs, &block) unless merge
+
           live_trees(include_archived: include_archived, **kargs, &block).inject(&:merge)
         else
           config.tagtree(recache: recache)
@@ -118,10 +119,12 @@ module Eco
       # @return [Eco::Data::Mapper] the mappings between the internal and external attribute/property names.
       def fields_mapper
         return @fields_mapper if instance_variable_defined?(:@fields_mapper)
+
         mappings = []
         if (map_file = config.people.fields_mapper)
           mappings = map_file ? file_manager.load_json(map_file) : []
         end
+
         @fields_mapper = Eco::Data::Mapper.new(mappings)
       end
 
@@ -166,9 +169,9 @@ module Eco
       # @param phase [Symbol] the phase when this parser should be active.
       # @return [Object] the parsed attribute.
       def parse_attribute(attr, source, phase = :internal, deps: {})
-        unless (parsers = entry_factory.person_parser)
-          raise "There are no parsers defined"
-        end
+        msg = "There are no parsers defined"
+        raise msg unless (parsers = entry_factory.person_parser)
+
         parsers.parse(attr, source, phase, deps: deps)
       end
 
@@ -390,18 +393,19 @@ module Eco
 
       # from schema `id` or `name` to a PersonSchema object
       def to_schema(value)
-        return nil unless value
         sch = nil
+        return unless value
+
         case value
         when String
-          unless (sch = schemas.schema(value))
-            fatal "The schema with id or name '#{value}' does not exist."
-          end
+          msg = "The schema with id or name '#{value}' does not exist."
+          fatal msg unless (sch = schemas.schema(value))
         when Ecoportal::API::V1::PersonSchema
           sch = value
         else
           fatal "Required String or Ecoportal::API::V1::PersonSchema. Given: #{value}"
         end
+
         sch
       end
     end

data/lib/eco/api/usecases/default/locations/tagtree_extract_case.rb

@@ -195,6 +195,7 @@ class Eco::API::UseCases::Default::Locations::TagtreeExtract < Eco::API::UseCase
 
   def excel(filename)
     require 'fast_excel'
+
     FastExcel.open(filename, constant_memory: true).tap do |workbook|
       yield(workbook)
       workbook.close

data/lib/eco/api/usecases/default/locations/tagtree_upload_case.rb

@@ -27,6 +27,7 @@ class Eco::API::UseCases::Default::Locations::TagtreeUpload < Eco::API::UseCases
         comms << insert_command(tree, pid: pid) unless top_id?(tree.id)
         pid    = tree.id
       end
+
       tree.nodes.map do |node|
         insert_commands(node, pid: pid)
       end.flatten(1).tap do |subs|
@@ -54,6 +55,7 @@ class Eco::API::UseCases::Default::Locations::TagtreeUpload < Eco::API::UseCases
 
   def top_id?(node_id = nil)
     return top_id.is_a?(String) if node_id.nil?
+
     node_id == top_id
   end
 

data/lib/eco/api/usecases/default_cases/samples/sftp_case.rb

@@ -7,7 +7,7 @@ class Eco::API::UseCases::DefaultCases::Samples::Sftp < Eco::API::Common::Loader
   name "sftp"
   type :other
 
-  CONST_REFERRAL = /^(?:::)?(?:[A-Z][a-zA-Z0-9_]*(?:::[A-Z][a-zA-Z0-9_]*)*)$/.freeze
+  CONST_REFERRAL = /^(?:::)?(?:[A-Z][a-zA-Z0-9_]*(?:::[A-Z][a-zA-Z0-9_]*)*)$/
 
   def main(session, options, _usecase)
     options[:end_get] = false
@@ -31,7 +31,7 @@ class Eco::API::UseCases::DefaultCases::Samples::Sftp < Eco::API::Common::Loader
   def file_pattern(require: true)
     fpc = file_pattern_const
     return fpc if fpc
-    return unless require
+    return     unless require
 
     msg  = "(#{self.class}) You should redefine the file_pattern function "
     msg << "as a RegEx expression that matches the target remote file"
@@ -41,6 +41,7 @@ class Eco::API::UseCases::DefaultCases::Samples::Sftp < Eco::API::Common::Loader
   def file_pattern_const
     if (fpc = options.dig(:sftp, :file_pattern_const))
       raise WrongConst, "(#{self.class}) Invalid file pattern const referral: #{fpc}" unless fpc.match(CONST_REFERRAL)
+
       begin
         self.eval(fpc)
       rescue NameError
@@ -54,6 +55,7 @@ class Eco::API::UseCases::DefaultCases::Samples::Sftp < Eco::API::Common::Loader
   # Ex: "/IN/Personnel"
   def remote_subfolder(require: true)
     rm_sf = options.dig(:sftp, :remote_subfolder)
+
     return rm_sf if rm_sf
     return unless require
 
@@ -78,7 +80,7 @@ class Eco::API::UseCases::DefaultCases::Samples::Sftp < Eco::API::Common::Loader
     options.dig(:sftp, :local_folder) || "."
   end
 
-  def with_remote_files(folder: self.remote_folder, pattern: self.file_pattern)
+  def with_remote_files(folder: remote_folder, pattern: file_pattern)
     sftp.files(folder, pattern: pattern).each do |remote_file|
       yield(remote_file) if block_given?
     end
@@ -100,22 +102,25 @@ class Eco::API::UseCases::DefaultCases::Samples::Sftp < Eco::API::Common::Loader
 
   def get_files
     with_remote_files.tap do |files|
-      unless files.empty?
-        file_names = files.map {|file| to_remote_path(file.name)}
-        puts "Getting the following files into the local folder '#{local_folder}':"
-        puts file_names
-        sftp.download(file_names, local_folder: local_folder)
-      end
+      next if files.empty?
+
+      file_names = files.map {|file| to_remote_path(file.name)}
+
+      puts "Getting the following files into the local folder '#{local_folder}':"
+      puts file_names
+
+      sftp.download(file_names, local_folder: local_folder)
     end
   end
 
   def get_last
     with_remote_files.last.tap do |file|
-      if file
-        file_name = to_remote_path(file.name)
-        puts "Getting the following file: #{file_name}"
-        sftp.download(file_name, local_folder: local_folder)
-      end
+      next unless file
+
+      file_name = to_remote_path(file.name)
+      puts "Getting the following file: #{file_name}"
+
+      sftp.download(file_name, local_folder: local_folder)
     end
   end
 
@@ -125,7 +130,9 @@ class Eco::API::UseCases::DefaultCases::Samples::Sftp < Eco::API::Common::Loader
       dest   = to_remote_path("#{archive_subfolder}/#{file.name}")
       move_file(source, dest)
     end.tap do |files|
-      puts "Moved the file(s) to the #{archive_subfolder} folder" unless files.empty?
+      next if files.empty?
+
+      puts "Moved the file(s) to the #{archive_subfolder} folder"
     end
   end
 

data/lib/eco/api/usecases/ooze_cases/export_register_case.rb

@@ -40,7 +40,7 @@ class Eco::API::UseCases::OozeCases::ExportRegisterCase < Eco::API::UseCases::Oo
 
   def build_tags_filter(mode = :any)
     tags = option_tags(mode)
-    return nil if !tags || tags.empty?
+    return if !tags || tags.empty?
 
     tags_filter(tags, any: mode == :any)
   end
@@ -48,7 +48,7 @@ class Eco::API::UseCases::OozeCases::ExportRegisterCase < Eco::API::UseCases::Oo
   def build_range_filter(key = :update_at)
     from = from_date(key)
     to   = to_date(key)
-    return nil unless from || to
+    return unless from || to
 
     date_range_filter(from: from, to: to, key: key)
   end
@@ -92,10 +92,10 @@ class Eco::API::UseCases::OozeCases::ExportRegisterCase < Eco::API::UseCases::Oo
 
   def filename
     @filename ||= (options[:file] || options.dig(:export, :file, :name)).tap do |filename|
-      unless filename
-        log(:error) { "Destination file not specified" }
-        return false
-      end
+      next if filename
+
+      log(:error) { "Destination file not specified" }
+      return false
     end
   end
 end

data/lib/eco/api/usecases/ooze_samples/helpers/exportable_register.rb

@@ -48,6 +48,7 @@ module Eco
 
             def header(refresh: false)
               return @header if instance_variable_defined?(:@header) && !refresh
+
               @header = typed_header.map do |name|
                 ExportableOoze.key_to_label(name)
               end

data/lib/eco/api/usecases/ooze_samples/ooze_base_case.rb

@@ -234,7 +234,7 @@ class Eco::API::UseCases::OozeSamples::OozeBaseCase < Eco::API::Common::Loaders:
 
   def dry_count
     @dry_count ||= 0
-    @dry_count += 1
+    @dry_count  += 1
   end
 
   def dry_run_feedback(entry = target)

data/lib/eco/api/usecases/ooze_samples/ooze_run_base_case.rb

@@ -3,17 +3,19 @@ class Eco::API::UseCases::OozeSamples::OozeRunBaseCase < Eco::API::UseCases::Ooz
   name "ooze-run-base"
   type :other
 
-  SAVE_PATCH = "ooze_patch_update.json"
+  SAVE_PATCH = "ooze_patch_update.json".freeze
 
   def main(session, options, usecase)
     super(session, options, usecase) do
-      if method(:process_ooze).parameters.count == 0
+      if method(:process_ooze).parameters.count.zero?
         ooze # retrieve ooze
         process_ooze
       else
         process_ooze(ooze)
       end
+
       yield(target) if block_given?
+
       exit_if_no_changes!
       update_ooze(target)
     end
@@ -30,7 +32,7 @@ class Eco::API::UseCases::OozeSamples::OozeRunBaseCase < Eco::API::UseCases::Ooz
   end
 
   def stage(stage_id_name = stage_id, ooze: target)
-    super(stage_id_name, ooze: ooze)
+    super
   end
 
   def ooze_id
@@ -43,11 +45,12 @@ class Eco::API::UseCases::OozeSamples::OozeRunBaseCase < Eco::API::UseCases::Ooz
 
   def update_ooze(ooz = target)
     prompt_to_confirm!
-    super(ooz)
+
+    super
   end
 
   def exit_if_no_changes!
-    return if (changes = !!patch_doc["page"])
+    return if !!patch_doc["page"]
 
     log(:info) { "No Changes!!" }
     exit(0)

data/lib/eco/cli_default/workflow.rb

@@ -1,12 +1,14 @@
 ASSETS.cli do |cli| # rubocop:disable Metrics/BlockLength
   ASSETS.config.workflow do |wf| # rubocop:disable Metrics/BlockLength
     rescued = false
+
     # default rescue
     wf.rescue do |err, io|
       next io if rescued
 
       rescued = true
       log(:debug) { err.patch_full_message }
+
       wf.run(:close, io: io)
     rescue StandardError => e
       puts "Some problem in workflow.rescue: #{e}"
@@ -74,10 +76,10 @@ ASSETS.cli do |cli| # rubocop:disable Metrics/BlockLength
     end
 
     wf.on(:usecases) do |_wf_ca, io|
-      unless cli.config.usecases.process(io: io)
-        log(:info) { "No update operation specified... quitting" }
-        exit 0
-      end
+      next if cli.config.usecases.process(io: io)
+
+      log(:info) { "No update operation specified... quitting" }
+      exit 0
     end
 
     wf.before(:launch_jobs) do |_wf_jobs, _io|
@@ -95,11 +97,13 @@ ASSETS.cli do |cli| # rubocop:disable Metrics/BlockLength
       run_it = !options[:dry_run] || options.dig(:post_launch, :run)
       unless run_it
         wf_post.skip!
+
         log(:info) {
           msg  = "Although there are post_launch cases, they will NOT be RUN"
           msg << ", because we are in dry-run (simulate)." if options[:dry_run]
           msg
         }
+
         next
       end
 
@@ -117,6 +121,7 @@ ASSETS.cli do |cli| # rubocop:disable Metrics/BlockLength
           end
           msg
         }
+
         next
       end
 
@@ -131,6 +136,7 @@ ASSETS.cli do |cli| # rubocop:disable Metrics/BlockLength
           use.launch(io: io).base
         rescue Eco::API::UseCases::BaseIO::MissingParameter => e
           raise unless e.required == :people
+
           log(:debug) {
             "Skipping use case '#{use.name}' -- no base people detected for the current run"
           }

data/lib/eco/csv/stream.rb

@@ -7,6 +7,7 @@ module Eco
 
       def initialize(filename, **kargs)
         raise ArgumentError, "File '#{filename}' does not exist" unless ::File.exist?(filename)
+
         @filename = filename
         @params   = {
           headers:     true,
@@ -55,6 +56,7 @@ module Eco
       # see https://dalibornasevic.com/posts/68-processing-large-csv-files-with-ruby
       def csv
         return @csv if instance_variable_defined?(:@csv)
+
         @fd  = ::File.open(filename, 'r')
         @csv = Eco::CSV.new(fd, **params)
       end

data/lib/eco/csv.rb

@@ -5,9 +5,9 @@ module Eco
       include Eco::Data::Files
 
       # @return [Eco::CSV::Table]
-      def parse(data, **kargs, &block)
+      def parse(data, **kargs)
         kargs = {headers: true, skip_blanks: true}.merge(kargs)
-        Eco::CSV::Table.new(super(data, **kargs, &block))
+        Eco::CSV::Table.new(super)
       end
 
       # @return [Eco::CSV::Table]
@@ -51,6 +51,7 @@ module Eco
           included = yield(row) if block_given?
           count += 1            if included
         end
+
         count
       end
     end

data/lib/eco/language/methods/delegate_missing.rb

@@ -7,7 +7,7 @@ module Eco
         end
 
         def method_missing(method_name, *args, **kargs, &block)
-          super unless receiver = object_missing_delegated_to
+          super unless (receiver = object_missing_delegated_to)
           receiver.send(method_name, *args, **kargs, &block)
         end
 
@@ -19,8 +19,9 @@ module Eco
 
         # retrieve the delegate_missing_to object
         def object_missing_delegated_to
-          return nil unless @delegate_missing_to
-          self.method(@delegate_missing_to).call
+          return unless @delegate_missing_to
+
+          method(@delegate_missing_to).call
         end
       end
     end

data/lib/eco/version.rb

@@ -1,3 +1,3 @@
 module Eco
-  VERSION = '3.0.19'.freeze
+  VERSION = '3.0.20'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eco-helpers
 version: !ruby/object:Gem::Version
-  version: 3.0.19
+  version: 3.0.20
 platform: ruby
 authors:
 - Oscar Segura
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-11-20 00:00:00.000000000 Z
+date: 2024-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -538,6 +538,7 @@ files:
 - lib/eco/api/common/loaders/base.rb
 - lib/eco/api/common/loaders/case_base.rb
 - lib/eco/api/common/loaders/config.rb
+- lib/eco/api/common/loaders/config/session.rb
 - lib/eco/api/common/loaders/config/workflow.rb
 - lib/eco/api/common/loaders/config/workflow/mailer.rb
 - lib/eco/api/common/loaders/error_handler.rb