eco-helpers 2.7.2 → 2.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 80de08cdef4ada108f4853214720d30985461e43309b9d442932975e7400bf20
-  data.tar.gz: c9174f97cd87f2c092f3ec892397fa53711a7efd61d8bbd456b3e68d62d8cf03
+  metadata.gz: f5417454380ab9a37757721abd2b66a9097eac191ae435336fb436caeabfac49
+  data.tar.gz: fe83f4f50b5053050f8ff15dd43c224130a8e0bb7ece5e44aaa8e91f20c7ab77
 SHA512:
-  metadata.gz: dfc1092476a865d1902eaf1d241b27f4a141b72d287524f41107d13b9e447a1a83d04f278e1a04046e1435b7ce5b919e597a030c7c4eb8ccadb9431e90ace039
-  data.tar.gz: 4bf36063e2b8eca6051343a9b18ecbe61ac3e04c1789be8dc269d59f36c444690475ff0fdf42113ca74e035a41bef0d12e6d574a9845966ebbb73d4b303ef47d
+  metadata.gz: 8576cbd86fadc000127e2f83396e5cbf2d4b7196150fe3a7ff78c3ce987850ebe73758622678492811350434981cfa1962796dc847b39475e80b8ef61e09c6da
+  data.tar.gz: c6517c924dee344f9445e7213c404f7295f45ff9c41ff45b2fbad437becfd2ea8aaadc95b82b2e0189e0ade9bef299826f56910704a16954a59c0a91930133bb

data/CHANGELOG.md

@@ -1,14 +1,34 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
-## [2.7.2] - 2024-04-xx
+## [2.7.5] - 2024-05-xx
 
 ### Added
-  - **Parsers**
-    - Native **number parser**, added _warning_ when number cannot be parsed
+### Changed
+### Fixed
+  - Loading of tree diff / update service
+
+## [2.7.4] - 2024-05-07
+
+### Fixed
+  - Loading of tree diff / update service
+
+## [2.7.3] - 2024-05-07
 
 ### Changed
+  - upgraded `ecoportal-api-graphql`
+  - Mailer
+    - heading of errors and warnings: added **ALL** to state clearly that all warnings and errors come thereon
+  - Batch Errors: removed _batch_ wording, as it refers to a single action in the batch
+
 ### Fixed
+  - Tree diff helpers loading (load as if concern)
+
+## [2.7.2] - 2024-04-23
+
+### Added
+  - **Parsers**
+    - Native **number parser**, added _warning_ when number cannot be parsed
 
 ## [2.7.1] - 2024-04-23
 

data/eco-helpers.gemspec

@@ -32,7 +32,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'ecoportal-api',         '>= 0.9.7', '< 0.10'
   spec.add_dependency 'ecoportal-api-v2',      '>= 1.1.8', '< 1.2'
-  spec.add_dependency 'ecoportal-api-graphql', '>= 0.3.15', '< 0.4'
+  spec.add_dependency 'ecoportal-api-graphql', '>= 0.3.16', '< 0.4'
   spec.add_dependency 'aws-sdk-s3',    '>= 1.142.0', '< 2'
   spec.add_dependency 'aws-sdk-ses',   '>= 1.58.0', '< 2'
   spec.add_dependency 'dotenv',        '>= 2.8.1',  '< 3'

data/lib/eco/api/common/loaders/base.rb

@@ -54,9 +54,10 @@ module Eco
           end
 
           def abort(msg, raising: true)
-            logger.error(msg)
-            raise msg if raising
-            exit 1
+            log(:error) { msg }
+            exit(1) unless raising
+
+            raise msg
           end
         end
       end

data/lib/eco/api/common/loaders/config/workflow/mailer.rb

@@ -48,7 +48,7 @@ class Eco::API::Common::Loaders::Workflow::Mailer < Eco::API::Common::Loaders::W
     end
 
     def some_update?(io)
-      cli.config.usecases.active(io: io).any? do |usecase, data|
+      cli.config.usecases.active(io: io).any? do |usecase, _data|
         %i[transform sync].any? { |type| usecase.type == type }
       end
     end
@@ -64,7 +64,7 @@ class Eco::API::Common::Loaders::Workflow::Mailer < Eco::API::Common::Loaders::W
     def log_err_n_warn(io)
       warn_errors = io.logger.cache.logs(level: %i[error warn])
       return if warn_errors.empty?
-      "WARNINGS & ERRORS:\n#{warn_errors.join('')}\n"
+      "ALL WARNINGS & ERRORS:\n#{warn_errors.join}\n"
     end
 
     def error_message

data/lib/eco/api/common/loaders/parser.rb

@@ -15,6 +15,7 @@ module Eco
 
             def missing(*input_attrs)
               return [] if input_attrs.include?(attr)
+
               match = input_attrs & attrs
               miss  = attrs - match
               return []    if miss.empty?

data/lib/eco/api/common/people/default_parsers/csv_parser.rb

@@ -14,7 +14,7 @@ class Eco::API::Common::People::DefaultParsers::CSVParser < Eco::API::Common::Lo
     end
   end
 
-  def serializer(array_hash, deps)
+  def serializer(array_hash, _deps)
     arr_rows = []
     unless array_hash.empty?
       header = array_hash.first.keys
@@ -27,19 +27,22 @@ class Eco::API::Common::People::DefaultParsers::CSVParser < Eco::API::Common::Lo
 
   private
 
-  def abort(message)
-    logger.error(message)
-    exit(1)
+  def abort(msg)
+    super(msg, raising: false)
   end
 
   def require_headers!(table)
     headers = table.headers
-    abort("Missing headers in CSV") unless headers && !headers.empty?
+
+    abort("Missing headers in CSV") unless headers&.any?
+
     empty = []
     headers.each_with_index do |header, idx|
       empty << idx if header.to_s.strip.empty?
     end
-    abort("Empty headers in column(s): #{empty.join(', ')}") unless empty.empty?
+
+    abort("Empty headers in column(s): #{empty.join(', ')}") if empty.any?
+
     true
   end
 
@@ -58,12 +61,13 @@ class Eco::API::Common::People::DefaultParsers::CSVParser < Eco::API::Common::Lo
   end
 
   def null?(value)
-    return true if !value
+    return true unless value
+
     str = value.strip.upcase
     ["NULL"].any? {|token| str == token}
   end
 
-  def check_headers(table)
+  def check_headers(table) # rubocop:disable Metrics/AbcSize
     headers  = table.headers
     unmatch  = []
     unmatch  = unmatched_headers(headers) if options.dig(:input, :header_check, :order)
@@ -72,7 +76,7 @@ class Eco::API::Common::People::DefaultParsers::CSVParser < Eco::API::Common::Lo
     criteria = [unknown, missing[:direct], missing[:indirect], unmatch]
     return if criteria.all?(&:empty?)
 
-    msg  = "Detected possible HEADER ISSUES !!!\n"
+    msg = "Detected possible HEADER ISSUES !!!\n"
 
     # requires exact match
     unless unmatch.empty?
@@ -86,9 +90,11 @@ class Eco::API::Common::People::DefaultParsers::CSVParser < Eco::API::Common::Lo
         msg << "    - #{missed.join("\n    - ")}\n"
       end
     end
+
     msg << "Missing or Wrong HEADER names in the CSV file:\n"
     msg << "  * UNKNOWN (or not used?): #{unknown}\n" unless unknown.empty?
     msg << "  * MISSING HEADER: #{missing[:direct]}\n" unless missing[:direct].empty?
+
     unless (data = missing[:indirect]).empty?
       msg << "  * MISSING INDIRECTLY:\n"
       data.each do |ext, info|
@@ -99,13 +105,16 @@ class Eco::API::Common::People::DefaultParsers::CSVParser < Eco::API::Common::Lo
           elsif status == :active
             "there could be missing info in: #{attrs}"
           end
-        end.compact.join("; ") + "\n"
+        end.compact.join("; ")
+        msg << "\n"
       end
     end
-    logger.warn(msg)
-    if options.dig(:input, :header_check, :must_be_valid)
-      abort("There were issues identified on the CSV header names. Aborting...")
-    end
+
+    log(:warn) { msg }
+
+    msg = "There were issues identified on the CSV header names. Aborting..."
+    abort(msg) if options.dig(:input, :header_check, :must_be_valid)
+
     sleep(2)
   end
 
@@ -119,13 +128,14 @@ class Eco::API::Common::People::DefaultParsers::CSVParser < Eco::API::Common::Lo
     (headers - known_headers) - all_internal_attrs
   end
 
-  def missing_headers(headers)
+  def missing_headers(headers) # rubocop:disable Metrics/AbcSize
     int_head = internal_present_or_active(headers)
-    ext  = headers.select do |e|
+    external = headers.select do |e|
       i = fields_mapper.to_internal(e)
       int_head.include?(i)
     end
-    ext_present = known_headers_present(int_head) | ext
+
+    ext_present = known_headers_present(int_head) | external
     ext_miss    = known_headers - ext_present
 
     {
@@ -133,7 +143,8 @@ class Eco::API::Common::People::DefaultParsers::CSVParser < Eco::API::Common::Lo
       indirect: {}
     }.tap do |missing|
       ext_miss.each do |ext|
-        next unless int = fields_mapper.to_internal(ext)
+        next unless (int = fields_mapper.to_internal(ext))
+
         missing[:direct] << ext if all_internal_attrs.include?(int)
         related_attrs_requirements = required_attrs.values.select do |req|
           dep       = req.dependant?(int)
@@ -141,10 +152,13 @@ class Eco::API::Common::People::DefaultParsers::CSVParser < Eco::API::Common::Lo
           in_header = int_head.include?(req.attr)
           affects || (dep && !in_header)
         end
+
         next if related_attrs_requirements.empty?
+
         data = missing[:indirect][ext] = {}
         data[:int]   = int
         data[:attrs] = {}
+
         related_attrs_requirements.each_with_object(data[:attrs]) do |req, attrs|
           status = req.active?(*int_head) ? :active : :inactive
           attrs[status] ||= []
@@ -155,32 +169,33 @@ class Eco::API::Common::People::DefaultParsers::CSVParser < Eco::API::Common::Lo
   end
 
   def known_headers_present(headers_internal)
-    @known_internal ||= known_headers.select do |ext|
+    known_headers.select do |ext|
       int = fields_mapper.to_internal(ext)
       headers_internal.include?(int)
     end
   end
 
   # Scopes what internal attrs appear in headers as they are
-  def internal_present_or_active(headers, inactive_requirements = {})
+  def internal_present_or_active(headers, inactive_requirements = {}) # rubocop:disable Metrics/AbcSize
     # internal attrs that are not being mapped
-    int_all = all_internal_attrs.reject {|i| fields_mapper.external?(i)}
-    hint = headers & int_all
-    hext = headers - hint
+    int_all     = all_internal_attrs.reject {|i| fields_mapper.external?(i)}
+    hint        = headers & int_all
+    hext        = headers - hint
     int_present = hint + hext.map {|e| fields_mapper.to_internal(e)}.compact
 
-    update_inactive = Proc.new do
+    update_inactive = proc do
       inactive_requirements.dup.each do |attr, req|
-        if req.active?(*int_present)
-          inactive_requirements.delete(attr)
-          int_present << attr
-          update_inactive.call
-        end
+        next unless req.active?(*int_present)
+
+        inactive_requirements.delete(attr)
+        int_present << attr
+        update_inactive.call
       end
     end
 
-    required_attrs.values.each do |req|
+    required_attrs.each_value do |req|
       next if int_present.include?(req)
+
       if req.active?(*int_present)
         inactive_requirements.delete(req.attr)
         int_present << req.attr
@@ -189,6 +204,7 @@ class Eco::API::Common::People::DefaultParsers::CSVParser < Eco::API::Common::Lo
         inactive_requirements[req.attr] = req
       end
     end
+
     int_present
   end
 
@@ -202,9 +218,7 @@ class Eco::API::Common::People::DefaultParsers::CSVParser < Eco::API::Common::Lo
   end
 
   def required_attrs
-    @required_attrs ||= person_parser.required_attrs.each_with_object({}) do |ra, out|
-      out[ra.attr] = ra
-    end
+    @required_attrs ||= person_parser.required_attrs.to_h {|ra| [ra.attr, ra]}
   end
 
   def all_internal_attrs

data/lib/eco/api/common/people/default_parsers/login_providers_parser.rb

@@ -8,7 +8,7 @@ class Eco::API::Common::People::DefaultParsers::LoginProvidersParser < Eco::API:
       login_providers.to_id(name&.downcase&.strip).tap do |known|
         unless !name || known || unknown_pgs.include?(name)
           unknown_pgs.push(name)
-          logger.warn("Unknown Login Provider: '#{name}'")
+          log(:warn) { "Unknown Login Provider: '#{name}'" }
         end
       end
     end.compact

data/lib/eco/api/common/people/default_parsers/xls_parser.rb

@@ -29,7 +29,9 @@ class Eco::API::Common::People::DefaultParsers::XLSParser < Eco::API::Common::Lo
   end
 
   def headers
-    logger.warn("Headers detection is using your fields_map.json file (native behaviour)")
+    log(:warn) {
+      "Headers detection is using your fields_map.json file (native behaviour)"
+    }
     session.fields_mapper.list(:external).uniq
   end
 
@@ -50,7 +52,11 @@ class Eco::API::Common::People::DefaultParsers::XLSParser < Eco::API::Common::Lo
     spreadheet.parse(header_search: target, clean: true)
   rescue Roo::HeaderRowNotFoundError => e
     missing = JSON.parse(e.message)
-    logger.warn("The input file is missing these headers: #{missing}")
+
+    log(:warn) {
+      "The input file is missing these headers: #{missing}"
+    }
+
     present = target - missing
     rows(present)
   end

data/lib/eco/api/common/people/default_parsers.rb

@@ -6,17 +6,6 @@ module Eco
         class DefaultParsers < PersonParser
           autoloads_children_of "Eco::API::Common::Loaders::Parser"
           autoload_namespace    "Eco::API::Common::People::DefaultParsers"
-
-          def initialize(**kargs)
-            super(**kargs)
-            define_defaults
-          end
-
-          private
-
-          def define_defaults
-            # SelectParser.new(self, select_hashes: select_tables).process
-          end
         end
       end
     end

data/lib/eco/api/common/people/person_attribute_parser.rb

@@ -77,7 +77,8 @@ module Eco
           end
 
           # Helper to obtain the current internal named attributes of the data
-          # @param source_data [Array<String>, Hash] if `Array` those are already the `keys`, if `Hash` it gets the `keys`
+          # @param source_data [Array<String>, Hash] if `Array` those are already the `keys`,
+          #   if `Hash` it gets the `keys`
           # @return [Array<String>] `keys` of `source_data`
           def data_keys(source_data)
             case source_data

data/lib/eco/api/common/people/person_entry.rb

@@ -5,11 +5,13 @@ module Eco
         class PersonEntry
           DEBUG = false
 
-          # This class is meant to provide a common interface to access entries of source data that come in different formats.
+          # This class is meant to provide a common interface to access entries of source data that come in
+          # different formats.
           # @note
           #   - if `data` is a `Person` object, its behaviour is `serialise`.
           #   - if `data` is **not** a `Person` object, it does a `parse`.
-          #   - currently **in rework**, so there may be subtle differences that make it temporarily unstable (yet it is reliable).
+          #   - currently **in rework**, so there may be subtle differences that make it temporarily unstable
+          #     (yet it is reliable).
           # @param data [Hash, Ecoportal::API::V1::Person] `Person` object
           #   to be serialized or hashed entry (`CSV::Row` is accepted).
           # @param person_parser [Common::People::PersonParser]  parser/serializer

data/lib/eco/api/session/batch/errors.rb

@@ -4,7 +4,6 @@ module Eco
       class Batch
         # Helper object linked to a `Batch::Status`. Its aim is to manage the errors of the batch status.
         class Errors
-
           # @attr_reader status [Eco::API::Session::Batch::Status] `batch status` this `Errors` object is associated to.
           attr_reader :status
 
@@ -12,7 +11,9 @@ module Eco
 
           # @param status [Eco::API::Session::Batch::Status] `batch status` this `Errors` object is associated to.
           def initialize(status:)
-            "Expected Batch::Status as root. Given: #{status.class}" unless status.is_a?(Eco::API::Session::Batch::Status)
+            msg = "Expected Batch::Status as root. Given: #{status.class}"
+            raise ArgumentError msg unless status.is_a?(Eco::API::Session::Batch::Status)
+
             @status = status
           end
 
@@ -52,7 +53,8 @@ module Eco
           end
 
           # Was there any _Sever_ (reply) **error** as a result of this batch?
-          # @return [Boolean] `true` if any of the queried _entries_ got an unsuccessful `Ecoportal::API::Common::BatchResponse`
+          # @return [Boolean] `true` if any of the queried _entries_ got
+          #   an unsuccessful `Ecoportal::API::Common::BatchResponse`
           def any?
             queue.any? {|query| !status[query].success?}
           end
@@ -62,14 +64,10 @@ module Eco
           #   1. `entries` that got that error, if `only_entries` is `true`
           #   2. `ErrorCache` objects, if `only_entries` is `false`
           def by_type(only_entries: true)
-            errors.group_by do |e|
-              e.type
-            end.transform_values do |arr|
-              if only_entries
-                arr.map {|e| e.entry}
-              else
-                arr
-              end
+            errors.group_by(&:type).transform_values do |arr|
+              next arr unless only_entries
+
+              arr.map(&:entry)
             end
           end
           # @!endgroup
@@ -83,27 +81,28 @@ module Eco
           def errors
             entries.each_with_object([]) do |entry, arr|
               response = status[entry]
-              if body = response.body
-                errs = []
-                case body
-                when Hash
-                  if errs = (body["errors"] || body["error"])
-                    errs = [errs].flatten(1).compact
-                  end
-                  if errs.empty? && !response.success?
-                    errs = [body["response"]].flatten(1).compact
-                  end
-                when String
-                  errs = [body]
-                end
-                errs.each do |msg|
-                  arr.push(ErrorCache.new(
-                    klass = Eco::API::Error.get_type(msg),
-                    klass.new(err_msg: msg, entry: entry, session: session),
-                    entry,
-                    response
-                  ))
-                end
+              next unless (body = response.body)
+
+              errs = []
+              case body
+              when Hash
+                body_errs = body["errors"] || body["error"]
+                errs = [body_errs].flatten(1).compact if body_errs
+
+                response_errs = errs.empty? && !response.success?
+                errs = [body["response"]].flatten(1).compact if response_errs
+              when String
+                errs = [body]
+              end
+
+              errs.each do |msg|
+                err_cache = ErrorCache.new(
+                  klass = Eco::API::Error.get_type(msg),
+                  klass.new(err_msg: msg, entry: entry, session: session),
+                  entry,
+                  response
+                )
+                arr.push(err_cache)
               end
             end
           end
@@ -112,19 +111,19 @@ module Eco
 
           def message
             msgs = strs
-            if msgs.length > 0
-              "There were #{msgs.length} errors:\n" + msgs.join("\n")
-            else
+            if msgs.empty?
               "There were no errors for the current batch '#{method}'!! ;)"
+            else
+              "There were #{msgs.length} errors:\n" + msgs.join("\n")
             end
           end
 
           def print
             msgs = strs
-            if msgs.length > 0
-              logger.error("There were #{msgs.length} errors:\n" + msgs.join("\n"))
-            else
+            if msgs.empty?
               logger.info("There were no errors for the current batch '#{method}'!! ;)")
+            else
+              logger.error("There were #{msgs.length} errors:\n" + msgs.join("\n"))
             end
           end
           # @!endgroup
@@ -142,12 +141,12 @@ module Eco
           # @return [Array<Hash>, Array<Ecoportal::API::V1::Person>, Array<Ecoportal::API::Internal::Person>]
           def entries
             queue.select.with_index do |query, i|
-              unless response = status[i]
+              unless (response = status[i])
                 msg  = "Error: query with no response. You might have duplicated entries in your queue.\n"
                 msg += "Queue length: #{queue.length}; Queue elements class: #{queue.first.class}\n"
                 msg += "Query with no response. Person: #{person_ref(query)}\n"
                 queue.map do |entry|
-                  if [:id, :external_id, :email].any? {|attr| (v = get_attr(entry, attr)) && v == get_attr(query, attr)}
+                  if %i[id external_id email].any? {|attr| (v = get_attr(entry, attr)) && v == get_attr(query, attr)}
                     msg += "It could be this peson entry (idx: #{to_index(entry)}): #{person_ref(entry)}\n"
                   end
                 end
@@ -184,15 +183,15 @@ module Eco
               entry    = queue.to_a[i]
               response = status[i]
               msg      = "Error #{response.status}: #{response.body}\n"
-              msg     += "-- Failed to batch #{method}. Person: #{person_ref(entry)}"
+              msg     += "-- Failed to #{method}. Person: #{person_ref(entry)}"
             end
             msg
           end
 
           def print_one(key)
-            unless status.success?(key)
-              logger.error(str(key))
-            end
+            return if status.success?(key)
+
+            logger.error(str(key))
           end
         end
       end

data/lib/eco/api/session.rb

@@ -281,7 +281,7 @@ module Eco
       # Shortcut to create a job of certain type within a group
       # @param [see @Eco::API::Session::Batch::Jobs#new]
       # @return [Eco::API::Session::Batch::Job]
-      def new_job(
+      def new_job( # rubocop:disable Metrics/ParameterLists
         group,
         name,
         type,
@@ -290,7 +290,14 @@ module Eco
         accept_update_with_no_id = false, # rubocop:disable Style/OptionalBooleanParameter
         &block
       )
-        job_group(group).new(name, usecase: usecase, type: type, sets: sets, accept_update_with_no_id: accept_update_with_no_id, &block)
+        job_group(group).new(
+          name,
+          usecase:                  usecase,
+          type:                     type,
+          sets:                     sets,
+          accept_update_with_no_id: accept_update_with_no_id,
+          &block
+        )
       end
 
       # @see Eco::API::Session::Batch::JobsGroups#launch

data/lib/eco/api/usecases/default/locations/csv_to_tree_case.rb

@@ -13,7 +13,7 @@ class Eco::API::UseCases::Default::Locations::CsvToTree < Eco::API::Common::Load
     File.open(output_file, "w") do |fd|
       fd << tree_struct.as_json.to_json
     end
-    logger.info("Saved structure in '#{output_file}'")
+    log(:info) { "Saved structure in '#{output_file}'" }
   end
 
   private

data/lib/eco/api/usecases/default/people/set_default_tag_case.rb

@@ -6,7 +6,7 @@ class Eco::API::UseCases::Default::People::SetDefaultTagCase < Eco::API::Common:
   # different options (several nodes at the same depth):
   # => take the common node between them (i.e. you have Hamilton and Auckland -> take New Zealand)
   # => if there's no common node between them, take the `first` (unless they are at top level of the tree)
-  def main(people, session, options, usecase)
+  def main(_people, session, options, usecase)
     tagtree_present!
     users  = users_present!
     update = session.new_job("main", "update", :update, usecase, :account)
@@ -22,7 +22,7 @@ class Eco::API::UseCases::Default::People::SetDefaultTagCase < Eco::API::Common:
   def tagtree_present!
     return unless tagtree?
 
-    msg  = "There is no locs struct defined. Aborting..."
+    msg = "There is no locs struct defined. Aborting..."
     logger.fatal(msg)
     raise msg
   end

data/lib/eco/api/usecases/default/people/supers_cyclic_identify_case.rb

@@ -4,7 +4,7 @@ class Eco::API::UseCases::Default::People::SupersCyclicIdentify < Eco::API::Comm
 
   attr_reader :people
 
-  def main(people, session, options, usecase)
+  def main(_people, _session, options, _usecase)
     options[:end_get] = false
     save!(cyclic_sets)
   end
@@ -21,25 +21,23 @@ class Eco::API::UseCases::Default::People::SupersCyclicIdentify < Eco::API::Comm
 
   def save!(data)
     if data.empty?
-      session.logger.info("There were no cyclic supervisors identified!!")
+      log(:info) { "There were no cyclic supervisors identified!!" }
       return
     end
 
     ext = File.extname(file).downcase.delete(".")
 
-    File.open(file, "w") do |fd|
-      case ext
-      when "txt"
-        create_file(data, file: file, format: :txt)
-      when "html"
-        log(:warn) { "html is still not supported" }
-        exit(1)
-        # create_file(data, file: file, format: :html)
-      when "json"
-        log(:warn) { "json is still not supported" }
-        exit(1)
-        # create_file(data, file: file, format: :json)
-      end
+    case ext
+    when "txt"
+      create_file(data, file: file, format: :txt)
+    when "html"
+      log(:warn) { "html is still not supported" }
+      exit(1)
+      # create_file(data, file: file, format: :html)
+    when "json"
+      log(:warn) { "json is still not supported" }
+      exit(1)
+      # create_file(data, file: file, format: :json)
     end
   end
 
@@ -64,8 +62,8 @@ class Eco::API::UseCases::Default::People::SupersCyclicIdentify < Eco::API::Comm
 
     "".tap do |str|
       entry = set.shift
-      str << "#{"  " * lev}"
-      str << lev > 0 ? "+-#{lev}- " : ""
+      str << "  " * lev
+      str << lev&.positive? ? "+-#{lev}- " : ""
       str << entry.name
       str << " (#{entry.external_id}|#{entry.email}|#{entry.id})\n"
       next unless set && !set.empty?