eco-helpers 2.7.23 → 2.7.24

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1d522c29136b4722235f8dbf8349d7328ba7ebe90f77d5fecf15a03a049cc8fe
-  data.tar.gz: b2529b04d22fcc9f013366c07a5bb7905c8d6154af97c4d235fafc1f0bf6452b
+  metadata.gz: 6576d3f9439855c0004110d104d82634733df41822acb362bc82cafcbf90d6ca
+  data.tar.gz: e0052851a9c33b54c77bcb4577874cb765e744c40ed63b7eaa5a5fd3d59632ec
 SHA512:
-  metadata.gz: 822b1359de0c56118ed2e8e564a54c1119a2bb7597373c029cc72e3f808b3fbd94853a8eced013033613f77b0cfb0c47983e4e03e60e928e30bb6084096d9250
-  data.tar.gz: f32a7ad2a927015c1a2a1b0642f379c1014231db7a2aea00187bf690584a738c7f6770ba361422eeecbf097f2b760c6c6ee502b8c6ca5d790354cef13bf58f26
+  metadata.gz: 479a0ed0a903b1f05a930673e0098912df91cb66a49b1acb99d2b7c82dd531f9bcd4704f46c0a4a84ad9f8c2e12a0469ccbc1b8760cba65fae1e7e272d6575aa
+  data.tar.gz: 5f626293d3de079368627f68eb5337abe64afde56f86248721ed3615a90d7e694cacde99fe78467e50fb4c24a8d19cb66670cffc14f63c08ab1b4735d9652041

data/CHANGELOG.md

@@ -2,7 +2,7 @@
 
 All notable changes to this project will be documented in this file.
 
-## [2.7.24] - 2024-07-xx
+## [2.7.25] - 2024-07-xx
 
 ### Added
 
@@ -10,6 +10,13 @@ All notable changes to this project will be documented in this file.
 
 ### Fixed
 
+## [2.7.24] - 2024-07-30
+
+### Fixed
+
+- `Eco::API::Common::People::PersonEntry#set_core`
+  - Exclude setting `id` (should invariably be set via back-end only)
+
 ## [2.7.23] - 2024-07-29
 
 ### Fixed
@@ -18,8 +25,6 @@ All notable changes to this project will be documented in this file.
 
 ## [2.7.22] - 2024-07-26
 
-### Added
-
 ### Changed
 
 - Patch on exception: to show cause
@@ -27,8 +32,6 @@ All notable changes to this project will be documented in this file.
   - `load_json` prevent avoidable memory leaks
   - `save_json` prevent avoidable memory leaks
 
-### Fixed
-
 ## [2.7.21] - 2024-07-13
 
 ### Added

data/lib/eco/api/common/people/person_entry.rb

@@ -211,7 +211,8 @@ module Eco
           # @param person [Ecoportal::API::V1::Person] the person we want to set the core values to.
           # @param exclude [String, Array<String>] core attributes that should not be set/changed to the person.
           def set_core(person, exclude: nil)
-            scoped_attrs = @emap.core_attrs(@final_entry) - into_a(exclude)
+            scoped_attrs  = @emap.core_attrs(@final_entry) - into_a(exclude)
+            scoped_attrs -= ['id']
             @final_entry.slice(*scoped_attrs).each do |attr, value|
               set_part(person, attr, value)
             rescue StandardError => e

data/lib/eco/api/microcases/with_each.rb

@@ -15,12 +15,12 @@ module Eco
       def with_each(entries, people, options, append_created: true)
         @_skip_all_multiple_results = false
         people_copy = people.newFrom(people.to_a)
+
         entries.each_with_object([]) do |entry, scoped|
           begin
-            unless person = people_copy.find(entry, strict: micro.strict_search?(options))
-              person = session.new_person.tap do |person|
-                people << person if append_created
-              end
+            person   = people_copy.find(entry, strict: micro.strict_search?(options))
+            person ||= session.new_person.tap do |pers|
+              people << pers if append_created
             end
           rescue Eco::API::Organization::People::MultipleSearchResults => e
             unless @_skip_all_multiple_results
@@ -29,17 +29,19 @@ module Eco
             end
           end
 
-          if person
-            person.entry = entry
-            yield(entry, person) if block_given?
-            scoped << person
-          end
-        end.yield_self {|all_people| people.newFrom all_people.uniq}
+          next unless person
+
+          person.entry = entry
+          yield(entry, person) if block_given?
+          scoped << person
+        end.then do |all_people|
+          people.newFrom all_people.uniq
+        end
       end
 
       private
 
-      def _with_each_prompt_to_select_user(error, entry: nil, increase_count: true)
+      def _with_each_prompt_to_select_user(error, entry: nil, increase_count: true) # rubocop:disable Metrics/AbcSize
         unless error.is_a?(Eco::API::Organization::People::MultipleSearchResults)
           raise "Expecting Eco::API::Organization::People::MultipleSearchResults. Given: #{error.class}"
         end
@@ -47,7 +49,7 @@ module Eco
         @_with_each_prompts += 1 if increase_count
 
         lines = []
-        lines << "\n(#{@_with_each_prompts}) " + error.to_s + "\n"
+        lines << "\n(#{@_with_each_prompts}) #{error}\n"
         lines << "  #index   - Select the correct person by its number index among the list above."
         lines << "  (I)      - Just Skip/Ignore this one. I will deal with that input entry in another launch."
         lines << "  (A)      - Ignore all the rest of input entries with this problem."
@@ -56,20 +58,20 @@ module Eco
 
         prompt_user("Type one option (#number/I/A/C/B):", explanation: lines.join("\n"), default: "I") do |res|
           res = res.upcase
-          case
-          when res.start_with?("I")
-            logger.info "Ignoring entry... #{entry.to_s(:identify) if entry}"
+
+          if res.start_with?("I")
+            logger.info "Ignoring entry... #{entry&.to_s(:identify)}"
             nil
-          when res.start_with?("A")
+          elsif res.start_with?("A")
             logger.info "All input entries with this same issue will be ignored for this launch"
             @_skip_all_multiple_results = true
             nil
-          when res.start_with?("C")
+          elsif res.start_with?("C")
             logger.info "Creating new person...#{"for entry #{entry.to_s(:identify)}" if entry}"
             session.new_person
-          when res.start_with?("B")
+          elsif res.start_with?("B")
             raise error
-          when res && !res.empty? && (pos = res.to_i rescue nil) && (pos < error.candidates.length)
+          elsif res && !res.empty? && (pos = res.to_i rescue nil) && (pos < error.candidates.length) # rubocop:disable Style/RescueModifier
             error.candidate(pos).tap do |person|
               logger.info "Thanks!! You selected #{person.identify}"
               sleep(1.5)

data/lib/eco/version.rb

@@ -1,3 +1,3 @@
 module Eco
-  VERSION = '2.7.23'.freeze
+  VERSION = '2.7.24'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: eco-helpers
 version: !ruby/object:Gem::Version
-  version: 2.7.23
+  version: 2.7.24
 platform: ruby
 authors:
 - Oscar Segura