ecfr 1.1.3 → 1.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4d08cec2c05e1ac2e15d1889deec5f7348c767eafe2c1c8970e440051e3b4460
-  data.tar.gz: 04ab00ed24f91fde2327ae63565e9a010bf174373e0125670963d9c5f5dcfa13
+  metadata.gz: 93cb578d4fc85f48e9d1d0ac423522886fa575a2425da6836547eb075d4e6cf5
+  data.tar.gz: b896739d0023e6398da9effbab99ed0b48323d6a61b9f21b94b2680f9ed74146
 SHA512:
-  metadata.gz: 3ca1f2aeaf1d5b27b9da1af4505bf0d73c7f059665c8fce3572439aa8018abaa6aaf7e9af6e8ddb63dbefdb40266e5be04b5cad00056203332817bf5d2a28ff7
-  data.tar.gz: 7120fcf30c26e811d0c4f7fa20ebefebbf8a44fa4407460760e010df2623922d35dcc8b64a54a3bcd3b35cf509eb073668886884df4a12b93cd7e665a5217624
+  metadata.gz: cc03bfa1d18e5e202f4e3f069d4cf3f8ee3caf5aa3af26fdf0f9813a1c9c7756fe403764ac69f00268e3c96cbad85f1697e69eb8eab6f74b4d84351e74806e2e
+  data.tar.gz: 599a3c76236594b98fde583b801922b3bfb686071c9cbf2460610895d229580c428ba02026898b181dd0729dcfa18ccbecd8c1af5fde036edc17229c55ca739d

data/.rubocop.yml

@@ -1,4 +1,5 @@
 AllCops:
+  NewCops: enable
   Exclude:
     - bin/*
     - lib/yard/*

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 ## [Unreleased]
 
+## [1.1.4] - 2025-03-27
+### Additions
+- Add factory for Agency (38185411) 
+### Dependencies
+- Removed lock to Rails 6 (f6c5024a)
+
 ## [1.1.3] - 2024-12-10
 ### Additions
 - Add content attribute to origin (292fed36)

data/Gemfile.lock

@@ -2,119 +2,139 @@ PATH
   remote: .
   specs:
     ecfr (1.1.3)
-      activemodel (~> 6.0)
-      activesupport (~> 6.0)
+      activemodel
+      activesupport
       faraday (~> 2.0)
       faraday-net_http_persistent (~> 2.0)
+      ostruct
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (6.1.4)
-      activesupport (= 6.1.4)
-    activesupport (6.1.4)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
+    activemodel (7.2.1)
+      activesupport (= 7.2.1)
+    activesupport (7.2.1)
+      base64
+      bigdecimal
+      concurrent-ruby (~> 1.0, >= 1.3.1)
+      connection_pool (>= 2.2.5)
+      drb
       i18n (>= 1.6, < 2)
+      logger (>= 1.4.2)
       minitest (>= 5.1)
-      tzinfo (~> 2.0)
-      zeitwerk (~> 2.3)
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0, >= 2.0.5)
     ast (2.4.2)
+    base64 (0.2.0)
+    bigdecimal (3.1.8)
     coderay (1.1.3)
-    concurrent-ruby (1.1.9)
+    concurrent-ruby (1.3.4)
     connection_pool (2.4.1)
-    diff-lcs (1.4.4)
+    diff-lcs (1.5.1)
+    drb (2.2.1)
     ethon (0.16.0)
       ffi (>= 1.15.0)
-    factory_bot (6.2.1)
+    factory_bot (6.5.0)
       activesupport (>= 5.0.0)
-    faraday (2.5.2)
-      faraday-net_http (>= 2.0, < 3.1)
-      ruby2_keywords (>= 0.0.4)
-    faraday-net_http (3.0.0)
-    faraday-net_http_persistent (2.1.0)
+    faraday (2.12.0)
+      faraday-net_http (>= 2.0, < 3.4)
+      json
+      logger
+    faraday-net_http (3.3.0)
+      net-http
+    faraday-net_http_persistent (2.3.0)
       faraday (~> 2.5)
-      net-http-persistent (~> 4.0)
-    faraday-typhoeus (1.0.0)
+      net-http-persistent (>= 4.0.4, < 5)
+    faraday-typhoeus (1.1.0)
       faraday (~> 2.0)
       typhoeus (~> 1.4)
-    ffi (1.15.5)
-    i18n (1.8.10)
+    ffi (1.17.0)
+    i18n (1.14.6)
       concurrent-ruby (~> 1.0)
-    json (2.6.3)
+    json (2.7.2)
     language_server-protocol (3.17.0.3)
-    method_source (1.0.0)
-    mini_portile2 (2.8.1)
-    minitest (5.14.4)
-    net-http-persistent (4.0.2)
+    lint_roller (1.1.0)
+    logger (1.6.1)
+    method_source (1.1.0)
+    mini_portile2 (2.8.7)
+    minitest (5.25.1)
+    net-http (0.4.1)
+      uri
+    net-http-persistent (4.0.4)
       connection_pool (~> 2.2)
-    nokogiri (1.14.0)
-      mini_portile2 (~> 2.8.0)
+    nokogiri (1.16.7)
+      mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
-    optparse (0.3.1)
-    parallel (1.22.1)
-    parallel_tests (4.2.0)
+    ostruct (0.6.1)
+    parallel (1.26.3)
+    parallel_tests (4.7.2)
       parallel
-    parser (3.2.2.0)
+    parser (3.3.5.0)
       ast (~> 2.4.1)
-    pry (0.14.1)
+      racc
+    pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    racc (1.6.2)
-    rack (3.0.4.1)
+    racc (1.8.1)
+    rack (3.1.7)
     rainbow (3.1.1)
-    regexp_parser (2.7.0)
-    request_store (1.5.1)
+    regexp_parser (2.9.2)
+    request_store (1.7.0)
       rack (>= 1.4)
-    rexml (3.2.5)
-    rspec (3.10.0)
-      rspec-core (~> 3.10.0)
-      rspec-expectations (~> 3.10.0)
-      rspec-mocks (~> 3.10.0)
-    rspec-core (3.10.1)
-      rspec-support (~> 3.10.0)
-    rspec-expectations (3.10.1)
+    rspec (3.13.0)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.1)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.3)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-mocks (3.10.2)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-support (3.10.2)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.1)
     rspec_junit_formatter (0.6.0)
       rspec-core (>= 2, < 4, != 2.12.0)
-    rubocop (1.48.1)
+    rubocop (1.66.1)
       json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.2.0.0)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.26.0, < 2.0)
+      regexp_parser (>= 2.4, < 3.0)
+      rubocop-ast (>= 1.32.2, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.28.0)
-      parser (>= 3.2.1.0)
-    rubocop-performance (1.16.0)
-      rubocop (>= 1.7.0, < 2.0)
-      rubocop-ast (>= 0.4.0)
+    rubocop-ast (1.32.3)
+      parser (>= 3.3.1.0)
+    rubocop-performance (1.22.1)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
     ruby-progressbar (1.13.0)
-    ruby2_keywords (0.0.5)
-    standard (1.26.0)
+    securerandom (0.3.1)
+    standard (1.41.0)
       language_server-protocol (~> 3.17.0.2)
-      rubocop (~> 1.48.1)
-      rubocop-performance (~> 1.16.0)
-    turbo_tests (1.0.0)
-      optparse
-      parallel_tests
-      rspec
-    typhoeus (1.4.0)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.66.0)
+      standard-custom (~> 1.0.0)
+      standard-performance (~> 1.5)
+    standard-custom (1.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.50)
+    standard-performance (1.5.0)
+      lint_roller (~> 1.1)
+      rubocop-performance (~> 1.22.0)
+    turbo_tests (2.2.4)
+      parallel_tests (>= 3.3.0, < 5)
+      rspec (>= 3.10)
+    typhoeus (1.4.1)
       ethon (>= 0.9.0)
-    tzinfo (2.0.4)
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.4.2)
-    webrick (1.7.0)
-    yard (0.9.28)
-      webrick (~> 1.7.0)
-    zeitwerk (2.4.2)
+    unicode-display_width (2.6.0)
+    uri (0.13.1)
+    yard (0.9.37)
 
 PLATFORMS
   ruby
@@ -135,4 +155,4 @@ DEPENDENCIES
   yard
 
 BUNDLED WITH
-   2.2.33
+   2.6.5

data/README.md

@@ -34,7 +34,7 @@ Some endpoints return XML (like the Structure) and will be automatically parsed
 
 ### Response caching
 
-Response caching can be enabled via a configuration option. This is a performance feature that allows the calling code to not worry about performance when different parts of the application call the same endpoints at different times in the same request. Responses are cached my HTTP method, api endpoint and requested parameters. You will need to install the [request_store](https://github.com/steveklabnik/request_store) gem when enabling this option.
+Response caching can be enabled via a configuration option. This is a performance feature that allows the calling code to not worry about performance when different parts of the application call the same endpoints at different times in the same request. Responses are cached by HTTP method, api endpoint and requested parameters. You will need to install the [request_store](https://github.com/steveklabnik/request_store) gem when enabling this option.
 
 If you are using request store outside of a Rails project or in a background process (eg Sidekiq) check the RequestStore documentation for how to use the required middleware.
 

data/ecfr.gemspec

@@ -29,10 +29,11 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "activemodel", "~> 6.0"
-  spec.add_dependency "activesupport", "~> 6.0"
+  spec.add_dependency "activemodel"
+  spec.add_dependency "activesupport"
   spec.add_dependency "faraday", "~> 2.0"
   spec.add_dependency "faraday-net_http_persistent", "~> 2.0"
+  spec.add_dependency "ostruct"
 
   spec.add_development_dependency "factory_bot"
   spec.add_development_dependency "parallel_tests"
@@ -64,7 +65,7 @@ Gem::Specification.new do |spec|
     Some features of the eCFR gem support parsing XML responses, response
     caching, and parallel requests.
 
-    To use these features you will beed to install the appropriate gems
+    To use these features you will need to install the appropriate gems
     (nokogiri, request_store, and faraday-typhoeus respectively) in your
     application. In order to minimize depedencies and code that is loaded these
     are not a default dependencies of the eCFR gem.

data/lib/ecfr/attribute_method_definition.rb

@@ -43,7 +43,7 @@ module Ecfr
         end
 
         if options[:type] == :boolean
-          define_method "#{attr}?" do
+          define_method :"#{attr}?" do
             val = extract_value(attr, options)
             Ecfr::AttributeCaster.cast_attr(val, options[:type], options[:options] || {})
           end

data/lib/ecfr/configuration.rb

@@ -50,7 +50,7 @@ module Ecfr
 
     def initialize
       CONFIG_DEFAULTS.each do |k, v|
-        instance_variable_set("@#{k}", v)
+        instance_variable_set(:"@#{k}", v)
       end
     end
 

data/lib/ecfr/facet_attribute_method_definition.rb

@@ -13,7 +13,7 @@ module Ecfr
           raise "must set :as to either :key or :value, was: #{as}"
         end
 
-        super(*attribute)
+        super
       end
     end
 
@@ -37,7 +37,7 @@ module Ecfr
         results[self.class.fv] = value
       end
 
-      super(results, options)
+      super
     end
 
     def count_for(key)

data/lib/ecfr/prince_xml_service/pdf.rb

@@ -5,9 +5,9 @@ module Ecfr
 
       PDF_PATH = ""
 
-      def self.client(client_options = {}, &block)
+      def self.client(client_options = {}, &)
         client_options[:timeout] = Ecfr.config.prince_xml_service_pdf_timeout
-        super(client_options: client_options, &block)
+        super(client_options: client_options, &)
       end
 
       def self.html_to_pdf(string, output_path, sha)

data/lib/ecfr/search_service/content_version.rb

@@ -1,11 +1,11 @@
 module Ecfr
   module SearchService
     class ContentVersion < Base
-      require_relative "./content_version/count"
-      require_relative "./content_version/hierarchichal_result"
-      require_relative "./content_version/result"
-      require_relative "./content_version/suggestion"
-      require_relative "./content_version/summary"
+      require_relative "content_version/count"
+      require_relative "content_version/hierarchichal_result"
+      require_relative "content_version/result"
+      require_relative "content_version/suggestion"
+      require_relative "content_version/summary"
 
       #
       # Metadata about the number of matching items

data/lib/ecfr/search_service/date_facet.rb

@@ -12,7 +12,7 @@ module Ecfr
       # @return [<DateFacet>] counts by date
       def self.search(type, options = {})
         # no-op documentation only
-        super(type, options)
+        super
       end
     end
   end

data/lib/ecfr/testing/factories/admin_service/agency_factory.rb

@@ -0,0 +1,27 @@
+FactoryBot.define do
+  factory :agency, class: "Ecfr::AdminService::Agency" do
+    skip_create
+
+    name { "Agency Name" }
+    display_name { "The Agency Name" }
+    short_name { "AN" }
+    sortable_name { "Name, Agency" }
+    slug { "agency-name" }
+    children {
+      []
+    }
+    cfr_references {
+      [ecfr_attribute_hash(:hierarchy)]
+    }
+
+    initialize_with {
+      new(attributes.deep_stringify_keys)
+    }
+  end
+
+  trait :with_child do
+    children {
+      [build(:agency, name: "Child Agency")]
+    }
+  end
+end

data/lib/ecfr/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ecfr
-  VERSION = "1.1.3"
+  VERSION = "1.1.4"
 end

data/lib/ecfr/versioner_service/ancestors.rb

@@ -157,7 +157,7 @@ module Ecfr
       #     response
       #
       def initialize(attributes, options = {})
-        super(attributes, options)
+        super
 
         ancestors.each_with_object({}) do |ancestor, hsh|
           hsh[ancestor.type] = ancestor.identifier

data/lib/ecfr.rb

@@ -9,6 +9,8 @@ require "active_support/core_ext/hash"
 require "active_support/core_ext/module/delegation"
 require "active_support/core_ext/string"
 
+require "ostruct"
+
 require "faraday"
 require "faraday/net_http_persistent"
 require_relative "ecfr/faraday/user_agent/middleware"

metadata

@@ -1,43 +1,42 @@
 --- !ruby/object:Gem::Specification
 name: ecfr
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.1.4
 platform: ruby
 authors:
 - Peregrinator
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-12-10 00:00:00.000000000 Z
+date: 2025-03-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
@@ -66,6 +65,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: ostruct
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: factory_bot
   requirement: !ruby/object:Gem::Requirement
@@ -324,6 +337,7 @@ files:
 - lib/ecfr/testing/extensions/search_service/date_facet_extensions.rb
 - lib/ecfr/testing/extensions/versioner_service/ancestors_extensions.rb
 - lib/ecfr/testing/extensions/versioner_service/title_extenstions.rb
+- lib/ecfr/testing/factories/admin_service/agency_factory.rb
 - lib/ecfr/testing/factories/admin_service/cfr_reference_factory.rb
 - lib/ecfr/testing/factories/admin_service/ecfr_correction_factory.rb
 - lib/ecfr/testing/factories/admin_service/issue_change_factory.rb
@@ -369,7 +383,7 @@ metadata:
   changelog_uri: https://github.com/criticaljuncture/ecfr
 post_install_message: "\n    Some features of the eCFR gem support parsing XML responses,
   response\n    caching, and parallel requests.\n\n    To use these features you will
-  beed to install the appropriate gems\n    (nokogiri, request_store, and faraday-typhoeus
+  need to install the appropriate gems\n    (nokogiri, request_store, and faraday-typhoeus
   respectively) in your\n    application. In order to minimize depedencies and code
   that is loaded these\n    are not a default dependencies of the eCFR gem.\n\n    See
   the README for details of these features.\n  "
@@ -387,8 +401,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.16
-signing_key:
+rubygems_version: 3.6.2
 specification_version: 4
 summary: eCFR.gov API client
 test_files: []