ecdsa_ext 0.5.1 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 344f77af4186a6c073efd7ceb86c1023f9395921e360a6239e6443aeaf31c957
-  data.tar.gz: e9a32a697a607c61dd7f7993975eea458bfb09ccd1445ebe9715809b6c3620d5
+  metadata.gz: 49c7d6aa8f97890fc13a7648051ca3c232cd2bdf35dd5e669c071e6fb8dd3e58
+  data.tar.gz: 576286bd095cde15807d3512cbe57e08c10c8936549b4280c854abf29ee1a12b
 SHA512:
-  metadata.gz: b45f1ef8661a6b1a6a3b222f29b8ed5b95dbf90576040bc6cef13f295b496017508867d1ae0a6ef14c51310d349e6b01d881ba9e8f151b5fa01bc02bb6f04093
-  data.tar.gz: e5717cb07126434a13051d760a9b2c797f6834d7e95a31a2ec433128480f55a40b2cf8e4d336913781319858e0fc7de30a00832bd3810a624a67498a9cab08ef
+  metadata.gz: 1209c40701adcb12a716d70914ce4c03ec4bb92cf6e1df4b628ff1d62944aa0cbf5f7172c7ad45679e04fa376baca65e87d1e7e97ce9202315e0312e5b165b90
+  data.tar.gz: 010464b3223ba96790714b0c705661bd8445acc780e95d28de73137c42b3dbf592e9a5d0a9c1fcdec91f0e4276d9cb862cc258280d0ac2d5d8139f8dbf3f98e4

data/.rubocop.yml

@@ -17,5 +17,6 @@ Style/WhileUntilModifier:
   Enabled: false
 Naming/MethodParameterName:
   Enabled: false
-RSpec/FilePath:
-  Enabled: false
+RSpec/SpecFilePathFormat:
+  Exclude:
+    - 'spec/ecdsa/ext/point_spec.rb'

data/.ruby-version

@@ -1 +1 @@
-ruby-3.3.0
+ruby-4.0.0

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 ## [Unreleased]
 
+## [0.5.2] - 2026-08-07
+
+- Fix a timing leak of the ephemeral key's bit length in `ECDSA.sign` by padding the scalar with the group order
+- Check r and s against the range [1, n-1] (group order) instead of the curve's prime field in `ECDSA.check_signature!`
+- Fix `NoMethodError` when comparing an infinity point with a non-infinity point via `==`
+
 ## [0.1.0] - 2023-02-23
 
 - Initial release

data/Gemfile

@@ -14,4 +14,10 @@ gem 'prettier', '4.0.3'
 gem 'rubocop-rake'
 gem 'rubocop-rspec'
 
-gem 'benchmark-ips'
+gem 'benchmark-ips'
+
+# Bundled gems removed from default gems in Ruby 3.5/4.0.
+gem 'base64'
+gem 'benchmark'
+gem 'ostruct'
+gem 'racc'

data/lib/ecdsa/ext/jacobian_point.rb

@@ -71,6 +71,7 @@ module ECDSA
       def ==(other)
         return false unless other.is_a?(JacobianPoint)
         return true if infinity? && other.infinity?
+        return false if infinity? || other.infinity?
 
         zz = field.square(z)
         other_zz = field.square(other.z)

data/lib/ecdsa/ext/projective_point.rb

@@ -68,6 +68,7 @@ module ECDSA
       def ==(other)
         return false unless other.is_a?(ProjectivePoint)
         return true if infinity? && other.infinity?
+        return false if infinity? || other.infinity?
 
         lhs_x = field.mod(x * other.z)
         rhs_x = field.mod(other.x * z)

data/lib/ecdsa/ext/sign_verify.rb

@@ -5,7 +5,12 @@ module ECDSA
   def self.sign(group, private_key, digest, temporary_key)
     # Second part of step 1: Select ephemeral elliptic curve key pair
     # temporary_key was already selected for us by the caller
-    r_point = (group.generator.to_jacobian * temporary_key).to_affine
+    # Pad the scalar with the group order so that its bit length is fixed,
+    # mitigating a timing leak of the bit length of temporary_key.
+    # Since (k + i * n)G = kG, this does not change the result.
+    k = temporary_key + group.order
+    k += group.order if k.bit_length == group.order.bit_length
+    r_point = (group.generator.to_jacobian * k).to_affine
 
     # Steps 2 and 3
     point_field = PrimeField.new(group.order)
@@ -29,13 +34,13 @@ module ECDSA
 
   def self.check_signature!(public_key, digest, signature)
     group = public_key.group
-    field = group.field
+    point_field = PrimeField.new(group.order)
 
-    # Step 1: r and s must be in the field and non-zero
-    unless field.include?(signature.r)
+    # Step 1: r and s must be in the range [1, n-1].
+    unless point_field.include?(signature.r)
       raise InvalidSignatureError, "Invalid signature: r is not in the field."
     end
-    unless field.include?(signature.s)
+    unless point_field.include?(signature.s)
       raise InvalidSignatureError, "Invalid signature: s is not in the field."
     end
     if signature.r.zero?
@@ -51,7 +56,6 @@ module ECDSA
     e = normalize_digest(digest, group.bit_length)
 
     # Step 4
-    point_field = PrimeField.new(group.order)
     s_inverted = point_field.inverse(signature.s)
     u1 = point_field.mod(e * s_inverted)
     u2 = point_field.mod(signature.r * s_inverted)

data/lib/ecdsa/ext/version.rb

@@ -2,6 +2,6 @@
 
 module ECDSA
   module Ext
-    VERSION = "0.5.1"
+    VERSION = "0.5.2"
   end
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ecdsa_ext
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors:
 - azuchi
-autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-02-08 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ecdsa
@@ -61,7 +60,6 @@ metadata:
   homepage_uri: https://github.com/azuchi/ruby_ecdsa_ext
   source_code_uri: https://github.com/azuchi/ruby_ecdsa_ext
   changelog_uri: https://github.com/azuchi/ruby_ecdsa_ext
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -76,8 +74,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.1
-signing_key: 
+rubygems_version: 4.0.3
 specification_version: 4
 summary: Extension of the ecdsa gem.
 test_files: []