ebay_client 0.1.0 → 0.2.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    OTQzYjA2ZmUwYzllYmJiNmNlOWQxMWRlZTVmYzk3M2MzODVlMmRkNg==
-  data.tar.gz: !binary |-
-    MWFjZWIyZWQwMmM1ZTE0MGZjYjY2N2UxYTI1OTM1YjRmODNkM2Q1Mg==
+SHA1:
+  metadata.gz: 7cea576c603795e615b04cefd3ca295ce205f729
+  data.tar.gz: 8571f1122c99c9cc445bb58c70bfc6e85444dd0d
 SHA512:
-  metadata.gz: !binary |-
-    NmY3NGI2MjllOWNmY2U0MDk5NzZmNTQzMDgxNTI3NjI5ZDc4N2NjYTAwYTg3
-    ODMyMjk4MWVjYzA2MDA4MjA3NGQ3NTI3ZmY1NTVkNzFlNjkwMjZjZTA0ZjAy
-    Y2Y2ODFiM2M0MzY4MTExNTJmOGExZDdlNTg0MGU0Yzc2MjFiZDA=
-  data.tar.gz: !binary |-
-    MTg2NjZmMGY2YjVmZmUzMWI4OTM4ZWJhNWUxYzQ3ZTFhYzY4MjJlMTBjYTQx
-    NTQ1NDQ3NmNiNWM3NDJkMGQ5ZDMwZTU3YjJiYTZjMTA5YTliZmM4NDQ0OTUz
-    N2I0YjQ3ZGY4ZWZjNjZkZTZhMDM0YWVkZmY5Zjg2YmNhNDM3N2E=
+  metadata.gz: 4395ab2c7e9d539c6578d092be1dc979a2b2ea0cc5e07e1fa2201d3cd1c9aac59f9cc4c6bd2758fd72a11c038eb684db732c41e97339a6a30ce1be1372c5908d
+  data.tar.gz: cfd9c380d43b4b1cd1e247f9cd48d7c4365b564c6b42dc122b1e564ddc6f536e2f7669c29143100a0fa9b5bcfb3b15e971b348190f84494c0be6c7b87e4fffb9

data/.ruby-version

@@ -1 +1 @@
-1.9.3
+2.2.3

data/Gemfile.lock

@@ -1,51 +1,88 @@
 PATH
   remote: .
   specs:
-    ebay_client (0.0.1)
+    ebay_client (0.2.0)
       activesupport (>= 3.1.0)
-      savon (~> 0.9.9)
+      savon (>= 2.0.0)
 
 GEM
-  remote: http://rubygems.org/
+  remote: https://rubygems.org/
   specs:
-    activesupport (3.2.3)
-      i18n (~> 0.6)
-      multi_json (~> 1.0)
-    akami (1.0.0)
+    activesupport (4.2.5.1)
+      i18n (~> 0.7)
+      json (~> 1.7, >= 1.7.7)
+      minitest (~> 5.1)
+      thread_safe (~> 0.3, >= 0.3.4)
+      tzinfo (~> 1.1)
+    addressable (2.4.0)
+    akami (1.3.1)
       gyoku (>= 0.4.0)
-    builder (3.0.0)
-    columnize (0.3.6)
-    debugger (1.1.1)
-      columnize (>= 0.3.1)
-      debugger-linecache (~> 1.1)
-      debugger-ruby_core_source (~> 1.1)
-    debugger-linecache (1.1.1)
-      debugger-ruby_core_source (>= 1.1.1)
-    debugger-ruby_core_source (1.1.2)
-    gyoku (0.4.4)
+      nokogiri
+    builder (3.2.2)
+    crack (0.4.3)
+      safe_yaml (~> 1.0.0)
+    diff-lcs (1.2.5)
+    docile (1.1.5)
+    gyoku (1.3.1)
       builder (>= 2.1.2)
-    httpi (0.9.6)
+    hashdiff (0.2.3)
+    httpi (2.4.1)
       rack
-    i18n (0.6.0)
-    multi_json (1.3.2)
-    nokogiri (1.5.2)
-    nori (1.1.0)
-    rack (1.4.1)
-    savon (0.9.9)
-      akami (~> 1.0)
+    i18n (0.7.0)
+    json (1.8.3)
+    mini_portile2 (2.0.0)
+    minitest (5.8.4)
+    nokogiri (1.6.7.2)
+      mini_portile2 (~> 2.0.0.rc2)
+    nori (2.6.0)
+    rack (1.6.4)
+    rspec (3.4.0)
+      rspec-core (~> 3.4.0)
+      rspec-expectations (~> 3.4.0)
+      rspec-mocks (~> 3.4.0)
+    rspec-core (3.4.1)
+      rspec-support (~> 3.4.0)
+    rspec-expectations (3.4.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.4.0)
+    rspec-mocks (3.4.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.4.0)
+    rspec-support (3.4.1)
+    safe_yaml (1.0.4)
+    savon (2.11.1)
+      akami (~> 1.2)
       builder (>= 2.1.2)
-      gyoku (>= 0.4.0)
-      httpi (~> 0.9)
-      nokogiri (>= 1.4.0)
-      nori (~> 1.1)
-      wasabi (~> 2.1)
-    wasabi (2.1.0)
+      gyoku (~> 1.2)
+      httpi (~> 2.3)
       nokogiri (>= 1.4.0)
+      nori (~> 2.4)
+      wasabi (~> 3.4)
+    simplecov (0.11.1)
+      docile (~> 1.1.0)
+      json (~> 1.8)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.0)
+    thread_safe (0.3.5)
+    tzinfo (1.2.2)
+      thread_safe (~> 0.1)
+    wasabi (3.5.0)
+      httpi (~> 2.0)
+      nokogiri (>= 1.4.2)
+    webmock (1.22.6)
+      addressable (>= 2.3.6)
+      crack (>= 0.3.2)
+      hashdiff
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   bundler
-  debugger
   ebay_client!
+  rspec
+  simplecov
+  webmock
+
+BUNDLED WITH
+   1.10.6

data/README.md

@@ -10,7 +10,7 @@ Installation
 
 `Gemfile`:
 
-    gem 'ebay_client', '~> 0.1.0'
+    gem 'ebay_client', '~> 0.2.0'
 
 `config/ebay_client.yml`:
 

data/config/defaults.yml

@@ -1,20 +1,21 @@
 defaults: &defaults
-  version: 809
+  version: 949
   # use local file as default
-  #wsdl_file: 'http://developer.ebay.com/webservices/809/eBaySvc.wsdl'
+  #wsdl_file: 'http://developer.ebay.com/webservices/949/eBaySvc.wsdl'
   routing: default
   siteid: 0
   preload: false
   warning_level: Low
   error_language: en_US
   api_keys: []
-  savon_log_level: debug
+  savon_log_level: :debug
+  http_read_timeout: 600
 
 development: &development
   <<: *defaults
   url: 'https://api.sandbox.ebay.com/wsapi'
   warning_level: High
-  savon_log_level: info
+  savon_log_level: :debug
 
 test:
   <<: *development
@@ -23,3 +24,4 @@ production:
   <<: *defaults
   url: 'https://api.ebay.com/wsapi'
   preload: true
+  savon_log_level: :info

data/ebay_client.gemspec

@@ -1,29 +1,29 @@
 # -*- encoding: utf-8 -*-
-$:.push File.expand_path("../lib", __FILE__)
-require "ebay_client/version"
+$:.push File.expand_path('../lib', __FILE__)
+require 'ebay_client/version'
 
 Gem::Specification.new do |s|
-  s.name        = "ebay_client"
+  s.name        = 'ebay_client'
   s.version     = EbayClient::VERSION
   s.platform    = Gem::Platform::RUBY
-  s.date        = Time.now.strftime("%Y-%m-%d")
-  s.authors     = ["Marian Theisen"]
-  s.email       = 'marian.theisen@kayoom.com'
-  s.summary     = "Ebay Trading API Client"
-  s.homepage    = "http://github.com/kayoom/ebay_client"
-  s.description = "Simple, lightweight eBay Trading API Client"
-  s.license     = "MIT"
-  s.metadata    = {
-    'issue_tracker' => 'https://github.com/kayoom/ebay_client/issues'
-  }
+  s.date        = Time.now.strftime('%Y-%m-%d')
+  s.authors     = ['Marian Theisen','Burkhard Vogel-Kreykenbohm']
+  s.email       = ['marian.theisen@kayoom.com','b.vogel@buddyandselly.com']
+  s.summary     = 'Ebay Trading API Client'
+  s.homepage    = 'http://github.com/kayoom/ebay_client'
+  s.description = 'Simple, lightweight eBay Trading API Client'
+  s.license     = 'MIT'
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
-  s.require_paths = ["lib"]
+  s.require_paths = ['lib']
 
-  s.add_dependency "activesupport", ">= 3.1.0"
-  s.add_dependency "savon", "< 2.0.0"
+  s.add_dependency 'activesupport', '>= 3.1.0'
+  s.add_dependency 'savon', '>= 2.0.0'
 
-  s.add_development_dependency "bundler"
+  s.add_development_dependency 'bundler'
+  s.add_development_dependency 'rspec'
+  s.add_development_dependency 'webmock'
+  s.add_development_dependency 'simplecov'
 end

data/lib/ebay_client/api.rb

@@ -2,36 +2,51 @@ require 'savon'
 require 'gyoku'
 require 'ebay_client/response'
 
-class EbayClient::Api < ActiveSupport::BasicObject
+class EbayClient::Api < ActiveSupport::ProxyObject
   attr_reader :configuration, :endpoint, :namespace, :header, :client, :calls
 
-  def initialize configuration
+  def initialize(configuration)
     @configuration = configuration
     @endpoint = ::EbayClient::Endpoint.new configuration
     @namespace = :urn
     @header = ::EbayClient::Header.new configuration, namespace
-    @client = ::Savon::Client.new configuration.wsdl_file
-    @client.http.read_timeout = 600
+    @logger = (defined?(Rails) && Rails.respond_to?(:logger) ? Rails.logger : ::Logger.new(::STDOUT))
+    @client = ::Savon.client(
+      :wsdl => configuration.wsdl_file,
+      :read_timeout => configuration.http_read_timeout,
+      :namespaces => {'xmlns:urn' => 'urn:ebay:apis:eBLBaseComponents'},
+      :convert_request_keys_to => :camelcase,
+      :log => true,
+      :logger => @logger,
+      :log_level => configuration.savon_log_level,
+    )
     @calls = 0
 
-    ::Gyoku.convert_symbols_to :camelcase
     create_methods if configuration.preload?
   end
 
-  def dispatch name, body
+  def dispatch(name, body, fail_on_error = false)
     request = ::EbayClient::Request.new self, name, body
+    response = nil
 
     @calls += 1
     begin
-      request.execute
-    rescue ::EbayClient::Response::Error.for_code('218050') => e
-      @configuration.next_key!
-      request.execute
+      response = request.execute
+      response.raise_failure if fail_on_error && response.failure?
+    rescue ::EbayClient::Response::Exception => e
+      if e.code == '218050'
+        @configuration.next_key!
+        response = request.execute
+      else
+        @logger.error e.to_s unless @logger.nil? || !@logger.respond_to?(:error)
+        raise e
+      end
     end
+    response
   end
 
-  def dispatch! name, body
-    dispatch(name, body).payload!
+  def dispatch!(name, body)
+    dispatch(name, body, true).payload
   end
 
   def inspect
@@ -43,7 +58,7 @@ class EbayClient::Api < ActiveSupport::BasicObject
   def create_methods
     api_methods = ::Module.new
 
-    client.wsdl.soap_actions.each do |action|
+    client.operations.each do |action|
       name = action.to_s.gsub(/e_bay_/, '_ebay_')
 
       api_methods.send :define_method, name do |*args|
@@ -58,9 +73,9 @@ class EbayClient::Api < ActiveSupport::BasicObject
     api_methods.send :extend_object, self
   end
 
-  def method_missing name, *args, &block
-    if name.to_s[-1,1] == '!'
-      dispatch! name, args.first
+  def method_missing(name, *args, &block)
+    if name.to_s[-1, 1] == '!'
+      dispatch! name[0..-2], args.first
     else
       dispatch name, args.first
     end

data/lib/ebay_client/configuration.rb

@@ -2,16 +2,16 @@ class EbayClient::Configuration
   class ApiKey
     attr_accessor :appid, :devid, :certid, :token
 
-    def initialize key_values
+    def initialize(key_values)
       key_values.each do |key, val|
         instance_variable_set "@#{key}", val
       end
     end
   end
 
-  attr_accessor :version, :siteid, :routing, :url, :api_keys, :warning_level, :error_language, :current_key, :savon_log_level
+  attr_accessor :version, :siteid, :routing, :url, :api_keys, :warning_level, :error_language, :current_key, :savon_log_level, :http_read_timeout
 
-  def initialize presets
+  def initialize(presets)
     presets.each do |key, val|
       instance_variable_set "@#{key}", val
     end
@@ -53,7 +53,7 @@ class EbayClient::Configuration
   end
 
   class << self
-    def load file
+    def load(file)
       defaults = load_defaults
       configs = YAML.load_file file
 

data/lib/ebay_client/endpoint.rb

@@ -1,22 +1,22 @@
 class EbayClient::Endpoint
   attr_reader :configuration
 
-  def initialize configuration
+  def initialize(configuration)
     @configuration = configuration
   end
 
-  def url_for action
+  def url_for(action)
     url_base + action.to_s
   end
 
   def url_base
-    @url_base ||= [
+    [
       configuration.url,
       params_base
     ].join
   end
 
   def params_base
-    @params_base ||= "?appid=#{configuration.appid}&siteid=#{configuration.siteid}&version=#{configuration.version}&routing=#{configuration.routing}&callname="
+    "?appid=#{configuration.appid}&siteid=#{configuration.siteid}&version=#{configuration.version}&routing=#{configuration.routing}&callname="
   end
 end

data/lib/ebay_client/engine.rb

@@ -9,12 +9,6 @@ module EbayClient
       configuration = configurations[Rails.env]
 
       EbayClient.api = EbayClient::Api.new configuration
-
-      ::Savon.configure do |config|
-        config.log = true
-        config.logger = Rails.logger
-        config.log_level = configuration.savon_log_level
-      end
     end
   end
 end

data/lib/ebay_client/header.rb

@@ -1,7 +1,7 @@
 class EbayClient::Header
   attr_reader :configuration, :namespace
 
-  def initialize configuration, namespace
+  def initialize(configuration, namespace)
     @configuration = configuration
     @namespace = namespace
   end
@@ -20,7 +20,7 @@ class EbayClient::Header
   end
 
   protected
-  def ns_key key
+  def ns_key(key)
     "#{namespace}:#{key}"
   end
 end

data/lib/ebay_client/request.rb

@@ -1,5 +1,5 @@
 class EbayClient::Request
-  def initialize api, name, body
+  def initialize(api, name, body)
     @api = api
     @name = name
     @body = body || {}
@@ -9,6 +9,10 @@ class EbayClient::Request
     @normalized_name ||= @name.to_s.camelcase.gsub(/ebay/i, 'eBay')
   end
 
+  def name_symbol
+    @name_sym ||= @name.to_s.gsub(/_ebay_/i, 'e_bay_').to_sym
+  end
+
   def normalized_body
     @normalized_body ||= @body.to_hash.merge body_defaults
   end
@@ -27,14 +31,18 @@ class EbayClient::Request
   end
 
   def execute_request
-    @api.client.request(@api.namespace, normalized_name + 'Request') do |soap|
-      soap.endpoint = @api.endpoint.url_for normalized_name
-      soap.header = @api.header.to_hash
-      soap.body = normalized_body
-    end
+    @api.client.set_endpoint @api.endpoint.url_for normalized_name
+    @api.client.call(name_symbol, soap_header:  @api.header.to_hash, message: normalized_body)
   end
 
-  def read_response response_body
+  def read_response(response_body)
     EbayClient::Response.new response_body.values.first
   end
 end
+
+# We need to monkey-patch savon to be able to alter the endpoint on each call
+class Savon::Client
+  def set_endpoint(endpoint)
+    @globals[:endpoint] = endpoint
+  end
+end