ebay-finding-api 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9bfcc47fce886638f162cf550cd97ba2b60ebbbceb9cec12ca1c0c5bb10e23a8
-  data.tar.gz: c4dc66eb1789960aa4ce1290b5c37223fa1023ca3410edb890180c9ed9b9fce6
+  metadata.gz: 138cd0fdefa75ca5ed2505554c22090351a6564a97ace1174011438d85b1b8d9
+  data.tar.gz: 51ac371b1fcc262f8b1b8ad66ac8dbcb26c2d45e635dd1e091f4badf81a81e80
 SHA512:
-  metadata.gz: cfd7a820e6ff161c9c9776dfa36b0efc55d13fadbfaaa7796372c9c24a0d7b81c66908443d20984b0825a3a08923abb1fafa3701dbf4b806870769164e3f9a03
-  data.tar.gz: 32cd9887030688bf08194f2e9853ad90b426019bfc4635c05a28cd852ed510edbc675b3c9b3be9523681cd651ad425fbaa9ba908271f1c936f2a1064c39220c1
+  metadata.gz: ae88581f2067bb13e4d2e7ded6fcfec7902ebc1a26eb0010a4996ab1ab7a9fe4b53155727ad04a98017d25974976354c8d2b8e51656f28430081aec58faccc62
+  data.tar.gz: 12fb3cbe62c5272951104a588c1756b3bf06256abb9f688f33877fa7651262ec9f8008cf8952b30d4465ac5f7767d2b47d7507d1e96daacb1076076210d73f20

data/lib/ebay/finding/api.rb

@@ -11,3 +11,4 @@ end
 require "ebay/finding/api/version"
 require "ebay/finding/api/client"
 require "ebay/finding/api/response"
+require "ebay/finding/api/error"

data/lib/ebay/finding/api/client.rb

@@ -2,19 +2,33 @@ module Ebay::Finding::Api
   PRODUCTION_ENDPOINT = "https://svcs.ebay.com"
   SANDBOX_ENDPOINT    = "https://svcs.sandbox.ebay.com"
   SERVICE_VERSION     = "1.13.0"
+  PRODUCT_TYPES       = %w(ISBN UPC EAN ReferenceID)
 
   class Client
     def initialize(app_id, sandbox = true)
       @app_id  = app_id
       @sandbox = sandbox
+      @base_options = { "SECURITY-APPNAME" => @app_id, "SERVICE-VERSION" => SERVICE_VERSION, "REST-PAYLOAD" => "TRUE",
+                        "RESPONSE-DATA-FORMAT" => "JSON" }
     end
 
     def find_items_by_keywords(keyword)
       operation_name = "findItemsByKeywords"
-      options = { "OPERATION-NAME" => operation_name, "SERVICE-VERSION" => SERVICE_VERSION, "REST-PAYLOAD" => "TRUE",
-                  "SECURITY-APPNAME" => @app_id, "RESPONSE-DATA-FORMAT" => "JSON", "keywords" => keyword }
+      options = @base_options.merge("OPERATION-NAME" => operation_name, "keywords" => keyword)
 
-      Response.new(operation_name, connection.get("/ervices/search/FindingService/v1", options))
+      Response.new(operation_name, connection.get("/services/search/FindingService/v1", options))
+    end
+
+    def find_items_by_product(type, product_id)
+      operation_name = "findItemsByProduct"
+
+      unless PRODUCT_TYPES.include? type
+        raise ArgumentError.new("You need to pass string 'ISBN', 'UPC', 'EAN' or 'ReferenceID' to first argument")
+      end
+      options = @base_options.merge("OPERATION-NAME" => operation_name, "productId.@type" => type,
+                                    "productId" => product_id)
+
+      Response.new(operation_name, connection.get("/services/search/FindingService/v1", options))
     end
 
     private

data/lib/ebay/finding/api/error.rb

@@ -0,0 +1,7 @@
+module Ebay::Finding::Api
+  class Error < StandardError
+  end
+
+  class ArgumentError < Error
+  end
+end

data/lib/ebay/finding/api/response.rb

@@ -10,7 +10,11 @@ module Ebay::Finding::Api
     def items
       return [] unless success?
 
-      @items ||= JSON.parse(@response.body)["#{@key_name}Response"].first["searchResult"]
+      result = JSON.parse(@response.body)["#{@key_name}Response"].first["searchResult"].first
+
+      return [] if result["@count"] === "0"
+
+      @items ||= result["item"]
     end
 
     def success?

data/lib/ebay/finding/api/version.rb

@@ -1,7 +1,7 @@
 module Ebay
   module Finding
     module Api
-      VERSION = "0.1.0"
+      VERSION = "0.1.1"
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ebay-finding-api
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - camelmasa
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-05-13 00:00:00.000000000 Z
+date: 2018-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -85,6 +85,7 @@ files:
 - ebay-finding-api.gemspec
 - lib/ebay/finding/api.rb
 - lib/ebay/finding/api/client.rb
+- lib/ebay/finding/api/error.rb
 - lib/ebay/finding/api/response.rb
 - lib/ebay/finding/api/version.rb
 homepage: https://github.com/camelmasa/ebay-finding-api