eb_deployer 0.0.4 → 0.0.5

data/lib/eb_deployer/deployment_strategy.rb

@@ -26,7 +26,7 @@ module EbDeployer
 
       def deploy(version_label, env_settings)
         if !envs.any?(&method(:active_env?))
-          env('blue', @major_cname_prefix).
+          env('a', @major_cname_prefix).
             deploy(version_label, env_settings)
           return
         end
@@ -44,11 +44,11 @@ module EbDeployer
       end
 
       def envs
-        [env('blue'), env('green')]
+        [env('a'), env('b')]
       end
 
-      def env(color, cname_prefix=nil)
-        Environment.new(@app, @env_name + '-' + color, @eb_driver,
+      def env(suffix, cname_prefix=nil)
+        Environment.new(@app, @env_name + '-' + suffix, @eb_driver,
                         :solution_stack => @solution_stack,
                         :cname_prefix => cname_prefix || inactive_cname_prefix,
                         :smoke_test => @smoke_test)

data/lib/eb_deployer/environment.rb

@@ -1,9 +1,16 @@
 module EbDeployer
   class Environment
     attr_reader :app, :name
+
+    def self.unique_ebenv_name(app_name, env_name)
+      raise "Environment name #{env_name} is too long, it must be under 15 chars" if env_name.size > 15
+      digest = Digest::SHA1.hexdigest(app_name + '-' + env_name)[0..6]
+      "#{env_name}-#{digest}"
+    end
+
     def initialize(app, env_name, eb_driver, creation_opts={})
       @app = app
-      @name = @app + '-' + env_name
+      @name = self.class.unique_ebenv_name(app, env_name)
       @bs = eb_driver
       @creation_opts = creation_opts
       @poller = EventPoller.new(@app, @name, @bs)
@@ -30,6 +37,14 @@ module EbDeployer
 
     private
 
+
+    def shorten(str, max_length, digest_length=5)
+      raise "max length (#{max_length}) should be larger than digest_length (#{digest_length})" if max_length < digest_length
+      return self if str.size <= max_length
+      sha1 = Digest::SHA1.hexdigest(str)
+      sha1[0..(digest_length - 1)] + str[(max_length - digest_length - 1)..-1]
+    end
+
     def create_or_update_env(version_label, settings)
       if @bs.environment_exists?(@app, @name)
         @bs.update_environment(@app, @name, version_label, settings)

data/lib/eb_deployer/version.rb

@@ -1,3 +1,3 @@
 module EbDeployer
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/test/aws_driver_stubs.rb

@@ -6,6 +6,7 @@ class EBStub
 
   def create_environment(app, env, solution_stack, cname_prefix, version, settings)
     raise 'cname prefix is not avaible' if @envs.values.detect { |env| env[:cname_prefix] == cname_prefix }
+    raise "env name #{env} is longer than 23 chars" if env.size > 23
     @envs[env_key(app, env)] = {
       :solution_stack => solution_stack,
       :version => version,

data/test/deploy_test.rb

@@ -19,30 +19,38 @@ class DeployTest < Minitest::Test
 
 
   def test_first_deployment_create_environment
-    assert !@eb_driver.environment_exists?('simple', 'simple-production')
+    assert !@eb_driver.environment_exists?('simple', eb_envname('simple', 'production'))
     deploy(:application => 'simple', :environment => "production")
-    assert @eb_driver.environment_exists?('simple', 'simple-production')
+    assert @eb_driver.environment_exists?('simple', eb_envname('simple', 'production'))
   end
 
+  def test_support_very_very_long_app_name
+    deploy(:application => 'ver-very-simple-application', :environment => "production")
+    assert @eb_driver.environment_exists?('ver-very-simple-application', eb_envname('ver-very-simple-application', 'production'))
+  end
+
+  def test_should_raise_error_when_env_name_is_too_long
+    assert_raises(RuntimeError) { deploy(:application => 'simple', :environment => "p" * 16) }
+  end
 
   def test_update_environment_with_new_version_should_change_version_that_deployed
     deploy(:application => 'simple',
            :environment => "production",
            :version_label => 1)
-    assert_equal '1', @eb_driver.environment_verion_label('simple', 'simple-production')
+    assert_equal '1', @eb_driver.environment_verion_label('simple', eb_envname('simple', 'production'))
 
     deploy(:application => 'simple',
            :environment => "production",
            :version_label => 2)
 
-    assert_equal '2', @eb_driver.environment_verion_label('simple', 'simple-production')
+    assert_equal '2', @eb_driver.environment_verion_label('simple', eb_envname('simple', 'production'))
   end
 
   def test_default_cname_that_deployed_should_app_env_name
     deploy(:application => 'simple',
            :environment => "production",
            :version_label => 42)
-    assert_equal "simple-production", @eb_driver.environment_cname_prefix('simple', 'simple-production')
+    assert_equal "simple-production", @eb_driver.environment_cname_prefix('simple', eb_envname('simple', 'production'))
   end
 
   def test_cname_prefix_can_be_override
@@ -50,10 +58,9 @@ class DeployTest < Minitest::Test
            :environment => "production",
            :cname_prefix => 'sports123',
            :version_label => 42)
-    assert_equal "sports123", @eb_driver.environment_cname_prefix('simple', 'simple-production')
+    assert_equal "sports123", @eb_driver.environment_cname_prefix('simple', eb_envname('simple', 'production'))
   end
 
-
   def test_smoke_test_should_be_run_after_env_created_or_update
     host_for_smoke_test = nil
     deploy(:application => 'simple',
@@ -81,8 +88,8 @@ class DeployTest < Minitest::Test
            :strategy => 'blue_green',
            :version_label => 42)
 
-    assert @eb_driver.environment_exists?('simple', 'simple-production-blue')
-    assert_equal 'simple-production',  @eb_driver.environment_cname_prefix('simple', 'simple-production-blue')
+    assert @eb_driver.environment_exists?('simple', eb_envname('simple', 'production-a'))
+    assert_equal 'simple-production',  @eb_driver.environment_cname_prefix('simple', eb_envname('simple', 'production-a'))
   end
 
 
@@ -97,8 +104,8 @@ class DeployTest < Minitest::Test
            :strategy => 'blue_green',
            :version_label => 43)
 
-    assert @eb_driver.environment_exists?('simple', 'simple-production-blue')
-    assert @eb_driver.environment_exists?('simple', 'simple-production-green')
+    assert @eb_driver.environment_exists?('simple', eb_envname('simple', 'production-a'))
+    assert @eb_driver.environment_exists?('simple', eb_envname('simple', 'production-b'))
   end
 
 
@@ -113,9 +120,9 @@ class DeployTest < Minitest::Test
            :strategy => 'blue_green',
            :version_label => 43)
 
-    assert_match(/simple-production-inactive/,  @eb_driver.environment_cname_prefix('simple', 'simple-production-blue'))
+    assert_match(/simple-production-inactive/,  @eb_driver.environment_cname_prefix('simple', eb_envname('simple', 'production-a')))
 
-    assert_equal 'simple-production',  @eb_driver.environment_cname_prefix('simple', 'simple-production-green')
+    assert_equal 'simple-production',  @eb_driver.environment_cname_prefix('simple', eb_envname('simple', 'production-b'))
 
 
     deploy(:application => 'simple',
@@ -123,9 +130,9 @@ class DeployTest < Minitest::Test
            :strategy => 'blue_green',
            :version_label => 44)
 
-    assert_match(/simple-production-inactive/,  @eb_driver.environment_cname_prefix('simple', 'simple-production-green'))
+    assert_match(/simple-production-inactive/,  @eb_driver.environment_cname_prefix('simple', eb_envname('simple', 'production-b')))
 
-    assert_equal 'simple-production',  @eb_driver.environment_cname_prefix('simple', 'simple-production-blue')
+    assert_equal 'simple-production',  @eb_driver.environment_cname_prefix('simple', eb_envname('simple', 'production-a'))
   end
 
 
@@ -144,4 +151,10 @@ class DeployTest < Minitest::Test
                   'simple-production-inactive.elasticbeanstalk.com',
                   'simple-production-inactive.elasticbeanstalk.com'], smoked_host
   end
+
+  private
+
+  def eb_envname(app_name, env_name)
+    EbDeployer::Environment.unique_ebenv_name(app_name, env_name)
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: eb_deployer
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors: