eaternet 0.3.7 → 0.3.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 69d5ee1ad12b2a3330be98c3536fc6ff2dfcb6cb
-  data.tar.gz: e5303a438a035a75f920f9bb9dccbbb7cfe33cbf
+  metadata.gz: ff6175db527668d8bd514bb319d2e13208518be4
+  data.tar.gz: 1a6230beb016725a566d0ab090d599859dd13c4c
 SHA512:
-  metadata.gz: 8c603eaa53c4ac06e76d1b9804291e252ace7af9dd956bc19aaca529bba08fcc30dc456149596d282dcadcc43a5908c875609c80d0facefc1469fea6aab284f3
-  data.tar.gz: e125485f3ee7cc6e05b55e2a7b14b0df06a8257746161665aae8b3bc6c14989612460e422cf58eb2dbc86262052be48384ff6d7d847d87530c50b3addcfc4cc7
+  metadata.gz: 31841f71e071ae88ff56be7eb528c488bfe7c4471274f4d54e5772be869b656007b88f83d9cdae955919e2448fc9961abdc52236375be8cf92624fc9b08ae101
+  data.tar.gz: 7bfd07a732ebfd9db5723328d64e342f49197bc3ca75fd55b518daba2c7be645d086cb1e52320db695d1bfa6f4ac5a7bb773fec14f9ac835d615045abcb3d864

data/lib/eaternet/agencies/nyc.rb

@@ -94,7 +94,7 @@ module Eaternet
       end
 
 
-      private
+      # private
 
       def try_to_create_business(row)
         business(row)
@@ -115,11 +115,13 @@ module Eaternet
       end
 
       def business(row)
+        address = "#{cleanup(row['BUILDING'])} #{cleanup(row['STREET'])}"
+        
         Business.new do |b|
           b.business_id = business_id(row)
-          b.name = row['DBA']
-          b.address = "#{row['BUILDING']} #{row['STREET']}"
-          b.city = row['BORO']
+          b.name = row['DBA'].titleize
+          b.address = address.titleize
+          b.city = row['BORO'].titleize
           b.postal_code = row['ZIPCODE']
           b.state = 'NY'
           b.phone_number = row['PHONE']
@@ -205,6 +207,10 @@ module Eaternet
       def self.download_via_url(a_file)
         a_file.write(open(CSV_URL).read)
       end
+
+      def cleanup(a_string)
+        a_string.strip.gsub(/ +/, ' ')
+      end
     end
   end
 end

data/lib/eaternet/version.rb

@@ -1,3 +1,3 @@
 module Eaternet
-  VERSION = '0.3.7'
+  VERSION = '0.3.8'
 end

data/test/eaternet/nyc_adapter_test.rb

@@ -9,6 +9,18 @@ MORRIS_PARK_CSV = 'test/fixtures/morris-park-bake-shop.csv'
 class NycAdapterTest < Minitest::Test
   @@nyc = Eaternet::Nyc.new(csv_path: MORRIS_PARK_CSV)
 
+  def setup
+    @may_may_data = {
+      'CAMIS' =>    '40358429',
+      'DBA' =>      'MAY MAY KITCHEN',
+      'BUILDING' => '1269      ',
+      'STREET' =>   'SUTTER AVENUE                                     ',
+      'BORO' =>     'BROOKLYN',
+      'ZIPCODE' =>  '11208',
+      'PHONE' =>    '7182354485'
+    }
+  end
+
   #
   # Businesses
   #
@@ -20,9 +32,9 @@ class NycAdapterTest < Minitest::Test
   def test_businesses_returns_lives_attributes
     b = @@nyc.businesses.first
     assert_equal '30075445', b.business_id
-    assert_equal 'MORRIS PARK BAKE SHOP', b.name
-    assert_equal '1007 MORRIS PARK AVE', b.address
-    assert_equal 'BRONX', b.city
+    assert_equal 'Morris Park Bake Shop', b.name
+    assert_equal '1007 Morris Park Ave', b.address
+    assert_equal 'Bronx', b.city
     assert_equal '10462', b.postal_code
     assert_equal 'NY', b.state
     assert_equal '7188924968', b.phone_number
@@ -32,6 +44,17 @@ class NycAdapterTest < Minitest::Test
     assert_equal 1, @@nyc.businesses.to_a.size
   end
 
+  def test_cleans_up_whitespace_1
+    b = @@nyc.business(@may_may_data)
+    assert_equal '1269 Sutter Avenue', b.address
+  end
+
+  def test_cleans_up_whitespace_2
+    @may_may_data['STREET'] = 'EAST   52 STREET                                  '
+    b = @@nyc.business(@may_may_data)
+    assert_equal '1269 East 52 Street', b.address
+  end
+
   #
   # Inspections
   #

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: eaternet
 version: !ruby/object:Gem::Version
-  version: 0.3.7
+  version: 0.3.8
 platform: ruby
 authors:
 - Robb Shecter