easy_rails_money 0.0.4 → 0.0.5

data/.gitignore

@@ -19,6 +19,10 @@ _yardoc
 doc/
 rdoc
 
+# temporary emacs files
+\#*
+\.\#*
+
 .rvmrc
 .ruby-version
 .ruby-gemset

data/CHANGELOG.md

@@ -21,3 +21,12 @@
 
 ## 0.0.4
 - add dsl with_currency for defining a single currency on the model
+
+## 0.0.5
+- bugfix: defining a model before the table is created throws an error  
+  see spec tagged with `migration`.  
+  if we define a ActiveRecord object with a money column  
+  "before" the table is defined. Then it will throw  
+  an error and we will assume that a single  
+  currency is defined. So always restart the app after the  
+  migrations are run.  

data/README.md

@@ -361,3 +361,10 @@ loan_usd.currency # equals Money::Currency.new(:usd)
 11. the column names are suffixed with ```_money``` and ```_currency```  
     We need this for now, to reflect on the database scheme. 
     Ideally should be able to read the metadata from rails scheme cache.  
+12. see spec tagged with `migration`.  
+    if we define a ActiveRecord object with a money column  
+    "before" the table is defined. Then it will throw  
+    an error and we will assume that a single  
+    currency is defined. So always restart the app after the  
+    migrations are run.  
+    Any better way ?  

data/lib/easy_rails_money/active_record/money_dsl.rb

@@ -10,7 +10,17 @@ module EasyRailsMoney
         attr_accessor :single_currency
 
         def single_currency?
+          # if we define a ActiveRecord object with a money column
+          # "before" the table is defined. Then it will throw an error
+          # and we will assume that a single currency is defined
+          # So always restart the app after the migrations are run
           self.columns_hash.has_key? "currency"
+        rescue ::ActiveRecord::StatementInvalid => err
+          if err.message =~ /Could not find table/
+            return true
+          else
+            raise
+          end
         end
         
         def with_currency currency, &block

data/lib/easy_rails_money/version.rb

@@ -1,3 +1,3 @@
 module EasyRailsMoney
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/active_record/migration_spec.rb

@@ -1,6 +1,5 @@
 require 'spec_helper'
 require 'active_record_spec_helper'
-require 'tempfile'
 require 'active_record/schema_dumper'
 
 # migrations used in tests. our factories/fixtures
@@ -233,7 +232,7 @@ EOF
   end
 EOF
   end
-
+  
   context "and testing schema statements", :schema_statements do
     context "which have one currency column for each money column" do
       before(:each) do

data/spec/active_record/money_dsl_spec.rb

@@ -26,6 +26,22 @@ describe "Money DSL" do
   describe "#money" do
     # validations
 
+    # the #money dsl queries the database schema to find out if a
+    # single-currency column is defined. or does every money column
+    # have its own currency column. If no table exists we assume that
+    # a single currency column exists (so that no error is thrown).
+    # for this to work, the app has to be reloaded after the migration
+    # is run
+    it "does not throw an error if a model is defined without the table being created ie. before the migration runs", :fixme, :migration do
+      expect(dump_schema).to be_blank
+      expect {
+        class Loan < ActiveRecord::Base
+          attr_accessible :name
+          money :principal
+        end
+      }.to_not raise_error
+    end
+    
     context "individual currency columns" do
       before(:each) do
         migrate CreateTableDefinition::CreateLoanWithoutCurrency

data/spec/active_record_spec_helper.rb

@@ -1,3 +1,5 @@
+require 'tempfile'
+
 module CreateTableDefinition
   class CreateLoanWithCurrency < ActiveRecord::Migration
     def change

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: easy_rails_money
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-05 00:00:00.000000000 Z
+date: 2013-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: money
@@ -242,7 +242,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2090962941235077945
+      hash: 539753263843198908
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -251,7 +251,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2090962941235077945
+      hash: 539753263843198908
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24