easy_meli 0.6.1 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8c8dc1140d9368b076baf0a49a9742aea8de95565a90512152c9c58ec2b98723
-  data.tar.gz: 543cbed2c4789b0259b62f11d332a02c3b5b281feb2c5b60c5f87fd8640c0754
+  metadata.gz: bc240e7ae7a827cff6460162be1a9460f5e860676f3800a50d18ae3558f2976e
+  data.tar.gz: 714503d3e3886b1d491d1ea579d72f1d74e2408d476b9ada5ee6446f0efbb467
 SHA512:
-  metadata.gz: c2a7ecfa32beed3a9329b01312b1cfd4ed70fceb26469dc90e8d0d2c3b42186a9c1ec06f115f1dc5fa15236aa48d99b7e074a089fad7f710bddaf2bcb324680a
-  data.tar.gz: dfc01a8544c0f2d23711888fdfa3fb6a6f6f68196782d41cb501c1f50d53900882fb5c1b8d7a9f88e610eb1fafc8112447943ff87b8793af7fccd29e800a6d17
+  metadata.gz: 7004c03b3ec4be44170bb4ea92c5ac2595ddd5d244a7e680a88e67d5bdc9eec0197ae7a7bd0970ac78d0912e42f04b9b44a65ee907e5333db479f569753853b2
+  data.tar.gz: 139f426a07c7782b73ea52959283b70e068f8565d9c5e646790cd7f3373b51eed3f3e179d418a72ddf746012c13f4ea735a133c023b59da4c6d8d24aed38ab91

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## V 0.6.2
+- Update Error classification mechanism to use error message as first option
+
 ## V 0.6.1
 - Fix a bug in the error raising in the authorization client introduced in V 0.6.0
 

data/lib/easy_meli/api_client.rb

@@ -6,14 +6,11 @@ class EasyMeli::ApiClient
   API_ROOT_URL = 'https://api.mercadolibre.com'
 
   ERROR_LIST = {
-    'invalid_grant' => EasyMeli::InvalidGrantError,
+    'Error validating grant' => EasyMeli::InvalidGrantError,
     'forbidden' => EasyMeli::ForbiddenError,
     'invalid_token' => EasyMeli::InvalidTokenError,
-    'Malformed access_token' => EasyMeli::MalformedTokenError
-  }
-
-  STATUS_ERRORS = {
-    429 => EasyMeli::TooManyRequestsError
+    'Malformed access_token' => EasyMeli::MalformedTokenError,
+    'too_many_requests' => EasyMeli::TooManyRequestsError
   }
 
   base_uri API_ROOT_URL
@@ -51,30 +48,27 @@ class EasyMeli::ApiClient
 
     self.class.send(verb, path, params.merge(query)).tap do |response|
       logger&.log response
-      check_authentication(response)
-      check_status(response)
+      check_for_errors(response)
     end
   end
 
-  def check_authentication(response)
-    response_message = error_message_from_body(response.to_h) if response.parsed_response.is_a? Hash
-    return if response_message.to_s.empty?
+  def check_for_errors(response)
+    return unless response.parsed_response.is_a? Hash
 
-    ERROR_LIST.keys.each do |key|
-      if response_message.include?(key)
-        exception = ERROR_LIST[key]
-        raise exception.new(response)
-      end
+    exception = error_class(response)
+
+    if exception
+      raise exception.new(response)
     end
   end
 
-  def error_message_from_body(body)
-    return if body.nil?
-    body['error'].to_s.empty? ? body['message'] : body['error']
+  def error_class(body)
+    ERROR_LIST.find { |key, _| error_message_from_body(body).include?(key) }&.last
   end
 
-  def check_status(response)
-    status_error = STATUS_ERRORS[response.code]
-    raise status_error.new(response) if status_error
+  def error_message_from_body(response)
+    return if response.body.nil?
+
+    response['message'].to_s.empty? ? response['error'] : response['message']
   end
 end

data/lib/easy_meli/version.rb

@@ -1,3 +1,3 @@
 module EasyMeli
-  VERSION = "0.6.1"
+  VERSION = "0.6.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: easy_meli
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - Eric Northam
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-01-27 00:00:00.000000000 Z
+date: 2021-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty