easy-resources 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3848905fec923b2461ca35dab3f43d13f9e690c36a43dafe03e0cfa37ab39775
-  data.tar.gz: db2a4779b7c4774ee382e21cc79366f510f4af2c4cb23caec61c9f70748ae200
+  metadata.gz: fdaa3a94f0e1549a33bfe6e3c9401824ed0ae9937b8be66e75efb2c1bb64c89e
+  data.tar.gz: bda0af2d019e2e28ea1236344d038b3fd59a2459da0b0bb83bbcd73a204ed8ee
 SHA512:
-  metadata.gz: 3b613b8e5910f904790aeee7bdce6bfb2245e46ccc7a9f07ff98c534f93b1c42b22dbfb37a8bfabcb0b0204f64d4edcc26572b7d13ad82cc332ee6aaa57f4ba1
-  data.tar.gz: 42e293bf5b410c0b2b7917bb3c2311a34e030c6a791f6268d776b2f1dfb430fcf17cea2385d53b9497541656aa3163da3a9c5e0da7a6ec8f2af262a43117e5ed
+  metadata.gz: d02e7009079481c7b40730e126826f0288fec9f2abd454e05ab5ed1268c5c794802095fc63ed077be184ae7a0894f682b64aea716c30e31dccf4a2766fb7dc00
+  data.tar.gz: cbd2cc87d9d53f70367fb2b6604b67cda4c73becd7dbecebae5fc5c6a48f78bdf4637fcf679fe3be92531883146afb13af231f859967b9cd11f3db6a368a01a0

data/lib/easy/resources.rb

@@ -9,6 +9,8 @@ module Easy
   module Resources
     module Redmine
 
+      autoload :Errors, "easy/resources/redmine/errors"
+
       autoload :RedmineBase, "easy/resources/redmine/redmine_base"
       autoload :EasyAttendance, "easy/resources/redmine/easy_attendance"
       autoload :EasyContact, "easy/resources/redmine/easy_contact"

data/lib/easy/resources/redmine/errors.rb

@@ -0,0 +1,15 @@
+module Easy
+  module Resources
+    module Redmine
+      class Errors < ::ActiveResource::Errors
+
+        # Redmine in XML responses specify type="array" on Errors
+        # It cause that `Hash.from_xml` already parsed errors as a Array
+        def from_xml(xml, save_cache = false)
+          array = Array.wrap(Hash.from_xml(xml)["errors"]) rescue []
+          from_array array, save_cache
+        end
+      end
+    end
+  end
+end

data/lib/easy/resources/redmine/redmine_base.rb

@@ -26,10 +26,16 @@ module Easy
             h
           end
 
+          # Parse value of TOTAL amount of entities from headers or response
+          # @return [Integer]
+          def retrieve_total(response)
+            (response['Total'] || response.body[/total_count[:="]+(\d+)/] && $1).to_i
+          end
+
           def get_all(**params, &block)
             records      = results = all(params: params)
             response     = results.http_response
-            total        = response['Total'].to_i
+            total        = retrieve_total(response)
             current_page = 1
 
             while records.any?
@@ -46,6 +52,10 @@ module Easy
           end
 
         end
+
+        def errors
+          @errors ||= Errors.new(self)
+        end
       end
     end
   end

data/lib/easy/resources/version.rb

@@ -1,5 +1,5 @@
 module Easy
   module Resources
-    VERSION = '0.8.0'
+    VERSION = '0.8.1'
   end
 end

data/spec/fixtures/files/time_entry/invalid_update.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<errors type="array">
+  <error>Projekt je neplatné</error>
+</errors>

data/spec/models/easy-resources/redmine/errors_spec.rb

@@ -0,0 +1,15 @@
+RSpec.describe Easy::Resources::Redmine::Errors do
+  include_context "redmine active resource shares" do
+    let(:entity_name) { 'time_entry' }
+  end
+
+  it 'invalid request' do
+    stub_xml source_file: "invalid_update", path: "#{entity_name.pluralize}.xml", method: :post, status: 422, request_body: { hours: 8.0, user_id: 1 }.to_xml(root: "time_entry")
+
+    time_entry = Easy::Resources::Redmine::TimeEntry.new hours: 8.0, user_id: 1
+    expect(time_entry.save).to eq false
+    expect(time_entry.errors).to be_a described_class
+    expect(time_entry.errors.full_messages).to eq ["Projekt je neplatné"]
+  end
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: easy-resources
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - petr
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-29 00:00:00.000000000 Z
+date: 2020-06-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -142,6 +142,7 @@ files:
 - lib/easy/resources/redmine/easy_web_application.rb
 - lib/easy/resources/redmine/easy_web_application_activity.rb
 - lib/easy/resources/redmine/easy_web_hook.rb
+- lib/easy/resources/redmine/errors.rb
 - lib/easy/resources/redmine/issue.rb
 - lib/easy/resources/redmine/project.rb
 - lib/easy/resources/redmine/redmine_base.rb
@@ -168,6 +169,7 @@ files:
 - spec/fixtures/files/issue/show.xml
 - spec/fixtures/files/project.json
 - spec/fixtures/files/project/show.xml
+- spec/fixtures/files/time_entry/invalid_update.xml
 - spec/fixtures/files/time_entry/show.xml
 - spec/fixtures/files/user/show.xml
 - spec/models/easy-resources/redmine/easy_attendance_spec.rb
@@ -176,6 +178,7 @@ files:
 - spec/models/easy-resources/redmine/easy_server_spec.rb
 - spec/models/easy-resources/redmine/easy_web_application_activity_spec.rb
 - spec/models/easy-resources/redmine/easy_web_application_spec.rb
+- spec/models/easy-resources/redmine/errors_spec.rb
 - spec/models/easy-resources/redmine/issue_spec.rb
 - spec/models/easy-resources/redmine/project_spec.rb
 - spec/models/easy-resources/redmine/redmine_base_spec.rb
@@ -206,7 +209,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Summary of Easy::Resources.
@@ -221,6 +224,7 @@ test_files:
 - spec/models/easy-resources/redmine/easy_web_application_activity_spec.rb
 - spec/models/easy-resources/redmine/easy_web_application_spec.rb
 - spec/models/easy-resources/redmine/easy_server_spec.rb
+- spec/models/easy-resources/redmine/errors_spec.rb
 - spec/models/easy-resources/redmine/user_spec.rb
 - spec/models/easy-resources/redmine/easy_attendance_spec.rb
 - spec/models/easy-resources/resource_spec.rb
@@ -230,6 +234,7 @@ test_files:
 - spec/easy_resources_spec.rb
 - spec/fixtures/files/easy_contact/show.xml
 - spec/fixtures/files/time_entry/show.xml
+- spec/fixtures/files/time_entry/invalid_update.xml
 - spec/fixtures/files/easy_crm_case.json
 - spec/fixtures/files/easy_crm_case/show.xml
 - spec/fixtures/files/project.json