dzema_dm-counter-cache 0.9.12 → 0.9.12.1

data/History.txt

@@ -1,3 +1,7 @@
+=== 0.9.12.1 / 2009-11-19
+
+* Fix an error occured when parent object was deleted and child tries to adjust counter cache
+
 === 0.9.12 / 2009-11-15
 
 * Version without class_eval

data/Rakefile

@@ -13,7 +13,7 @@ AUTHOR = ['Saimon Moore', 'Dmitriy Dzema']
 EMAIL  = ['daimonmoore [a] gmail [d] com', 'dima [a] dzema [d] name']
 GEM_NAME = 'dzema_dm-counter-cache'
 GEM_VERSION = DataMapper::CounterCacheable::VERSION
-GEM_DEPENDENCIES = [['dm-core', "=#{GEM_VERSION}"]]
+GEM_DEPENDENCIES = [['dm-core', "=0.9.12"]]
 GEM_CLEAN = %w[ log pkg coverage ]
 GEM_EXTRAS = { :has_rdoc => true, :extra_rdoc_files => %w[ README.txt LICENSE TODO History.txt ] }
 

data/lib/dm-counter-cache.rb

@@ -67,6 +67,7 @@ module DataMapper
       protected
       def adjust_counter_cache_for(relationship, counter_cache_attribute, amount)
         association = get_association(relationship)
+        return if association.nil?
 
         return unless  relationship.parent_model.properties.has_property?(counter_cache_attribute)
         association.update_attributes(counter_cache_attribute => association.reload.__send__(counter_cache_attribute) + amount)

data/lib/dm-counter-cache/version.rb

@@ -1,5 +1,5 @@
 module DataMapper
   module CounterCacheable
-    VERSION = '0.9.12'
+    VERSION = '0.9.12.1'
   end
 end

data/spec/integration/dm-counter-cache_spec.rb

@@ -84,4 +84,12 @@ describe DataMapper::CounterCacheable do
     @group.reload.members_count.should == 1    
   end
 
+  it "should not try to adjust counter on nil relationship" do
+    comment = @post.comments.create
+    @post.destroy
+
+    lambda do
+      comment.reload.destroy
+    end.should_not raise_error(NoMethodError)
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: dzema_dm-counter-cache
 version: !ruby/object:Gem::Version 
-  version: 0.9.12
+  version: 0.9.12.1
 platform: ruby
 authors: 
 - Saimon Moore
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-15 00:00:00 +10:00
+date: 2009-11-19 00:00:00 +10:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -86,7 +86,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: datamapper
-rubygems_version: 1.3.4
+rubygems_version: 1.3.5
 signing_key: 
 specification_version: 3
 summary: DataMapper plugin for counter caches ala ActiveRecord. Original idea and implementation by Saimon Moore (daimonmoore [a] gmail [d] com)