dynopoker 1.2.1 → 1.3.2

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: a517653def897da013aac4e959cd295d69ea64f5
+  data.tar.gz: a2ea00e6a9c9cffafe6fd2af97df299db5acb876
+SHA512:
+  metadata.gz: c4c5b44ff5b5c32a555882349fcd68d4eacae9d24367ab920c3f8d2529ffc368406f03ec98fd71811aba23a57f0b389109f80385876faf033b1d9ac9aef5f222
+  data.tar.gz: 5e8d23878eb81398de4658e1fd81aecab76daaaa03ae39b304c4e2e559a321dde80828a06ef9006693c02dfee84eed17fc7e7e10c388849c7168b412cd4bb7e3

data/.travis.yml

@@ -0,0 +1,12 @@
+script:
+  - bundle
+rvm:
+  - 1.8.7
+  - 1.9.2
+  - 1.9.3
+  - 2.0.0
+  - ruby-head
+notifications:
+  email:
+    on_success: always
+    on_failure: always

data/README.md

@@ -1,4 +1,4 @@
-DynoPoker
+DynoPoker [![Build Status](https://travis-ci.org/kubenstein/dynopoker.png?branch=master)](https://travis-ci.org/kubenstein/dynopoker)
 =============
 
 Dynopoker is a gem which prevent your Heroku dyno from falling asleep.
@@ -24,4 +24,8 @@ Add this configuration to your config file:
 	#  config.enable = false # default is true
 	#  config.poke_frequency = 123 # default is 1800s (30min)
 	end
-	
+
+TODO
+-----
+Dynopoker is already doing what it was designed for. No extra features are needed. Code is very simple and well written.
+I recently added specs but I feel that those specs could be written better. Feel free to contribute.

data/dynopoker.gemspec

@@ -15,8 +15,10 @@ Gem::Specification.new do |s|
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
   s.add_dependency "logger"
+
+  s.add_development_dependency 'rspec', '~> 2.14.1'
+  s.add_development_dependency 'webmock', '~> 1.16.0'
 end

data/lib/dynopoker.rb

@@ -1,18 +1,23 @@
 require 'dynopoker/version'
 require 'open-uri'
+require 'logger'
 
 module Dynopoker
 
-  def self.configure
-    Poker.new.tap { |p| yield p }.start!
+  def self.configure(poker_factory = Poker, execution_flow = $0)
+    poker_factory.new.tap do |p|
+      yield p
+      p.start! unless execution_flow =~ /rake/
+    end
   end
 
   class Poker
     attr_accessor :enable, :address, :poke_frequency, :logger
+    alias_method :enable?, :enable
 
     def start!
       merge_default_options!
-      start_poking_thread! if should_poke?
+      start_poking_thread! if enable?
     end
 
 
@@ -41,12 +46,13 @@ module Dynopoker
       self.poke_frequency ||= 1800
       self.logger ||= Logger.new($stdout)
       self.enable = enable.nil? ? true : enable
-      raise('Dynopoker: no address provided!') if !address && enable
+      raise('Dynopoker: no address provided!') if (enable? && !valid_address?)
     end
 
-    def should_poke?
-      !address.nil? && enable && !poke_frequency.nil?
+    def valid_address?
+      address && !address.empty?
     end
 
   end
+
 end

data/lib/dynopoker/version.rb

@@ -1,3 +1,3 @@
 module Dynopoker
-  VERSION = "1.2.1"
+  VERSION = '1.3.2'
 end

data/spec/dynopoker_spec.rb

@@ -0,0 +1,47 @@
+#encoding: UTF-8
+require 'spec_helper'
+require 'ostruct'
+
+
+describe Dynopoker do
+
+  subject { Dynopoker }
+  let(:fake_poker) { Struct.new(:enable, :address, :poke_frequency, :logger, :start!) }
+  let(:fake_logger) { OpenStruct.new(fake?: true) }
+
+  context 'configuration' do
+
+    it 'should pass config vars during configuration' do
+      new_instance_of_poker = subject.configure(fake_poker) do |config|
+        config.address = 'http://test.org'
+        config.enable = false
+        config.poke_frequency = 123
+        config.logger = fake_logger
+      end
+
+      new_instance_of_poker.address.should eq 'http://test.org'
+      new_instance_of_poker.enable.should be_false
+      new_instance_of_poker.poke_frequency.should eq 123
+      new_instance_of_poker.logger.should be_fake
+    end
+
+    it 'should pass start poking!' do
+      fake_poker.any_instance.should_receive(:start!).once
+      subject.configure(fake_poker) {}
+    end
+
+  end
+
+  context 'asset precompile process' do
+    it 'should not start while in asset precompile process' do
+      fake_poker.any_instance.should_not_receive(:start!)
+      subject.configure(fake_poker, '/bin/rake') {}
+    end
+
+    it 'should start while not in asset precompile process' do
+      fake_poker.any_instance.should_receive(:start!).once
+      subject.configure(fake_poker, '/bin/rails') {}
+    end
+  end
+
+end

data/spec/poker_spec.rb

@@ -0,0 +1,91 @@
+#encoding: UTF-8
+require 'spec_helper'
+require 'ostruct'
+
+
+describe Dynopoker::Poker do
+
+  context 'default params' do
+    it 'should use default params if no other params are given' do
+      subject.stub(start_poking_thread!: false, address: 'http://test.org')
+      subject.start!
+      subject.poke_frequency.should eq 1800
+      subject.logger.class.name.should eq 'Logger'
+      subject.enable.should be_true
+    end
+  end
+
+  context 'no address provided error' do
+    it 'should raise exception if address is not given' do
+      expect { subject.start! }.to raise_error(Exception, 'Dynopoker: no address provided!')
+    end
+
+    it 'should raise exception if address is empty' do
+      subject.stub(address: '')
+      expect { subject.start! }.to raise_error(Exception, 'Dynopoker: no address provided!')
+    end
+
+    it 'should NOT raise exception if address is not given but poking is disabled' do
+      subject.stub(enable: false)
+      expect { subject.start! }.not_to raise_error(Exception, 'Dynopoker: no address provided!')
+    end
+
+    it 'should NOT raise exception if address is empty but poking is disabled' do
+      subject.stub(enable: false, address: '')
+      expect { subject.start! }.not_to raise_error(Exception, 'Dynopoker: no address provided!')
+    end
+  end
+
+  context 'thread' do
+    it 'should start thread' do
+      subject.stub(address: 'http://test.org')
+      Thread.should_receive(:new).once
+      subject.start!
+    end
+  end
+
+  context 'poking' do
+    before do
+      #
+      # testing while(true) in separate thread can be really tuff task
+      # first I skip thread itself by replacing 'start_poking_thread!' method with 'poking'
+      def subject.start_poking_thread!; poking end
+
+      #
+      # then I need to break while true loop...
+      # I replace sleep method in the loop to raise exception after x calls
+      def subject.sleep(_)
+        break_after_attempts = 2
+        @x ||= 0
+        raise('breaking while true loop') if ((@x+=1) == break_after_attempts)
+      end
+
+      #
+      # One thing that can not be tested in this configuration is poking frequency
+    end
+
+    it 'should poke address' do
+      stub_request(:get, 'http://test.org')
+      subject.stub(address: 'http://test.org')
+
+      expect {
+        subject.start!
+      }.to raise_error(Exception, 'breaking while true loop')
+
+      WebMock.should have_requested(:get, 'http://test.org').twice
+    end
+
+    it 'should write to logger error if any exception was raised during poking' do
+      fake_logger = double()
+      fake_logger.stub(:info)
+      fake_logger.stub(:error)
+      fake_logger.should_receive(:error).with('Dynopoker: poking error Errno::ENOENT: No such file or directory - INVALID_ADDRESS').twice
+
+      subject.stub(address: 'INVALID_ADDRESS', logger: fake_logger)
+      expect {
+        subject.start!
+      }.to raise_error(Exception, 'breaking while true loop')
+    end
+  end
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,2 @@
+require 'webmock/rspec'
+require 'dynopoker'

metadata

@@ -1,32 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: dynopoker
 version: !ruby/object:Gem::Version
-  version: 1.2.1
-  prerelease: 
+  version: 1.3.2
 platform: ruby
 authors:
 - kubenstein
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-22 00:00:00.000000000 Z
+date: 2014-07-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: logger
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.14.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.14.1
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.16.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.16.0
 description: Dynopoker is a gem that will make your ruby based heroku app self pinging
   system, preventing single dyno from falling asleep
 email:
@@ -36,34 +61,40 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - README.md
 - Rakefile
 - dynopoker.gemspec
 - lib/dynopoker.rb
 - lib/dynopoker/version.rb
+- spec/dynopoker_spec.rb
+- spec/poker_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/kubenstein/dynopoker
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: dynopoker
-rubygems_version: 1.8.25
+rubygems_version: 2.1.11
 signing_key: 
-specification_version: 3
-summary: ! 'Dynopoker: prevent your heroku dyno from falling asleep'
-test_files: []
+specification_version: 4
+summary: 'Dynopoker: prevent your heroku dyno from falling asleep'
+test_files:
+- spec/dynopoker_spec.rb
+- spec/poker_spec.rb
+- spec/spec_helper.rb