dynflow 0.8.36 → 0.8.37

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9d355c9b625deb22695548050c4d72ee3c43ce3a14e43488507173554c9c04d0
-  data.tar.gz: 63693d7793f8e1f12ff03d4b0b9ea3e9bbb1114f701cd92f470dd268f8dac732
+  metadata.gz: 07d302583997706186e5c5a55185a32b35757971615e5e42b73d9121cab2d23d
+  data.tar.gz: 9b5f20a8788784b95f4f52d66f3af1b7b1425f077a370b51a2e2ca2aed2b1c10
 SHA512:
-  metadata.gz: 6760a74b0ec0f87e9ffb01a87f322b4151be4b1ddb578aa4ce56956f363a0a75db7bbcfbdf1eecc370dedc0b5ea1e182e4d85b86c22b411947b728ac531ed69f
-  data.tar.gz: 29a76f2faa3d93a24269c1cc233ca5f4cde5865e5c454dfb945b2605a184fc29203b7bb4f5a99100695557332bf6a0690f999ed4026dfc9570877f6085d8b374
+  metadata.gz: 3cd1c9ca74ab31c3afead86db86af7565c2f34e71c48d608d0dcac3ba105f0113fed48f9560865a3acced8545dd0daa55f7149311b91d81387b8ab00e2132aa8
+  data.tar.gz: 6fbf67d06c58b64076178aed4cd271d07d1ac89b5a6d962360dd140a63324c738552e74586d9d350e08216963ffa925cacffa53be45fb932ad9a982ada1b6bae

data/doc/pages/source/404.md

@@ -1,6 +1,7 @@
 ---
 layout: page
 title: "404"
+permalink: /404.html
 ---
 
 We are sorry, page You are looking for does not exist :'(

data/doc/pages/source/_includes/menu.html

@@ -1,7 +1,6 @@
 <!--TODO make active-->
 <li><a href="/">About</a></li>
 <li><a href="/documentation/">Documentation</a></li>
-<li><a href="/blog/">Blog</a></li>
 <li><a href="/faq/">FAQ</a></li>
 <li><a href="/media/">Media</a></li>
 <li><a href="/projects/">Related projects</a></li>

data/doc/pages/source/_includes/menu_right.html

@@ -1 +1 @@
-<li><a class="extra" href="/atom.xml">RSS</a></li>
+<!--<li><a class="extra" href="/atom.xml">RSS</a></li>-->

data/doc/pages/source/documentation/index.md

@@ -9,7 +9,7 @@ comments: true
 {% danger_block %}
 
 Work in progress! It contains a lot of tpyos, please let us know. There are comments at the bottom
-or you can submit a PR against [pages branch](https://github.com/dynflow/dynflow/tree/pages).
+or you can submit a PR against [master branch](https://github.com/dynflow/dynflow/tree/master).
 
 Please help with the documentation if you know Dynflow.
 

data/lib/dynflow/delayed_executors/abstract_core.rb

@@ -52,8 +52,10 @@ module Dynflow
               plan.timeout
             else
               @logger.debug "Executing plan #{plan.execution_plan_uuid}"
-              plan.plan
-              plan.execute
+              Executors.run_user_code do
+                plan.plan
+                plan.execute
+              end
             end
             processed_plan_uuids << plan.execution_plan_uuid
           end

data/lib/dynflow/execution_plan/hooks.rb

@@ -60,12 +60,16 @@ module Dynflow
         # @param action [Action] the action which triggered the hooks
         # @param kind [Symbol] the kind of hooks to run, one of {HOOK_KINDS}
         def run(execution_plan, action, kind)
-          on(kind).each do |hook|
-            begin
-              action.send(hook, execution_plan)
-            rescue => e
-              execution_plan.logger.error "Failed to run hook '#{hook}' for action '#{action.class}'"
-              execution_plan.logger.debug e
+          hooks = on(kind)
+          return if hooks.empty?
+          Executors.run_user_code do
+            hooks.each do |hook|
+              begin
+                action.send(hook, execution_plan)
+              rescue => e
+                execution_plan.logger.error "Failed to run hook '#{hook}' for action '#{action.class}'"
+                execution_plan.logger.debug e
+              end
             end
           end
         end

data/lib/dynflow/executors.rb

@@ -4,5 +4,14 @@ module Dynflow
     require 'dynflow/executors/abstract'
     require 'dynflow/executors/parallel'
 
+    # Every time we run a code that can be defined outside of Dynflow,
+    # we should wrap it with this method, and we can ensure here to do
+    # necessary cleanup, such as cleaning ActiveRecord connections
+    def self.run_user_code
+      yield
+    ensure
+      ::ActiveRecord::Base.clear_active_connections! if defined? ::ActiveRecord
+    end
+
   end
 end

data/lib/dynflow/executors/parallel/worker.rb

@@ -8,12 +8,13 @@ module Dynflow
         end
 
         def on_message(work_item)
-          work_item.execute
+          Executors.run_user_code do
+            work_item.execute
+          end
         rescue Errors::PersistenceError => e
           @pool.tell([:handle_persistence_error, e])
         ensure
           @pool.tell([:worker_done, reference, work_item])
-          @transaction_adapter.cleanup
         end
       end
     end

data/lib/dynflow/rails.rb

@@ -41,6 +41,7 @@ module Dynflow
           config.run_on_init_hooks(world)
           # leave this just for long-running executors
           unless config.rake_task_with_executor?
+            world.perform_validity_checks
             world.auto_execute
           end
         end

data/lib/dynflow/rails/configuration.rb

@@ -111,6 +111,7 @@ module Dynflow
 
           # we can't do any operation until the Rails.application.dynflow.world is set
           config.auto_execute        = false
+          config.auto_validity_check = false
         end
       end
 

data/lib/dynflow/transaction_adapters/abstract.rb

@@ -10,12 +10,6 @@ module Dynflow
       def rollback
         raise NotImplementedError
       end
-
-      # Called on each thread after work is done.
-      # E.g. it's used to checkin ActiveRecord connections back to pool.
-      def cleanup
-        # override if needed
-      end
     end
   end
 end

data/lib/dynflow/transaction_adapters/active_record.rb

@@ -8,10 +8,6 @@ module Dynflow
       def rollback
         raise ::ActiveRecord::Rollback
       end
-
-      def cleanup
-        ::ActiveRecord::Base.clear_active_connections!
-      end
     end
   end
 end

data/lib/dynflow/version.rb

@@ -1,3 +1,3 @@
 module Dynflow
-  VERSION = '0.8.36'.freeze
+  VERSION = '0.8.37'.freeze
 end

data/lib/dynflow/world.rb

@@ -42,10 +42,8 @@ module Dynflow
         @executor_dispatcher = spawn_and_wait(Dispatcher::ExecutorDispatcher, "executor-dispatcher", self, config_for_world.executor_semaphore)
         executor.initialized.wait
       end
-      if auto_validity_check
-        self.worlds_validity_check
-        self.locks_validity_check
-      end
+      perform_validity_checks if auto_validity_check
+
       @delayed_executor         = try_spawn(config_for_world, :delayed_executor, Coordinator::DelayedExecutorLock)
       @execution_plan_cleaner   = try_spawn(config_for_world, :execution_plan_cleaner, Coordinator::ExecutionPlanCleanerLock)
       @meta                     = config_for_world.meta
@@ -337,6 +335,11 @@ module Dynflow
       logger.error "failed to write data while invalidating execution lock #{execution_lock}"
     end
 
+    def perform_validity_checks
+      worlds_validity_check
+      locks_validity_check
+    end
+
     def worlds_validity_check(auto_invalidate = true, worlds_filter = {})
       worlds = coordinator.find_worlds(false, worlds_filter)
 

data/test/daemon_test.rb

@@ -16,6 +16,7 @@ class DaemonTest < ActiveSupport::TestCase
     @world_class = mock('dummy world factory')
     @dummy_world = ::Dynflow::Testing::DummyWorld.new
     @dummy_world.stubs(:auto_execute)
+    @dummy_world.stubs(:perform_validity_checks)
     @event = Concurrent.event
     @dummy_world.stubs(:terminated).returns(@event)
     @world_class.stubs(:new).returns(@dummy_world)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dynflow
 version: !ruby/object:Gem::Version
-  version: 0.8.36
+  version: 0.8.37
 platform: ruby
 authors:
 - Ivan Necas
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-06 00:00:00.000000000 Z
+date: 2018-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -252,7 +252,6 @@ files:
 - doc/pages/plugins/toc.rb
 - doc/pages/source/.nojekyll
 - doc/pages/source/404.md
-- doc/pages/source/_drafts/2015-03-01-new-documentation.markdown
 - doc/pages/source/_includes/disqus.html
 - doc/pages/source/_includes/google_analytics.html
 - doc/pages/source/_includes/google_plus_one.html
@@ -344,7 +343,6 @@ files:
 - doc/pages/source/_sass/bootstrap/mixins/_text-overflow.scss
 - doc/pages/source/_sass/bootstrap/mixins/_vendor-prefixes.scss
 - doc/pages/source/atom.xml
-- doc/pages/source/blog/index.html
 - doc/pages/source/bootstrap/config.json
 - doc/pages/source/bootstrap/css/bootstrap-theme.css
 - doc/pages/source/bootstrap/css/bootstrap-theme.min.css

data/doc/pages/source/_drafts/2015-03-01-new-documentation.markdown

@@ -1,10 +0,0 @@
----
-layout: post
-title: "New documentation"
-date: 2015-03-01 10:00
-tags:
-- documentation
----
-
-We have a new Dynflow documentation!
-

data/doc/pages/source/blog/index.html

@@ -1,12 +0,0 @@
----
-layout: page
-title: Posts
----
-
-{% for post in site.posts %}
-{% include post_item.html %}
-{% endfor %}
-
-<p id="tag-cloud">
-    All tags: {{ site | tag_cloud }}
-</p>