dynflow 0.8.13 → 0.8.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9215ff1efd57ed6ece39b4ae15891123a6304050
-  data.tar.gz: 7c68d582ed355012b1de8211172d7b10240a6d45
+  metadata.gz: 10c16849649c62a6f0754fdbde3a7fe85adf36fd
+  data.tar.gz: 62bf44e0fce93610906a347d46f9573cdb5dee57
 SHA512:
-  metadata.gz: 3f0439afb6121642343bcf9180164d0ae4155b13a42207b3f439bfd33709dd616a8bffb55b31855f7c80091e2e322de142acf6f46e42447e82645d221ec9185d
-  data.tar.gz: aae18c603de99391980735fda2deb3ac7c1320268623a6bc550578cdf7e24e9c69274224fbe90ffdb93481bd87ab75054b338e21affce221c9be70052bc7a116
+  metadata.gz: 3b2160f687df87809778801247a9fb3b58001f4c8fa7763f0403c5bd81d2a49d0a84afad33071d70dc799b7f5b4e517311402a4c1eb708c6944d566b8a0bb644
+  data.tar.gz: b4fbc38656f85f2040015e0c9c5b3099071595badb7e15d59d16da7cfde9e930083688105ef4913c74151d125ce036c0e4e1e580da0c4d92ab3818a3c32e2534

data/.rubocop.yml

@@ -0,0 +1 @@
+inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -0,0 +1,635 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config --exclude-limit 0`
+# on 2016-08-24 10:37:35 -0400 using RuboCop version 0.39.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 7
+Lint/AmbiguousOperator:
+  Enabled: false
+
+# Offense count: 2
+Lint/AmbiguousRegexpLiteral:
+  Enabled: false
+
+# Offense count: 7
+# Configuration parameters: AllowSafeAssignment.
+Lint/AssignmentInCondition:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: AlignWith, SupportedStyles.
+# SupportedStyles: either, start_of_block, start_of_line
+Lint/BlockAlignment:
+  Enabled: false
+
+# Offense count: 1
+Lint/DuplicateMethods:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
+# SupportedStyles: keyword, variable, start_of_line
+Lint/EndAlignment:
+  Enabled: false
+
+# Offense count: 6
+Lint/IneffectiveAccessModifier:
+  Enabled: false
+
+# Offense count: 5
+Lint/ParenthesesAsGroupedExpression:
+  Enabled: false
+
+# Offense count: 1
+Lint/RandOne:
+  Enabled: false
+
+# Offense count: 3
+Lint/RescueException:
+  Enabled: false
+
+# Offense count: 1
+Lint/ShadowingOuterLocalVariable:
+  Enabled: false
+
+# Offense count: 1
+Lint/UnderscorePrefixedVariableName:
+  Enabled: false
+
+# Offense count: 17
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoreEmptyBlocks.
+Lint/UnusedBlockArgument:
+  Enabled: false
+
+# Offense count: 78
+# Cop supports --auto-correct.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
+Lint/UnusedMethodArgument:
+  Enabled: false
+
+# Offense count: 3
+Lint/UselessAccessModifier:
+  Enabled: false
+
+# Offense count: 5
+Lint/UselessAssignment:
+  Enabled: false
+
+# Offense count: 73
+Metrics/AbcSize:
+  Max: 207
+
+# Offense count: 9
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 402
+
+# Offense count: 11
+Metrics/CyclomaticComplexity:
+  Max: 11
+
+# Offense count: 521
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 166
+
+# Offense count: 99
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 104
+
+# Offense count: 14
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+  Max: 548
+
+# Offense count: 3
+# Configuration parameters: CountKeywordArgs.
+Metrics/ParameterLists:
+  Max: 13
+
+# Offense count: 9
+Metrics/PerceivedComplexity:
+  Max: 11
+
+# Offense count: 16
+# Cop supports --auto-correct.
+Performance/RedundantBlockCall:
+  Enabled: false
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Performance/TimesMap:
+  Enabled: false
+
+# Offense count: 8
+Style/AccessorMethodName:
+  Enabled: false
+
+# Offense count: 13
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: prefer_alias, prefer_alias_method
+Style/Alias:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle, SupportedLastArgumentHashStyles.
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Style/AlignHash:
+  Enabled: false
+
+# Offense count: 51
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: with_first_parameter, with_fixed_indentation
+Style/AlignParameters:
+  Enabled: false
+
+# Offense count: 11
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: always, conditionals
+Style/AndOr:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: percent_q, bare_percent
+Style/BarePercentLiterals:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
+# SupportedStyles: line_count_based, semantic, braces_for_chaining
+# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
+# FunctionalMethods: let, let!, subject, watch
+# IgnoredMethods: lambda, proc, it
+Style/BlockDelimiters:
+  Enabled: false
+
+# Offense count: 18
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: braces, no_braces, context_dependent
+Style/BracesAroundHashParameters:
+  Enabled: false
+
+# Offense count: 13
+Style/CaseEquality:
+  Enabled: false
+
+# Offense count: 24
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: nested, compact
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: is_a?, kind_of?
+Style/ClassCheck:
+  Enabled: false
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Style/ColonMethodCall:
+  Enabled: false
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: Keywords.
+# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
+Style/CommentAnnotation:
+  Enabled: false
+
+# Offense count: 4
+Style/ConstantName:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/DeprecatedHashMethods:
+  Enabled: false
+
+# Offense count: 172
+Style/Documentation:
+  Enabled: false
+
+# Offense count: 20
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: leading, trailing
+Style/DotPosition:
+  Enabled: false
+
+# Offense count: 3
+Style/DoubleNegation:
+  Enabled: false
+
+# Offense count: 1
+Style/EachWithObject:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: empty, nil, both
+Style/EmptyElse:
+  Enabled: false
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: AllowAdjacentOneLineDefs.
+Style/EmptyLineBetweenDefs:
+  Enabled: false
+
+# Offense count: 14
+# Cop supports --auto-correct.
+Style/EmptyLines:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/EmptyLinesAroundAccessModifier:
+  Enabled: false
+
+# Offense count: 91
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: empty_lines, no_empty_lines
+Style/EmptyLinesAroundBlockBody:
+  Enabled: false
+
+# Offense count: 143
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: empty_lines, no_empty_lines
+Style/EmptyLinesAroundClassBody:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/EmptyLinesAroundMethodBody:
+  Enabled: false
+
+# Offense count: 52
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: empty_lines, no_empty_lines
+Style/EmptyLinesAroundModuleBody:
+  Enabled: false
+
+# Offense count: 25
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
+Style/ExtraSpacing:
+  Enabled: false
+
+# Offense count: 9
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: consistent, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
+Style/FirstParameterIndentation:
+  Enabled: false
+
+# Offense count: 4
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: format, sprintf, percent
+Style/FormatString:
+  Enabled: false
+
+# Offense count: 7
+# Configuration parameters: AllowedVariables.
+Style/GlobalVars:
+  Enabled: false
+
+# Offense count: 13
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Enabled: false
+
+# Offense count: 106
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues.
+# SupportedStyles: ruby19, ruby19_no_mixed_keys, hash_rockets
+Style/HashSyntax:
+  Enabled: false
+
+# Offense count: 4
+Style/IfInsideElse:
+  Enabled: false
+
+# Offense count: 22
+# Cop supports --auto-correct.
+# Configuration parameters: MaxLineLength.
+Style/IfUnlessModifier:
+  Enabled: false
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: IndentationWidth.
+Style/IndentAssignment:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: special_inside_parentheses, consistent, align_braces
+Style/IndentHash:
+  Enabled: false
+
+# Offense count: 8
+# Cop supports --auto-correct.
+Style/Lambda:
+  Enabled: false
+
+# Offense count: 13
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: call, braces
+Style/LambdaCall:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/LineEndConcatenation:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/MethodCallParentheses:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline
+Style/MethodDefParentheses:
+  Enabled: false
+
+# Offense count: 6
+Style/MultilineBlockChain:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/MultilineIfThen:
+  Enabled: false
+
+# Offense count: 23
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: aligned, indented
+Style/MultilineMethodCallIndentation:
+  Enabled: false
+
+# Offense count: 9
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: aligned, indented
+Style/MultilineOperationIndentation:
+  Enabled: false
+
+# Offense count: 9
+# Cop supports --auto-correct.
+Style/MutableConstant:
+  Enabled: false
+
+# Offense count: 5
+# Cop supports --auto-correct.
+Style/NegatedIf:
+  Enabled: false
+
+# Offense count: 9
+Style/NestedParenthesizedCalls:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
+# SupportedStyles: skip_modifier_ifs, always
+Style/Next:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/Not:
+  Enabled: false
+
+# Offense count: 2
+Style/OpMethod:
+  Enabled: false
+
+# Offense count: 5
+# Cop supports --auto-correct.
+Style/ParallelAssignment:
+  Enabled: false
+
+# Offense count: 24
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/PerlBackrefs:
+  Enabled: false
+
+# Offense count: 4
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
+Style/PredicateName:
+  Enabled: false
+
+# Offense count: 6
+# Cop supports --auto-correct.
+Style/Proc:
+  Enabled: false
+
+# Offense count: 4
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: compact, exploded
+Style/RaiseArgs:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantBegin:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/RedundantParentheses:
+  Enabled: false
+
+# Offense count: 43
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleReturnValues.
+Style/RedundantReturn:
+  Enabled: false
+
+# Offense count: 87
+# Cop supports --auto-correct.
+Style/RedundantSelf:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RescueModifier:
+  Enabled: false
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: AllowAsExpressionSeparator.
+Style/Semicolon:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: only_raise, only_fail, semantic
+Style/SignalException:
+  Enabled: false
+
+# Offense count: 6
+# Configuration parameters: Methods.
+# Methods: {"reduce"=>["a", "e"]}, {"inject"=>["a", "e"]}
+Style/SingleLineBlockParams:
+  Enabled: false
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: AllowIfMethodIsEmpty.
+Style/SingleLineMethods:
+  Enabled: false
+
+# Offense count: 42
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment.
+Style/SpaceAroundOperators:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/SpaceBeforeComma:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
+# SupportedStyles: space, no_space
+Style/SpaceInsideBlockBraces:
+  Enabled: false
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
+# SupportedStyles: space, no_space
+Style/SpaceInsideHashLiteralBraces:
+  Enabled: false
+
+# Offense count: 7
+# Cop supports --auto-correct.
+Style/SpaceInsideParens:
+  Enabled: false
+
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: space, no_space
+Style/SpaceInsideStringInterpolation:
+  Enabled: false
+
+# Offense count: 9
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: use_perl_names, use_english_names
+Style/SpecialGlobalVars:
+  Enabled: false
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: require_parentheses, require_no_parentheses
+Style/StabbyLambdaParentheses:
+  Enabled: false
+
+# Offense count: 230
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiteralsInInterpolation:
+  Enabled: false
+
+# Offense count: 9
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoredMethods.
+# IgnoredMethods: respond_to
+Style/SymbolProc:
+  Enabled: false
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: final_newline, final_blank_line
+Style/TrailingBlankLines:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
+# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
+Style/TrivialAccessors:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/UnneededCapitalW:
+  Enabled: false
+
+# Offense count: 2
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: snake_case, camelCase
+Style/VariableName:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: MaxLineLength.
+Style/WhileUntilModifier:
+  Enabled: false
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: SupportedStyles, WordRegex.
+# SupportedStyles: percent, brackets
+Style/WordArray:
+  EnforcedStyle: percent
+  MinSize: 4
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/ZeroLengthPredicate:
+  Enabled: false

data/.travis.yml

@@ -23,4 +23,5 @@ install:
   - test/prepare_travis_env.sh
 
 script:
+  - bundle exec rubocop
   - bundle exec rake test

data/Gemfile

@@ -21,3 +21,7 @@ end
 if RUBY_VERSION < "2.2.2"
   gem 'activesupport', '~> 4.2'
 end
+
+group :lint do
+  gem 'rubocop', '0.39.0'
+end

data/examples/remote_executor.rb

@@ -91,7 +91,7 @@ if $0 == __FILE__
     puts <<MSG
 The observer starting…. You can see what's going on there
 MSG
-   RemoteExecutorExample.run_observer
+    RemoteExecutorExample.run_observer
   when 'server'
     puts <<MSG
 The server is starting…. You can send the work to it by running:
@@ -99,7 +99,7 @@ The server is starting…. You can send the work to it by running:
    #{$0} client
 
 MSG
-   RemoteExecutorExample.run_server
+    RemoteExecutorExample.run_server
   when 'client'
     RemoteExecutorExample.run_client
   else

data/examples/sub_plan_concurrency_control.rb

@@ -44,7 +44,7 @@ class ConcurrencyControlExample < Dynflow::Action
 
   ConcurrencyLevel = 2
   RunWithin = 2 * 60
-  
+
   def plan(count)
     limit_concurrency_level(ConcurrencyLevel)
     distribute_over_time(RunWithin)

data/lib/dynflow/action/rescue.rb

@@ -2,7 +2,7 @@ module Dynflow
   module Action::Rescue
 
     Strategy = Algebrick.type do
-      variants Skip = atom, Pause = atom
+      variants Skip = atom, Pause = atom, Fail = atom
     end
 
     SuggestedStrategy = Algebrick.type do
@@ -21,7 +21,8 @@ module Dynflow
     def rescue_strategy
       suggested_strategies = []
 
-      if self.steps.compact.any? { |step| step.state == :error }
+      if self.steps.compact.any? { |step| step.state == :error } ||
+         self.steps.compact.all? { |step| [:pending, :success].include? step.state }
         suggested_strategies << SuggestedStrategy[self, rescue_strategy_for_self]
       end
 
@@ -44,14 +45,20 @@ module Dynflow
       action.rescue_strategy
     end
 
-    # Override when different appraoch should be taken for combining
+    # Override when different approach should be taken for combining
     # the suggested strategies
     def combine_suggested_strategies(suggested_strategies)
-      if suggested_strategies.empty? ||
-            suggested_strategies.all? { |suggested_strategy| suggested_strategy.strategy == Skip }
+      if suggested_strategies.empty?
         return Skip
       else
-        return Pause
+        # TODO: Find the safest rescue strategy among the suggested ones
+        if suggested_strategies.all? { |suggested_strategy| suggested_strategy.strategy == Skip }
+          return Skip
+        elsif suggested_strategies.all? { |suggested_strategy| suggested_strategy.strategy == Fail }
+          return Fail
+        else
+          return Pause # We don't know how to handle this case, so we'll just pause
+        end
       end
     end
   end

data/lib/dynflow/delayed_plan.rb

@@ -48,11 +48,11 @@ module Dynflow
     end
 
     def to_hash
-       recursive_to_hash :execution_plan_uuid => @execution_plan_uuid,
-                         :start_at            => time_to_str(@start_at),
-                         :start_before        => time_to_str(@start_before),
-                         :serialized_args     => @args_serializer.serialized_args,
-                         :args_serializer     => @args_serializer.class.name
+      recursive_to_hash :execution_plan_uuid => @execution_plan_uuid,
+                        :start_at            => time_to_str(@start_at),
+                        :start_before        => time_to_str(@start_before),
+                        :serialized_args     => @args_serializer.serialized_args,
+                        :args_serializer     => @args_serializer.class.name
     end
 
     # @api private

data/lib/dynflow/execution_plan.rb

@@ -29,7 +29,7 @@ module Dynflow
                                planning: [:planned, :stopped],
                                planned:  [:running, :stopped],
                                running:  [:paused, :stopped],
-                               paused:   [:running],
+                               paused:   [:running, :stopped],
                                stopped:  [] }
     end
 
@@ -124,6 +124,9 @@ module Dynflow
       case rescue_strategy
       when Action::Rescue::Pause
         nil
+      when Action::Rescue::Fail
+        update_state :stopped
+        nil
       when Action::Rescue::Skip
         failed_steps.each { |step| self.skip(step) }
         self.id

data/lib/dynflow/executors/parallel/worker.rb

@@ -15,7 +15,7 @@ module Dynflow
                   step.execute event
                 end),
                 (on Work::Finalize.(~any, any) do |sequential_manager|
-                  sequential_manager.finalize
+                   sequential_manager.finalize
                  end)
         rescue Errors::PersistenceError => e
           @pool.tell([:handle_persistence_error, e])

data/lib/dynflow/version.rb

@@ -1,3 +1,3 @@
 module Dynflow
-  VERSION = '0.8.13'
+  VERSION = '0.8.14'
 end

data/lib/dynflow/web/console_helpers.rb

@@ -17,7 +17,7 @@ module Dynflow
         value = prettyprint_references(value)
         if value
           pretty_value = prettify_value(value)
-            <<-HTML
+          <<-HTML
               <pre class="prettyprint lang-yaml">#{h(pretty_value)}</pre>
             HTML
         else
@@ -68,7 +68,7 @@ module Dynflow
       def show_action_data(label, value)
         value_html = prettyprint(value)
         if !value_html.empty?
-            <<-HTML
+          <<-HTML
               <p>
                 <b>#{h(label)}</b>
             #{value_html}

data/test/action_test.rb

@@ -460,7 +460,7 @@ module Dynflow
           triggered_plan.finished.value.state.must_equal :stopped
           triggered_plan.finished.value.result.must_equal :success
         end
-     end
+      end
     end
   end
 end

data/test/middleware_test.rb

@@ -51,12 +51,12 @@ module Dynflow
         end
 
         it "puts the middleware to the beginning of the stack" do
-            world_with_middleware.trigger(Support::MiddlewareExample::Action, {}).finished.wait
-            log.must_equal %w[AnotherLogRunMiddleware::before_run
-                              LogRunMiddleware::before_run
-                              run
-                              LogRunMiddleware::after_run
-                              AnotherLogRunMiddleware::after_run]
+          world_with_middleware.trigger(Support::MiddlewareExample::Action, {}).finished.wait
+          log.must_equal %w[AnotherLogRunMiddleware::before_run
+                            LogRunMiddleware::before_run
+                            run
+                            LogRunMiddleware::after_run
+                            AnotherLogRunMiddleware::after_run]
         end
       end
 

data/test/rescue_test.rb

@@ -32,7 +32,7 @@ module Dynflow
           rescued_plan.state.must_equal :stopped
           rescued_plan.result.must_equal :warning
           rescued_plan.entry_action.output[:message].
-              must_equal "skipped because some error as you wish"
+            must_equal "skipped because some error as you wish"
         end
 
       end
@@ -113,6 +113,27 @@ module Dynflow
 
       end
 
+      describe 'of complex action with fail' do
+
+        let :execution_plan do
+          execute(Example::ComplexActionWithFail, :error_on_run)
+        end
+
+        it 'suggests failing the plan' do
+          execution_plan.rescue_strategy.must_equal Action::Rescue::Fail
+        end
+
+        it 'fails rescuing' do
+          proc { rescued_plan }.must_raise Errors::RescueError
+          execution_plan.state.must_equal :stopped
+          execution_plan.result.must_equal :error
+          execution_plan.steps_in_state(:success).count.must_equal 5
+          execution_plan.steps_in_state(:pending).count.must_equal 4
+          execution_plan.steps_in_state(:error).count.must_equal 1
+        end
+
+      end
+
       describe 'auto rescue' do
 
         let(:world) do
@@ -123,43 +144,58 @@ module Dynflow
 
         describe 'of plan with skips' do
 
-           let :execution_plan do
-             execute(Example::ComplexActionWithSkip, :error_on_run)
-           end
+          let :execution_plan do
+            execute(Example::ComplexActionWithSkip, :error_on_run)
+          end
 
-           it 'skips the action and continues automatically' do
-             execution_plan.state.must_equal :stopped
-             execution_plan.result.must_equal :warning
-           end
+          it 'skips the action and continues automatically' do
+            execution_plan.state.must_equal :stopped
+            execution_plan.result.must_equal :warning
+          end
 
         end
 
         describe 'of plan faild on auto-rescue' do
 
-           let :execution_plan do
-             execute(Example::ActionWithSkip, 1, :error_on_skip)
-           end
+          let :execution_plan do
+            execute(Example::ActionWithSkip, 1, :error_on_skip)
+          end
 
-           it 'tryied to rescue only once' do
-             execution_plan.state.must_equal :paused
-             execution_plan.result.must_equal :error
-           end
+          it 'tried to rescue only once' do
+            execution_plan.state.must_equal :paused
+            execution_plan.result.must_equal :error
+          end
 
         end
 
         describe 'of plan without skips' do
 
           let :execution_plan do
-             execute(Example::ComplexActionWithoutSkip, :error_on_run)
-           end
+            execute(Example::ComplexActionWithoutSkip, :error_on_run)
+          end
 
-           it 'skips the action and continues automatically' do
-             execution_plan.state.must_equal :paused
-             execution_plan.result.must_equal :error
-           end
+          it 'skips the action and continues automatically' do
+            execution_plan.state.must_equal :paused
+            execution_plan.result.must_equal :error
+          end
 
         end
 
+        describe 'of plan with fail' do
+
+          let :execution_plan do
+            execute(Example::ComplexActionWithFail, :error_on_run)
+          end
+
+          it 'fails the execution plan automatically' do
+            execution_plan.state.must_equal :stopped
+            execution_plan.result.must_equal :error
+            execution_plan.steps_in_state(:success).count.must_equal 5
+            execution_plan.steps_in_state(:pending).count.must_equal 4
+            execution_plan.steps_in_state(:error).count.must_equal 1
+          end
+        end
+
       end
     end
   end

data/test/semaphores_test.rb

@@ -40,7 +40,7 @@ module Dynflow
         waiting = semaphore.get_waiting
         waiting.must_equal 3
       end
-      
+
     end
 
     describe ::Dynflow::Semaphores::Dummy do
@@ -93,6 +93,6 @@ module Dynflow
         assert_semaphore_state semaphore, 0, 0
       end
     end
-    
+
   end
 end

data/test/support/rescue_example.rb

@@ -14,6 +14,11 @@ module Support
           plan_action(ActionWithSkip, 5, :success)
         end
       end
+
+      def rescue_strategy_for_self
+        Dynflow::Action::Rescue::Skip
+      end
+
     end
 
     class ComplexActionWithoutSkip < ComplexActionWithSkip
@@ -69,5 +74,29 @@ module Support
       end
 
     end
+
+    class ActionWithFail < AbstractAction
+
+      def rescue_strategy_for_self
+        Dynflow::Action::Rescue::Fail
+      end
+
+    end
+
+    class ComplexActionWithFail < ActionWithFail
+
+      def plan(error_state)
+        sequence do
+          concurrence do
+            plan_action(ActionWithFail, 3, :success)
+            plan_action(ActionWithFail, 4, error_state)
+          end
+          plan_action(ActionWithFail, 5, :success)
+        end
+      end
+
+    end
+
+
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dynflow
 version: !ruby/object:Gem::Version
-  version: 0.8.13
+  version: 0.8.14
 platform: ruby
 authors:
 - Ivan Necas
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-25 00:00:00.000000000 Z
+date: 2016-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -201,6 +201,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - Gemfile
 - MIT-LICENSE