dyndnsd 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 52b78d9faf8be67cd76202d2f6060ee5f6b96c382603d7431f906a5b03b3c468
-  data.tar.gz: 889f266280f47c44418fca138d5253f1eaee7ef5ab79555d96e76b455d74d029
+  metadata.gz: db179e252883aaa67b13141d717f4b05fbf94855cca48818e7c21fad127f660a
+  data.tar.gz: 35c7ceb2ebfa157672e3c40c93309170effa583e46acd4ad94526a918235a7e7
 SHA512:
-  metadata.gz: 72c3cb12a042ebbc9c5ccb8ee00d6278165e5f25acc00e0666793e9ed0bae8bffbcb9057b63fbf7d4ed22c696fee664ce0ffd872c554042ec098437df6853181
-  data.tar.gz: 44dae96b17ce80eaf60de42bf5ae30444b911659c779182598bd06ce5d936db55d672c5c1b846deb76e911752b81b2613ae3d5eebb4d823631deb49ca4473f29
+  metadata.gz: e34cb6fa4efea78da85206ba61dacfc0420121aab94bce8eb63f0947b2c0fded6b2b8cd886bda5b2d29e88a96a93ad035ea0783fa8f83683073607d6a1ebd5df
+  data.tar.gz: 2c50826bb39c0e043cdb6905fb2e9c5dea43bd2169045c7aba6cb095e02e84349005f2108fefb3b06d265ee5329759c31cf1475799d5c83616d93a4bbb6679e7

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 2.1.1 (March 1, 2020)
+
+IMPROVEMENTS:
+
+- Fix potential `nil` cases detected by [Sorbet](https://sorbet.org) including refactorings
+
 ## 2.1.0 (March 1, 2020)
 
 IMPROVEMENTS:

data/lib/dyndnsd.rb

@@ -112,8 +112,14 @@ module Dyndnsd
 
       # drop priviliges as soon as possible
       # NOTE: first change group than user
-      Process::Sys.setgid(Etc.getgrnam(config['group']).gid) if config['group']
-      Process::Sys.setuid(Etc.getpwnam(config['user']).uid) if config['user']
+      if config['group']
+        group = Etc.getgrnam(config['group'])
+        Process::Sys.setgid(group.gid) if group
+      end
+      if config['user']
+        user = Etc.getpwnam(config['user'])
+        Process::Sys.setuid(user.uid) if user
+      end
 
       setup_traps
 

data/lib/dyndnsd/database.rb

@@ -15,7 +15,7 @@ module Dyndnsd
     # @return [void]
     def load
       if File.file?(@db_file)
-        @db = JSON.parse(File.open(@db_file, 'r', &:read))
+        @db = JSON.parse(File.read(@db_file, mode: 'r'))
       else
         @db = {}
       end

data/lib/dyndnsd/helper.rb

@@ -57,7 +57,7 @@ module Dyndnsd
           'error.kind': e.class.to_s,
           'error.object': e,
           message: e.message,
-          stack: e.backtrace.join("\n")
+          stack: e.backtrace&.join("\n") || ''
         )
         raise
       ensure

data/lib/dyndnsd/updater/command_with_bind_zone.rb

@@ -14,7 +14,7 @@ module Dyndnsd
       # @return [void]
       def update(db)
         Helper.span('updater_update') do |span|
-          span.set_tag('dyndnsd.updater.name', self.class.name.split('::').last)
+          span.set_tag('dyndnsd.updater.name', self.class.name&.split('::')&.last || 'None')
 
           # write zone file in bind syntax
           File.open(@zone_file, 'w') { |f| f.write(@generator.generate(db)) }
@@ -24,7 +24,7 @@ module Dyndnsd
           end
 
           # detach so children don't become zombies
-          Process.detach(pid)
+          Process.detach(pid) if pid
         end
       end
     end

data/lib/dyndnsd/version.rb

@@ -1,4 +1,4 @@
 
 module Dyndnsd
-  VERSION = '2.1.0'.freeze
+  VERSION = '2.1.1'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dyndnsd
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Christian Nicolai