dynamini 2.2.5 → 2.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cc2cb03535d576707c7d063479495420f147402c
-  data.tar.gz: 9a13209c5dd606f18be36a0a6b8178cee4a95309
+  metadata.gz: 42a0405b70513e4b385e3e5817bd165f3965a9da
+  data.tar.gz: c248a81d97633dd595b6dfb3ff3f5881dee6c264
 SHA512:
-  metadata.gz: ed8549da709ccd8347fa152729a07ad9889ae33afbdfaa7e8d0162d791a869bbe660c78185eb332eb70ec3c784deda8d0a2d4559848ba24e742b7bb53dbfdabb
-  data.tar.gz: 054b7037256a8e9c8af8c7e8fbe12de5b6f99df929ace57361c731ec07c622bfe49bded36cf43db93b629bd18896455a7ab520bf7711841fe1def54c1cdef51d
+  metadata.gz: ba66289642c867b5cbadbf3078a80d0d809e1210170c7b7ab41046dd6ced32a8d753596dcc919b4f7a602a9c552de0661a39d184593a9c7bc4422b16776d84c6
+  data.tar.gz: 56d3a8b2f619e62de98763b88fec4fec50c2681a53b5086dae33865d979f7f2ac00e9d16af773d61047f6c8fb3c7c564d8625de48c2bb6394a24923ee9c38ce8

data/README.md

@@ -187,6 +187,8 @@ Vehicle.find('H3LLO').stuff
 > ['wheel', 'brakes', BigDecimal(5)]
 ```
 
+Please note that changing arrays in place using mutator methods like << or map! will not record a change to the object. If you want to make changes like this, either use the assignment operator (e.g. model.array = model.array << 'foo') or call model.mark(:attribute) after mutation and before saving to force Dynamini to write the change.
+
 ## Testing
 We've included an optional in-memory test client, so you don't necessarily have to connect to a real Dynamo instance when running tests. You could also use this in your development environment if you don't have a real Dynamo instance yet, but the data saved to it won't persist through a server restart.
 

data/dynamini.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = 'dynamini'
-  s.version = '2.2.5'
+  s.version = '2.2.6'
   s.summary = 'DynamoDB interface'
   s.description = 'Lightweight DynamoDB interface gem designed as
                    a drop-in replacement for ActiveRecord.

data/lib/dynamini/dirty.rb

@@ -14,6 +14,13 @@ module Dynamini
       @new_record
     end
 
+    def mark(attr)
+      if @changes[attr] == [nil, nil]
+        val = @attributes[attr]
+        @changes[attr] = [val, val]
+      end
+    end
+
     private
 
     def record_change(attribute, new_value, old_value)
@@ -35,4 +42,4 @@ module Dynamini
       @changes[attr_name].compact.present? ? @changes[attr_name][0] : read_attribute(attr_name)
     end
   end
-end
+end

data/lib/dynamini/test_client.rb

@@ -1,6 +1,7 @@
-module Dynamini
-  require 'ostruct'
+require 'ostruct'
+require 'active_support/core_ext/object/deep_dup'
 
+module Dynamini
   # In-memory database client for test purposes.
   class TestClient
 
@@ -30,7 +31,6 @@ module Dynamini
       )
 
       primary_index_insertion(hash_key_value, range_key_value, updates, table) if hash_key_value
-
     end
 
     def primary_index_insertion(hash_key_value, range_key_value, updates, table)
@@ -66,7 +66,7 @@ module Dynamini
       attributes_hash = table[hash_key_value]
       attributes_hash = attributes_hash[range_key_value] if attributes_hash && range_key_value
 
-      OpenStruct.new(item: attributes_hash)
+      OpenStruct.new(item: (attributes_hash ? attributes_hash.deep_dup : nil))
     end
 
     # No range key support - use query instead.
@@ -90,7 +90,7 @@ module Dynamini
         put_requests.each do |request_hash|
           item = request_hash[:put_request][:item]
           key = item[hash_key_attr.to_s]
-          get_table(table_name)[key] = item
+          get_table(table_name)[key] = item # not merging since real client does not support batch update
         end
       end
     end

data/spec/dynamini/dirty_spec.rb

@@ -3,13 +3,14 @@ require 'spec_helper'
 describe Dynamini::Dirty do
 
   let(:model_attributes) {
-    {
-        name: 'Widget',
-        price: 9.99,
-        id: 'abcd1234',
-        hash_key: '009'
-    }
+   {
+       name: 'Widget',
+       price: 9.99,
+       id: 'abcd1234',
+       hash_key: '009'
+   }
   }
+
   let(:dirty_model) { Dynamini::Base.new(model_attributes) }
   let(:model) { Dynamini::Base.new(model_attributes, false) }
 
@@ -22,7 +23,31 @@ describe Dynamini::Dirty do
     end
 
     it 'should not include the primary key in the changes' do
-      expect(dirty_model.changes[:id]).to be_nil
+      expect(dirty_model.changes['id']).to be_nil
+    end
+  end
+
+  describe '#mark' do
+    context 'when marking an unchanged attribute' do
+      it 'should add the marked attribute to @changed' do
+        model.mark(:price)
+        expect(model.changed).to eq(['price'])
+      end
+    end
+    context 'when marking an already changed attribute' do
+      it 'should do nothing' do
+        dirty_model.mark(:price)
+        expect(dirty_model.changes['price']).to eq([nil, model_attributes[:price]])
+      end
+    end
+    context 'when using it to mark a changed array' do
+      it 'should write the mutated array value when saving' do
+        model_with_array = Dynamini::Base.new({elements: ['a','b','c'], id: 'foo'}, false)
+        model_with_array.elements << 'd'
+        model_with_array.mark(:elements)
+        model_with_array.save
+        expect(Dynamini::Base.find('foo').elements).to eq(['a','b','c','d'])
+      end
     end
   end
 
@@ -141,4 +166,4 @@ describe Dynamini::Dirty do
       expect(model.changed).to eq(['price', 'name'])
     end
   end
-end
+end

data/spec/dynamini/test_client_spec.rb

@@ -19,7 +19,6 @@ describe Dynamini::TestClient do
         test_client.update_item(table_name: table_name, key: {hash_key_name: 'hash_key_value'}, attribute_updates: {abc: {value: 'def', action: 'PUT'}})
         expect(test_client.data[table_name]['hash_key_value']).to eq(abc: 'def', :hash_key_name => "hash_key_value")
       end
-
     end
 
     context 'with Hash key and range key' do
@@ -76,6 +75,13 @@ describe Dynamini::TestClient do
 
         expect(test_client.get_item(table_name: table_name, key: {test_client.hash_key_attr => "abc", :extra_key => "extra"}).item[:test_attr]).to eq('test')
       end
+
+      it 'should return new (cloned) arrays if arrays are present in the model attributes' do
+        test_client.update_item(table_name: table_name, key: {test_client.hash_key_attr => "abc"}, attribute_updates: {ary: {value: ['a','b','c'], action: 'PUT'}})
+        retrieved = test_client.get_item(table_name: table_name, key: {test_client.hash_key_attr => "abc", :extra_key => "extra"}).item
+        retrieved[:ary] = ['a','b','c','d']
+        expect(test_client.get_item(table_name: table_name, key: {test_client.hash_key_attr => "abc", :extra_key => "extra"}).item[:ary]).to eq(['a','b','c'])
+      end
     end
 
     context 'table with hash and range key' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dynamini
 version: !ruby/object:Gem::Version
-  version: 2.2.5
+  version: 2.2.6
 platform: ruby
 authors:
 - Greg Ward
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-23 00:00:00.000000000 Z
+date: 2016-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel