dynamic_migrations 3.8.7 → 3.8.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 443be07abb74aef74bd5d94de87ab2be7f227f81e1c401cb7bf8ebc55bc1c6af
-  data.tar.gz: f93c398273cb1ae28cf6d5b257adeda625f3c732952f327692fb3ef076798f7f
+  metadata.gz: d822c8e95efe29d0f03f07162f27909ba4222ab4be98c421d64bd167fe923443
+  data.tar.gz: 88a20111dae2a34872d0759f47a0c8c29eab87d354ebb7a55d33152c9d06c6e3
 SHA512:
-  metadata.gz: c35b3c1d1834fea80cfdc2c9b14f611b5d76f005b408e0cbfd7592216780454647c519fbc5113bcd5a946a578320417cde47eeaa785fc097dc5062b79a310522
-  data.tar.gz: '09780db07d086da4fc27c5187770248b174d91e7c89a6f3021f1a87e42f97c3b4cf091e7ed510ef7e853e4da360f5b359bbc91a7375b94edd55d09c52e0f905a'
+  metadata.gz: 2210081126891f62ebadb6dd9f9f53cafd5cdd7ae196558b00e94ffdf91b64b1686d65c95ec07357ee8043ba1e8c698812ed07503d8b46287ab5496e26beb46d
+  data.tar.gz: eb23900019d373320e0f2510eadd2714c1c2c4324af0b0a4f68886754204deb7ebc0de11f833bf43b0a53b38f80448b70370ccd57ca55005c97715c397f4b579

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## [3.8.8](https://github.com/craigulliott/dynamic_migrations/compare/v3.8.7...v3.8.8) (2023-10-11)
+
+
+### Bug Fixes
+
+* adding a specific error type for invalid names ([12df7bd](https://github.com/craigulliott/dynamic_migrations/commit/12df7bddcb947d3ab5b1b00eebefdda0a3ce15ac))
+* fixed bug where check_clause and action_condition were being modified, also freezing strings to prevent similar bugs in the future ([dc1191b](https://github.com/craigulliott/dynamic_migrations/commit/dc1191b7e219b73da8469742259686721265a2a7))
+* removed arbitrary column name sorting, as we want migrations to create columns in the order they were added ([e9a515e](https://github.com/craigulliott/dynamic_migrations/commit/e9a515eb9dbf16ef5a5e77ca0084a6514690530b))
+* removing deferrable and initially deferred from check constraints because postgres doesn't support them ([945aef2](https://github.com/craigulliott/dynamic_migrations/commit/945aef2419fd5f55a0551929244f3f9b0a29a905))
+* should not have assumed enums in the same schema use their short name, enums are always referenced by their full name (including schema) ([a9863ba](https://github.com/craigulliott/dynamic_migrations/commit/a9863ba49727e5016c8eae74f5f2a6e7ab8c1042))
+* we were not resolving the correct deferred and initially_deferred values when loading existing database structure ([02c539a](https://github.com/craigulliott/dynamic_migrations/commit/02c539a8ea153cde6d06f6be6d8fdb0aaf851f40))
+
 ## [3.8.7](https://github.com/craigulliott/dynamic_migrations/compare/v3.8.6...v3.8.7) (2023-10-09)
 
 

data/lib/dynamic_migrations/active_record/migrators/validation.rb

@@ -3,7 +3,7 @@ module DynamicMigrations
     module Migrators
       module Validation
         # this exists because because the standard rails migration does not support deffered constraints
-        def add_validation table_name, name:, initially_deferred: false, deferrable: false, comment: nil, &block
+        def add_validation table_name, name:, comment: nil, &block
           unless block
             raise MissingFunctionBlockError, "create_function requires a block"
           end
@@ -12,28 +12,10 @@ module DynamicMigrations
             sql = block.call.strip
           end
 
-          if initially_deferred == true && deferrable == false
-            raise DeferrableOptionsError, "A constraint can only be initially deferred if it is also deferrable"
-          end
-
-          # allow it to be deferred, and defer it by default
-          deferrable_sql = if initially_deferred
-            "DEFERRABLE INITIALLY DEFERRED"
-
-          # allow it to be deferred, but do not deferr by default
-          elsif deferrable
-            "DEFERRABLE INITIALLY IMMEDIATE"
-
-          # it can not be deferred (this is the default)
-          else
-            "NOT DEFERRABLE"
-          end
-
           execute <<~SQL
             ALTER TABLE #{table_name}
               ADD CONSTRAINT #{name}
-                CHECK (#{sql})
-                #{deferrable_sql};
+                CHECK (#{sql});
           SQL
 
           if comment.is_a? String

data/lib/dynamic_migrations/postgres/generator/fragment.rb

@@ -5,6 +5,9 @@ module DynamicMigrations
         class InvalidNameError < StandardError
         end
 
+        class ContentRequiredError < StandardError
+        end
+
         attr_reader :schema_name
         attr_reader :table_name
         attr_reader :migration_method
@@ -33,8 +36,12 @@ module DynamicMigrations
           @object_name = object_name
 
           @migration_method = migration_method
-          @code_comment = code_comment
-          @content = content
+          @code_comment = code_comment&.freeze
+
+          if content.nil?
+            raise ContentRequiredError, "Content is required for a fragment"
+          end
+          @content = content.freeze
         end
 
         # Returns a string representation of the fragment for use in the final

data/lib/dynamic_migrations/postgres/generator/validation.rb

@@ -38,9 +38,7 @@ module DynamicMigrations
           else
 
             options = {
-              name: ":#{validation.name}",
-              deferrable: validation.deferrable,
-              initially_deferred: validation.initially_deferred
+              name: ":#{validation.name}"
             }
 
             if validation.description.nil?

data/lib/dynamic_migrations/postgres/generator/validation_template_base.rb

@@ -10,17 +10,11 @@ module DynamicMigrations
 
         def initialize validation, code_comment
           @validation = validation
-          @code_comment = code_comment
+          @code_comment = code_comment&.freeze
         end
 
         private
 
-        def assert_not_deferred!
-          if @validation.initially_deferred || @validation.deferrable
-            raise TemplateError, "#{self.class.name} validation template requires constraints to be are not deferrable"
-          end
-        end
-
         def assert_column_count! count = 1
           if @validation.columns.count != count
             raise TemplateError, "#{self.class.name} validation template requires a validation with only #{count} column"

data/lib/dynamic_migrations/postgres/server/database/differences.rb

@@ -367,9 +367,7 @@ module DynamicMigrations
               result[name] = compare_record validation, comparison_validations[name], [
                 :normalized_check_clause,
                 :column_names,
-                :description,
-                :deferrable,
-                :initially_deferred
+                :description
               ]
             end
             # look for any validations in the comparison list which were not in the base list
@@ -435,6 +433,13 @@ module DynamicMigrations
                 log.debug "    Comparing `#{method_name}`"
 
                 matches = (comparison && comparison.send(method_name) == base.send(method_name)) || false
+
+                unless matches
+                  log.debug "      Values are different"
+                  log.debug "        Base Value:  `#{base.send(method_name)}`"
+                  log.debug "        Other Value: `#{comparison.nil? ? "nil" : comparison.send(method_name)}`"
+                end
+
                 result[method_name] = {
                   value: base.send(method_name),
                   matches: matches

data/lib/dynamic_migrations/postgres/server/database/keys_and_unique_constraints_loader.rb

@@ -152,8 +152,8 @@ module DynamicMigrations
                 on_delete = nil
               end
 
-              deferrable = row["deferrable"] == "TRUE"
-              initially_deferred = row["initially_deferred"] == "TRUE"
+              deferrable = row["deferrable"] == "t"
+              initially_deferred = row["initially_deferred"] == "t"
 
               index_type = if row["index_type"].nil?
                 nil

data/lib/dynamic_migrations/postgres/server/database/loaded_schemas_builder.rb

@@ -60,7 +60,7 @@ module DynamicMigrations
 
                 # add any validations
                 table_validations&.each do |validation_name, validation_definition|
-                  table.add_validation validation_name, validation_definition[:columns], validation_definition[:check_clause], description: validation_definition[:description], deferrable: validation_definition[:deferrable], initially_deferred: validation_definition[:initially_deferred]
+                  table.add_validation validation_name, validation_definition[:columns], validation_definition[:check_clause], description: validation_definition[:description]
                 end
               end
             end

data/lib/dynamic_migrations/postgres/server/database/schema/enum.rb

@@ -50,7 +50,7 @@ module DynamicMigrations
 
               unless description.nil?
                 raise ExpectedStringError, description unless description.is_a? String
-                @description = description.strip
+                @description = description.strip.freeze
                 @description = nil if description == ""
               end
             end
@@ -68,7 +68,7 @@ module DynamicMigrations
                 raise EnumValueTooLongError, "Value `#{value}` must be less than 64 characters"
               end
 
-              @values << value
+              @values << value.freeze
             end
 
             # returns true if this enum has a description, otehrwise false

data/lib/dynamic_migrations/postgres/server/database/schema/function.rb

@@ -37,11 +37,11 @@ module DynamicMigrations
               unless definition.is_a?(String) && definition.strip != "" && definition.strip.end_with?("END;", "END")
                 raise ExpectedDefinitionError, "Definition must be a string, and end with `END;`. Definition provided:\n#{definition}"
               end
-              @definition = definition.strip
+              @definition = definition.strip.freeze
 
               unless description.nil?
                 raise ExpectedStringError, description unless description.is_a? String
-                @description = description.strip
+                @description = description.strip.freeze
                 @description = nil if description == ""
               end
             end

data/lib/dynamic_migrations/postgres/server/database/schema/table/column.rb

@@ -14,6 +14,9 @@ module DynamicMigrations
               class UnexpectedEnumError < StandardError
               end
 
+              class InvalidNameError < StandardError
+              end
+
               attr_reader :table
               attr_reader :name
               attr_reader :data_type
@@ -29,7 +32,8 @@ module DynamicMigrations
                 raise ExpectedTableError, table unless table.is_a? Table
                 @table = table
 
-                raise ExpectedSymbolError, name unless name.is_a? Symbol
+                raise InvalidNameError, "Unexpected name `#{name}`. Name should be a Symbol" unless name.is_a? Symbol
+                raise InvalidNameError, "The name `#{name}` is too long. Names must be less than 64 characters" unless name.length < 64
                 @name = name
 
                 raise ExpectedSymbolError, data_type unless data_type.is_a? Symbol
@@ -44,7 +48,7 @@ module DynamicMigrations
 
                 unless description.nil?
                   raise ExpectedStringError, description unless description.is_a? String
-                  @description = description.strip
+                  @description = description.strip.freeze
                   @description = nil if description == ""
                 end
 

data/lib/dynamic_migrations/postgres/server/database/schema/table/columns.rb

@@ -50,12 +50,6 @@ module DynamicMigrations
                 else
                   raise ModuleIncludedIntoUnexpectedTargetError, included_target
                 end
-                # sort the hash so that the columns are in alphabetical order by name
-                sorted_columns = {}
-                @columns.keys.sort.each do |name|
-                  sorted_columns[name] = @columns[name]
-                end
-                @columns = sorted_columns
                 # return the new column
                 new_column
               end

data/lib/dynamic_migrations/postgres/server/database/schema/table/foreign_key_constraint.rb

@@ -20,6 +20,9 @@ module DynamicMigrations
               class UnexpectedReferentialActionError < StandardError
               end
 
+              class InvalidNameError < StandardError
+              end
+
               attr_reader :table
               attr_reader :foreign_table
               attr_reader :name
@@ -64,12 +67,13 @@ module DynamicMigrations
                   add_column column, true
                 end
 
-                raise ExpectedSymbolError, name unless name.is_a? Symbol
+                raise InvalidNameError, "Unexpected name `#{name}`. Name should be a Symbol" unless name.is_a? Symbol
+                raise InvalidNameError, "The name `#{name}` is too long. Names must be less than 64 characters" unless name.length < 64
                 @name = name
 
                 unless description.nil?
                   raise ExpectedStringError, description unless description.is_a? String
-                  @description = description.strip
+                  @description = description.strip.freeze
                   @description = nil if description == ""
                 end
 

data/lib/dynamic_migrations/postgres/server/database/schema/table/index.rb

@@ -30,6 +30,9 @@ module DynamicMigrations
               class DuplicateColumnError < StandardError
               end
 
+              class InvalidNameError < StandardError
+              end
+
               attr_reader :table
               attr_reader :name
               attr_reader :unique
@@ -56,12 +59,13 @@ module DynamicMigrations
                   add_column column
                 end
 
-                raise ExpectedSymbolError, name unless name.is_a? Symbol
+                raise InvalidNameError, "Unexpected name `#{name}`. Name should be a Symbol" unless name.is_a? Symbol
+                raise InvalidNameError, "The name `#{name}` is too long. Names must be less than 64 characters" unless name.length < 64
                 @name = name
 
                 unless description.nil?
                   raise ExpectedStringError, description unless description.is_a? String
-                  @description = description.strip
+                  @description = description.strip.freeze
                   @description = nil if description == ""
                 end
 
@@ -70,7 +74,7 @@ module DynamicMigrations
 
                 unless where.nil?
                   raise ExpectedStringError, where unless where.is_a? String
-                  @where = where
+                  @where = where.freeze
                 end
 
                 raise UnexpectedIndexTypeError, type unless INDEX_TYPES.include?(type)

data/lib/dynamic_migrations/postgres/server/database/schema/table/primary_key.rb

@@ -20,6 +20,9 @@ module DynamicMigrations
               class DuplicateColumnError < StandardError
               end
 
+              class InvalidNameError < StandardError
+              end
+
               attr_reader :table
               attr_reader :name
               attr_reader :description
@@ -40,12 +43,13 @@ module DynamicMigrations
                   add_column column
                 end
 
-                raise ExpectedSymbolError, name unless name.is_a? Symbol
+                raise InvalidNameError, "Unexpected name `#{name}`. Name should be a Symbol" unless name.is_a? Symbol
+                raise InvalidNameError, "The name `#{name}` is too long. Names must be less than 64 characters" unless name.length < 64
                 @name = name
 
                 unless description.nil?
                   raise ExpectedStringError, description unless description.is_a? String
-                  @description = description.strip
+                  @description = description.strip.freeze
                   @description = nil if description == ""
                 end
               end

data/lib/dynamic_migrations/postgres/server/database/schema/table/trigger.rb

@@ -41,6 +41,9 @@ module DynamicMigrations
               class UnnormalizableActionConditionError < StandardError
               end
 
+              class InvalidNameError < StandardError
+              end
+
               attr_reader :table
               attr_reader :name
               attr_reader :event_manipulation
@@ -63,9 +66,8 @@ module DynamicMigrations
                 end
                 @table = table
 
-                unless name.is_a? Symbol
-                  raise ExpectedSymbolError, name
-                end
+                raise InvalidNameError, "Unexpected name `#{name}`. Name should be a Symbol" unless name.is_a? Symbol
+                raise InvalidNameError, "The name `#{name}` is too long. Names must be less than 64 characters" unless name.length < 64
                 @name = name
 
                 unless [:before, :after].include? action_timing
@@ -93,12 +95,12 @@ module DynamicMigrations
                 unless action_condition.nil? || action_condition.is_a?(String)
                   raise ExpectedStringError, action_condition
                 end
-                @action_condition = action_condition&.strip
+                @action_condition = action_condition&.strip&.freeze
 
                 unless parameters.is_a?(Array) && parameters.all? { |p| p.is_a? String }
                   raise UnexpectedParametersError, "unexpected parameters `#{parameters}`, currently only an array of strings is supported"
                 end
-                @parameters = parameters
+                @parameters = parameters.map(&:freeze)
 
                 unless [:row, :statement].include? action_orientation
                   raise UnexpectedActionOrientationError, action_orientation
@@ -128,7 +130,7 @@ module DynamicMigrations
 
                 unless description.nil?
                   raise ExpectedStringError, description unless description.is_a? String
-                  @description = description.strip
+                  @description = description.strip.freeze
                   @description = nil if description == ""
                 end
 
@@ -166,7 +168,7 @@ module DynamicMigrations
                 unless new_action_condition.nil? || new_action_condition.is_a?(String)
                   raise ExpectedStringError, new_action_condition
                 end
-                @action_condition = new_action_condition&.strip
+                @action_condition = new_action_condition&.strip&.freeze
               end
 
               def add_parameter new_parameter
@@ -224,7 +226,7 @@ module DynamicMigrations
                       $$ BEGIN END $$;
                     SQL
 
-                    temp_action_condition = action_condition
+                    temp_action_condition = action_condition.dup
                     # string replace any real enum names with their temp enum names
                     temp_enums.each do |temp_enum_name, enum|
                       temp_action_condition.gsub!("::#{enum.name}", "::#{temp_enum_name}")

data/lib/dynamic_migrations/postgres/server/database/schema/table/triggers.rb

@@ -17,14 +17,14 @@ module DynamicMigrations
               # returns the trigger object for the provided trigger name, and raises an
               # error if the trigger does not exist
               def trigger name
-                raise ExpectedSymbolError, name unless name.is_a? Symbol
+                raise Trigger::InvalidNameError, name unless name.is_a? Symbol
                 raise TriggerDoesNotExistError unless has_trigger? name
                 @triggers[name]
               end
 
               # returns true if this table has a trigger with the provided name, otherwise false
               def has_trigger? name
-                raise ExpectedSymbolError, name unless name.is_a? Symbol
+                raise Trigger::InvalidNameError, name unless name.is_a? Symbol
                 @triggers.key? name
               end
 

data/lib/dynamic_migrations/postgres/server/database/schema/table/unique_constraint.rb

@@ -23,6 +23,9 @@ module DynamicMigrations
               class DuplicateColumnError < StandardError
               end
 
+              class InvalidNameError < StandardError
+              end
+
               attr_reader :table
               attr_reader :name
               attr_reader :deferrable
@@ -45,12 +48,13 @@ module DynamicMigrations
                   add_column column
                 end
 
-                raise ExpectedSymbolError, name unless name.is_a? Symbol
+                raise InvalidNameError, "Unexpected name `#{name}`. Name should be a Symbol" unless name.is_a? Symbol
+                raise InvalidNameError, "The name `#{name}` is too long. Names must be less than 64 characters" unless name.length < 64
                 @name = name
 
                 unless description.nil?
                   raise ExpectedStringError, description unless description.is_a? String
-                  @description = description.strip
+                  @description = description.strip.freeze
                   @description = nil if description == ""
                 end
 

data/lib/dynamic_migrations/postgres/server/database/schema/table/validation.rb

@@ -26,25 +26,27 @@ module DynamicMigrations
               class UnnormalizableCheckClauseError < StandardError
               end
 
+              class InvalidNameError < StandardError
+              end
+
               attr_reader :table
               attr_reader :name
               attr_reader :check_clause
-              attr_reader :deferrable
-              attr_reader :initially_deferred
               attr_reader :description
               attr_reader :template
 
               # initialize a new object to represent a validation in a postgres table
-              def initialize source, table, columns, name, check_clause, description: nil, deferrable: false, initially_deferred: false, template: nil
+              def initialize source, table, columns, name, check_clause, description: nil, template: nil
                 super source
                 raise ExpectedTableError, table unless table.is_a? Table
                 @table = table
 
-                raise ExpectedSymbolError, name unless name.is_a? Symbol
+                raise InvalidNameError, "Unexpected name `#{name}`. Name should be a Symbol" unless name.is_a? Symbol
+                raise InvalidNameError, "The name `#{name}` is too long. Names must be less than 64 characters" unless name.length < 64
                 @name = name
 
                 raise ExpectedStringError, check_clause unless check_clause.is_a? String
-                @check_clause = check_clause.strip
+                @check_clause = check_clause.strip.freeze
 
                 # if this validation is created via configuration (apposed to being loaded) then they can be lazy loaded
                 unless from_configuration? && columns.nil?
@@ -61,16 +63,10 @@ module DynamicMigrations
 
                 unless description.nil?
                   raise ExpectedStringError, description unless description.is_a? String
-                  @description = description.strip
+                  @description = description.strip.freeze
                   @description = nil if description == ""
                 end
 
-                raise ExpectedBooleanError, deferrable unless [true, false].include?(deferrable)
-                @deferrable = deferrable
-
-                raise ExpectedBooleanError, initially_deferred unless [true, false].include?(initially_deferred)
-                @initially_deferred = initially_deferred
-
                 unless template.nil?
                   unless Generator::Validation.has_template? template
                     raise UnexpectedTemplateError, "Unrecognised template #{template}"
@@ -96,14 +92,12 @@ module DynamicMigrations
               end
 
               def column_names
-                columns.map(&:name)
+                columns.map(&:name).sort
               end
 
               def differences_descriptions other_validation
                 method_differences_descriptions other_validation, [
-                  :normalized_check_clause,
-                  :deferrable,
-                  :initially_deferred
+                  :normalized_check_clause
                 ]
               end
 
@@ -134,7 +128,7 @@ module DynamicMigrations
 
                   temp_enums = table.create_temp_table(connection, "validation_normalized_check_clause_temp_table")
 
-                  temp_check_clause = check_clause
+                  temp_check_clause = check_clause.dup
                   # string replace any real enum names with their temp enum names
                   temp_enums.each do |temp_enum_name, enum|
                     temp_check_clause.gsub!("::#{enum.name}", "::#{temp_enum_name}")
@@ -182,8 +176,7 @@ module DynamicMigrations
 
                   # string replace any enum names with their real enum names
                   temp_enums.each do |temp_enum_name, enum|
-                    real_enum_name = (enum.schema == table.schema) ? enum.name : enum.full_name
-                    check_clause_result.gsub!("::#{temp_enum_name}", "::#{real_enum_name}")
+                    check_clause_result.gsub!("::#{temp_enum_name}", "::#{enum.full_name}")
                   end
 
                   column_names_result = column_names_string.gsub(/\A\{/, "").gsub(/\}\Z/, "").split(",").map { |column_name| column_name.to_sym }

data/lib/dynamic_migrations/postgres/server/database/schema/table.rb

@@ -43,7 +43,7 @@ module DynamicMigrations
 
               unless description.nil?
                 raise ExpectedStringError, description unless description.is_a? String
-                @description = description.strip
+                @description = description.strip.freeze
                 @description = nil if description == ""
               end
 

data/lib/dynamic_migrations/postgres/server/database/validations_loader.rb

@@ -86,9 +86,7 @@ module DynamicMigrations
               table[validation_name] = {
                 columns: row["columns"].gsub(/\A\{/, "").gsub(/\}\Z/, "").split(",").map { |column_name| column_name.to_sym },
                 check_clause: check_clause,
-                description: row["description"],
-                deferrable: row["deferrable"] == "TRUE",
-                initially_deferred: row["initially_deferred"] == "TRUE"
+                description: row["description"]
               }
             end
             schemas

data/lib/dynamic_migrations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DynamicMigrations
-  VERSION = "3.8.7"
+  VERSION = "3.8.8"
 end

data/sig/dynamic_migrations/active_record/migrators/validation.rbs

@@ -5,7 +5,7 @@ module DynamicMigrations
   module ActiveRecord
     module Migrators
       module Validation
-        def add_validation: (Symbol table_name, name: Symbol, ?initially_deferred: bool, ?deferrable: bool, ?comment: String?) -> void
+        def add_validation: (Symbol table_name, name: Symbol, ?comment: String?) -> void
         def remove_validation: (Symbol table_name, Symbol name) -> void
         def set_validation_comment: (Symbol table_name, Symbol validation_name, String comment) -> void
         def remove_validation_comment: (Symbol table_name, Symbol validation_name) -> void

data/sig/dynamic_migrations/postgres/generator/fragment.rbs

@@ -40,6 +40,9 @@ module DynamicMigrations
 
         class InvalidNameError < StandardError
         end
+
+        class ContentRequiredError < StandardError
+        end
       end
     end
   end

data/sig/dynamic_migrations/postgres/generator/validation_template_base.rbs

@@ -15,7 +15,6 @@ module DynamicMigrations
         def fragment_arguments: -> {schema: Postgres::Server::Database::Schema, table: Postgres::Server::Database::Schema::Table, migration_method: Symbol, object: untyped, code_comment: String?, migration: String, dependent_function: Postgres::Server::Database::Schema::Function?}
 
         private
-        def assert_not_deferred!: -> void
         def assert_column_count!: (?Integer count) -> void
         def first_column: -> Postgres::Server::Database::Schema::Table::Column
         def value_from_check_clause: (Regexp regex) -> untyped

data/sig/dynamic_migrations/postgres/server/database/schema/table/column.rbs

@@ -27,6 +27,9 @@ module DynamicMigrations
 
               class UnexpectedEnumError < StandardError
               end
+
+              class InvalidNameError < StandardError
+              end
             end
           end
         end

data/sig/dynamic_migrations/postgres/server/database/schema/table/foreign_key_constraint.rbs

@@ -43,6 +43,9 @@ module DynamicMigrations
 
               class UnexpectedReferentialActionError < StandardError
               end
+
+              class InvalidNameError < StandardError
+              end
             end
           end
         end

data/sig/dynamic_migrations/postgres/server/database/schema/table/index.rbs

@@ -53,6 +53,9 @@ module DynamicMigrations
 
               class DuplicateColumnError < StandardError
               end
+
+              class InvalidNameError < StandardError
+              end
             end
           end
         end

data/sig/dynamic_migrations/postgres/server/database/schema/table/primary_key.rbs

@@ -31,6 +31,9 @@ module DynamicMigrations
 
               class DuplicateColumnError < StandardError
               end
+
+              class InvalidNameError < StandardError
+              end
             end
           end
         end

data/sig/dynamic_migrations/postgres/server/database/schema/table/trigger.rbs

@@ -65,6 +65,9 @@ module DynamicMigrations
 
               class UnnormalizableActionConditionError < StandardError
               end
+
+              class InvalidNameError < StandardError
+              end
             end
           end
         end

data/sig/dynamic_migrations/postgres/server/database/schema/table/unique_constraint.rbs

@@ -40,6 +40,9 @@ module DynamicMigrations
 
               class DuplicateColumnError < StandardError
               end
+
+              class InvalidNameError < StandardError
+              end
             end
           end
         end

data/sig/dynamic_migrations/postgres/server/database/schema/table/validation.rbs

@@ -11,12 +11,10 @@ module DynamicMigrations
               attr_reader table: Table
               attr_reader name: Symbol
               attr_reader check_clause: String
-              attr_reader deferrable: bool
-              attr_reader initially_deferred: bool
               attr_reader description: String?
               attr_reader template: Symbol?
 
-              def initialize: (database_or_configuration source, Table table, Array[Column]? columns, Symbol name, String check_clause, ?deferrable: bool, ?initially_deferred: bool, ?description: String?, ?template: Symbol?) -> void
+              def initialize: (database_or_configuration source, Table table, Array[Column]? columns, Symbol name, String check_clause, ?description: String?, ?template: Symbol?) -> void
               def columns: -> Array[Column]
               def column_names: -> Array[Symbol]
               def has_description?: -> bool
@@ -50,6 +48,9 @@ module DynamicMigrations
 
               class UnnormalizableCheckClauseError < StandardError
               end
+
+              class InvalidNameError < StandardError
+              end
             end
           end
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dynamic_migrations
 version: !ruby/object:Gem::Version
-  version: 3.8.7
+  version: 3.8.8
 platform: ruby
 authors:
 - Craig Ulliott
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-10-09 00:00:00.000000000 Z
+date: 2023-10-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pg
@@ -96,7 +96,6 @@ files:
 - lib/dynamic_migrations/expected_symbol_error.rb
 - lib/dynamic_migrations/invalid_source_error.rb
 - lib/dynamic_migrations/module_included_into_unexpected_target_error.rb
-- lib/dynamic_migrations/name_helper.rb
 - lib/dynamic_migrations/postgres.rb
 - lib/dynamic_migrations/postgres/connections.rb
 - lib/dynamic_migrations/postgres/generator.rb

data/lib/dynamic_migrations/name_helper.rb

@@ -1,13 +0,0 @@
-module DynamicMigrations
-  module NameHelper
-    # shortens a table name like 'invoice_subscription_prepayments' to 'inv_sub_pre'
-    warn "no unit tests"
-    def abbreviate_table_name table_name
-      table_name_without_schema = table_name.to_s.split(".").last
-      if table_name_without_schema.nil?
-        raise "no table name provided"
-      end
-      table_name_without_schema.split("_").map { |v| v[0..2] }.join("_")
-    end
-  end
-end