dynamic_fieldsets 0.0.12 → 0.0.13

data/CHANGELOG

@@ -1,3 +1,8 @@
+== 0.0.13
+
+* Added an error to the FieldsetAssociator.find_by_fieldset_model_parameters to give better information if the fieldset is missing
+* Fixed a problem with field_show_renderer and added markup/classes to it.
+
 == 0.0.12
 
 * Fixed stray typo and failing test

data/VERSION

@@ -1 +1 @@
-0.0.12
+0.0.13

data/app/helpers/dynamic_fieldsets_helper.rb

@@ -27,9 +27,9 @@ module DynamicFieldsetsHelper
   def field_show_renderer(fsa, fieldset_child, values = [])
     field = fieldset_child.child
     lines = []
-    lines.push "<div class='dynamic_fieldsets_field'>"
-    lines.push "<div class='dynamic_fieldsets_field_label'>#{field.label}</div>"
-    lines.push "<div class='dynamic_fieldsets_field_value'>"
+    lines.push "<div class='dynamic_fieldsets field'>"
+    lines.push "<span class='label'>#{field.label}</div>"
+    lines.push "<span class='value'>"
     if values
       if field.field_type == "multiple_select" || field.field_type == "checkbox"
         values.each do |value|
@@ -43,8 +43,9 @@ module DynamicFieldsetsHelper
         lines.push values
       end
     else
-      lines.push "No answer given"
+      lines.push "<em class='empty'>No answer given</em>"
     end
+    lines.push "</span>"
     lines.push "</div>"
     return lines
   end

data/app/models/dynamic_fieldsets/fieldset_associator.rb

@@ -25,10 +25,14 @@ module DynamicFieldsets
     # fieldset_model_type: The class name of the fieldset model
     # fieldset_model_name: The named fieldset in the model
     #
+    # Throws an error if the fieldset does not exist to help with debugging
+    #
     # @params [Hash] args A hash of arguments for the scope
-    # @retursn [Array] An array of fieldset associators that match the arguments
+    # @returns [Array] An array of fieldset associators that match the arguments
     def self.find_by_fieldset_model_parameters(args)
       fieldset = Fieldset.find_by_nkey(args[:fieldset])
+      throw "Fieldset not found in FieldsetAssociator.find_by_fieldset_model_parameters" if fieldset.nil?
+
       where(
         :fieldset_id => fieldset.id, 
         :fieldset_model_id => args[:fieldset_model_id], 

data/dynamic_fieldsets.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{dynamic_fieldsets}
-  s.version = "0.0.12"
+  s.version = "0.0.13"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = [%q{Jeremiah Hemphill}, %q{Ethan Pemble}, %q{John Carter}]
-  s.date = %q{2012-01-25}
+  s.date = %q{2012-01-30}
   s.description = %q{Dynamic fieldsets for rails controllers}
   s.email = %q{jeremiah@cloudspace.com}
   s.extra_rdoc_files = [

data/spec/models/fieldset_associator_spec.rb

@@ -66,6 +66,11 @@ describe FieldsetAssociator do
       FieldsetAssociator.find_by_fieldset_model_parameters(@fieldset_model_attributes)
     end
 
+    it "should throw an error if the fieldset does not exist" do
+      Fieldset.stub!(:find_by_nkey).and_return(nil)
+      lambda { FieldsetAssociator.find_by_fieldset_model_parameters(@fieldset_model_attributes) }.should raise_error
+    end
+
     it "should return the correct fieldset associator" do
       Fieldset.stub!(:find_by_nkey).and_return(@fieldset)
       # this is a fun hack because of all the fsas being made during tests

metadata

@@ -2,7 +2,7 @@
 name: dynamic_fieldsets
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.12
+  version: 0.0.13
 platform: ruby
 authors: 
 - Jeremiah Hemphill
@@ -12,7 +12,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-01-25 00:00:00 Z
+date: 2012-01-30 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rails
@@ -351,7 +351,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 1785029968753232682
+      hash: 4534077377862689434
       segments: 
       - 0
       version: "0"