dynamic_fieldsets 0.0.9 → 0.0.10

data/CHANGELOG

@@ -1,3 +1,8 @@
+== 0.0.10
+
+* Fixed an issue where models using Dynamic Fieldsets could not be created without the fieldset information
+* Removed a line break from the default textarea introduced by the html processing in the hlper
+
 == 0.0.9
 
 * Added field_records_by_field_name method to find the answers to questions by name

data/VERSION

@@ -1 +1 @@
-0.0.9
+0.0.10

data/app/helpers/dynamic_fieldsets_helper.rb

@@ -117,9 +117,9 @@ module DynamicFieldsetsHelper
       tag = "<textarea"
       attrs.each{ |att,val| tag += " #{att}=\"#{val}\"" }
       tag += ">"
+      tag += populate( field, values )
+      tag += "</textarea>"
       field_markup.push tag
-      field_markup.push populate( field, values )
-      field_markup.push "</textarea>"
       
     when :date
       date_options = { start_year: Time.now.year - 70 }

data/dynamic_fieldsets.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{dynamic_fieldsets}
-  s.version = "0.0.9"
+  s.version = "0.0.10"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = [%q{Jeremiah Hemphill}, %q{Ethan Pemble}, %q{John Carter}]
-  s.date = %q{2012-01-19}
+  s.date = %q{2012-01-25}
   s.description = %q{Dynamic fieldsets for rails controllers}
   s.email = %q{jeremiah@cloudspace.com}
   s.extra_rdoc_files = [

data/lib/dynamic_fieldsets/dynamic_fieldsets_in_model.rb

@@ -52,16 +52,23 @@ module DynamicFieldsets
       end
 
       # Iterates over the fieldset associator's children and adds errors
+      #
+      # Will not validate fieldsets that are missing from the dynamic_fieldsets_values hash
+      # This means that if the data is not provided by the controller, no checks will be run
       def run_dynamic_fieldset_validations!
         # for each fsa
         self.dynamic_fieldsets.keys.each do |key|
           fsa = self.fieldset_associator(key)
-          run_fieldset_child_validations!(fsa.id, fsa.fieldset)
+          fsa_tag_id = "fsa-" + fsa.id.to_s
+
+          if !self.dynamic_fieldset_values.nil? && self.dynamic_fieldset_values.has_key?(fsa_tag_id)
+            run_fieldset_child_validations!(fsa.id, fsa.fieldset)
+          end
         end
       end
       
       # Checks if a fieldset child is required and adds an error if it's value is blank
-      # Adds errors to the sel.errors array, does not return them
+      # Adds errors to the self.errors array, does not return them
       #
       # @param [Integer] fsa_id The id for the fieldset associator the child belongs to
       # @param [Field or Fieldset] child The child of the fieldset associator
@@ -75,8 +82,8 @@ module DynamicFieldsets
           # if a child, check if the params value is set, check if it is required, check if it satisfies condition
           fsa_tag_id = "fsa-" + fsa_id.to_s
           field_tag_id = "field-" + child.id.to_s
-          if !self.dynamic_fieldset_values.has_key?(fsa_tag_id) || !self.dynamic_fieldset_values[fsa_tag_id].has_key?(field_tag_id)
-            self.errors.add(:base, child.label + " is required and the input is missing")
+          if !self.dynamic_fieldset_values[fsa_tag_id].has_key?(field_tag_id)
+            self.errors.add(:base, child.label + " is missing from the form data")
           else
             # get the value
             value = self.dynamic_fieldset_values[fsa_tag_id][field_tag_id]
@@ -91,7 +98,9 @@ module DynamicFieldsets
         end
       end
       
-      # Stores the dynamic fieldset values
+      # Stores data from the controller into the dynamic_fieldset_values instance variable
+      #
+      # @param [Hash] params The parameters from the controller that include fsa tags
       def set_fieldset_values( params )
         values = params.select{ |key| key.match(/^fsa-/) }
         values.keys.each do |key|
@@ -101,6 +110,11 @@ module DynamicFieldsets
       end
       
       # This turns your date fields into a MySQL-happy single format.  This modifies the hash.
+      #
+      # This method may cause bugs for servers not using UTC time because of the way rails deals with
+      # time conversions.  If the query receives a string instead of a time object, time zone information
+      # may be saved incorrectly. (1-25-2012)
+      #
       # @param [Hash] post The post parameters that include date fields like date(1i), date(2i), ...
       # @return [Hash] The modified hash containing one key-pair value in YYYY-MM-DD[ hh:mm] format.
       def set_date_to_mysql( post )

data/spec/dummy/app/models/information_form.rb

@@ -1,3 +1,5 @@
 class InformationForm < ActiveRecord::Base
+  # important note: for this to work, there needs to have a fieldset with an nkey of "first" in the db
+  # so that DynamicFieldsets::Fieldset.find_by_nkey("first") returns a fieldset
   acts_as_dynamic_fieldset :child_form => {:fieldset => :first}
 end

data/spec/dynamic_fieldsets_in_model_spec.rb

@@ -62,6 +62,7 @@ describe DynamicFieldsetsInModel do
     end
 
     it "should call run_fieldset_child_validations for each key" do
+      @information_form.stub!(:dynamic_fieldset_values).and_return({"fsa-1" => {}})
       @information_form.should_receive(:run_fieldset_child_validations!)
       @information_form.run_dynamic_fieldset_validations!
     end
@@ -91,7 +92,7 @@ describe DynamicFieldsetsInModel do
       values = { "fsa-1" => { "field-4200"=>"" } }
       @information_form.stub!(:dynamic_fieldset_values).and_return(values)
       @information_form.run_fieldset_child_validations!(@fsa.id, @field)
-      @information_form.errors[:base].should include "Test Field is required and the input is missing"
+      @information_form.errors[:base].should include "Test Field is missing from the form data"
     end
 
     it "should add an error if the field is required, the value is an array, and the value is empty" do

metadata

@@ -2,7 +2,7 @@
 name: dynamic_fieldsets
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.9
+  version: 0.0.10
 platform: ruby
 authors: 
 - Jeremiah Hemphill
@@ -12,7 +12,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-01-19 00:00:00 Z
+date: 2012-01-25 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rails
@@ -351,7 +351,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -2492720374457276068
+      hash: -1922917679847302797
       segments: 
       - 0
       version: "0"