dynamic_class 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f0bcefb083d8034817163abd4a89cea881857f76
-  data.tar.gz: f022a9ff7afefd4f40383b5e2be213a9510dab95
+  metadata.gz: 9b151ef4fe4e1436998fe710a7398d0f4260f17c
+  data.tar.gz: 7814c667c0cb6bfb2495e65a216198de3b23338a
 SHA512:
-  metadata.gz: 1743ad57ee809cc4900c37b33d02e97838570ba5e408aa5f9a2f690b5c071b0cdb6bff9582e8e2f2d88fdb6d726966632c6f7e5392c5b91f78b11eca718f4027
-  data.tar.gz: dddc7b18eb8ca3a59439fb72df86e756384a8e94b0b7bdf1cef88835ec8bc64cd687e3983a32182024249c5f3a24f27290e7a2af301cb6dd5cfebacdf4a9a785
+  metadata.gz: 0f2bf53ba80db5106d3b26b498cc694e72b81adb5a4bafeb6dc0597f6b65f503c0fdcd55c85a3068645058a86abdd4d245381bf375e2c0a1f460d6ed70cb8ff7
+  data.tar.gz: 0f2a16f2112a9cccd930ad8bb49ce34f0a4ea99866c0edeb11efd12c14e3c65c049a6fb08a24288490123a344aa93063686fcd26b3ac20b2a34d4320477b64d9

data/README.md

@@ -36,107 +36,106 @@ the cost of setting a property drops.
 
 The results are pretty astounding. Here are the results of the benchmark in
 `bin/benchmark.rb` (including a few other `OpenStruct`-like solutions for
-comparison):
+comparison), run on Ruby 2.2.4:
 
 ```
 Initialization benchmark
 
 Calculating -------------------------------------
-          OpenStruct    11.183k i/100ms
-PersistentOpenStruct    46.448k i/100ms
-      OpenFastStruct    47.295k i/100ms
-        DynamicClass    47.797k i/100ms
-        RegularClass   101.410k i/100ms
+          OpenStruct    14.668k i/100ms
+PersistentOpenStruct    50.880k i/100ms
+      OpenFastStruct    49.682k i/100ms
+        DynamicClass    60.946k i/100ms
+        RegularClass   107.521k i/100ms
 -------------------------------------------------
-          OpenStruct    138.431k (±13.8%) i/s -    682.163k
-PersistentOpenStruct    757.737k (± 5.3%) i/s -      3.809M
-      OpenFastStruct    783.310k (± 6.0%) i/s -      3.925M
-        DynamicClass    766.130k (± 3.6%) i/s -      3.872M
-        RegularClass      3.037M (± 7.2%) i/s -     15.110M
+          OpenStruct    165.010k (± 6.0%) i/s -    836.076k
+PersistentOpenStruct    793.144k (± 5.4%) i/s -      3.969M
+      OpenFastStruct    850.827k (± 5.0%) i/s -      4.273M
+        DynamicClass      1.026M (± 4.0%) i/s -      5.180M
+        RegularClass      3.451M (± 3.7%) i/s -     17.311M
 
 Comparison:
-        RegularClass:  3037473.6 i/s
-      OpenFastStruct:   783309.5 i/s - 3.88x slower
-        DynamicClass:   766129.7 i/s - 3.96x slower
-PersistentOpenStruct:   757736.8 i/s - 4.01x slower
-          OpenStruct:   138430.6 i/s - 21.94x slower
+        RegularClass:  3451422.2 i/s
+        DynamicClass:  1026234.0 i/s - 3.36x slower
+      OpenFastStruct:   850827.2 i/s - 4.06x slower
+PersistentOpenStruct:   793144.4 i/s - 4.35x slower
+          OpenStruct:   165009.7 i/s - 20.92x slower
 
 
 
 Assignment Benchmark
 
 Calculating -------------------------------------
-          OpenStruct   107.675k i/100ms
-PersistentOpenStruct   108.952k i/100ms
-      OpenFastStruct    59.163k i/100ms
-        DynamicClass   133.406k i/100ms
-        RegularClass   134.345k i/100ms
+          OpenStruct   112.139k i/100ms
+PersistentOpenStruct   113.798k i/100ms
+      OpenFastStruct    62.780k i/100ms
+        DynamicClass   140.472k i/100ms
+        RegularClass   141.757k i/100ms
 -------------------------------------------------
-          OpenStruct      3.511M (± 4.2%) i/s -     17.551M
-PersistentOpenStruct      3.491M (± 4.3%) i/s -     17.432M
-      OpenFastStruct    950.760k (± 4.8%) i/s -      4.792M
-        DynamicClass      8.891M (± 5.7%) i/s -     44.291M
-        RegularClass      8.939M (± 5.8%) i/s -     44.603M
+          OpenStruct      3.773M (± 5.8%) i/s -     18.839M
+PersistentOpenStruct      3.737M (± 6.8%) i/s -     18.663M
+      OpenFastStruct      1.086M (± 4.8%) i/s -      5.462M
+        DynamicClass      9.237M (± 5.8%) i/s -     46.075M
+        RegularClass      9.017M (± 7.6%) i/s -     44.795M
 
 Comparison:
-        RegularClass:  8939463.2 i/s
-        DynamicClass:  8890563.0 i/s - 1.01x slower
-          OpenStruct:  3511253.2 i/s - 2.55x slower
-PersistentOpenStruct:  3491119.3 i/s - 2.56x slower
-      OpenFastStruct:   950760.2 i/s - 9.40x slower
+        DynamicClass:  9236626.8 i/s
+        RegularClass:  9017300.5 i/s - 1.02x slower
+          OpenStruct:  3773095.2 i/s - 2.45x slower
+PersistentOpenStruct:  3737490.7 i/s - 2.47x slower
+      OpenFastStruct:  1085576.3 i/s - 8.51x slower
 
 
 
 Access Benchmark
 
 Calculating -------------------------------------
-          OpenStruct   121.935k i/100ms
-PersistentOpenStruct   122.673k i/100ms
-      OpenFastStruct   111.492k i/100ms
-        DynamicClass   136.066k i/100ms
-        RegularClass   135.946k i/100ms
+          OpenStruct   126.018k i/100ms
+PersistentOpenStruct   123.179k i/100ms
+      OpenFastStruct   113.118k i/100ms
+        DynamicClass   139.960k i/100ms
+        RegularClass   142.888k i/100ms
 -------------------------------------------------
-          OpenStruct      5.603M (± 6.1%) i/s -     27.923M
-PersistentOpenStruct      5.613M (± 5.8%) i/s -     27.969M
-      OpenFastStruct      3.683M (± 6.9%) i/s -     18.396M
-        DynamicClass      9.674M (± 5.8%) i/s -     48.167M
-        RegularClass      9.809M (± 5.5%) i/s -     48.941M
+          OpenStruct      5.409M (± 5.3%) i/s -     26.968M
+PersistentOpenStruct      5.341M (± 6.3%) i/s -     26.607M
+      OpenFastStruct      4.094M (± 5.5%) i/s -     20.474M
+        DynamicClass      9.623M (± 6.1%) i/s -     48.006M
+        RegularClass      9.655M (± 5.9%) i/s -     48.153M
 
 Comparison:
-        RegularClass:  9808944.8 i/s
-        DynamicClass:  9674457.9 i/s - 1.01x slower
-PersistentOpenStruct:  5612626.6 i/s - 1.75x slower
-          OpenStruct:  5603365.4 i/s - 1.75x slower
-      OpenFastStruct:  3683298.4 i/s - 2.66x slower
+        RegularClass:  9655298.6 i/s
+        DynamicClass:  9623042.4 i/s - 1.00x slower
+          OpenStruct:  5409401.0 i/s - 1.78x slower
+PersistentOpenStruct:  5341124.3 i/s - 1.81x slower
+      OpenFastStruct:  4094344.3 i/s - 2.36x slower
 
 
 
 All-Together Benchmark
 
 Calculating -------------------------------------
-          OpenStruct    11.371k i/100ms
-PersistentOpenStruct    41.683k i/100ms
-      OpenFastStruct    30.589k i/100ms
-        DynamicClass    52.041k i/100ms
-        RegularClass   100.225k i/100ms
+          OpenStruct    14.450k i/100ms
+PersistentOpenStruct    46.072k i/100ms
+      OpenFastStruct    34.287k i/100ms
+        DynamicClass    58.110k i/100ms
+        RegularClass   107.647k i/100ms
 -------------------------------------------------
-          OpenStruct    136.382k (±14.6%) i/s -    659.518k
-PersistentOpenStruct    647.752k (± 4.4%) i/s -      3.251M
-      OpenFastStruct    416.183k (± 5.4%) i/s -      2.080M
-        DynamicClass    827.546k (± 4.3%) i/s -      4.163M
-        RegularClass      3.034M (± 6.6%) i/s -     15.134M
+          OpenStruct    161.775k (± 5.7%) i/s -    809.200k
+PersistentOpenStruct    625.010k (± 5.7%) i/s -      3.133M
+      OpenFastStruct    446.903k (± 4.8%) i/s -      2.263M
+        DynamicClass    995.236k (± 5.0%) i/s -      4.997M
+        RegularClass      3.102M (± 5.7%) i/s -     15.501M
 
 Comparison:
-        RegularClass:  3033808.8 i/s
-        DynamicClass:   827546.3 i/s - 3.67x slower
-PersistentOpenStruct:   647751.5 i/s - 4.68x slower
-      OpenFastStruct:   416183.1 i/s - 7.29x slower
-          OpenStruct:   136382.0 i/s - 22.24x slower
+        RegularClass:  3102088.4 i/s
+        DynamicClass:   995235.5 i/s - 3.12x slower
+PersistentOpenStruct:   625010.1 i/s - 4.96x slower
+      OpenFastStruct:   446902.6 i/s - 6.94x slower
+          OpenStruct:   161775.4 i/s - 19.18x slower
 ```
 
-`DynamicClass` is still behind plain old Ruby classes, but it's the best (or
-effectively tied for best) out of the pack when it comes to `OpenStruct` and
-friends.
+`DynamicClass` is still behind plain old Ruby classes, but it's the best out of
+the pack when it comes to `OpenStruct` and friends.
 
 ## Installation
 

data/lib/dynamic_class.rb

@@ -1,4 +1,4 @@
-require "dynamic_class/version"
+require 'dynamic_class/version'
 require 'set'
 
 module DynamicClass
@@ -19,34 +19,58 @@ module DynamicClass
       def inherited(subclass)
         subclass.class_eval <<-RUBY
           def to_h
-            {}.tap do |hash|
-              each_pair do |key, value|
-                hash[key] = value
-              end
-            end
+            {}
           end
         RUBY
       end
+
+      def mutex
+        @mutex ||= Mutex.new
+      end
+
+      def add_methods!(key)
+        class_exec do
+          mutex.synchronize do
+            attr_accessor key
+            attributes << key
+
+            # I'm pretty sure this is safe, because attempting to add an attribute
+            # that isn't a valid instance variable name will raise an error. Please
+            # contact the maintainer if you find a situation where this could be a
+            # security problem.
+            #
+            # The reason to use class_eval here is because, based on benchmarking,
+            # this defines the fastest version of #to_h possible.
+            class_eval <<-RUBY
+              def to_h
+                {
+                  #{
+                    attributes.map { |attribute|
+                      "#{attribute.inspect} => #{attribute}"
+                    }.join(",\n")
+                  }
+                }
+              end
+            RUBY
+          end
+        end
+      end
     end
 
     def initialize(attributes = {})
       attributes.each_pair do |key, value|
-        send(:[]=, key, value)
+        send(:"#{key}=", value)
       end
     end
 
     def to_h
-      {}.tap do |hash|
-        each_pair do |key, value|
-          hash[key] = value
-        end
-      end
+      {}
     end
 
     def []=(key, value)
       key = key.to_sym
       instance_variable_set(:"@#{key}", value)
-      add_methods!(key) unless self.class.attributes.include?(key)
+      self.class.add_methods!(key) unless self.class.attributes.include?(key)
     end
 
     def [](key)
@@ -75,7 +99,7 @@ module DynamicClass
     end
 
     def delete_field(key)
-      self[key] = nil
+      instance_variable_set(:"@#{key}", nil)
     end
 
     def ==(other)
@@ -89,30 +113,5 @@ module DynamicClass
     def hash
       to_h.hash
     end
-
-    private
-    def add_methods!(key)
-      self.class.send(:attr_accessor, key)
-      self.class.attributes << key
-
-      # I'm pretty sure this is safe, because attempting to add an attribute
-      # that isn't a valid instance variable name will raise an error. Please
-      # contact the maintainer if you find a situation where this could be a
-      # security problem.
-      #
-      # The reason to use class_eval here is because, based on benchmarking,
-      # this defines the fastest version of #to_h possible.
-      self.class.class_eval <<-RUBY
-        def to_h
-          {
-            #{
-              self.class.attributes.map { |attribute|
-                "#{attribute.inspect} => #{attribute}"
-              }.join(",\n")
-            }
-          }
-        end
-      RUBY
-    end
   end
 end

data/lib/dynamic_class/version.rb

@@ -1,3 +1,3 @@
 module DynamicClass
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dynamic_class
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - amcaplan
@@ -14,84 +14,84 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.11'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: ofstruct
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.2'
 - !ruby/object:Gem::Dependency
   name: persistent_open_struct
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.0'
 - !ruby/object:Gem::Dependency
   name: benchmark-ips
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.3.0
 description: Specifically designed as an OpenStruct-like tool for consuming APIs,
@@ -103,9 +103,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -127,17 +127,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Create classes that define themselves... eventually.