dynamic_attribute_declaration 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 823bbe01675f8328ed7d7cba95a42611ba505a2b
-  data.tar.gz: f685a0d12105f87c69d03a7353e198ff56a96fa8
+  metadata.gz: a06b5b243da301f6a1fad227bc3f994626de2695
+  data.tar.gz: 4985de29d17066ec9edbbd3ab66415f475056435
 SHA512:
-  metadata.gz: 3800c7f6ab5c0815dc931f2733813936743b664318f5b57e3967f3346d07d272199b2c152964a67d2adacc2281b8c5b8c2927183a8442bc76879215e28b53527
-  data.tar.gz: e0abe7bd669032fbdfa3824b75277720ada4726885c68649fe881d4aedc475f9e20c86d6264c09dcbdfec9909651679f9b09a938c815ce7ef48871c7e08a846f
+  metadata.gz: c101d74f7db8e5faf8ba74964e71664d056f35378d80c6814838bb518b4fd025b3d474ab2c01df19e5cfc15eed8eff72f4c44d9302ac90de1f598dd1d38de50b
+  data.tar.gz: 54e6fd2554b07497bba47dc9bc0c5099d9f4151eeaf5592ee5abe564db9a0363d7deb191531ebb54480121799c173885ec0a3b4ec0749113594161c2c709e316

data/lib/dynamic_attribute_declaration.rb

@@ -48,20 +48,22 @@ module DynamicAttributeDeclaration
 
     def attrs_on_for attr_name
       attr = _dynamic_attrs[attr_name]
-      rtn = {}
-      attr.each do |a|
-        if a.key? :on
-          obj = a[:on]
-          obj.each do |key, value|
-            if rtn.key? key
-              rtn[key].push(value).flatten!
-            else
-              rtn[key] = value
+      if attr && !attr.empty?
+        rtn = {}
+        attr.each do |a|
+          if a.key? :on
+            obj = a[:on]
+            obj.each do |key, value|
+              if rtn.key? key
+                rtn[key].push(value).flatten!.uniq!
+              else
+                rtn[key] = value
+              end
             end
           end
         end
+        rtn
       end
-      rtn
     end
 
     def attrs_for state=nil, device=nil

data/lib/dynamic_attribute_declaration/version.rb

@@ -1,3 +1,3 @@
 module DynamicAttributeDeclaration
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/spec/lib/base_spec.rb

@@ -101,7 +101,10 @@ describe "BASE TESTS" do
             name: { on: :foo }
           },
           {
-            name: { on: :bar }
+            name: { on: [:bar] }
+          },
+          {
+            name: { on: [:foo, :bar] }
           }
         ]
         cls.define_attrs @definition
@@ -111,7 +114,34 @@ describe "BASE TESTS" do
         it "Should hold a hash for the defines on" do
           expect(cls._dynamic_attrs[:name]).not_to eq nil
           expect(cls._dynamic_attrs[:name].class).to eq Array
-          expect(cls._dynamic_attrs[:name].length).to eq 2
+          expect(cls._dynamic_attrs[:name].length).to eq 3
+        end
+      end
+
+      describe 'attrs_on_for' do
+        it "Should return right type" do
+          expect(cls.attrs_on_for(:name)).not_to eq nil
+          expect(cls.attrs_on_for(:name).class).to eq Hash
+          expect(cls.attrs_on_for(:lala)).to eq nil
+        end
+
+        it 'Should return unique states' do
+          obj = cls.attrs_on_for(:name)
+          count = {}
+
+          obj.keys.each do |state|
+            obj[state].each do |attr_name|
+              id = "#{state}-#{attr_name}"
+              puts "key #{id}"
+              if count.key? id
+                count[id] += 1
+              else
+                count[id] = 1
+              end
+            end
+          end
+
+          expect(count.select { |k,v| v != 1 }).to eq({})
         end
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dynamic_attribute_declaration
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Mikkel Wied Frederiksen