dynamic_attribute_declaration 0.0.10 → 0.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1ad3c08b64a3d53dcc5fd27e5896cb071bb50823
-  data.tar.gz: 8ff5b41d713eb37669edc7f22315fb83050c71bf
+  metadata.gz: 5b76e3142d2eed5bc086805161e9bc55595999f3
+  data.tar.gz: da66b9d1a260a72a7ef735d1eb8453334a1df032
 SHA512:
-  metadata.gz: 1881cac321ff34eb75ab1d203f789d5e198f63bed0b31e33e2e4d33ce7625ce58cf37dab8aed481f89741288e9640798ee109ae1da1728bb4152474d8ba57e98
-  data.tar.gz: 8fcb16e746e38c1fa01a5cf9ec75de1055ec2e7eb0c31cb0ff151dc8623906850867345cf77084117f8471b104af693dee1c9fc8d7d2df508c781518112db890
+  metadata.gz: 7be553e1972b3c823bc46e808f70474d88cddf96d86a421842577c0d47634db2307202ecdc6e3e0cfff0ef1003d183647abd660c6bd9d54e91c1b6b63db44c6d
+  data.tar.gz: 1c61921ef47b63b42135b87be4f54eb1d88cb30d1ac79f980df6812edb0470124723a5590610d04dc212e90f70ae62fdaade207b61a7d2a751574e9ccaf02467

data/dynamic_attribute_declaration.gemspec

@@ -9,8 +9,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Mikkel Wied Frederiksen"]
   spec.email         = ["mikkel@wied.cc"]
   spec.summary       = %q{This gem lets you dynamically declare validations, that can function as partly applied validation, based on some kind of model instance state.}
-  # spec.description   = %q{TODO: Write a longer description. Optional.}
-  spec.homepage      = ""
+  spec.description   = %q{DESCRIPTION ON THE WAY! :)}
+  spec.homepage      = "https://github.com/mikkelwf/dynamic_attribute_declaration"
   spec.license       = "MIT"
 
   spec.files         = `git ls-files -z`.split("\x0")
@@ -19,11 +19,11 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 1.6"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
-  spec.add_development_dependency "rspec-its"
-  spec.add_development_dependency "sqlite3"
-  spec.add_development_dependency('database_cleaner')
+  spec.add_development_dependency "rake", "~> 10"
+  spec.add_development_dependency "rspec", "~> 3"
+  spec.add_development_dependency "rspec-its", "~> 1"
+  spec.add_development_dependency "sqlite3", "~> 1.3"
+  spec.add_development_dependency "database_cleaner", "~> 1.3"
 
   spec.add_dependency "activerecord", "~> 4.0"
   spec.add_dependency "activesupport", "~> 4.0"

data/lib/dynamic_attribute_declaration.rb

@@ -65,21 +65,21 @@ module DynamicAttributeDeclaration
       # throw "No validation state if defined" unless _rdynamic_attr_state_if
       attrs.each do |key, val|
         if val.key?(:validates) && !val[:validates].empty?
-          opts = val[:validates]
+          opts = val[:validates].deep_symbolize_keys
 
           # Check if validation should only be used in specific state
           if val.key?(:on) && _dynamic_attr_state_if && _dynamic_attr_state_if.class == Proc
             validates_on = val[:on]
             # If validates contains if statement, wrap that statement in state check
-            if val[:validates].key?(:if)
-              original_if = val[:validates][:if]
+            if opts.key?(:if)
+              original_if = opts.delete(:if)
               opts.merge! if: ->(model) { model.instance_exec(validates_on, &_dynamic_attr_state_if) && model.instance_eval(&original_if) }
             else
               opts.merge! if: ->(model) { model.instance_exec(validates_on, &_dynamic_attr_state_if) }
             end
           end
 
-          validates key.to_sym, opts.deep_symbolize_keys()
+          validates key.to_sym, opts
         end
       end
     end

data/lib/dynamic_attribute_declaration/version.rb

@@ -1,3 +1,3 @@
 module DynamicAttributeDeclaration
-  VERSION = "0.0.10"
+  VERSION = "0.0.11"
 end

data/spec/lib/base_spec.rb

@@ -0,0 +1,155 @@
+require 'spec_helper'
+
+describe "BASE TESTS" do
+
+  let(:cls) { Phone }
+
+  describe "Basic gem tests" do
+
+    it "Accessor _dynamic_attrs should be Hash" do
+      expect(cls._dynamic_attrs.class).to eq Hash
+    end
+
+    %w(define_attrs attrs_for attrs_names_for build_validations_from_dynamic_attrs).each do |attr|
+      it "Should respond to #{attr}" do
+        expect(cls).to respond_to(attr.to_sym)
+      end
+    end
+  end
+
+  describe "Defining attrs" do
+
+    it "Clean Model should have no validators" do
+      expect(cls.validators).to eq []
+    end
+
+    describe "Simple definition of presence validator" do
+      let(:defition_array) { [{name:{validates:{presence: true}}}] }
+      let(:definition) { Hash[*defition_array.flatten] }
+
+      before do
+        cls.define_attrs definition
+      end
+
+      it "Should have at least one validator" do
+        expect(cls.validators).not_to eq []
+        expect(cls.validators.length).to be >= 1
+      end
+
+      it "Should have a specific validator" do
+        obj = definition
+        name = obj.keys.first
+        validators = obj[name][:validates]
+        validator_type = validators.keys.first
+
+        validator = cls.validators.first
+        expect(validator.class).to eq "ActiveRecord::Validations::#{validator_type.capitalize}Validator".constantize
+      end
+
+      it "_dynamic_attrs should have configuration from define_attrs" do
+        expect(cls._dynamic_attrs).to eq definition
+      end
+
+      it "attrs_for with no state should return definition" do
+        expect(cls.attrs_for).to eq definition
+      end
+
+      it "attrs_names_for with no state should return definition" do
+        expect(cls.attrs_names_for).to eq definition.keys
+      end
+    end
+
+    describe "Simple definition of presence validator, with on parameter" do
+      let(:defition_array) { [{name:{validates:{presence: true}, on: :right}}] }
+      let(:definition) { Hash[*defition_array.flatten] }
+      let(:instance) { cls.new }
+
+      before do
+        cls.define_attrs definition
+      end
+
+      it "Should have at least one validator" do
+        expect(cls.validators).not_to eq []
+        expect(cls.validators.length).to be >= 1
+      end
+
+      it "Should have a specific validator" do
+        obj = definition
+        name = obj.keys.first
+        validators = obj[name][:validates]
+        validator_type = validators.keys.first
+
+        validator = cls.validators.first
+        expect(validator.class).to eq "ActiveRecord::Validations::#{validator_type.capitalize}Validator".constantize
+      end
+
+      it "_dynamic_attrs should have configuration from define_attrs" do
+        expect(cls._dynamic_attrs).to eq definition
+      end
+
+      describe "attrs_for" do
+        it "with no state should return definition" do
+          expect(cls.attrs_for).to eq definition
+        end
+        describe "with right state" do
+          it "with symbol should return definition" do
+            expect(cls.attrs_for(:right)).to eq definition
+          end
+          it "with string should return definition" do
+            expect(cls.attrs_for("right")).to eq definition
+          end
+        end
+        describe "with wrong state" do
+          it "with symbol should return empty object" do
+            expect(cls.attrs_for(:wrong)).to eq({})
+          end
+          it "with string should return empty object" do
+            expect(cls.attrs_for("wrong")).to eq({})
+          end
+        end
+      end
+
+      describe "attrs_names_for" do
+        it "with no state should return definition keys" do
+          expect(cls.attrs_names_for).to eq definition.keys
+        end
+        describe "with right state" do
+          it "with symbol should return definition keys" do
+            expect(cls.attrs_names_for(:right)).to eq definition.keys
+          end
+          it "with string should return definition keys" do
+            expect(cls.attrs_names_for("right")).to eq definition.keys
+          end
+        end
+        describe "with wrong state" do
+          it "with symbol should return empty array" do
+            expect(cls.attrs_names_for(:wrong)).to eq []
+          end
+          it "with string should return empty array" do
+            expect(cls.attrs_names_for("wrong")).to eq []
+          end
+        end
+      end
+
+      describe "values_for" do
+        pending "TEST VALUES FOR"
+      end
+    end
+  end
+
+  describe "Defining define_attr_state_if" do
+    before do
+      cls.clear_dynamic_attrs!
+    end
+
+    it "Should have no _dynamic_attr_state_if as standard" do
+      expect(cls._dynamic_attr_state_if).to be_nil
+    end
+
+    it "lala" do
+      proc = Proc.new { true }
+      cls.define_attr_state_if proc
+      expect(cls._dynamic_attr_state_if).to eq proc
+    end
+  end
+end

data/spec/lib/dynamic_attribute_declaration_spec.rb

@@ -1,266 +1,304 @@
 require 'spec_helper'
 
-describe "Dynamic Attribute Declaration" do
-
+describe "MODEL INSTANCE TESTS" do
   let(:cls) { Phone }
 
-  describe "Basic gem tests" do
-
-    it "Accessor _dynamic_attrs should be Hash" do
-      expect(cls._dynamic_attrs.class).to eq Hash
-    end
+  before do
+    cls.clear_validators!
+    cls.clear_dynamic_attrs!
 
-    %w(define_attrs attrs_for attrs_names_for build_validations_from_dynamic_attrs).each do |attr|
-      it "Should respond to #{attr}" do
-        expect(cls).to respond_to(attr.to_sym)
-      end
-    end
+    cls.define_attr_state_if Proc.new { |value|
+      self.validator value
+    }
   end
 
-  describe "Defining attrs" do
-
-    it "Clean Model should have no validators" do
-      expect(cls.validators).to eq []
-    end
-
-    describe "Simple definition of presence validator" do
-      let(:defition_array) { [{name:{validates:{presence: true}}}] }
-      let(:definition) { Hash[*defition_array.flatten] }
-
-      before do
-        cls.define_attrs definition
-      end
-
-      it "Should have at least one validator" do
-        expect(cls.validators).not_to eq []
-        expect(cls.validators.length).to be >= 1
-      end
-
-      it "Should have a specific validator" do
-        obj = definition
-        name = obj.keys.first
-        validators = obj[name][:validates]
-        validator_type = validators.keys.first
-
-        validator = cls.validators.first
-        expect(validator.class).to eq "ActiveRecord::Validations::#{validator_type.capitalize}Validator".constantize
-      end
-
-      it "_dynamic_attrs should have configuration from define_attrs" do
-        expect(cls._dynamic_attrs).to eq definition
-      end
-
-      it "attrs_for with no state should return definition" do
-        expect(cls.attrs_for).to eq definition
-      end
-
-      it "attrs_names_for with no state should return definition" do
-        expect(cls.attrs_names_for).to eq definition.keys
-      end
+  ## WITH NO VALIDATOR ##
+  describe "With no validator" do
+    it "Should be valid" do
+      instance = cls.new
+      instance.valid?
+      expect(instance.valid?).to eq true
+      expect(instance.errors.full_messages).to eq []
     end
+  end
+  ## WITH NO VALIDATOR - END ##
 
-    describe "Simple definition of presence validator, with on parameter" do
-      let(:defition_array) { [{name:{validates:{presence: true}, on: :right}}] }
-      let(:definition) { Hash[*defition_array.flatten] }
-      let(:instance) { cls.new }
+  describe "With validator" do
 
-      before do
-        cls.define_attrs definition
-      end
+    describe "Without if" do
+      ## WITH VALIDATOR - WITHOUT STATE ##
+      describe "Without state" do
+        before do
+          cls.define_attrs  name: {
+                              validates: { presence: true }
+                            }
+          @instance = cls.new
+        end
 
-      it "Should have at least one validator" do
-        expect(cls.validators).not_to eq []
-        expect(cls.validators.length).to be >= 1
+        it "Should not be valid when having no value" do
+          @instance.valid?
+          expect(@instance.valid?).to eq false
+          expect(@instance.errors.full_messages).not_to eq []
+        end
+        it "Should be valid when having a value" do
+          @instance.name = 'My Phone'
+          @instance.valid?
+          expect(@instance.valid?).to eq true
+          expect(@instance.errors.full_messages).to eq []
+        end
       end
+      ## WITH VALIDATOR - WITHOUT STATE - END ##
 
-      it "Should have a specific validator" do
-        obj = definition
-        name = obj.keys.first
-        validators = obj[name][:validates]
-        validator_type = validators.keys.first
-
-        validator = cls.validators.first
-        expect(validator.class).to eq "ActiveRecord::Validations::#{validator_type.capitalize}Validator".constantize
-      end
+      ## WITH VALIDATOR - WITH STATE ##
+      describe "With state" do
+        before do
+          cls.define_attrs  name: {
+                              validates: { presence: true },
+                              on: :right
+                            }
+          @instance = cls.new
+        end
 
-      it "_dynamic_attrs should have configuration from define_attrs" do
-        expect(cls._dynamic_attrs).to eq definition
-      end
+        describe "With right validatable state" do
+          before do
+            @instance.state = :right
+          end
 
-      describe "attrs_for" do
-        it "with no state should return definition" do
-          expect(cls.attrs_for).to eq definition
-        end
-        describe "with right state" do
-          it "with symbol should return definition" do
-            expect(cls.attrs_for(:right)).to eq definition
+          it "Should not be valid when having no value" do
+            @instance.valid?
+            expect(@instance.valid?).to eq false
+            expect(@instance.errors.full_messages).not_to eq []
           end
-          it "with string should return definition" do
-            expect(cls.attrs_for("right")).to eq definition
+          it "Should be valid when having a value" do
+            @instance.name = 'My Phone'
+            @instance.valid?
+            expect(@instance.valid?).to eq true
+            expect(@instance.errors.full_messages).to eq []
           end
         end
-        describe "with wrong state" do
-          it "with symbol should return empty object" do
-            expect(cls.attrs_for(:wrong)).to eq({})
-          end
-          it "with string should return empty object" do
-            expect(cls.attrs_for("wrong")).to eq({})
+
+        describe "With wrong validatable state" do
+          before do
+            @instance.state = :wrong
           end
-        end
-      end
 
-      describe "attrs_names_for" do
-        it "with no state should return definition keys" do
-          expect(cls.attrs_names_for).to eq definition.keys
-        end
-        describe "with right state" do
-          it "with symbol should return definition keys" do
-            expect(cls.attrs_names_for(:right)).to eq definition.keys
+          it "Should be valid when having no value" do
+            @instance.valid?
+            expect(@instance.valid?).to eq true
+            expect(@instance.errors.full_messages).to eq []
           end
-          it "with string should return definition keys" do
-            expect(cls.attrs_names_for("right")).to eq definition.keys
+          it "Should be valid when having a value" do
+            @instance.name = 'My Phone'
+            @instance.valid?
+            expect(@instance.valid?).to eq true
+            expect(@instance.errors.full_messages).to eq []
           end
         end
-        describe "with wrong state" do
-          it "with symbol should return empty array" do
-            expect(cls.attrs_names_for(:wrong)).to eq []
+
+        describe "With no validatable state" do
+          it "Should be valid when having no value" do
+            @instance.valid?
+            expect(@instance.valid?).to eq true
+            expect(@instance.errors.full_messages).to eq []
           end
-          it "with string should return empty array" do
-            expect(cls.attrs_names_for("wrong")).to eq []
+          it "Should be valid when having a value" do
+            @instance.name = 'My Phone'
+            @instance.valid?
+            expect(@instance.valid?).to eq true
+            expect(@instance.errors.full_messages).to eq []
           end
         end
       end
-
-      describe "values_for" do
-        pending "TEST VALUES FOR"
-      end
-    end
-  end
-
-  describe "Defining define_attr_state_if" do
-    before do
-      cls.clear_dynamic_attrs!
-    end
-
-    it "Should have no _dynamic_attr_state_if as standard" do
-      expect(cls._dynamic_attr_state_if).to be_nil
-    end
-
-    it "lala" do
-      proc = Proc.new { true }
-      cls.define_attr_state_if proc
-      expect(cls._dynamic_attr_state_if).to eq proc
-    end
-  end
-
-  describe "Model Instance" do
-    let(:cls) { Phone }
-
-    describe "With no validator" do
-      let(:instance) { cls.new }
-
-      before do
-        cls.clear_validators!
-      end
-
-      it "Should be valid" do
-        instance.valid?
-        expect(instance.valid?).to eq true
-        expect(instance.errors.full_messages).to eq []
-      end
+      ## WITH VALIDATOR - WITH STATE ##
     end
 
-    describe "With validator" do
-      let(:defition_array) { [{name:{validates:{presence: true}, on: :right}}] }
-      let(:definition) { Hash[*defition_array.flatten] }
-
-      before do
-        cls.clear_validators!
-        cls.clear_dynamic_attrs!
-
-        cls.define_attr_state_if Proc.new { |value|
-          self.validator value
-        }
-        cls.define_attrs definition
-      end
-
-      describe "With rigth validatable state" do
-        let(:instance) { cls.new }
 
+    describe "With if statement" do
+      ## WITH VALIDATOR - WITHOUT STATE ##
+      describe "Without state" do
         before do
-          instance.state = :right
+          cls.define_attrs  name: {
+                              validates: { presence: true }
+                            },
+                            model: {
+                              validates: {
+                                presence: true,
+                                if: ->(state){ !!name }
+                              },
+                            }
+          @instance = cls.new
         end
 
-        it "Should not be valid when having no value" do
-          instance.valid?
-          expect(instance.valid?).to eq false
-          expect(instance.errors.full_messages).not_to eq []
+        it "Should not be valid when having no values" do
+          @instance.valid?
+          expect(@instance.class._validators).not_to eq({})
+          expect(@instance.valid?).to eq false
+          expect(@instance.errors.full_messages).not_to eq []
+          expect(@instance.errors.full_messages_for(:name)).to eq ["Name can't be blank"]
+          expect(@instance.errors.full_messages_for(:model)).to eq []
         end
-        it "Should be valid when having a value" do
-          instance.name = 'My Phone'
-          instance.valid?
-          expect(instance.valid?).to eq true
-          expect(instance.errors.full_messages).to eq []
+        it "Should not be valid when having set only the non-dependent attribute" do
+          @instance.name = 'My Phone'
+          @instance.valid?
+          expect(@instance.valid?).to eq false
+          expect(@instance.errors.full_messages).not_to eq []
+          expect(@instance.errors.full_messages_for(:name)).to eq []
+          expect(@instance.errors.full_messages_for(:model)).to eq ["Model can't be blank"]
+        end
+        it "Should not be valid when having set only the dependent attribute" do
+          @instance.model = 'The Awesome Phone'
+          @instance.valid?
+          expect(@instance.valid?).to eq false
+          expect(@instance.errors.full_messages).not_to eq []
+          expect(@instance.errors.full_messages_for(:name)).to eq ["Name can't be blank"]
+          expect(@instance.errors.full_messages_for(:model)).to eq []
+        end
+        it "Should be valid when having set both attributes" do
+          @instance.name = 'My Phone'
+          @instance.model = 'The Awesome Phone'
+          @instance.valid?
+          expect(@instance.valid?).to eq true
+          expect(@instance.errors.full_messages).to eq []
+          expect(@instance.errors.full_messages_for(:name)).to eq []
+          expect(@instance.errors.full_messages_for(:model)).to eq []
         end
       end
+      ## WITH VALIDATOR - WITHOUT STATE - END ##
 
-      describe "With wrong validatable state" do
-        let(:instance) { cls.new }
-
+      ## WITH VALIDATOR - WITH STATE ##
+      describe "With state" do
         before do
-          instance.state = :wrong
+          cls.define_attrs  name: {
+                              validates: { presence: true },
+                              on: :right
+                            },
+                            model: {
+                              validates: {
+                                presence: true,
+                                if: ->(state){ !!name }
+                              },
+                              on: :right
+                            }
+          @instance = cls.new
         end
 
-        it "Should be valid when having no value" do
-          instance.valid?
-          expect(instance.valid?).to eq true
-          expect(instance.errors.full_messages).to eq []
-        end
-        it "Should be valid when having a value" do
-          instance.name = 'My Phone'
-          instance.valid?
-          expect(instance.valid?).to eq true
-          expect(instance.errors.full_messages).to eq []
-        end
-      end
+        describe "With right validatable state" do
 
-      describe "With no validatable state" do
-        let(:instance) { cls.new }
+          before do
+            @instance.state = :right
+          end
 
-        it "Should be valid when having no value" do
-          instance.valid?
-          expect(instance.valid?).to eq true
-          expect(instance.errors.full_messages).to eq []
-        end
-        it "Should be valid when having a value" do
-          instance.name = 'My Phone'
-          instance.valid?
-          expect(instance.valid?).to eq true
-          expect(instance.errors.full_messages).to eq []
+          it "Should not be valid when having no values" do
+            @instance.valid?
+            expect(@instance.valid?).to eq false
+            expect(@instance.errors.full_messages).not_to eq []
+            expect(@instance.errors.full_messages_for(:name)).to eq ["Name can't be blank"]
+            expect(@instance.errors.full_messages_for(:model)).to eq []
+          end
+          it "Should not be valid when having set only the non-dependent attribute" do
+            @instance.name = 'My Phone'
+            @instance.valid?
+            expect(@instance.valid?).to eq false
+            expect(@instance.errors.full_messages).not_to eq []
+            expect(@instance.errors.full_messages_for(:name)).to eq []
+            expect(@instance.errors.full_messages_for(:model)).to eq ["Model can't be blank"]
+          end
+          it "Should not be valid when having set only the dependent attribute" do
+            @instance.model = 'The Awesome Phone'
+            @instance.valid?
+            expect(@instance.valid?).to eq false
+            expect(@instance.errors.full_messages).not_to eq []
+            expect(@instance.errors.full_messages_for(:name)).to eq ["Name can't be blank"]
+            expect(@instance.errors.full_messages_for(:model)).to eq []
+          end
+          it "Should be valid when having set both attributes" do
+            @instance.name = 'My Phone'
+            @instance.model = 'The Awesome Phone'
+            @instance.valid?
+            expect(@instance.valid?).to eq true
+            expect(@instance.errors.full_messages).to eq []
+            expect(@instance.errors.full_messages_for(:name)).to eq []
+            expect(@instance.errors.full_messages_for(:model)).to eq []
+          end
         end
-      end
-    end
-  end
 
-  describe "Multiple models" do
+        describe "With wrong validatable state" do
 
-    before do
-      [Phone, Car].each do |model|
-        model.clear_validators!
-        model.clear_dynamic_attrs!
-      end
-    end
+          before do
+            @instance.state = :wrong
+          end
 
-    it "_dynamic_attrs should be different" do
-      expect(Phone._dynamic_attrs).to eq({})
-      expect(Car._dynamic_attrs).to eq({})
+          it "Should be valid when having no values" do
+            @instance.valid?
+            expect(@instance.valid?).to eq true
+            expect(@instance.errors.full_messages).to eq []
+            expect(@instance.errors.full_messages_for(:name)).to eq []
+            expect(@instance.errors.full_messages_for(:model)).to eq []
+          end
+          it "Should be valid when having set only the non-dependent attribute" do
+            @instance.name = 'My Phone'
+            @instance.valid?
+            expect(@instance.valid?).to eq true
+            expect(@instance.errors.full_messages).to eq []
+            expect(@instance.errors.full_messages_for(:name)).to eq []
+            expect(@instance.errors.full_messages_for(:model)).to eq []
+          end
+          it "Should be valid when having set only the dependent attribute" do
+            @instance.model = 'The Awesome Phone'
+            @instance.valid?
+            expect(@instance.valid?).to eq true
+            expect(@instance.errors.full_messages).to eq []
+            expect(@instance.errors.full_messages_for(:name)).to eq []
+            expect(@instance.errors.full_messages_for(:model)).to eq []
+          end
+          it "Should be valid when having set both attributes" do
+            @instance.name = 'My Phone'
+            @instance.model = 'The Awesome Phone'
+            @instance.valid?
+            expect(@instance.valid?).to eq true
+            expect(@instance.errors.full_messages).to eq []
+            expect(@instance.errors.full_messages_for(:name)).to eq []
+            expect(@instance.errors.full_messages_for(:model)).to eq []
+          end
 
-      Phone.define_attrs [{name:{validates:{presence: true}, on: :right}}]
-      Car.define_attrs [{name:{validates:{presence: true}, on: :another}}]
-      expect(Phone._dynamic_attrs).not_to eq({})
-      expect(Car._dynamic_attrs).not_to eq({})
+        end
 
-      expect(Phone._dynamic_attrs).not_to eq Car._dynamic_attrs
+        describe "With no validatable state" do
+          it "Should be valid when having no values" do
+            @instance.valid?
+            expect(@instance.valid?).to eq true
+            expect(@instance.errors.full_messages).to eq []
+            expect(@instance.errors.full_messages_for(:name)).to eq []
+            expect(@instance.errors.full_messages_for(:model)).to eq []
+          end
+          it "Should be valid when having set only the non-dependent attribute" do
+            @instance.name = 'My Phone'
+            @instance.valid?
+            expect(@instance.valid?).to eq true
+            expect(@instance.errors.full_messages).to eq []
+            expect(@instance.errors.full_messages_for(:name)).to eq []
+            expect(@instance.errors.full_messages_for(:model)).to eq []
+          end
+          it "Should be valid when having set only the dependent attribute" do
+            @instance.model = 'The Awesome Phone'
+            @instance.valid?
+            expect(@instance.valid?).to eq true
+            expect(@instance.errors.full_messages).to eq []
+            expect(@instance.errors.full_messages_for(:name)).to eq []
+            expect(@instance.errors.full_messages_for(:model)).to eq []
+          end
+          it "Should be valid when having set both attributes" do
+            @instance.name = 'My Phone'
+            @instance.model = 'The Awesome Phone'
+            @instance.valid?
+            expect(@instance.valid?).to eq true
+            expect(@instance.errors.full_messages).to eq []
+            expect(@instance.errors.full_messages_for(:name)).to eq []
+            expect(@instance.errors.full_messages_for(:model)).to eq []
+          end
+        end
+      end
+      ## WITH VALIDATOR - WITH STATE ##
     end
   end
 end

data/spec/lib/multiple_spec.rb

@@ -0,0 +1,23 @@
+  require 'spec_helper'
+
+  describe "MULTIPLE MODELS TESTS" do
+
+    before do
+      [Phone, Car].each do |model|
+        model.clear_validators!
+        model.clear_dynamic_attrs!
+      end
+    end
+
+    it "_dynamic_attrs should be different" do
+      expect(Phone._dynamic_attrs).to eq({})
+      expect(Car._dynamic_attrs).to eq({})
+
+      Phone.define_attrs [{name:{validates:{presence: true}, on: :right}}]
+      Car.define_attrs [{name:{validates:{presence: true}, on: :another}}]
+      expect(Phone._dynamic_attrs).not_to eq({})
+      expect(Car._dynamic_attrs).not_to eq({})
+
+      expect(Phone._dynamic_attrs).not_to eq Car._dynamic_attrs
+    end
+  end

data/spec/support/schema.rb

@@ -3,6 +3,7 @@ ActiveRecord::Schema.define do
 
   create_table :phones, force: true do |t|
     t.string :name
+    t.string :model
     t.timestamps
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dynamic_attribute_declaration
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.0.11
 platform: ruby
 authors:
 - Mikkel Wied Frederiksen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-01 00:00:00.000000000 Z
+date: 2014-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,72 +28,72 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
@@ -122,7 +122,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '4.0'
-description: 
+description: DESCRIPTION ON THE WAY! :)
 email:
 - mikkel@wied.cc
 executables: []
@@ -139,11 +139,13 @@ files:
 - dynamic_attribute_declaration.gemspec
 - lib/dynamic_attribute_declaration.rb
 - lib/dynamic_attribute_declaration/version.rb
+- spec/lib/base_spec.rb
 - spec/lib/dynamic_attribute_declaration_spec.rb
+- spec/lib/multiple_spec.rb
 - spec/spec_helper.rb
 - spec/support/models.rb
 - spec/support/schema.rb
-homepage: ''
+homepage: https://github.com/mikkelwf/dynamic_attribute_declaration
 licenses:
 - MIT
 metadata: {}
@@ -169,7 +171,9 @@ specification_version: 4
 summary: This gem lets you dynamically declare validations, that can function as partly
   applied validation, based on some kind of model instance state.
 test_files:
+- spec/lib/base_spec.rb
 - spec/lib/dynamic_attribute_declaration_spec.rb
+- spec/lib/multiple_spec.rb
 - spec/spec_helper.rb
 - spec/support/models.rb
 - spec/support/schema.rb