dynamic-fields-for 1.0.0 → 1.0.1

data/README.md

@@ -1,5 +1,7 @@
 DynamicFieldsFor
 ================
+[![Gem Version](https://badge.fury.io/rb/dynamic-fields-for.svg)](http://badge.fury.io/rb/dynamic-fields-for)
+[![Build](https://travis-ci.org/stokarenko/dynamic-fields-for.svg)](https://travis-ci.org/stokarenko/dynamic-fields-for)
 
 DynamicFieldsFor is a Rails plugin which provides the dynamic association fieldsets to your forms without a pain. And it does nothing more.
 
@@ -8,7 +10,7 @@ The main features are:
 * Works with fields block, i.e. not requires the separated partial for them;
 * Not provides new form helpers, but extend the existing one;
 * Simple and predictable interface and behavior;
-* Not requires any special HTML intities inside templates;
+* Not requires any special HTML entities inside templates;
 * Supports [Simple Form](https://github.com/plataformatec/simple_form).
 
 ## Alternatives
@@ -16,6 +18,7 @@ The main features are:
 * [Nested Form](https://github.com/ryanb/nested_form)
 
 ## Dependencies
+* Ruby >= 1.9.3
 * [rails](https://github.com/rails/rails) >= 3.2.13
 * [jquery-rails](https://github.com/rails/jquery-rails)
 * [association-soft-build](https://github.com/stokarenko/association-soft-build)

data/lib/dynamic-fields-for/version.rb

@@ -1,3 +1,3 @@
 module DynamicFieldsFor
-  VERSION = '1.0.0'.freeze
+  VERSION = '1.0.1'.freeze
 end

data/spec/features/dynamic_fields_for_spec.rb

@@ -0,0 +1,110 @@
+describe DynamicFieldsFor::FormHelper do
+  describe '#fields_for' do
+    def expect_result(user)
+      expect(page).to have_button('Update User')
+      expect(user.roles.map(&:role_name)).to match_array(['role 0', 'new role 0', 'new role 1'])
+    end
+
+    def role_inputs
+      all('[name$="[role_name]"]')
+    end
+
+    def remove_links
+      all('a', text: 'Remove role')
+    end
+
+    def deal_with_dynamic_roles
+      expect{remove_links.last.click}.to change{remove_links.size}.from(3).to(2)
+      expect{2.times{ click_link 'Add role'}}.to change{remove_links.size}.to(4)
+      expect{remove_links.last.click}.to change{remove_links.size}.to(3)
+      expect{click_link 'Add role'}.to change{remove_links.size}.to(4)
+      expect{remove_links[1].click}.to change{remove_links.size}.to(3)
+
+      role_inputs.last(2).each_with_index do |element, index|
+        element.set("new role #{index}")
+      end
+    end
+
+    let(:user){User.first}
+
+    %w(form_for simple_form_for).each do |form_type|
+      context form_type do
+
+        it 'should pass for new object' do
+          visit "/users/new"
+
+          within("##{form_type}") do
+            deal_with_dynamic_roles
+
+            fill_in 'user[user_name]', with: 'New user'
+            role_inputs.first.set('role 0')
+
+            click_button 'Create User'
+          end
+
+          expect_result(User.find(URI.parse(current_url).path.match(/users\/(\d+)\/edit/)[1]))
+        end
+
+        it 'should pass for existing object' do
+          visit "/users/#{user.id}/edit"
+
+          within("##{form_type}") do
+            deal_with_dynamic_roles
+
+            click_button 'Update User'
+          end
+
+          expect_result(user)
+        end
+      end
+    end
+
+    it 'should not fail when remove link clicked but dynamic fields are not exists' do
+      visit "/users/#{user.id}/edit_without_fields"
+
+      click_link 'Remove without fields'
+      click_button 'Update without fields'
+      expect(page).to have_button('Update User')
+    end
+
+    it 'should deal with turbolinks' do
+      visit "/users/#{user.id}/edit_without_fields"
+      click_link 'Edit'
+
+      within('#form_for') do
+        expect{click_link 'Add role'}.to change{remove_links.size}.from(3).to(4)
+      end
+
+    end
+
+    it 'should trigger add event' do
+      visit "/users/#{user.id}/events"
+
+      click_link('Add role')
+      expect(page).to have_selector(
+        '#event_catcher', text: %Q(
+          dynamic-fields:before-add-into : fields_container
+          dynamic-fields:after-add : role_name
+          dynamic-fields:after-add : remove_link
+          dynamic-fields:after-add-into : fields_container
+        ).gsub(/\s{2,}/, ' ').strip
+      )
+    end
+
+    it 'should trigger remove event' do
+      visit "/users/#{user.id}/events"
+
+      all('a', text: 'Remove role').last.click
+      expect(page).to have_selector(
+        '#event_catcher', text: %Q(
+          dynamic-fields:before-remove-from : fields_container
+          dynamic-fields:before-remove : role_name
+          dynamic-fields:before-remove : remove_link
+          dynamic-fields:before-remove : id
+          dynamic-fields:after-remove-from : fields_container
+        ).gsub(/\s{2,}/, ' ').strip
+      )
+    end
+
+  end
+end

data/spec/fixtures/roles.yml

@@ -0,0 +1,11 @@
+role_2:
+  user: existing
+  role_name: role 2
+
+role_1:
+  user: existing
+  role_name: role 1
+
+role_0:
+  user: existing
+  role_name: role 0

data/spec/fixtures/users.yml

@@ -0,0 +1,2 @@
+existing:
+  user_name: Existing user

data/spec/rails_app/Rakefile

@@ -0,0 +1,6 @@
+# Add your own tasks in files placed in lib/tasks ending in .rake,
+# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
+
+require File.expand_path('../config/application', __FILE__)
+
+RailsApp::Application.load_tasks

data/spec/rails_app/app/assets/javascripts/application.coffee

@@ -0,0 +1,13 @@
+#= require jquery
+#= require turbolinks
+#= require dynamic-fields-for
+
+$(document).on '
+dynamic-fields:before-add-into
+dynamic-fields:after-add
+dynamic-fields:after-add-into
+dynamic-fields:before-remove-from
+dynamic-fields:before-remove
+dynamic-fields:after-remove-from
+', (e)->
+  $('#event_catcher').append("#{e.type} : #{e.target.className || 'id'}<br />")

data/spec/rails_app/app/controllers/application_controller.rb

@@ -0,0 +1,5 @@
+class ApplicationController < ActionController::Base
+  # Prevent CSRF attacks by raising an exception.
+  # For APIs, you may want to use :null_session instead.
+  protect_from_forgery with: :exception
+end

data/spec/rails_app/app/controllers/users_controller.rb

@@ -0,0 +1,38 @@
+class UsersController < ApplicationController
+  before_filter :build_resource, only: [:new, :create]
+  before_filter :load_resource, only: [:edit, :update, :edit_without_fields, :events]
+
+  def new
+    3.times{ @resource.roles.build }
+  end
+
+  def create
+    @resource.update_attributes!(resource_params)
+    redirect_to edit_user_path(@resource)
+  end
+
+  def update
+    @resource.update_attributes!(resource_params)
+    redirect_to edit_user_path(@resource)
+  end
+
+  private
+
+  def scope
+    User
+  end
+
+  def build_resource
+    @resource = scope.new
+  end
+
+  def load_resource
+    @resource = scope.find(params[:id])
+  end
+
+  def resource_params
+    DynamicFieldsFor.rails4? ?
+      params.fetch(:user, {}).permit(:user_name, roles_attributes: [:id, :role_name, :_destroy]) :
+      params[:user]
+  end
+end

data/spec/rails_app/app/models/role.rb

@@ -0,0 +1,5 @@
+class Role < ActiveRecord::Base
+  belongs_to :user
+
+  validates :user, :role_name, presence: true
+end

data/spec/rails_app/app/models/user.rb

@@ -0,0 +1,7 @@
+class User < ActiveRecord::Base
+  has_many :roles, inverse_of: :user
+
+  accepts_nested_attributes_for :roles, allow_destroy: true
+
+  validates :user_name, presence: true
+end

data/spec/rails_app/app/views/layouts/application.html.haml

@@ -0,0 +1,7 @@
+!!!
+%html
+  %head
+    %title DynamicFieldsFor Test App
+    = javascript_include_tag "application", "data-turbolinks-track" => true
+
+  %body= yield

data/spec/rails_app/app/views/users/_form.html.haml

@@ -0,0 +1,23 @@
+#form_for
+  = form_for resource do |f|
+    = f.text_field :user_name
+
+    = f.fields_for :roles, dynamic: true do |rf|
+      = rf.text_field :role_name
+      = rf.remove_fields_link 'Remove role'
+
+    = f.add_fields_link :roles, 'Add role'
+
+    = f.submit
+
+#simple_form_for
+  = simple_form_for resource do |f|
+    = f.input :user_name
+
+    = f.simple_fields_for :roles, dynamic: true do |rf|
+      = rf.input :role_name
+      .remove_link= rf.remove_fields_link 'Remove role'
+
+    = f.add_fields_link :roles, 'Add role'
+
+    = f.submit

data/spec/rails_app/app/views/users/edit.html.haml

@@ -0,0 +1 @@
+= render 'form', resource: @resource

data/spec/rails_app/app/views/users/edit_without_fields.html.haml

@@ -0,0 +1,6 @@
+= link_to 'Edit', edit_user_path(@resource)
+
+= form_for @resource do |f|
+  = f.remove_fields_link 'Remove without fields'
+  = f.add_fields_link :roles, 'Add without fields'
+  = f.submit 'Update without fields'

data/spec/rails_app/app/views/users/events.html.haml

@@ -0,0 +1,13 @@
+= form_for @resource do |f|
+  = f.text_field :user_name
+
+  .fields_container
+    = f.fields_for :roles, dynamic: true do |rf|
+      = rf.text_field :role_name, class: 'role_name'
+      = rf.remove_fields_link 'Remove role', class: 'remove_link'
+
+  = f.add_fields_link :roles, 'Add role'
+
+  = f.submit
+
+#event_catcher

data/spec/rails_app/app/views/users/new.html.haml

@@ -0,0 +1 @@
+= render 'form', resource: @resource

data/spec/rails_app/bin/bundle

@@ -0,0 +1,3 @@
+#!/usr/bin/env ruby
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../../Gemfile', __FILE__)
+load Gem.bin_path('bundler', 'bundle')

data/spec/rails_app/bin/rails

@@ -0,0 +1,4 @@
+#!/usr/bin/env ruby
+APP_PATH = File.expand_path('../../config/application',  __FILE__)
+require_relative '../config/boot'
+require 'rails/commands'

data/spec/rails_app/bin/rake

@@ -0,0 +1,4 @@
+#!/usr/bin/env ruby
+require_relative '../config/boot'
+require 'rake'
+Rake.application.run

data/spec/rails_app/config/application.rb

@@ -0,0 +1,28 @@
+require File.expand_path('../boot', __FILE__)
+
+require 'rails/all'
+
+# Require the gems listed in Gemfile, including any gems
+# you've limited to :test, :development, or :production.
+Bundler.require(*Rails.groups)
+
+module RailsApp
+  class Application < Rails::Application
+    # Settings in config/environments/* take precedence over those specified here.
+    # Application configuration should go into files in config/initializers
+    # -- all .rb files in that directory are automatically loaded.
+
+    # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
+    # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
+    # config.time_zone = 'Central Time (US & Canada)'
+
+    # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
+    config.i18n.load_path += Dir[Rails.root.join('config', 'locales', "**", '*.{rb,yml}').to_s]
+    # config.i18n.default_locale = :de
+
+    # Enable the asset pipeline
+    unless DynamicFieldsFor.rails4?
+      config.assets.enabled = true
+    end
+  end
+end

data/spec/rails_app/config/boot.rb

@@ -0,0 +1,10 @@
+module DynamicFieldsFor
+  def self.rails4?
+    Rails.version.start_with? '4'
+  end
+end
+
+# Set up gems listed in the Gemfile.
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../../Gemfile', __FILE__)
+
+require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE'])

data/spec/rails_app/config/database.yml

@@ -0,0 +1,24 @@
+# SQLite version 3.x
+#   gem install sqlite3
+#
+#   Ensure the SQLite 3 gem is defined in your Gemfile
+#   gem 'sqlite3'
+#
+default: &default
+  adapter: sqlite3
+  database: ":memory:"
+
+development:
+  <<: *default
+  database: db/development.sqlite3
+  pool: 5
+  timeout: 5000
+
+# Warning: The database defined as "test" will be erased and
+# re-generated from your development database when you run "rake".
+# Do not set this db to the same as development or production.
+test:
+  <<: *default
+
+production:
+  <<: *default

data/spec/rails_app/config/environment.rb

@@ -0,0 +1,7 @@
+ENV['FIXTURES_PATH'] = '../fixtures'
+
+# Load the Rails application.
+require File.expand_path('../application', __FILE__)
+
+# Initialize the Rails application.
+RailsApp::Application.initialize!

data/spec/rails_app/config/environments/development.rb

@@ -0,0 +1,37 @@
+RailsApp::Application.configure do
+  # Settings specified here will take precedence over those in config/application.rb.
+
+  # In the development environment your application's code is reloaded on
+  # every request. This slows down response time but is perfect for development
+  # since you don't have to restart the web server when you make code changes.
+  config.cache_classes = false
+
+  # Do not eager load code on boot.
+  config.eager_load = false
+
+  # Show full error reports and disable caching.
+  config.consider_all_requests_local       = true
+  config.action_controller.perform_caching = false
+
+  # Don't care if the mailer can't send.
+  config.action_mailer.raise_delivery_errors = false
+
+  # Print deprecation notices to the Rails logger.
+  config.active_support.deprecation = :log
+
+  # Raise an error on page load if there are pending migrations.
+  config.active_record.migration_error = :page_load
+
+  # Debug mode disables concatenation and preprocessing of assets.
+  # This option may cause significant delays in view rendering with a large
+  # number of complex assets.
+  config.assets.debug = true
+
+  # Adds additional error checking when serving assets at runtime.
+  # Checks for improperly declared sprockets dependencies.
+  # Raises helpful error messages.
+  config.assets.raise_runtime_errors = true
+
+  # Raises error for missing translations
+  # config.action_view.raise_on_missing_translations = true
+end

data/spec/rails_app/config/environments/production.rb

@@ -0,0 +1,80 @@
+RailsApp::Application.configure do
+  # Settings specified here will take precedence over those in config/application.rb.
+
+  # Code is not reloaded between requests.
+  config.cache_classes = true
+
+  # Eager load code on boot. This eager loads most of Rails and
+  # your application in memory, allowing both threaded web servers
+  # and those relying on copy on write to perform better.
+  # Rake tasks automatically ignore this option for performance.
+  config.eager_load = true
+
+  # Full error reports are disabled and caching is turned on.
+  config.consider_all_requests_local       = false
+  config.action_controller.perform_caching = true
+
+  # Enable Rack::Cache to put a simple HTTP cache in front of your application
+  # Add `rack-cache` to your Gemfile before enabling this.
+  # For large-scale production use, consider using a caching reverse proxy like nginx, varnish or squid.
+  # config.action_dispatch.rack_cache = true
+
+  # Disable Rails's static asset server (Apache or nginx will already do this).
+  DynamicFieldsFor.rails4? ?
+    config.serve_static_files = false :
+    config.serve_static_assets = false
+
+  # Compress JavaScripts and CSS.
+  config.assets.js_compressor = :uglifier
+  # config.assets.css_compressor = :sass
+
+  # Do not fallback to assets pipeline if a precompiled asset is missed.
+  config.assets.compile = false
+
+  # Generate digests for assets URLs.
+  config.assets.digest = true
+
+  # `config.assets.precompile` and `config.assets.version` have moved to config/initializers/assets.rb
+
+  # Specifies the header that your server uses for sending files.
+  # config.action_dispatch.x_sendfile_header = "X-Sendfile" # for apache
+  # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for nginx
+
+  # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
+  # config.force_ssl = true
+
+  # Set to :debug to see everything in the log.
+  config.log_level = :info
+
+  # Prepend all log lines with the following tags.
+  # config.log_tags = [ :subdomain, :uuid ]
+
+  # Use a different logger for distributed setups.
+  # config.logger = ActiveSupport::TaggedLogging.new(SyslogLogger.new)
+
+  # Use a different cache store in production.
+  # config.cache_store = :mem_cache_store
+
+  # Enable serving of images, stylesheets, and JavaScripts from an asset server.
+  # config.action_controller.asset_host = "http://assets.example.com"
+
+  # Ignore bad email addresses and do not raise email delivery errors.
+  # Set this to true and configure the email server for immediate delivery to raise delivery errors.
+  # config.action_mailer.raise_delivery_errors = false
+
+  # Enable locale fallbacks for I18n (makes lookups for any locale fall back to
+  # the I18n.default_locale when a translation cannot be found).
+  config.i18n.fallbacks = true
+
+  # Send deprecation notices to registered listeners.
+  config.active_support.deprecation = :notify
+
+  # Disable automatic flushing of the log to improve performance.
+  # config.autoflush_log = false
+
+  # Use default logging formatter so that PID and timestamp are not suppressed.
+  config.log_formatter = ::Logger::Formatter.new
+
+  # Do not dump schema after migrations.
+  config.active_record.dump_schema_after_migration = false
+end

data/spec/rails_app/config/environments/test.rb

@@ -0,0 +1,41 @@
+RailsApp::Application.configure do
+  # Settings specified here will take precedence over those in config/application.rb.
+
+  # The test environment is used exclusively to run your application's
+  # test suite. You never need to work with it otherwise. Remember that
+  # your test database is "scratch space" for the test suite and is wiped
+  # and recreated between test runs. Don't rely on the data there!
+  config.cache_classes = true
+
+  # Do not eager load code on boot. This avoids loading your whole application
+  # just for the purpose of running a single test. If you are using a tool that
+  # preloads Rails for running tests, you may have to set it to true.
+  config.eager_load = false
+
+  # Configure static asset server for tests with Cache-Control for performance.
+  DynamicFieldsFor.rails4? ?
+    config.serve_static_files = true :
+    config.serve_static_assets = true
+  config.static_cache_control = 'public, max-age=3600'
+
+  # Show full error reports and disable caching.
+  config.consider_all_requests_local       = true
+  config.action_controller.perform_caching = false
+
+  # Raise exceptions instead of rendering exception templates.
+  config.action_dispatch.show_exceptions = false
+
+  # Disable request forgery protection in test environment.
+  config.action_controller.allow_forgery_protection = false
+
+  # Tell Action Mailer not to deliver emails to the real world.
+  # The :test delivery method accumulates sent emails in the
+  # ActionMailer::Base.deliveries array.
+  config.action_mailer.delivery_method = :test
+
+  # Print deprecation notices to the stderr.
+  config.active_support.deprecation = :stderr
+
+  # Raises error for missing translations
+  # config.action_view.raise_on_missing_translations = true
+end

data/spec/rails_app/config/initializers/assets.rb

@@ -0,0 +1,8 @@
+# Be sure to restart your server when you modify this file.
+
+# Version of your assets, change this if you want to expire all your assets.
+Rails.application.config.assets.version = '1.0'
+
+# Precompile additional assets.
+# application.js, application.css, and all non-JS/CSS in app/assets folder are already added.
+# Rails.application.config.assets.precompile += %w( search.js )

data/spec/rails_app/config/initializers/backtrace_silencers.rb

@@ -0,0 +1,7 @@
+# Be sure to restart your server when you modify this file.
+
+# You can add backtrace silencers for libraries that you're using but don't wish to see in your backtraces.
+# Rails.backtrace_cleaner.add_silencer { |line| line =~ /my_noisy_library/ }
+
+# You can also remove all the silencers if you're trying to debug a problem that might stem from framework code.
+# Rails.backtrace_cleaner.remove_silencers!

data/spec/rails_app/config/initializers/cookies_serializer.rb

@@ -0,0 +1,3 @@
+# Be sure to restart your server when you modify this file.
+
+Rails.application.config.action_dispatch.cookies_serializer = :json

data/spec/rails_app/config/initializers/filter_parameter_logging.rb

@@ -0,0 +1,4 @@
+# Be sure to restart your server when you modify this file.
+
+# Configure sensitive parameters which will be filtered from the log file.
+Rails.application.config.filter_parameters += [:password]

data/spec/rails_app/config/initializers/inflections.rb

@@ -0,0 +1,16 @@
+# Be sure to restart your server when you modify this file.
+
+# Add new inflection rules using the following format. Inflections
+# are locale specific, and you may define rules for as many different
+# locales as you wish. All of these examples are active by default:
+# ActiveSupport::Inflector.inflections(:en) do |inflect|
+#   inflect.plural /^(ox)$/i, '\1en'
+#   inflect.singular /^(ox)en/i, '\1'
+#   inflect.irregular 'person', 'people'
+#   inflect.uncountable %w( fish sheep )
+# end
+
+# These inflection rules are supported but not enabled by default:
+# ActiveSupport::Inflector.inflections(:en) do |inflect|
+#   inflect.acronym 'RESTful'
+# end

data/spec/rails_app/config/initializers/mime_types.rb

@@ -0,0 +1,4 @@
+# Be sure to restart your server when you modify this file.
+
+# Add new mime types for use in respond_to blocks:
+# Mime::Type.register "text/richtext", :rtf

data/spec/rails_app/config/initializers/secret_token.rb

@@ -0,0 +1,5 @@
+if DynamicFieldsFor.rails4?
+  RailsApp::Application.config.secret_key_base = '8cec03a73bd1f8cdf2c519131bb5475775684177ce99c27c254e9617313950f06972cd0e027ea5627570b133f8d5385bd5aaec119351f65bec03a0facb0de559'
+else
+  RailsApp::Application.config.secret_token = '8cec03a73bd1f8cdf2c519131bb5475775684177ce99c27c254e9617313950f06972cd0e027ea5627570b133f8d5385bd5aaec119351f65bec03a0facb0de559'
+end

data/spec/rails_app/config/initializers/session_store.rb

@@ -0,0 +1,3 @@
+# Be sure to restart your server when you modify this file.
+
+RailsApp::Application.config.session_store :cookie_store, key: '_rails_app_session'